)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b037954a1420421e616fe30f9ba1f47f3f071f1f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add status filtering options to port list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch \"--status\" options to port list."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I710437f67e9432b2b6389986bc922eac4a60c934"},{"line_number":12,"context_line":"Partially-Implements: blueprint network-commands-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_fda646bf","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":42},"updated":"2017-03-13 11:03:01.000000000","message":"Maybe:\nThis patch adds \"--status\" option to port list command.","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dfa041d6f48e6c5b8cf44b828aaa0db4cceea58f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"33ad27e1_75fa6747","updated":"2024-09-30 15:01:57.000000000","message":"recheck","commit_id":"9c223696a0e3b45bcd8bcb0a8f81e3354ccea9c6"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4d426a507433ec861fa59ce5aac1b6500b9a1586","unresolved":false,"context_lines":[{"line_number":492,"context_line":"            metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":493,"context_line":"            choices\u003d[\u0027ACTIVE\u0027, \u0027BUILD\u0027, \u0027DOWN\u0027, \u0027ERROR\u0027],"},{"line_number":494,"context_line":"            help\u003d_(\"List ports according to their status \""},{"line_number":495,"context_line":"                   \"(\u0027ACTIVE\u0027, \u0027BUILD\u0027, \u0027DOWN\u0027, \u0027ERROR\u0027)\")"},{"line_number":496,"context_line":"        )"},{"line_number":497,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":498,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_3c382aec","line":495,"updated":"2017-04-20 15:36:49.000000000","message":"We use/allow lower case values when there are enumerated values like this.  I would prefer to see lower case in the help strings even if upper case is accepted.","commit_id":"adca61b89cce3bccf42bae75b4991ea7600b4257"}],"openstackclient/tests/unit/network/v2/test_port.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b037954a1420421e616fe30f9ba1f47f3f071f1f","unresolved":false,"context_lines":[{"line_number":869,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"    def test_port_list_status(self):"},{"line_number":872,"context_line":"        import random"},{"line_number":873,"context_line":"        choices \u003d [\u0027ACTIVE\u0027, \u0027BUILD\u0027, \u0027DOWN\u0027, \u0027ERROR\u0027]"},{"line_number":874,"context_line":"        test_status \u003d random.choice(choices)"},{"line_number":875,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_bdd5aee5","line":872,"range":{"start_line":872,"start_character":8,"end_line":872,"end_character":21},"updated":"2017-03-13 11:03:01.000000000","message":"Move the import at the beginning of the file","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ae630ee96eccd6927c8b22555525b9c0661fcee","unresolved":false,"context_lines":[{"line_number":869,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"    def test_port_list_status(self):"},{"line_number":872,"context_line":"        import random"},{"line_number":873,"context_line":"        choices \u003d [\u0027ACTIVE\u0027, \u0027BUILD\u0027, \u0027DOWN\u0027, \u0027ERROR\u0027]"},{"line_number":874,"context_line":"        test_status \u003d random.choice(choices)"},{"line_number":875,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_3dd37ed6","line":872,"range":{"start_line":872,"start_character":8,"end_line":872,"end_character":21},"in_reply_to":"9a30ddce_bdd5aee5","updated":"2017-03-13 11:08:48.000000000","message":"+1","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ae630ee96eccd6927c8b22555525b9c0661fcee","unresolved":false,"context_lines":[{"line_number":871,"context_line":"    def test_port_list_status(self):"},{"line_number":872,"context_line":"        import random"},{"line_number":873,"context_line":"        choices \u003d [\u0027ACTIVE\u0027, \u0027BUILD\u0027, \u0027DOWN\u0027, \u0027ERROR\u0027]"},{"line_number":874,"context_line":"        test_status \u003d random.choice(choices)"},{"line_number":875,"context_line":"        arglist \u003d ["},{"line_number":876,"context_line":"            \u0027--status\u0027, test_status,"},{"line_number":877,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_1db5da7c","line":874,"range":{"start_line":874,"start_character":0,"end_line":874,"end_character":44},"updated":"2017-03-13 11:08:48.000000000","message":"Pretty difficult to make the Expected Data set from random, unless you filter the expected data set as well","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d481d794607b28c0d89f77bbfb2ecbf1dedc8b8f","unresolved":false,"context_lines":[{"line_number":871,"context_line":"    def test_port_list_status(self):"},{"line_number":872,"context_line":"        import random"},{"line_number":873,"context_line":"        choices \u003d [\u0027ACTIVE\u0027, \u0027BUILD\u0027, \u0027DOWN\u0027, \u0027ERROR\u0027]"},{"line_number":874,"context_line":"        test_status \u003d random.choice(choices)"},{"line_number":875,"context_line":"        arglist \u003d ["},{"line_number":876,"context_line":"            \u0027--status\u0027, test_status,"},{"line_number":877,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a22e58a_1a6869ba","line":874,"range":{"start_line":874,"start_character":0,"end_line":874,"end_character":44},"in_reply_to":"9a30ddce_1db5da7c","updated":"2017-03-14 09:12:44.000000000","message":"I don\u0027t disagree with this idea. In fact, I prefer this way.","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b037954a1420421e616fe30f9ba1f47f3f071f1f","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            \u0027--status\u0027, test_status,"},{"line_number":877,"context_line":"        ]"},{"line_number":878,"context_line":"        verifylist \u003d ["},{"line_number":879,"context_line":"            (\u0027long\u0027, False),"},{"line_number":880,"context_line":"            (\u0027status\u0027, test_status),"},{"line_number":881,"context_line":"        ]"},{"line_number":882,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_fd300658","line":879,"range":{"start_line":879,"start_character":13,"end_line":879,"end_character":19},"updated":"2017-03-13 11:03:01.000000000","message":"Which is this parameter?","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ae630ee96eccd6927c8b22555525b9c0661fcee","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            \u0027--status\u0027, test_status,"},{"line_number":877,"context_line":"        ]"},{"line_number":878,"context_line":"        verifylist \u003d ["},{"line_number":879,"context_line":"            (\u0027long\u0027, False),"},{"line_number":880,"context_line":"            (\u0027status\u0027, test_status),"},{"line_number":881,"context_line":"        ]"},{"line_number":882,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_bddf6ed4","line":879,"range":{"start_line":879,"start_character":13,"end_line":879,"end_character":19},"in_reply_to":"9a30ddce_fd300658","updated":"2017-03-13 11:08:48.000000000","message":"This should be (\"status\", True)","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b037954a1420421e616fe30f9ba1f47f3f071f1f","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        ]"},{"line_number":882,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":883,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":884,"context_line":"  "},{"line_number":885,"context_line":"        self.network.ports.assert_called_once_with("},{"line_number":886,"context_line":"            **{\u0027status\u0027: test_status}"},{"line_number":887,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_9ddaaa15","line":884,"range":{"start_line":884,"start_character":0,"end_line":884,"end_character":2},"updated":"2017-03-13 11:03:01.000000000","message":"Remove these spaces","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ae630ee96eccd6927c8b22555525b9c0661fcee","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        ]"},{"line_number":882,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":883,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":884,"context_line":"  "},{"line_number":885,"context_line":"        self.network.ports.assert_called_once_with("},{"line_number":886,"context_line":"            **{\u0027status\u0027: test_status}"},{"line_number":887,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_5d059243","line":884,"range":{"start_line":884,"start_character":0,"end_line":884,"end_character":2},"in_reply_to":"9a30ddce_9ddaaa15","updated":"2017-03-13 11:08:48.000000000","message":"Yep , +1","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ae630ee96eccd6927c8b22555525b9c0661fcee","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        self.network.ports.assert_called_once_with("},{"line_number":886,"context_line":"            **{\u0027status\u0027: test_status}"},{"line_number":887,"context_line":"        )"},{"line_number":888,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":889,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"class TestSetPort(TestPort):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_3da1be46","line":889,"range":{"start_line":888,"start_character":0,"end_line":889,"end_character":47},"updated":"2017-03-13 11:08:48.000000000","message":"Are you sure the assert equal will work here ?\nWont you get more data than you expect?\n\n\nAlso why dont you use assertListEqual:\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertListEqual","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d481d794607b28c0d89f77bbfb2ecbf1dedc8b8f","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        self.network.ports.assert_called_once_with("},{"line_number":886,"context_line":"            **{\u0027status\u0027: test_status}"},{"line_number":887,"context_line":"        )"},{"line_number":888,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":889,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"class TestSetPort(TestPort):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a22e58a_7a523ddf","line":889,"range":{"start_line":888,"start_character":0,"end_line":889,"end_character":47},"in_reply_to":"9a30ddce_3da1be46","updated":"2017-03-14 09:12:44.000000000","message":"Internally, assertEqual uses assertListEqual. In this case is OK.","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4d426a507433ec861fa59ce5aac1b6500b9a1586","unresolved":false,"context_lines":[{"line_number":868,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":869,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"    def test_port_list_status(self):"},{"line_number":872,"context_line":"        arglist \u003d ["},{"line_number":873,"context_line":"            \u0027--status\u0027, \u0027ACTIVE\u0027,"},{"line_number":874,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_8f449e48","line":871,"updated":"2017-04-20 15:36:49.000000000","message":"There needs to be a test that actually shows the filtering at work, ie not the full list of ports is returned.","commit_id":"adca61b89cce3bccf42bae75b4991ea7600b4257"}],"releasenotes/notes/add-port-list-status-option-f51da0aed0528a5d.yaml":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4ae630ee96eccd6927c8b22555525b9c0661fcee","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--status`` option to ``port list`` command."},{"line_number":5,"context_line":"    [Blueprint `network-commands-options \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-commands-options\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a30ddce_1d431a6d","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":40},"updated":"2017-03-13 11:08:48.000000000","message":"I think they have defined a short form lpbp to link the Launchpad Blueprints","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d481d794607b28c0d89f77bbfb2ecbf1dedc8b8f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--status`` option to ``port list`` command."},{"line_number":5,"context_line":"    [Blueprint `network-commands-options \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-commands-options\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a22e58a_daaa5185","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":40},"in_reply_to":"9a30ddce_1d431a6d","updated":"2017-03-14 09:12:44.000000000","message":"Each patch creates a bug attached to the main spec.","commit_id":"ee0363fbe1e3c717e58111b5e861e19fab4d40e5"}]}