)]}'
{"id":"openstack%2Fpython-openstackclient~445856","triplet_id":"openstack%2Fpython-openstackclient~master~I74ae16cd633830bd45a7702b8d74f60c92b02a42","project":"openstack/python-openstackclient","branch":"master","topic":"bp/replace-iteritems-with-items","hashtags":[],"change_id":"I74ae16cd633830bd45a7702b8d74f60c92b02a42","subject":"[1/3]Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-03-15 10:07:17.000000000","updated":"2017-07-07 04:05:49.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3559f426790c9eaef688cec4e26a38d124865859","_number":445856,"virtual_id_number":445856,"owner":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-03-15 15:43:28.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2017-03-20 03:15:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-03-16 10:08:13.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2017-06-05 06:32:45.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2017-03-17 00:29:59.000000000","_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"value":1,"date":"2017-06-05 06:23:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-15 15:43:28.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-03-16 10:08:13.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2017-03-20 03:15:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-06-05 06:23:24.000000000","updated_by":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"reviewer":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"state":"REVIEWER"},{"updated":"2017-06-05 06:32:45.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"}],"messages":[{"id":"5ef78eee63aca85e95762dacd5b02c1f60dce803","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-15 10:07:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bb406d02d4a76b163917055dc7c006251f3fed7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-15 11:24:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/56/445856/1/check/gate-python-openstackclient-docs-ubuntu-xenial/c194c1b//doc/build/html/ : SUCCESS in 3m 03s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/b99344c/ : SUCCESS in 5m 06s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python27-ubuntu-xenial/859b433/ : SUCCESS in 3m 02s\n- gate-python-openstackclient-python35 http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python35/bb840b9/ : SUCCESS in 5m 01s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/4b7d2e8/ : SUCCESS in 1h 16m 01s\n- check-osc-plugins http://logs.openstack.org/56/445856/1/check/check-osc-plugins/b8efc9d/ : SUCCESS in 3m 52s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-ubuntu-xenial/7a0d82d/ : FAILURE in 42m 32s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/19e9a50/ : FAILURE in 36m 45s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/56/445856/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/f04fdd2/ : SUCCESS in 1h 03m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d0fbb5c31f5fadccc7b7988dfd7111254b7b6eeb","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-03-15 15:43:28.000000000","message":"Patch Set 1:\n\ni\u0027m generally OK with this, but would like to hear feedback from others before pushing +A","accounts_in_message":[],"_revision_number":1},{"id":"6ad357337fcd12039df96ef4fbec1f42be92dd1e","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2017-03-16 10:08:13.000000000","message":"Patch Set 1:\n\nrecheck gate issues are resolved","accounts_in_message":[],"_revision_number":1},{"id":"46c358d96155381bf5641df91172527d520f2483","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 11:18:36.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/56/445856/1/check/gate-python-openstackclient-docs-ubuntu-xenial/d6d90b1//doc/build/html/ : SUCCESS in 2m 53s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/27c2cf9/ : SUCCESS in 5m 41s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python27-ubuntu-xenial/0658c40/ : SUCCESS in 5m 12s\n- gate-python-openstackclient-python35 http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python35/27d7f99/ : SUCCESS in 5m 02s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/f2ac6ea/ : SUCCESS in 1h 07m 15s\n- check-osc-plugins http://logs.openstack.org/56/445856/1/check/check-osc-plugins/6a0e8db/ : SUCCESS in 5m 41s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-ubuntu-xenial/9e540aa/ : FAILURE in 49m 52s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/f37ba63/ : FAILURE in 51m 29s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/56/445856/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/ddeec35/ : SUCCESS in 1h 02m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e92d1e6f33333d5c9ea75f587b056d1260ce3e75","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-17 00:29:59.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"34cc99117cbc176eb89174b6382c9a8c3a9fb74e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 01:55:40.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/56/445856/1/check/gate-python-openstackclient-docs-ubuntu-xenial/b365ac0//doc/build/html/ : SUCCESS in 4m 41s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/336f975/ : SUCCESS in 3m 11s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python27-ubuntu-xenial/073bc18/ : SUCCESS in 5m 30s\n- gate-python-openstackclient-python35 http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python35/2751051/ : SUCCESS in 2m 41s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/1b864ea/ : SUCCESS in 1h 24m 46s\n- check-osc-plugins http://logs.openstack.org/56/445856/1/check/check-osc-plugins/d469ae1/ : SUCCESS in 5m 36s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-ubuntu-xenial/189c06e/ : FAILURE in 43m 19s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/836d406/ : FAILURE in 47m 41s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/56/445856/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/fe5718c/ : SUCCESS in 1h 01m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9f5630a86ebce13dc189cbf2f41136c500a658d3","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-20 02:09:56.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"5d14dd9449358bcb37d4ce301f3d17e21148ed72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 03:15:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/56/445856/1/check/gate-python-openstackclient-docs-ubuntu-xenial/f3a8204//doc/build/html/ : SUCCESS in 2m 36s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/e0dfc2a/ : SUCCESS in 5m 27s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python27-ubuntu-xenial/a95813e/ : SUCCESS in 4m 31s\n- gate-python-openstackclient-python35 http://logs.openstack.org/56/445856/1/check/gate-python-openstackclient-python35/1b49802/ : SUCCESS in 2m 22s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/e51710e/ : SUCCESS in 1h 04m 58s\n- check-osc-plugins http://logs.openstack.org/56/445856/1/check/check-osc-plugins/259ae06/ : SUCCESS in 5m 54s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-ubuntu-xenial/3fc8c6e/ : SUCCESS in 34m 02s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/56/445856/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/1eb2a9a/ : FAILURE in 50m 22s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/56/445856/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/b368f1c/ : SUCCESS in 1h 01m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dd1553b78c51a1731693b656b3b0b6fc8ebd7e18","author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"date":"2017-06-05 06:23:24.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM!","accounts_in_message":[],"_revision_number":1},{"id":"8e5bff02f6988b01f134b906372b312e2c682e8b","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-06-05 06:32:45.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e7f9d5242ee45c307475fd8c07e7fed464903bd1","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-07-07 04:05:49.000000000","message":"Abandoned\n\nFall behind master too much. Abandon. And put three commits in a new one:https://review.openstack.org/#/c/481407/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"18fbd285deb91e200c9acf7ecb05e9b311406f4a","revisions":{"18fbd285deb91e200c9acf7ecb05e9b311406f4a":{"kind":"REWORK","_number":1,"created":"2017-03-15 10:07:17.000000000","uploader":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"ref":"refs/changes/56/445856/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/56/445856/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/56/445856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/56/445856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/56/445856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/56/445856/1"}}},"commit":{"parents":[{"commit":"4a19f6753b9e21b3089824d17943b39c211a616a","subject":"Merge \"Fix reference in network flavor create command reference\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4a19f6753b9e21b3089824d17943b39c211a616a"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 10:03:44.000000000","tz":480},"committer":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 10:03:44.000000000","tz":480},"subject":"[1/3]Replace six.iteritems() with .items()","message":"[1/3]Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be\nnegligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nThe patch list:\n    1. common\n    2. compute\n\nChange-Id: I74ae16cd633830bd45a7702b8d74f60c92b02a42\nPartial-Implements: blueprint replace-iteritems-with-items\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/18fbd285deb91e200c9acf7ecb05e9b311406f4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/18fbd285deb91e200c9acf7ecb05e9b311406f4a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}