)]}'
{"id":"openstack%2Fpython-openstackclient~445865","triplet_id":"openstack%2Fpython-openstackclient~master~I995656565f1747824b87c66e33761634b972e20f","project":"openstack/python-openstackclient","branch":"master","topic":"bp/replace-iteritems-with-items","hashtags":[],"change_id":"I995656565f1747824b87c66e33761634b972e20f","subject":"[2/3]Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-03-15 10:32:21.000000000","updated":"2017-07-07 04:06:08.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dfa383fa1657e4e84a006d36f768fe0ca4ab1b3f","_number":445865,"virtual_id_number":445865,"owner":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-03-16 11:23:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-03-16 10:08:07.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"},{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2017-05-26 02:51:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"},{"value":1,"date":"2017-06-05 06:24:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"},{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},{"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-16 10:08:07.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2017-03-16 11:23:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-26 02:51:33.000000000","updated_by":{"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"},"reviewer":{"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"},"state":"REVIEWER"},{"updated":"2017-06-05 06:24:17.000000000","updated_by":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"reviewer":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"state":"REVIEWER"}],"messages":[{"id":"bcabfe147b0478bcba717924e1232bedd81c62ff","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-15 10:32:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ec50f17a408a9557bf2676bace0644c312b2d94f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-15 11:46:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/65/445865/1/check/gate-python-openstackclient-docs-ubuntu-xenial/d660fd2//doc/build/html/ : SUCCESS in 5m 18s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/1c2e1dc/ : SUCCESS in 5m 46s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-python-openstackclient-python27-ubuntu-xenial/53061f1/ : SUCCESS in 3m 59s\n- gate-python-openstackclient-python35 http://logs.openstack.org/65/445865/1/check/gate-python-openstackclient-python35/a83ba5d/ : SUCCESS in 4m 27s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/f752eea/ : SUCCESS in 1h 10m 07s\n- check-osc-plugins http://logs.openstack.org/65/445865/1/check/check-osc-plugins/9296330/ : SUCCESS in 7m 50s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-osc-dsvm-functional-ubuntu-xenial/315b5b0/ : FAILURE in 33m 03s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/65/445865/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/f1cad37/ : FAILURE in 47m 03s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/65/445865/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/0f3cc01/ : SUCCESS in 59m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"42666bbad1e72634c65954a5bca5b6c18ba18a43","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2017-03-16 10:08:07.000000000","message":"Patch Set 1:\n\nrecheck gate issues are resolved","accounts_in_message":[],"_revision_number":1},{"id":"55391e6cf5484f4c555fe9f1e7218d14779d6f97","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 11:23:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/65/445865/1/check/gate-python-openstackclient-docs-ubuntu-xenial/7e281ae//doc/build/html/ : SUCCESS in 4m 42s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/53ed198/ : SUCCESS in 4m 48s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-python-openstackclient-python27-ubuntu-xenial/8e537fd/ : SUCCESS in 4m 27s\n- gate-python-openstackclient-python35 http://logs.openstack.org/65/445865/1/check/gate-python-openstackclient-python35/2bdda1e/ : SUCCESS in 4m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/9dcdb91/ : SUCCESS in 1h 13m 30s\n- check-osc-plugins http://logs.openstack.org/65/445865/1/check/check-osc-plugins/e1d6041/ : SUCCESS in 3m 24s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/65/445865/1/check/gate-osc-dsvm-functional-ubuntu-xenial/7a8665e/ : SUCCESS in 33m 35s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/65/445865/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/c8dd56d/ : FAILURE in 34m 07s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/65/445865/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/3c776aa/ : SUCCESS in 1h 04m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"423a5a82fc79d9fa61528b2e169da7642d8f7067","author":{"_account_id":24903,"name":"Hongtao Zhang","email":"changhungtao@126.com","username":"ZhangHongtao"},"date":"2017-05-26 02:51:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d45246939e983989a73bc3664ae60ff6c82b136b","author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"date":"2017-06-05 06:24:17.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM!","accounts_in_message":[],"_revision_number":1},{"id":"f63d5bba3429fab5f344b708f231703b8690efa4","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-07-07 04:06:08.000000000","message":"Abandoned\n\nFall behind master too much. Abandon. And put three commits in a new one:https://review.openstack.org/#/c/481407/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"60c807392bf105d86491796609ba2a181903084f","revisions":{"60c807392bf105d86491796609ba2a181903084f":{"kind":"REWORK","_number":1,"created":"2017-03-15 10:32:21.000000000","uploader":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"ref":"refs/changes/65/445865/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/445865/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/445865/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/445865/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/445865/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/445865/1"}}},"commit":{"parents":[{"commit":"18fbd285deb91e200c9acf7ecb05e9b311406f4a","subject":"[1/3]Replace six.iteritems() with .items()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/18fbd285deb91e200c9acf7ecb05e9b311406f4a"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 10:28:04.000000000","tz":480},"committer":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 10:28:04.000000000","tz":480},"subject":"[2/3]Replace six.iteritems() with .items()","message":"[2/3]Replace six.iteritems() with .items()\n\n    1.As mentioned in [1], we should avoid using\n    six.iteritems to achieve iterators. We can\n    use dict.items instead, as it will return\n    iterators in PY3 as well. And dict.items/keys\n    will more readable.\n    2.In py2, the performance about list should be\n    negligible, see the link [2].\n\n    [1] https://wiki.openstack.org/wiki/Python3\n    [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\n    The patch list:\n        identity\n\n    Partial-Implements: blueprint replace-iteritems-with-items\n\nChange-Id: I995656565f1747824b87c66e33761634b972e20f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/60c807392bf105d86491796609ba2a181903084f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/60c807392bf105d86491796609ba2a181903084f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}