)]}'
{"id":"openstack%2Fpython-openstackclient~445878","triplet_id":"openstack%2Fpython-openstackclient~master~I8ac4f96d606a4530209de914542e035c3bd970c0","project":"openstack/python-openstackclient","branch":"master","topic":"bp/replace-iteritems-with-items","hashtags":[],"change_id":"I8ac4f96d606a4530209de914542e035c3bd970c0","subject":"[3/3]Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-03-15 11:13:21.000000000","updated":"2017-07-07 04:06:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"029373fa8cab61a71d18da615a5318c40577424d","_number":445878,"virtual_id_number":445878,"owner":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2017-06-05 20:12:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-03-16 10:08:40.000000000","_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2017-03-20 00:54:38.000000000","_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"value":-1,"date":"2017-07-06 06:33:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-16 10:08:40.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2017-06-05 20:12:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-06 06:33:55.000000000","updated_by":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"reviewer":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"state":"REVIEWER"}],"messages":[{"id":"b39fa52b43e3973316f408bc13f787324bc30157","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-15 11:13:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48e8ed83ddc5a6aa6d6c18fce90af8911fcfadc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-15 12:43:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/78/445878/1/check/gate-python-openstackclient-docs-ubuntu-xenial/0d7e82d//doc/build/html/ : SUCCESS in 3m 06s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/78/445878/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/cd98808/ : FAILURE in 6m 47s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/78/445878/1/check/gate-python-openstackclient-python27-ubuntu-xenial/aba89ad/ : SUCCESS in 4m 15s\n- gate-python-openstackclient-python35 http://logs.openstack.org/78/445878/1/check/gate-python-openstackclient-python35/f96233b/ : SUCCESS in 4m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/78/445878/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/a6e8fbb/ : SUCCESS in 1h 22m 05s\n- check-osc-plugins http://logs.openstack.org/78/445878/1/check/check-osc-plugins/88c9bea/ : SUCCESS in 4m 09s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/78/445878/1/check/gate-osc-dsvm-functional-ubuntu-xenial/1d1070a/ : FAILURE in 40m 45s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/78/445878/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/881b53b/ : FAILURE in 41m 00s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/78/445878/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/6a6813c/ : SUCCESS in 1h 27m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4e286291787dabdbacb956aeaae70c6a984e5d3a","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-16 02:00:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f19541eb478833202d1cf7684b2fe68692ba963c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 03:09:29.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/78/445878/2/check/gate-python-openstackclient-docs-ubuntu-xenial/168c505//doc/build/html/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/54364f4/ : SUCCESS in 3m 33s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-python27-ubuntu-xenial/c44ded7/ : SUCCESS in 2m 37s\n- gate-python-openstackclient-python35 http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-python35/5bb0699/ : SUCCESS in 2m 28s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/5a4984e/ : SUCCESS in 1h 08m 48s\n- check-osc-plugins http://logs.openstack.org/78/445878/2/check/check-osc-plugins/e9501a2/ : SUCCESS in 5m 57s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-osc-dsvm-functional-ubuntu-xenial/c1f6410/ : FAILURE in 34m 39s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/78/445878/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/e6de05c/ : FAILURE in 46m 02s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/78/445878/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/f2a91a1/ : SUCCESS in 1h 00m 19s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6cde813ea87e6f2cca4ded9ed0a7787010031a25","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2017-03-16 10:08:40.000000000","message":"Patch Set 2:\n\nrecheck gate issues are resolved","accounts_in_message":[],"_revision_number":2},{"id":"877100e9d544d7f5fabdec3f0bc0edc94a7f5943","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 11:29:56.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/78/445878/2/check/gate-python-openstackclient-docs-ubuntu-xenial/2551a37//doc/build/html/ : SUCCESS in 4m 18s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/267c64c/ : SUCCESS in 5m 13s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-python27-ubuntu-xenial/8b5ab23/ : SUCCESS in 3m 53s\n- gate-python-openstackclient-python35 http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-python35/0350aeb/ : SUCCESS in 3m 56s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/3488a36/ : SUCCESS in 1h 12m 13s\n- check-osc-plugins http://logs.openstack.org/78/445878/2/check/check-osc-plugins/78b383d/ : SUCCESS in 5m 41s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-osc-dsvm-functional-ubuntu-xenial/9a0200d/ : FAILURE in 39m 43s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/78/445878/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/cc53a7d/ : FAILURE in 32m 23s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/78/445878/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/586bfc3/ : SUCCESS in 1h 16m 13s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"874eecceafc2f6e7af5497a67d822f32ae27402c","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-03-20 00:54:38.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"b80dbc413826e2ef3ccf8ba13f89cd0b3146cdbf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 02:23:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/78/445878/2/check/gate-python-openstackclient-docs-ubuntu-xenial/16f4cd9//doc/build/html/ : SUCCESS in 2m 41s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/d6daf71/ : SUCCESS in 3m 24s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-python27-ubuntu-xenial/7768bc9/ : SUCCESS in 2m 30s\n- gate-python-openstackclient-python35 http://logs.openstack.org/78/445878/2/check/gate-python-openstackclient-python35/38563d6/ : SUCCESS in 2m 30s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/824f1e7/ : SUCCESS in 1h 07m 26s\n- check-osc-plugins http://logs.openstack.org/78/445878/2/check/check-osc-plugins/4427799/ : SUCCESS in 3m 49s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/78/445878/2/check/gate-osc-dsvm-functional-ubuntu-xenial/98ab295/ : SUCCESS in 43m 16s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/78/445878/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/5e9e56f/ : FAILURE in 46m 55s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/78/445878/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/140e632/ : SUCCESS in 1h 28m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"60854a0a4cae7a53aea9d5733c88690586f95f9b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-05 20:12:40.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"706542b2bf007c957f1f19421776a958ece8b5dd","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-07-06 06:33:55.000000000","message":"Patch Set 2: Code-Review-1\n\nHi,\nCould you please rebase this patch?","accounts_in_message":[],"_revision_number":2},{"id":"7976429af04f0f2d6f8b8404704b474b0e190eec","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-07-07 04:06:15.000000000","message":"Abandoned\n\nFall behind master too much. Abandon. And put three commits in a new one:https://review.openstack.org/#/c/481407/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"69a550bd70766c0fe3716ba93fc4dee186c310ce","revisions":{"d7a9d516bdf82af019db8eccc91dd40a06c48adf":{"kind":"REWORK","_number":1,"created":"2017-03-15 11:13:21.000000000","uploader":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"ref":"refs/changes/78/445878/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/78/445878/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/1"}}},"commit":{"parents":[{"commit":"60c807392bf105d86491796609ba2a181903084f","subject":"[2/3]Replace six.iteritems() with .items()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/60c807392bf105d86491796609ba2a181903084f"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 11:09:40.000000000","tz":480},"committer":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 11:09:40.000000000","tz":480},"subject":"[3/3]Replace six.iteritems() with .items()","message":"[3/3]Replace six.iteritems() with .items()\n\n        1.As mentioned in [1], we should avoid using\n        six.iteritems to achieve iterators. We can\n        use dict.items instead, as it will return\n        iterators in PY3 as well. And dict.items/keys\n        will more readable.\n        2.In py2, the performance about list should be\n        negligible, see the link [2].\n\n        [1] https://wiki.openstack.org/wiki/Python3\n        [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\n        The patch list:\n            1. api\n            2. image\n            3. network\n            4. object\n            5. volume\n            6. tests\n\n        Partial-Implements: blueprint replace-iteritems-with-items\n\nChange-Id: I8ac4f96d606a4530209de914542e035c3bd970c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d7a9d516bdf82af019db8eccc91dd40a06c48adf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d7a9d516bdf82af019db8eccc91dd40a06c48adf"}]},"branch":"refs/heads/master"},"69a550bd70766c0fe3716ba93fc4dee186c310ce":{"kind":"REWORK","_number":2,"created":"2017-03-16 02:00:19.000000000","uploader":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"ref":"refs/changes/78/445878/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/78/445878/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/78/445878/2"}}},"commit":{"parents":[{"commit":"60c807392bf105d86491796609ba2a181903084f","subject":"[2/3]Replace six.iteritems() with .items()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/60c807392bf105d86491796609ba2a181903084f"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-15 11:09:40.000000000","tz":480},"committer":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-03-16 01:51:04.000000000","tz":480},"subject":"[3/3]Replace six.iteritems() with .items()","message":"[3/3]Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be\nnegligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nThe patch list:\n    1. api\n    2. image\n    3. network\n    4. object\n    5. volume\n    6. tests\n\nPartial-Implements: blueprint replace-iteritems-with-items\n\nChange-Id: I8ac4f96d606a4530209de914542e035c3bd970c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/69a550bd70766c0fe3716ba93fc4dee186c310ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/69a550bd70766c0fe3716ba93fc4dee186c310ce"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}