)]}'
{"id":"openstack%2Fpython-openstackclient~446892","triplet_id":"openstack%2Fpython-openstackclient~master~I9bbe6922f5b5476be186dfa30fb79c548ecc5df9","project":"openstack/python-openstackclient","branch":"master","topic":"bp/add-sort-option","hashtags":[],"change_id":"I9bbe6922f5b5476be186dfa30fb79c548ecc5df9","subject":"Add \"--sort\" option to \"volume backup list\" in a common way","status":"ABANDONED","created":"2017-03-17 08:43:23.000000000","updated":"2021-03-19 18:22:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5d65e0464821f18d40d940e47fcfa274c0041c20","_number":446892,"virtual_id_number":446892,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"date":"2017-03-21 02:06:08.000000000","_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"date":"2017-03-20 15:35:08.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2017-03-17 15:24:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-17 15:24:48.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-03-20 15:35:08.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"7fbf311bbf32ad9cc1c281bf65d091e3891acefb","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2017-03-17 08:43:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"88b38556b06183f1d0667cae68cd110e82c13bf8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 10:05:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/92/446892/1/check/gate-python-openstackclient-docs-ubuntu-xenial/29de4db//doc/build/html/ : SUCCESS in 4m 05s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/92/446892/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/4fb9683/ : SUCCESS in 6m 49s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/92/446892/1/check/gate-python-openstackclient-python27-ubuntu-xenial/a05b4aa/ : SUCCESS in 3m 48s\n- gate-python-openstackclient-python35 http://logs.openstack.org/92/446892/1/check/gate-python-openstackclient-python35/efd6f8d/ : SUCCESS in 4m 21s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/92/446892/1/check/gate-python-openstackclient-releasenotes/dde79d1//releasenotes/build/html/ : SUCCESS in 2m 39s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/92/446892/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/49dc540/ : SUCCESS in 1h 17m 39s\n- check-osc-plugins http://logs.openstack.org/92/446892/1/check/check-osc-plugins/071c863/ : SUCCESS in 3m 36s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/92/446892/1/check/gate-osc-dsvm-functional-ubuntu-xenial/9386e58/ : SUCCESS in 31m 43s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/92/446892/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/cb799fb/ : FAILURE in 32m 53s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/92/446892/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/ad6585b/ : SUCCESS in 1h 07m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3d33ba75773fccbf26f86754a67301648d47777b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-03-17 15:24:48.000000000","message":"Patch Set 1: Code-Review+2\n\nwe also have this with project and images, we should have the same pattern for all of them if possible","accounts_in_message":[],"_revision_number":1},{"id":"b62f76ed332af66baa1ed3c4511cd0ba9b44e249","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-03-20 15:35:08.000000000","message":"Patch Set 1:\n\nIt seems a bit overkill to create a new common file and function to add a single parser argument.","accounts_in_message":[],"_revision_number":1},{"id":"7725c5c377a74b397af7d5060691163186f94313","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2017-03-21 02:06:08.000000000","message":"Patch Set 1:\n\n\u003e It seems a bit overkill to create a new common file and function to\n \u003e add a single parser argument.\n\nYea, a bit overkill. I am thinking about other ways, what about:\n\nAdd this option to identity/common.py since some identity commands will also use it, and we can see there have been some common options in there.\n\nOr just leave it as-if, we maybe have some more common functions for volume and we may beef up this in the future","accounts_in_message":[],"_revision_number":1},{"id":"72d9063ed9ff60993b1d0a5331cfce6d17fb2183","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-03-23 15:45:14.000000000","message":"Patch Set 1:\n\nOr just follow the established pattern in the rest of OSC and put the declaration inline as required by the commands.\n\nI believe strongly that it is better documenting for future developers to have those in one place rather than scattered all over.\n\nThere are exceptions, and I think the Identity domain args is a good example, that appears all over, but I\u0027ve seen a lot of this happening that does not reach that high bar.","accounts_in_message":[],"_revision_number":1},{"id":"7533b9bf441a8ef280f8adea289777c83d88c452","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-23 20:36:43.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"fd221636ab862b6b96ec356a41cc3793b6286251","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 03:11:36.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":1},{"id":"5d65e0464821f18d40d940e47fcfa274c0041c20","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-19 18:22:49.000000000","message":"Abandoned\n\nThis never got broad agreement and there\u0027s an existing \u0027--sort\u0027 option in cliff that we could reuse if we went this way","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1b8053b25a30e756f7b736181bf086e9b359b4a6","revisions":{"1b8053b25a30e756f7b736181bf086e9b359b4a6":{"kind":"REWORK","_number":1,"created":"2017-03-17 08:43:23.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/92/446892/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/92/446892/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/92/446892/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/92/446892/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/92/446892/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/92/446892/1"}}},"commit":{"parents":[{"commit":"ad5b57fd19d08bb16c539a042f0a48653b700b4a","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ad5b57fd19d08bb16c539a042f0a48653b700b4a"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2017-03-17 08:39:36.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2017-03-17 08:39:36.000000000","tz":480},"subject":"Add \"--sort\" option to \"volume backup list\" in a common way","message":"Add \"--sort\" option to \"volume backup list\" in a common way\n\nAdd a commom method \"add_sort_option_to_parser()\"\nto support adding \"--sort\" option for list commands.\nthis review use it for \"volume backup list\" command first.\n\nChange-Id: I9bbe6922f5b5476be186dfa30fb79c548ecc5df9\nImplements: bp add-sort-option\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1b8053b25a30e756f7b736181bf086e9b359b4a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1b8053b25a30e756f7b736181bf086e9b359b4a6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}