)]}'
{"doc/source/command-objects/router.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"640ceb918480e43a0cca7ea596b32cfbe3d4a068","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Create a distributed router"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --ha"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    Create a highly available router"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. option:: --no-ha"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    Create a legacy router"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_4288471e","line":99,"range":{"start_line":93,"start_character":0,"end_line":99,"end_character":26},"updated":"2017-03-24 02:09:16.000000000","message":"Which one is the default when both are not specified? You can add a \"(default)\" in the help message for the default one.","commit_id":"bac41c83e03cba60ae97750e13cf3a81e0629ce0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4a675a20ab8019a42712ec373e5ce3cd3b444564","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Create a distributed router"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --ha"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    Create a highly available router"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. option:: --no-ha"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    Create a legacy router"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_f3aa8f17","line":99,"range":{"start_line":93,"start_character":0,"end_line":99,"end_character":26},"in_reply_to":"ffe62b97_4288471e","updated":"2017-03-24 04:27:18.000000000","message":"Hi Huanxuan , \nActually , if the right configuration information is updated, only HA routers would be created on Router create.\nThat means, that a part of the router creation procedure depends on the entries in neutron.conf\n\nThis patch allows to overwrite this behavior and make a Legacy router even if the conf information is set...","commit_id":"bac41c83e03cba60ae97750e13cf3a81e0629ce0"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"936a48c64b2584abe091447164ed2ab288212550","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Create a distributed router"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --ha"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    Create a highly available router"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. option:: --no-ha"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    Create a legacy router"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_4be3b406","line":99,"range":{"start_line":93,"start_character":0,"end_line":99,"end_character":26},"in_reply_to":"ffe62b97_b9cbc51c","updated":"2017-03-24 10:56:16.000000000","message":"@Reedip, @Cedric Brandily, Thank you for the explanation! LGTM","commit_id":"bac41c83e03cba60ae97750e13cf3a81e0629ce0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"628d6b94e9456b9055f87ef3088b20c41319d8e3","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Create a distributed router"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --ha"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    Create a highly available router"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. option:: --no-ha"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    Create a legacy router"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_b9cbc51c","line":99,"range":{"start_line":93,"start_character":0,"end_line":99,"end_character":26},"in_reply_to":"ffe62b97_f3aa8f17","updated":"2017-03-24 08:01:53.000000000","message":"Exactly the default behavior depends on neutron server configuration","commit_id":"bac41c83e03cba60ae97750e13cf3a81e0629ce0"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"72919d5184df49d694f1c624876ada5aa21f2083","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":224,"context_line":"        if parsed_args.ha:"},{"line_number":225,"context_line":"            attrs[\u0027ha\u0027] \u003d True"},{"line_number":226,"context_line":"        elif parsed_args.no_ha:"},{"line_number":227,"context_line":"            attrs[\u0027ha\u0027] \u003d False"},{"line_number":228,"context_line":"        obj \u003d client.create_router(**attrs)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_5e5c547d","line":226,"range":{"start_line":226,"start_character":8,"end_line":226,"end_character":12},"updated":"2017-03-27 08:59:02.000000000","message":"s/elif/if/, just a small issue, no value to -1.\n\nAccording to devref[1]\n\n[1]: https://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"d7fb0e6aa3edbb55f6c7a9a787a9bf156c1122e8"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"022795343471b4a34d113996d969165e30caa300","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":224,"context_line":"        if parsed_args.ha:"},{"line_number":225,"context_line":"            attrs[\u0027ha\u0027] \u003d True"},{"line_number":226,"context_line":"        elif parsed_args.no_ha:"},{"line_number":227,"context_line":"            attrs[\u0027ha\u0027] \u003d False"},{"line_number":228,"context_line":"        obj \u003d client.create_router(**attrs)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_6a062bd1","line":226,"range":{"start_line":226,"start_character":8,"end_line":226,"end_character":12},"in_reply_to":"ffe62b97_5e5c547d","updated":"2017-03-27 11:07:50.000000000","message":"[1] is an \"example handler\" using if/if ... not the pattern we should use. \n\nMoreover i don\u0027t understand why we should check L226 condition even when L224 condition is satisfied.","commit_id":"d7fb0e6aa3edbb55f6c7a9a787a9bf156c1122e8"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"221097fe850f5dfaff37c25289060e33acc157b6","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":224,"context_line":"        if parsed_args.ha:"},{"line_number":225,"context_line":"            attrs[\u0027ha\u0027] \u003d True"},{"line_number":226,"context_line":"        elif parsed_args.no_ha:"},{"line_number":227,"context_line":"            attrs[\u0027ha\u0027] \u003d False"},{"line_number":228,"context_line":"        obj \u003d client.create_router(**attrs)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_4d5ff30d","line":226,"in_reply_to":"ffe62b97_6a062bd1","updated":"2017-03-27 16:11:57.000000000","message":"This is actually checking two different argparse options.  Even if they may be exclusive in argparse, there are no guarantees of that, so we like the consistent pattern in take_action().  It makes it simpler, especially when options are changed later or code is copy-n-pasted elsewhere.","commit_id":"d7fb0e6aa3edbb55f6c7a9a787a9bf156c1122e8"}]}