)]}'
{"id":"openstack%2Fpython-openstackclient~449559","triplet_id":"openstack%2Fpython-openstackclient~master~I6aa76cea5dd45cefba840d7f960289f7f5e49c57","project":"openstack/python-openstackclient","branch":"master","topic":"doc-fix","hashtags":[],"change_id":"I6aa76cea5dd45cefba840d7f960289f7f5e49c57","subject":"Unified the version marks of options in OSC","status":"ABANDONED","created":"2017-03-24 10:41:55.000000000","updated":"2022-03-09 17:43:48.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bb54043ce7b040caa0c4b1100b7cb6d1376b8bea","_number":449559,"virtual_id_number":449559,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2017-03-24 11:30:52.000000000","_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"disliked":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":2,"date":"2017-03-24 15:09:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":-1,"date":"2017-03-24 17:38:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"date":"2017-03-25 09:41:44.000000000","_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-24 15:09:16.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-03-24 17:38:04.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-03-25 09:41:44.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"}],"messages":[{"id":"da3db26b11f254dca333b21fe059ebbeab090b7c","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2017-03-24 10:41:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66bcc13e306002f7f89f09cd450847613fae71e4","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2017-03-24 10:57:07.000000000","message":"Patch Set 1:\n\nAre you sure that both are supposed to mean the same? For example if there will be a version 4, than \"version 3 only\" means it is only not included in version 4 anymore, while \"versionadded:: 3\" means it is included in version 3 and any later version.","accounts_in_message":[],"_revision_number":1},{"id":"073003bf145ae668f3fd777631602b7f2e71d5a3","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2017-03-24 11:30:52.000000000","message":"Patch Set 1:\n\n\u003e Are you sure that both are supposed to mean the same? For example\n \u003e if there will be a version 4, than \"version 3 only\" means it is\n \u003e only not included in version 4 anymore, while \"versionadded:: 3\"\n \u003e means it is included in version 3 and any later version.\n\nGood point! But for now they are supposed to mean the same since we have no more newer version, and I think we cannot sure what options will exist in the newer wersion, in my option maybe \"version X only\" is safer for now since it just descripe the version we can see now (include nothing of the future).","accounts_in_message":[],"_revision_number":1},{"id":"0b97f60cb00f7d12c3a1a91914f9d9b11a18a3d1","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2017-03-24 11:35:38.000000000","message":"Patch Set 1:\n\n\u003e \u003e Are you sure that both are supposed to mean the same? For example\n \u003e \u003e if there will be a version 4, than \"version 3 only\" means it is\n \u003e \u003e only not included in version 4 anymore, while \"versionadded:: 3\"\n \u003e \u003e means it is included in version 3 and any later version.\n \u003e \n \u003e Good point! But for now they are supposed to mean the same since we\n \u003e have no more newer version, and I think we cannot sure what options\n \u003e will exist in the newer wersion, in my option maybe \"version X\n \u003e only\" is safer for now since it just descripe the version we can\n \u003e see now (include nothing of the future).\n\nOk, you are right. But since the standard behaviour is probably that new versions don\u0027t delete options but add them, I\u0027d prefer to use only \"versionadded:: 3\" instead of only using \"version 3 only\".\n\nWhat do you think?","accounts_in_message":[],"_revision_number":1},{"id":"e228efa11c6bd90a2b92202681cd16a84918a21b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-24 12:07:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/449559/1/check/gate-python-openstackclient-docs-ubuntu-xenial/871c373//doc/build/html/ : SUCCESS in 4m 16s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/8623eb8/ : SUCCESS in 6m 32s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-python-openstackclient-python27-ubuntu-xenial/1c5946b/ : SUCCESS in 5m 28s\n- gate-python-openstackclient-python35 http://logs.openstack.org/59/449559/1/check/gate-python-openstackclient-python35/b5c8420/ : SUCCESS in 4m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/dc396a3/ : SUCCESS in 1h 22m 29s\n- check-osc-plugins http://logs.openstack.org/59/449559/1/check/check-osc-plugins/5945683/ : SUCCESS in 4m 21s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-osc-dsvm-functional-ubuntu-xenial/c6c4435/ : FAILURE in 41m 33s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/59/449559/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/d78d577/ : FAILURE in 46m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fac9566411ae33ddb6f0431d8c31524606f74811","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-03-24 15:09:16.000000000","message":"Patch Set 1: Code-Review+2\n\nthanks for making these consistent","accounts_in_message":[],"_revision_number":1},{"id":"af31d250edf38e00cc0eb3b85a93b83b36406da3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-03-24 15:09:19.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"16cf265f4c037d2585a4a25c9507dd492f6a78ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-24 16:27:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/59/449559/1/check/gate-python-openstackclient-docs-ubuntu-xenial/2a88935//doc/build/html/ : SUCCESS in 4m 24s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/f8edb9d/ : SUCCESS in 6m 46s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-python-openstackclient-python27-ubuntu-xenial/29e091c/ : SUCCESS in 6m 00s\n- gate-python-openstackclient-python35 http://logs.openstack.org/59/449559/1/check/gate-python-openstackclient-python35/fa1f1d9/ : SUCCESS in 6m 42s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/37b4820/ : SUCCESS in 1h 17m 28s\n- check-osc-plugins http://logs.openstack.org/59/449559/1/check/check-osc-plugins/078e031/ : SUCCESS in 3m 45s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/59/449559/1/check/gate-osc-dsvm-functional-ubuntu-xenial/982b522/ : SUCCESS in 34m 22s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/59/449559/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/ce4f7a9/ : FAILURE in 54m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a9ef25a1db26ecfc335feb9072be572d82a8e061","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-03-24 17:38:04.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nWe already do have a case where there are at least two versions required to be mentioned, Volume v3.","accounts_in_message":[],"_revision_number":1},{"id":"932a1b05a9b64fcee88f1f6621546f15e4555879","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2017-03-25 09:51:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI\u0027d propose to use \"versionadded\" wherever the feature is still available.","accounts_in_message":[],"_revision_number":1},{"id":"586806f099db962efac17e626b9948b0ebfc431e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-23 20:36:43.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"9f81d2fbe5c1202938250a61c6fdf7aaad202005","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2017-06-23 20:47:32.000000000","message":"Removed the following votes:\n\n* Code-Review-1 by David Rabel \u003crabel@b1-systems.de\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"032014e0af160ab8ae5dfaa79c9e77912dc335a2","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 03:11:34.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":1},{"id":"bb54043ce7b040caa0c4b1100b7cb6d1376b8bea","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-03-09 17:43:48.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f17b50d5539687b6bba6cdb7ad393ce219b63fe9","revisions":{"f17b50d5539687b6bba6cdb7ad393ce219b63fe9":{"kind":"REWORK","_number":1,"created":"2017-03-24 10:41:55.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/59/449559/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/59/449559/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/59/449559/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/59/449559/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/59/449559/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/59/449559/1"}}},"commit":{"parents":[{"commit":"2a64a6404681e0cea5896a02573a8be03dd1a7d3","subject":"Merge \"OSC Extension Show\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2a64a6404681e0cea5896a02573a8be03dd1a7d3"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2017-03-24 10:29:53.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2017-03-24 10:29:53.000000000","tz":480},"subject":"Unified the version marks of options in OSC","message":"Unified the version marks of options in OSC\n\nIn OSC, most of one-version-only options were\nmarked as *XXX version X only*, but some others\nmarkes as \".. versionadded:: X\". it may confuse\nusers, so maybe we can unified the version marks\nwith the same format.\n\nChange-Id: I6aa76cea5dd45cefba840d7f960289f7f5e49c57\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f17b50d5539687b6bba6cdb7ad393ce219b63fe9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f17b50d5539687b6bba6cdb7ad393ce219b63fe9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}