)]}'
{"id":"openstack%2Fpython-openstackclient~457402","triplet_id":"openstack%2Fpython-openstackclient~master~If230f128e91cda44461fe93c976cac2aecec2252","project":"openstack/python-openstackclient","branch":"master","topic":"compute-api-networks","hashtags":[],"change_id":"If230f128e91cda44461fe93c976cac2aecec2252","subject":"Low-level Compute v2 API: network","status":"MERGED","created":"2017-04-18 00:11:07.000000000","updated":"2017-04-18 13:34:52.000000000","submitted":"2017-04-18 13:34:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d81b6978880cc37c1f12474ce5367829f311cd80","_number":457402,"virtual_id_number":457402,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-04-18 13:34:52.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2017-04-18 00:53:48.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-04-18 09:11:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":2,"date":"2017-04-18 12:19:45.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":1,"date":"2017-04-18 12:19:45.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-18 00:53:48.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-04-18 09:11:06.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2017-04-18 13:34:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"11b4ad82780356acf5face8ee380695e4cadb66b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-04-18 00:11:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1cd3094d11543aab143f9f20c431490d568a12de","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-04-18 00:49:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"63dc9acd8b76921823b00c44fcd3e3a19a77c1dc","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-04-18 00:53:48.000000000","message":"Patch Set 2: Code-Review+2\n\nthis one was much easier to follow","accounts_in_message":[],"_revision_number":2},{"id":"b7a0ce34f32e58c37c5dc28cb3a72edebbab3ff5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 02:22:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/02/457402/2/check/gate-python-openstackclient-docs-ubuntu-xenial/ea97a0b//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/d01e376/ : SUCCESS in 3m 57s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-python-openstackclient-python27-ubuntu-xenial/f5ef0ba/ : SUCCESS in 4m 43s\n- gate-python-openstackclient-python35 http://logs.openstack.org/02/457402/2/check/gate-python-openstackclient-python35/6ca1518/ : SUCCESS in 2m 39s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/6085e96/ : SUCCESS in 1h 21m 25s\n- check-osc-plugins http://logs.openstack.org/02/457402/2/check/check-osc-plugins/aa812c2/ : SUCCESS in 3m 40s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-osc-dsvm-functional-ubuntu-xenial/5c96e68/ : FAILURE in 45m 02s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/02/457402/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/f9c2835/ : FAILURE in 44m 19s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/02/457402/2/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/65812b7/ : SUCCESS in 1h 33m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0e975a7c8077fe5a87b0f635735259297f2525a6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-04-18 03:08:36.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"04c8e58f9bb58626173a7baaabca41e3e2d11012","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 04:50:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/02/457402/2/check/gate-python-openstackclient-docs-ubuntu-xenial/0667156//doc/build/html/ : SUCCESS in 3m 12s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/d2ebef7/ : SUCCESS in 3m 26s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-python-openstackclient-python27-ubuntu-xenial/e6fb3ca/ : SUCCESS in 2m 34s\n- gate-python-openstackclient-python35 http://logs.openstack.org/02/457402/2/check/gate-python-openstackclient-python35/9599774/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/742b839/ : SUCCESS in 1h 01m 55s\n- check-osc-plugins http://logs.openstack.org/02/457402/2/check/check-osc-plugins/68f1ccf/ : SUCCESS in 6m 56s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/02/457402/2/check/gate-osc-dsvm-functional-ubuntu-xenial/48aafb6/ : SUCCESS in 37m 31s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/02/457402/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/33c8ec1/ : FAILURE in 44m 48s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/02/457402/2/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/397b373/ : SUCCESS in 1h 39m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"91f3edaf5194a4264a94bd717b54309eee891a63","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2017-04-18 09:11:06.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, two things I need to make sure:\n1. we will switch to compute client.api in NetworkAndCompute* classes at the end of serial changes merged, right?\n2. I think if we have a jenkins job that enable n-net to verify all the changes in functional tests, that\u0027s good, nova might remove the configuration \"use_neutron\" in Queens release, only one release(Pike) is available for us, I\u0027m not sure whether we should add the jenkins job? I would like to do it.","accounts_in_message":[],"_revision_number":2},{"id":"98a82dfb9842c84867a2659bc59a82d5acd59dfc","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-04-18 12:19:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nRui,\n\n1. I am doing this in compute due to the novaclient 8.0 removals that we still need to support, no plans right now to move all of it\n\n2. We do need a nova-net job for this in functional tests but that will only live for as long as we test a nova-net-capable release in CI; mitaka is going away soon.  This is one of the downsides to attempting to continue to support things that are unsupported elsewhere.","accounts_in_message":[],"_revision_number":2},{"id":"c07564ba3daa469271fe659e04611f9f50a5554a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 12:20:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f70b5a3648461870e27a1fdfedc57fc89610b5af","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2017-04-18 12:34:22.000000000","message":"Patch Set 2:\n\nMy fault, I found the code in compute make_client()[1], don\u0027t need to change NetworkAndCompute* classes anymore.\n\n[1]: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/client.py#L92-L100","accounts_in_message":[],"_revision_number":2},{"id":"bb1bdb5c3dba0f3491d6885bae831fc165d26b7e","date":"2017-04-18 13:34:52.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"d5a3bb8864ef13a57e7708ba85d8ac6682b10b17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 13:34:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/02/457402/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/c860ff0//doc/build/html/ : SUCCESS in 5m 02s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/02/457402/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/38ae361/ : SUCCESS in 7m 29s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/02/457402/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/fa2ee5f/ : SUCCESS in 6m 50s\n- gate-python-openstackclient-python35 http://logs.openstack.org/02/457402/2/gate/gate-python-openstackclient-python35/68a159d/ : SUCCESS in 6m 50s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/02/457402/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/2b29ec8/ : SUCCESS in 1h 14m 33s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/02/457402/2/gate/gate-osc-dsvm-functional-ubuntu-xenial/8fa1f93/ : SUCCESS in 41m 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b2783dc3c44f5843a25770ff749d7a0de18b8dfc","revisions":{"13aaa7744cef6e75dbb93381862e7cf62f162b10":{"kind":"REWORK","_number":1,"created":"2017-04-18 00:11:07.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/02/457402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/02/457402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/1"}}},"commit":{"parents":[{"commit":"6f473be588a7d0dcd10ca189e3e1dba45a6eb2fe","subject":"Split network tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f473be588a7d0dcd10ca189e3e1dba45a6eb2fe"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2017-04-17 22:04:43.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2017-04-18 00:09:36.000000000","tz":-300},"subject":"Low-level Compute v2 API: network","message":"Low-level Compute v2 API: network\n\napi.compute.APIv2 network functions.\n\nnovaclient 8.0 is now released without support for the previously\ndeprecated nova-net functions, so include a new low-level REST\nimplementation of the removed APIs.\n\nChange-Id: If230f128e91cda44461fe93c976cac2aecec2252\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/13aaa7744cef6e75dbb93381862e7cf62f162b10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/13aaa7744cef6e75dbb93381862e7cf62f162b10"}]},"branch":"refs/heads/master"},"b2783dc3c44f5843a25770ff749d7a0de18b8dfc":{"kind":"REWORK","_number":2,"created":"2017-04-18 00:49:00.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/02/457402/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/02/457402/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/02/457402/2"}}},"commit":{"parents":[{"commit":"6f473be588a7d0dcd10ca189e3e1dba45a6eb2fe","subject":"Split network tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f473be588a7d0dcd10ca189e3e1dba45a6eb2fe"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2017-04-17 22:04:43.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2017-04-18 00:45:21.000000000","tz":-300},"subject":"Low-level Compute v2 API: network","message":"Low-level Compute v2 API: network\n\napi.compute.APIv2 network functions.\n\nnovaclient 8.0 is now released without support for the previously\ndeprecated nova-net functions, so include a new low-level REST\nimplementation of the removed APIs.\n\nChange-Id: If230f128e91cda44461fe93c976cac2aecec2252\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b2783dc3c44f5843a25770ff749d7a0de18b8dfc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b2783dc3c44f5843a25770ff749d7a0de18b8dfc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}