)]}'
{"openstackclient/network/v2/network_qos_rule.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f2238c6ea1bf72aac1f25c36336ff77309f3530f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"REQUIRED_PARAMETERS \u003d {"},{"line_number":30,"context_line":"    RULE_TYPE_MINIMUM_BANDWIDTH: {\u0027min_kbps\u0027, \u0027direction\u0027},"},{"line_number":31,"context_line":"    RULE_TYPE_DSCP_MARKING: {\u0027dscp_mark\u0027},"},{"line_number":32,"context_line":"    RULE_TYPE_BANDWIDTH_LIMIT: {\u0027max_kbps\u0027, \u0027max_burst_kbps\u0027, \u0027direction\u0027}}"},{"line_number":33,"context_line":"DIRECTION_EGRESS \u003d \u0027egress\u0027"},{"line_number":34,"context_line":"DIRECTION_INGRESS \u003d \u0027ingress\u0027"},{"line_number":35,"context_line":"DSCP_VALID_MARKS \u003d [0, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30, 32,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_7a1566e4","line":32,"updated":"2017-06-16 16:39:44.000000000","message":"direction is not required parameter, it\u0027s optional and default will be \"egress\" if it\u0027s not given","commit_id":"7fab12295ff760a47bb24ad8ef82b7d6283bc2ab"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264fc8b72c8f3b6655fdce75c66c294ca6a639df","unresolved":false,"context_lines":[{"line_number":29,"context_line":"REQUIRED_PARAMETERS \u003d {"},{"line_number":30,"context_line":"    RULE_TYPE_MINIMUM_BANDWIDTH: {\u0027min_kbps\u0027, \u0027direction\u0027},"},{"line_number":31,"context_line":"    RULE_TYPE_DSCP_MARKING: {\u0027dscp_mark\u0027},"},{"line_number":32,"context_line":"    RULE_TYPE_BANDWIDTH_LIMIT: {\u0027max_kbps\u0027, \u0027max_burst_kbps\u0027, \u0027direction\u0027}}"},{"line_number":33,"context_line":"DIRECTION_EGRESS \u003d \u0027egress\u0027"},{"line_number":34,"context_line":"DIRECTION_INGRESS \u003d \u0027ingress\u0027"},{"line_number":35,"context_line":"DSCP_VALID_MARKS \u003d [0, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30, 32,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_ca4a2582","line":32,"in_reply_to":"7f231b9d_7a1566e4","updated":"2017-06-20 07:53:06.000000000","message":"You are right. The directionality is optional and the default value is set by the backend.","commit_id":"7fab12295ff760a47bb24ad8ef82b7d6283bc2ab"}],"openstackclient/tests/functional/network/v2/test_network_qos_rule.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8bb334edd340601f2f8e83981b1f817c84868dce","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                    self.QOS_POLICY_NAME + \u0027 \u0027 + self.RULE_ID +"},{"line_number":242,"context_line":"                                    opts)"},{"line_number":243,"context_line":"        self.assertEqual(str(self.MAX_BURST_KBITS_MODIFIED) + \"\\n\", raw_output)"},{"line_number":244,"context_line":"        opts \u003d self.get_opts([\u0027direction\u0027])"},{"line_number":245,"context_line":"        raw_output \u003d self.openstack(\u0027network qos rule show \u0027 +"},{"line_number":246,"context_line":"                                    self.QOS_POLICY_NAME + \u0027 \u0027 + self.RULE_ID +"},{"line_number":247,"context_line":"                                    opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_6f20ec9b","line":244,"range":{"start_line":244,"start_character":15,"end_line":244,"end_character":43},"updated":"2017-06-08 09:35:16.000000000","message":"We can put the serial three \"network qos rule show\" commands together with multiple options that you want to assert, the rule show command only need to execute once, like this:\n\n    opts \u003d self.get_opts([\u0027direction\u0027, \u0027max_kbps\u0027, \u0027max_burst_kbps\u0027])\n\nthen assert the expected value in the raw output, of course, json format is better.","commit_id":"e323258d93a2fdd2277c25f32604cd68813b655c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"41dfdfb6244c79db87e805017c3bfd172e256620","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                    self.QOS_POLICY_NAME + \u0027 \u0027 + self.RULE_ID +"},{"line_number":242,"context_line":"                                    opts)"},{"line_number":243,"context_line":"        self.assertEqual(str(self.MAX_BURST_KBITS_MODIFIED) + \"\\n\", raw_output)"},{"line_number":244,"context_line":"        opts \u003d self.get_opts([\u0027direction\u0027])"},{"line_number":245,"context_line":"        raw_output \u003d self.openstack(\u0027network qos rule show \u0027 +"},{"line_number":246,"context_line":"                                    self.QOS_POLICY_NAME + \u0027 \u0027 + self.RULE_ID +"},{"line_number":247,"context_line":"                                    opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_b8ce6e57","line":244,"range":{"start_line":244,"start_character":15,"end_line":244,"end_character":43},"in_reply_to":"df140735_6f20ec9b","updated":"2017-06-16 14:32:49.000000000","message":"Done","commit_id":"e323258d93a2fdd2277c25f32604cd68813b655c"}],"releasenotes/notes/add-direction-to-network-qos-bw-limit-rule-a3c5b6892074d5ae.yaml":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8bb334edd340601f2f8e83981b1f817c84868dce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added directionality to Network QoS rule type ``bandwidth-limit``."},{"line_number":5,"context_line":"    Possible choices are ``--egress`` or ``--ingress``. This parameter"},{"line_number":6,"context_line":"    is available in ``openstack network qos rule create`` and"},{"line_number":7,"context_line":"    ``openstack network qos rule set``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df140735_0606521e","line":7,"updated":"2017-06-08 09:35:16.000000000","message":"please add bug link[1], we can know the original needs.\n\n[1]: https://bugs.launchpad.net/python-openstackclient/+bug/1614121","commit_id":"e323258d93a2fdd2277c25f32604cd68813b655c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"41dfdfb6244c79db87e805017c3bfd172e256620","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added directionality to Network QoS rule type ``bandwidth-limit``."},{"line_number":5,"context_line":"    Possible choices are ``--egress`` or ``--ingress``. This parameter"},{"line_number":6,"context_line":"    is available in ``openstack network qos rule create`` and"},{"line_number":7,"context_line":"    ``openstack network qos rule set``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f231b9d_f8b3c6e7","line":7,"in_reply_to":"df140735_0606521e","updated":"2017-06-16 14:32:49.000000000","message":"Done","commit_id":"e323258d93a2fdd2277c25f32604cd68813b655c"}]}