)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eea58cded1028fedd4bf442da7a9d01cd081f95","unresolved":false,"context_lines":[{"line_number":12,"context_line":"1.live migrate with host that is choosed by nova automatically"},{"line_number":13,"context_line":"2.live migrate with exact host that is specified by user"},{"line_number":14,"context_line":"3.no-live(cold) migrate with host that is choosed by nova automatically"},{"line_number":15,"context_line":"4.no-live(cold) migrate with exact host that is specified by user"},{"line_number":16,"context_line":"5.add \"force\" option to make nova don\u0027t check the dest host for live and"},{"line_number":17,"context_line":"no-live"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_25413ea7","line":15,"updated":"2018-06-08 14:07:14.000000000","message":"This requires microversion \u003e\u003d2.56:\n\nhttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id51\n\nSo we need to be clear about that in the option usage / help text.\n\nHowever, I don\u0027t see any cold migration support in here.\n\nWhat I\u0027d really just do with this command is this:\n\n1. Change --live to not be a hostname.\n2. Add a new --host option (not required).\n3. Add a new --cold option for cold migration.\n\nThen you can do live and cold migration with or without specifying a host. There are microversion restrictions based on what you\u0027re doing, as noted above, but that can be worked into each combination as appropriate.\n\nAnd then leave --force for another day / separate patch.","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f672a90253cbb34873ed0c02a22b58734958fdf2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"1.live migrate with host that is choosed by nova automatically"},{"line_number":13,"context_line":"2.live migrate with exact host that is specified by user"},{"line_number":14,"context_line":"3.no-live(cold) migrate with host that is choosed by nova automatically"},{"line_number":15,"context_line":"4.no-live(cold) migrate with exact host that is specified by user"},{"line_number":16,"context_line":"5.add \"force\" option to make nova don\u0027t check the dest host for live and"},{"line_number":17,"context_line":"no-live"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_75881f70","line":15,"in_reply_to":"5f7c97a3_25413ea7","updated":"2018-06-11 15:32:01.000000000","message":"I mostly agree with Matt here.  I wonder if it might make sense to keep backwards compatibility by just making the hostname after \"--live\" be optional, so that you could have:\n\nopenstack server migrate --live \u003cserver\u003e\nopenstack server migrate --live \u003chostname\u003e \u003cserver\u003e\nopenstack server migrate server\nopenstack server migrate \u003chostname\u003e server\n\nIn the latter two cases we could add a \"--cold\" which would make the migration type explicit but would be the same as not specifying \"--live\".","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8c4e4f98cf36d333a7f987c3b69efefb3e3fe651","unresolved":false,"context_lines":[{"line_number":13,"context_line":"2.live migrate with exact host that is specified by user"},{"line_number":14,"context_line":"3.no-live(cold) migrate with host that is choosed by nova automatically"},{"line_number":15,"context_line":"4.no-live(cold) migrate with exact host that is specified by user"},{"line_number":16,"context_line":"5.add \"force\" option to make nova don\u0027t check the dest host for live and"},{"line_number":17,"context_line":"no-live"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Add new option --live-auto to support case #1:"},{"line_number":20,"context_line":"    server migrate --live-auto \u003cserver\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff346bd7_8be825e2","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":7},"updated":"2017-07-26 14:43:01.000000000","message":"the \"force\" options are not implemented yet, is this still WIP? or in another patch?","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc84d688be3a842beea833e38a6bfea55cab0f5b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"2.live migrate with exact host that is specified by user"},{"line_number":14,"context_line":"3.no-live(cold) migrate with host that is choosed by nova automatically"},{"line_number":15,"context_line":"4.no-live(cold) migrate with exact host that is specified by user"},{"line_number":16,"context_line":"5.add \"force\" option to make nova don\u0027t check the dest host for live and"},{"line_number":17,"context_line":"no-live"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Add new option --live-auto to support case #1:"},{"line_number":20,"context_line":"    server migrate --live-auto \u003cserver\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_bdeb2876","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":7},"in_reply_to":"ff346bd7_8be825e2","updated":"2018-06-08 13:50:00.000000000","message":"Yeah I just noticed that also....\n\nI don\u0027t really want us to expose the forced host live migration anyway, since it can cause all sorts of problems, but it\u0027s in the API so I suppose people will use it, but if add an option for that it needs a big fat warning on it, like in the API reference:\n\nhttps://developer.openstack.org/api-ref/compute/#live-migrate-server-os-migratelive-action","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc84d688be3a842beea833e38a6bfea55cab0f5b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Add new option --force to support case #5:"},{"line_number":34,"context_line":"    server migrate --live \u003chostname\u003e --force \u003cserver\u003e"},{"line_number":35,"context_line":"    server migrate --no-live \u003chostname\u003e --force \u003cserver\u003e"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Related patches: https://review.openstack.org/#/c/459667/"},{"line_number":38,"context_line":"https://review.openstack.org/#/c/427565/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_1de33ca6","line":35,"updated":"2018-06-08 13:50:00.000000000","message":"There is no forced cold migration.","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc84d688be3a842beea833e38a6bfea55cab0f5b","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        live_group.add_argument("},{"line_number":1218,"context_line":"            \u0027--live\u0027,"},{"line_number":1219,"context_line":"            metavar\u003d\u0027\u003chostname\u003e\u0027,"},{"line_number":1220,"context_line":"            help\u003d_(\u0027Destination hostname for live migrate\u0027),"},{"line_number":1221,"context_line":"        )"},{"line_number":1222,"context_line":"        live_group.add_argument("},{"line_number":1223,"context_line":"            \u0027--live-auto\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_1dfc9c3c","line":1220,"updated":"2018-06-08 13:50:00.000000000","message":"We should put a warning in here that matches the API reference, which is that before microversion 2.30, the specified host was not validated by the scheduler, so if you\u0027re going to specify a host, it is strongly recommended that you run this will --os-compute-api-version \u003e\u003d 2.30.","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4ddf6811109aed41fa761a2c660309ca55039d34","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        live_group.add_argument("},{"line_number":1218,"context_line":"            \u0027--live\u0027,"},{"line_number":1219,"context_line":"            metavar\u003d\u0027\u003chostname\u003e\u0027,"},{"line_number":1220,"context_line":"            help\u003d_(\u0027Destination hostname for live migrate\u0027),"},{"line_number":1221,"context_line":"        )"},{"line_number":1222,"context_line":"        live_group.add_argument("},{"line_number":1223,"context_line":"            \u0027--live-auto\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_538e76d1","line":1220,"in_reply_to":"5f7c97a3_1dfc9c3c","updated":"2018-06-09 15:17:21.000000000","message":"We could also make the decision to not support \u003c 2.30 when a host is specified. That is breaking so it may need to wait until OSC4.  OSC isn\u0027t a slave to the API, it is a slave to the user.","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc84d688be3a842beea833e38a6bfea55cab0f5b","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                #                2.25 and above microversions, if use option"},{"line_number":1280,"context_line":"                #                --os-compute-api-version 2.25 and above,"},{"line_number":1281,"context_line":"                #                TypeError would be raised at here, we should"},{"line_number":1282,"context_line":"                #                handle this when osc support microversion."},{"line_number":1283,"context_line":"                #                And \"force\" argument of novaclient is added in"},{"line_number":1284,"context_line":"                #                2.30, so we can not support force option until"},{"line_number":1285,"context_line":"                #                we make option disk_over_commit worked in osc"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ddbce46d","line":1282,"range":{"start_line":1282,"start_character":45,"end_line":1282,"end_character":75},"updated":"2018-06-08 13:50:00.000000000","message":"OSC does support microversions if you pass them through, so we can enforce/restrict microversion usage if we want. The osc-placement plugin does that using a helper:\n\nhttps://github.com/openstack/osc-placement/blob/master/osc_placement/resources/resource_class.py#L36\n\nAnd there is also support in there for doing per-option microversion checks.","commit_id":"e8b4df582e6602ee5c55ea77ff3c16b9fffa2105"}]}