)]}'
{"openstackclient/network/v2/port.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1baa51be58fe92205514e1567b43e46a6551e62","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            if (obj.allowed_address_pairs and"},{"line_number":738,"context_line":"                    not parsed_args.no_allowed_address_pair):"},{"line_number":739,"context_line":"                attrs[\u0027allowed_address_pairs\u0027] \u003d ("},{"line_number":740,"context_line":"                    [addr for addr in obj.allowed_address_pairs if addr]"},{"line_number":741,"context_line":"                )"},{"line_number":742,"context_line":"            else:"},{"line_number":743,"context_line":"                attrs[\u0027allowed_address_pairs\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_5c87fbd8","line":740,"range":{"start_line":740,"start_character":20,"end_line":740,"end_character":72},"updated":"2017-05-29 12:39:39.000000000","message":"Honestly I cannot understand what this means. Why cannot we use just \u0027obj.allowed_address_pairs\u0027 here. I think addr always contains \u0027address\u0027 field, so \u0027addr\u0027 is never empty.","commit_id":"3d7db21a870d0c59770b6b1017723281ac4fe11e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1baa51be58fe92205514e1567b43e46a6551e62","unresolved":false,"context_lines":[{"line_number":743,"context_line":"                attrs[\u0027allowed_address_pairs\u0027] \u003d []"},{"line_number":744,"context_line":"            attrs[\u0027allowed_address_pairs\u0027].extend("},{"line_number":745,"context_line":"                _convert_address_pairs(parsed_args)"},{"line_number":746,"context_line":"            )"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":749,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_fc200ffa","line":746,"updated":"2017-05-29 12:39:39.000000000","message":"The logic is correct, but I think the following is easier to understand.\n\n  if parsed_args.no_allowed_address_pair:\n    new_allowed_address_pairs \u003d []\n  else:\n    new_allowed_address_pairs \u003d obj.allowed_address_pairs\n  if parsed_args.allowed_address_pairs:\n    new_allowed_address_pairs +\u003d _convert_address_pairs(parsed_args)\n  attrs[\u0027allowed_address_pairs\u0027] \u003d new_allowed_address_pairs","commit_id":"3d7db21a870d0c59770b6b1017723281ac4fe11e"}],"releasenotes/notes/bug-1687377-bc2ca269bd9cb1ef.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0d51ef6b469c97edc2a5577513d8b6d0b5f73653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix issue in ``port update`` command when the port has no allowed addresspair"},{"line_number":5,"context_line":"    and you want to add one."},{"line_number":6,"context_line":"    [Bug `1687377 \u003chttps://bugs.launchpad.net/bugs/1687377\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff0f0b1f_c117b145","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":81},"updated":"2017-05-25 19:07:07.000000000","message":"address pair? or ``addresspair``?","commit_id":"3d7db21a870d0c59770b6b1017723281ac4fe11e"}]}