)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e90362bbf8d7db214afb0089fe0c3c87dbd8b4ec","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            for each_sg in parsed_args.security_group:"},{"line_number":685,"context_line":"                sg \u003d network_client.find_security_group(each_sg,"},{"line_number":686,"context_line":"                                                        ignore_missing\u003dFalse)"},{"line_number":687,"context_line":"                security_group_names.append(sg.name)"},{"line_number":688,"context_line":"        else:"},{"line_number":689,"context_line":"            # Handle nova-network case"},{"line_number":690,"context_line":"            for each_sg in parsed_args.security_group:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_8312cbb0","line":687,"range":{"start_line":687,"start_character":44,"end_line":687,"end_character":51},"updated":"2017-05-18 04:02:24.000000000","message":"I think sg.id is enough in this case. Converting ID to name potentially introduces ambiguousness.","commit_id":"49b8ffbdbd98db0fdd299bdf0362e4abbc60028e"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"f7b18ef3135f174527d864f0db710f1047fee1fb","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            for each_sg in parsed_args.security_group:"},{"line_number":685,"context_line":"                sg \u003d network_client.find_security_group(each_sg,"},{"line_number":686,"context_line":"                                                        ignore_missing\u003dFalse)"},{"line_number":687,"context_line":"                security_group_names.append(sg.name)"},{"line_number":688,"context_line":"        else:"},{"line_number":689,"context_line":"            # Handle nova-network case"},{"line_number":690,"context_line":"            for each_sg in parsed_args.security_group:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_0ac367ef","line":687,"range":{"start_line":687,"start_character":44,"end_line":687,"end_character":51},"in_reply_to":"ff0f0b1f_8312cbb0","updated":"2017-05-18 09:16:17.000000000","message":"Got your point, in the special case, if user have two security groups with same name, the ID/name converting will cause unexpected behavior, thank you.","commit_id":"49b8ffbdbd98db0fdd299bdf0362e4abbc60028e"}]}