)]}'
{"openstackclient/identity/v3/identity_provider.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"196a2ca643cd9c7f9d10831a32d64ff76d9796c5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            help\u003d_(\u0027New identity provider description\u0027),"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--domain\u0027,"},{"line_number":61,"context_line":"            metavar\u003d\u0027\u003cdomain\u003e\u0027,"},{"line_number":62,"context_line":"            help\u003d_(\u0027Domain to associate with the Identity Provider. If not \u0027"},{"line_number":63,"context_line":"                   \u0027specified, a domain will be created automatically. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_8a12ed61","line":60,"range":{"start_line":60,"start_character":13,"end_line":60,"end_character":21},"updated":"2017-06-20 08:11:24.000000000","message":"please add the new option into document.\n\ndoc/source/command-objects/identity-provider.rst","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"290b2eaa51d441fc8834a7003e7e0ce5ec0dbf90","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            help\u003d_(\u0027New identity provider description\u0027),"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--domain\u0027,"},{"line_number":61,"context_line":"            metavar\u003d\u0027\u003cdomain\u003e\u0027,"},{"line_number":62,"context_line":"            help\u003d_(\u0027Domain to associate with the Identity Provider. If not \u0027"},{"line_number":63,"context_line":"                   \u0027specified, a domain will be created automatically. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_4eb269e8","line":60,"range":{"start_line":60,"start_character":13,"end_line":60,"end_character":21},"in_reply_to":"7f231b9d_8a12ed61","updated":"2017-06-22 17:11:00.000000000","message":"Done","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"196a2ca643cd9c7f9d10831a32d64ff76d9796c5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            id\u003dparsed_args.identity_provider_id,"},{"line_number":100,"context_line":"            remote_ids\u003dremote_ids,"},{"line_number":101,"context_line":"            description\u003dparsed_args.description,"},{"line_number":102,"context_line":"            domain_id\u003ddomain_id,"},{"line_number":103,"context_line":"            enabled\u003dparsed_args.enabled)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        idp._info.pop(\u0027links\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_cde7df46","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":21},"updated":"2017-06-20 08:11:24.000000000","message":"Do the new argument depends on specified python-keystoneclient version? osc use python-keystoneclient\u003e\u003d3.8.0 now.","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"290b2eaa51d441fc8834a7003e7e0ce5ec0dbf90","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            id\u003dparsed_args.identity_provider_id,"},{"line_number":100,"context_line":"            remote_ids\u003dremote_ids,"},{"line_number":101,"context_line":"            description\u003dparsed_args.description,"},{"line_number":102,"context_line":"            domain_id\u003ddomain_id,"},{"line_number":103,"context_line":"            enabled\u003dparsed_args.enabled)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        idp._info.pop(\u0027links\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_4e0f09e1","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":21},"in_reply_to":"7f231b9d_cde7df46","updated":"2017-06-22 17:11:00.000000000","message":"That version should be fine. For the create command, the python-keystoneclient will pass on all kwargs for identity provider.","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"196a2ca643cd9c7f9d10831a32d64ff76d9796c5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    _description \u003d _(\"List identity providers\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def take_action(self, parsed_args):"},{"line_number":147,"context_line":"        columns \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Description\u0027, \u0027Domain ID\u0027)"},{"line_number":148,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":149,"context_line":"        data \u003d identity_client.federation.identity_providers.list()"},{"line_number":150,"context_line":"        return (columns,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_2d79b32e","line":147,"updated":"2017-06-20 08:11:24.000000000","message":"I prefer to add \u0027Domain ID\u0027 in front of \u0027Description\u0027, that will make the result table more readable and neat, even if the description is long.\n\n    columns \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Domain ID\u0027, \u0027Description\u0027)","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"290b2eaa51d441fc8834a7003e7e0ce5ec0dbf90","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    _description \u003d _(\"List identity providers\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def take_action(self, parsed_args):"},{"line_number":147,"context_line":"        columns \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Description\u0027, \u0027Domain ID\u0027)"},{"line_number":148,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":149,"context_line":"        data \u003d identity_client.federation.identity_providers.list()"},{"line_number":150,"context_line":"        return (columns,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_ce1b1919","line":147,"in_reply_to":"7f231b9d_2d79b32e","updated":"2017-06-22 17:11:00.000000000","message":"Done","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"}],"releasenotes/notes/bug-1698390-0df8f0ec4fe354de.yaml":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"196a2ca643cd9c7f9d10831a32d64ff76d9796c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the `--domain` option to the `identity provider create` command to"},{"line_number":5,"context_line":"    associate an existing domain with an identity provider on its creation."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    [Bug `1698390 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1698390\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f231b9d_0d6cb79a","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":25},"updated":"2017-06-20 08:11:24.000000000","message":"We use double point for new option and command, please s/``/`/","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"196a2ca643cd9c7f9d10831a32d64ff76d9796c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the `--domain` option to the `identity provider create` command to"},{"line_number":5,"context_line":"    associate an existing domain with an identity provider on its creation."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    [Bug `1698390 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1698390\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f231b9d_ad0823d9","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":66},"updated":"2017-06-20 08:11:24.000000000","message":"ditto","commit_id":"8bcd85a7c3c90d5542005121644439fb90048b6f"}]}