)]}'
{"id":"openstack%2Fpython-openstackclient~481407","triplet_id":"openstack%2Fpython-openstackclient~master~I4b9edb326444264c0f6c4ad281acaac356a07e85","project":"openstack/python-openstackclient","branch":"master","topic":"bp/replace-iteritems-with-items","hashtags":[],"change_id":"I4b9edb326444264c0f6c4ad281acaac356a07e85","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-07-07 04:02:37.000000000","updated":"2020-01-09 15:26:30.000000000","submitted":"2020-01-09 15:23:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"481407-1578583437506-69f755c7","meta_rev_id":"aead6b8ee64ff449e1d6fc076134aefb54ce3861","_number":481407,"virtual_id_number":481407,"owner":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-09 15:23:57.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},{"value":0,"date":"2020-01-09 10:56:47.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"recommended":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"value":1,"date":"2020-01-09 13:08:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2020-01-09 13:52:55.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-01-09 13:52:55.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-04 01:22:06.000000000","updated_by":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"reviewer":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"state":"REVIEWER"},{"updated":"2017-08-16 15:14:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2020-01-09 10:56:47.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2020-01-09 13:08:27.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-01-09 13:52:55.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-01-09 15:23:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c1304beb737a91eb165113347f7904a82df89d9b","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-07-07 04:02:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f792c6d439803365386d0aff6c8ad7285e92c4a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-07 05:20:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/07/481407/1/check/gate-python-openstackclient-docs-ubuntu-xenial/cfca23b//doc/build/html/ : SUCCESS in 5m 34s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/07/481407/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/29cb292/ : FAILURE in 5m 45s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/07/481407/1/check/gate-python-openstackclient-python27-ubuntu-xenial/597e94b/ : SUCCESS in 4m 22s\n- gate-python-openstackclient-python35 http://logs.openstack.org/07/481407/1/check/gate-python-openstackclient-python35/2da0ff6/ : SUCCESS in 3m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/07/481407/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/005c78c/ : SUCCESS in 1h 15m 23s\n- check-osc-plugins http://logs.openstack.org/07/481407/1/check/check-osc-plugins/66ed2ee/ : SUCCESS in 3m 33s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/07/481407/1/check/gate-osc-dsvm-functional-ubuntu-xenial/506fad4/ : SUCCESS in 34m 13s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/07/481407/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/a18bff5/ : FAILURE in 16m 45s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/07/481407/1/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/21bb163/ : SUCCESS in 34m 42s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/07/481407/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/e657978/ : FAILURE in 26m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"776b9b49906468fbe0256b920145cfce8d869a15","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-07-07 06:07:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b3c29ad92070648dc13fb5c72e5a19f7ac51d8b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-07 07:29:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/07/481407/2/check/gate-python-openstackclient-docs-ubuntu-xenial/ffcfaa6//doc/build/html/ : SUCCESS in 5m 28s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/07/481407/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/b2b1417/ : SUCCESS in 3m 41s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/07/481407/2/check/gate-python-openstackclient-python27-ubuntu-xenial/e5e3ab0/ : SUCCESS in 3m 40s\n- gate-python-openstackclient-python35 http://logs.openstack.org/07/481407/2/check/gate-python-openstackclient-python35/bd89222/ : SUCCESS in 4m 58s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/07/481407/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/194f6de/ : SUCCESS in 1h 20m 03s\n- check-osc-plugins http://logs.openstack.org/07/481407/2/check/check-osc-plugins/eae94cd/ : SUCCESS in 6m 52s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/07/481407/2/check/gate-osc-dsvm-functional-ubuntu-xenial/c924034/ : SUCCESS in 37m 12s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/07/481407/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/a7da023/ : FAILURE in 16m 36s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/07/481407/2/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/3080233/ : SUCCESS in 32m 56s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/07/481407/2/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/989aca2/ : FAILURE in 21m 00s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ec4b1e4e09b8da05d02e31cfcd2e51a98d1cf8a2","author":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"date":"2017-08-04 01:22:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fa60534d3a0432ed0229098cf1b702183e196710","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-08-16 12:43:44.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"ac1e24f3015e77e26fc4c4173b0752215af3fd4e","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-08-16 12:44:34.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ec4276eb1638c2d0d550feb271620b5eb94bb9c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-16 15:14:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/07/481407/3/check/gate-python-openstackclient-docs-ubuntu-xenial/21117ac//doc/build/html/ : SUCCESS in 5m 05s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/07/481407/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/a91ea23/ : SUCCESS in 5m 28s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/07/481407/3/check/gate-python-openstackclient-python27-ubuntu-xenial/46df7e6/ : SUCCESS in 4m 18s\n- gate-python-openstackclient-python35 http://logs.openstack.org/07/481407/3/check/gate-python-openstackclient-python35/8c31cbc/ : SUCCESS in 5m 47s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/07/481407/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/4f11601/ : SUCCESS in 1h 38m 25s\n- check-osc-plugins http://logs.openstack.org/07/481407/3/check/check-osc-plugins/dddbca6/ : SUCCESS in 6m 31s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/07/481407/3/check/gate-osc-dsvm-functional-ubuntu-xenial/2e54582/ : SUCCESS in 58m 35s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/07/481407/3/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/5fc6392/ : SUCCESS in 50m 34s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/07/481407/3/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/41c7770/ : FAILURE in 48m 56s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/07/481407/3/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/b243c73/ : SUCCESS in 1h 33m 37s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"83b90bcbfa11fca079d8ee3f449c95b5dd037ed0","author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"date":"2017-08-16 23:23:33.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 3: Code-Review+1\n\nThanks！","accounts_in_message":[],"_revision_number":3},{"id":"13df0eb650598aa134e9fbc596cda31eee8737d0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-01-08 23:11:38.000000000","message":"Patch Set 3: Code-Review-1\n\nNeeds a rebase to fix merge conflicts, but it does look like this is still needed.","accounts_in_message":[],"_revision_number":3},{"id":"d04035eac3738b968c09606190d80eff7e645b38","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2020-01-09 09:42:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f47045aa817a58afa605d606cbc4a7a7ef5af869","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2020-01-09 09:43:52.000000000","message":"Patch Set 4:\n\n\u003e Needs a rebase to fix merge conflicts, but it does look like this is still needed.\n\nYeah, it is still the thing we would like to have. I resolved the merge conflict and cleanup iteritems added since this was proposed.","accounts_in_message":[],"_revision_number":4},{"id":"d569fc3f90769e1fb7a97b4b12b8bc5f4d0e72ec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 10:41:48.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/9594870c377c472da328708b0df5d54d : FAILURE in 5m 33s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/3bcc03db096a4a91b0c2f00bf7524a09 : SUCCESS in 4m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e7441373a4074892834b3ab86ef1788e : SUCCESS in 5m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0d693e75c0bc4be7aa11de36c9fb314b : SUCCESS in 3m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b2198452ceab45c4a3236b8703b50af1 : SUCCESS in 3m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/566b12746e21415b9ce04db0a432aef6 : SUCCESS in 5m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/db790fe593184a4fb9260fe0d10cbb08 : SUCCESS in 6m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bbea5f76bf3f422ba8c14af96d41e047 : SUCCESS in 4m 52s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4f8a356914124a7fb29802ffd8cce241 : FAILURE in 43m 49s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/2c27386111734a2091eaffcda398c2fc : FAILURE in 50m 09s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/c2930c3db73741f79e71e423d6174be7 : SUCCESS in 54m 44s","accounts_in_message":[],"_revision_number":4},{"id":"c1a7de247f424aada3b72c20b81b0c466e328a1b","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2020-01-09 10:56:47.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"a27e7baaf7fa8ee61fdead4fa58b90ada9710e0a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 12:39:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/bb4b943687054afaa93c01656d92ad74 : FAILURE in 5m 44s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/858c2eb447114b92b8189c08a98d8513 : SUCCESS in 5m 10s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a8a7273581384f2a85ce65cfc78d488f : SUCCESS in 6m 25s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7f8ceae17e154e528fe401b539578ea9 : SUCCESS in 4m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/180955f007f7431b96dfda51f2df32a5 : SUCCESS in 4m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cb0980cccc7b4ba7bb46b4d2e02b2d91 : SUCCESS in 3m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ac17334315ba4090be747247db3268b8 : SUCCESS in 3m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7449966af05c4f4881afe2fce0ac7cc4 : SUCCESS in 5m 27s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/acfa57ab71c546a69e8951c7348830e1 : SUCCESS in 1h 30m 49s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/17b7dcecf2e3490782b77f7f36ce3ef4 : SUCCESS in 56m 01s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/67f9c2597d4d46a1bf815afe062b8aa7 : SUCCESS in 52m 02s","accounts_in_message":[],"_revision_number":4},{"id":"8782e844f382e2bb3b1abc96e4c8b402c21ba508","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-01-09 13:08:27.000000000","message":"Patch Set 4: Code-Review+1\n\nLooks good to me. Thanks!","accounts_in_message":[],"_revision_number":4},{"id":"59b8b6a9ff6654313bab657c02f03ed86d5f01a9","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-01-09 13:52:55.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nApproving - amotoki is a co-author.","accounts_in_message":[],"_revision_number":4},{"id":"7d28de9d2d879e7a4e4f5ae28cf34b1d32f42aab","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 13:53:07.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"1dd8ff6cf031d434c71deb75fd07b8f6b4676b14","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 15:23:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"d64e008918d9a6d874aad204ef06ed4be42f4823","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 15:23:57.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/ca1e1caa003e45c2938ffad711784566 : SUCCESS in 6m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1825d5ecfd1b49ac86c4c45065936844 : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7ca45ed78ebc4b969bf4a470d7e84594 : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/74d9bb355ad94bb1b59ef601c1fd4696 : SUCCESS in 4m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/12aad62d15484b0082033d04b56676d6 : SUCCESS in 5m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec94f0d555b14a8b9197d29ba69ec7de : SUCCESS in 6m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8ef0af75d52b4d45984325eea11c867c : SUCCESS in 1h 30m 15s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/26a6ee619c1e4538ac44b391c6d7f9fe : SUCCESS in 1h 05m 43s","accounts_in_message":[],"_revision_number":4},{"id":"e7fd99784aca9f62c8ff966a903195ae6011d157","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 15:26:30.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dfa38cddf5794f9293099b1d6faf81f4 : SUCCESS in 2m 00s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"d15bbada73f81136c966007d9c564dd6cfb2fd9c","revisions":{"ae27a8f8d790c20d99b63df520441526aac393b0":{"kind":"REWORK","_number":1,"created":"2017-07-07 04:02:37.000000000","uploader":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"ref":"refs/changes/07/481407/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/481407/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/1"}}},"commit":{"parents":[{"commit":"91cc7311877c74adf2618bcb87f86f484e8d7aae","subject":"Merge \"Allow objects to be streamed to stdout\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/91cc7311877c74adf2618bcb87f86f484e8d7aae"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-07-07 03:48:48.000000000","tz":480},"committer":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-07-07 04:01:26.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be\nnegligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85\nImplements: blueprint replace-iteritems-with-items\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ae27a8f8d790c20d99b63df520441526aac393b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ae27a8f8d790c20d99b63df520441526aac393b0"}]},"branch":"refs/heads/master"},"8da976e5510bc3ae8f22d7be1a0d0d6356afb711":{"kind":"REWORK","_number":2,"created":"2017-07-07 06:07:46.000000000","uploader":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"ref":"refs/changes/07/481407/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/481407/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/2"}}},"commit":{"parents":[{"commit":"91cc7311877c74adf2618bcb87f86f484e8d7aae","subject":"Merge \"Allow objects to be streamed to stdout\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/91cc7311877c74adf2618bcb87f86f484e8d7aae"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-07-07 03:48:48.000000000","tz":480},"committer":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-07-07 06:03:00.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be\nnegligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85\nImplements: blueprint replace-iteritems-with-items\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8da976e5510bc3ae8f22d7be1a0d0d6356afb711"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8da976e5510bc3ae8f22d7be1a0d0d6356afb711"}]},"branch":"refs/heads/master"},"ab63f7f86a8ddd802cb11c8c936fc1bc144215bb":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2017-08-16 12:43:44.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/07/481407/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/481407/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/3"}}},"commit":{"parents":[{"commit":"64d6809c40f58eb1ae63267cea8dfc4cf1117769","subject":"Merge \"Convert network segment functional tests to JSON\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/64d6809c40f58eb1ae63267cea8dfc4cf1117769"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-07-07 03:48:48.000000000","tz":480},"committer":{"name":"Akihiro Motoki","email":"amotoki@gmail.com","date":"2017-08-16 12:43:44.000000000","tz":0},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be\nnegligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85\nImplements: blueprint replace-iteritems-with-items\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab63f7f86a8ddd802cb11c8c936fc1bc144215bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab63f7f86a8ddd802cb11c8c936fc1bc144215bb"}]},"branch":"refs/heads/master"},"d15bbada73f81136c966007d9c564dd6cfb2fd9c":{"kind":"REWORK","_number":4,"created":"2020-01-09 09:42:36.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/07/481407/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/481407/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/481407/4"}}},"commit":{"parents":[{"commit":"4b575083b7979473b9c83eb01a520d5bacb88dc3","subject":"Merge \"Bump tox minversion\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4b575083b7979473b9c83eb01a520d5bacb88dc3"}]}],"author":{"name":"lihaijing","email":"lihaijing@fiberhome.com","date":"2017-07-07 03:48:48.000000000","tz":480},"committer":{"name":"Akihiro Motoki","email":"amotoki@gmail.com","date":"2020-01-09 09:41:29.000000000","tz":540},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1. As mentioned in [1], we should avoid using six.iteritems to achieve\n   iterators. We can use dict.items instead, as it will return iterators\n   in PY3 as well. And dict.items/keys will more readable.\n\n2. In py2, the performance about list should be negligible,\n   see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nCo-Authored-By: Akihiro Motoki \u003camotoki@gmail.com\u003e\nChange-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85\nImplements: blueprint replace-iteritems-with-items\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d15bbada73f81136c966007d9c564dd6cfb2fd9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d15bbada73f81136c966007d9c564dd6cfb2fd9c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}