)]}'
{"openstackclient/tests/functional/identity/v3/common.py":[{"author":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"change_message_id":"0d932aa825eb3e5479a70b7add26f6c79e361d99","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          \u0027name\u0027: role_name})"},{"line_number":171,"context_line":"        role \u003d self.parse_show_as_object(raw_output)"},{"line_number":172,"context_line":"        if add_clean_up:"},{"line_number":173,"context_line":"            self.addCleanup("},{"line_number":174,"context_line":"                self.openstack,"},{"line_number":175,"context_line":"                \u0027role delete %s\u0027 % role[\u0027id\u0027])"},{"line_number":176,"context_line":"        items \u003d self.parse_show(raw_output)"},{"line_number":177,"context_line":"        self.assert_show_fields(items, self.ROLE_FIELDS)"},{"line_number":178,"context_line":"        self.assertEqual(role_name, role[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_46934201","line":175,"range":{"start_line":173,"start_character":12,"end_line":175,"end_character":46},"updated":"2018-09-14 05:27:23.000000000","message":"Nit: No need to break it into multiple lines, its effecting code readability","commit_id":"a6913eca462d60d284b314bcc58dc3dc72e7d283"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"fd7a6013f2096daf2e11421edfee1ab35b18dcb2","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                          \u0027name\u0027: role_name})"},{"line_number":171,"context_line":"        role \u003d self.parse_show_as_object(raw_output)"},{"line_number":172,"context_line":"        if add_clean_up:"},{"line_number":173,"context_line":"            self.addCleanup("},{"line_number":174,"context_line":"                self.openstack,"},{"line_number":175,"context_line":"                \u0027role delete %s\u0027 % role[\u0027id\u0027])"},{"line_number":176,"context_line":"        items \u003d self.parse_show(raw_output)"},{"line_number":177,"context_line":"        self.assert_show_fields(items, self.ROLE_FIELDS)"},{"line_number":178,"context_line":"        self.assertEqual(role_name, role[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_af11b45f","line":175,"range":{"start_line":173,"start_character":12,"end_line":175,"end_character":46},"in_reply_to":"3f79a3b5_46934201","updated":"2018-09-15 18:30:17.000000000","message":"Thanks for the review, but  I am just maintaining the same fashion of code as in the other helper functions.","commit_id":"a6913eca462d60d284b314bcc58dc3dc72e7d283"}],"openstackclient/tests/functional/identity/v3/test_role.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"97425b7bff16215bfcff39aa38334ed3a7ec6af5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self._create_dummy_role()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_role_create_with_description(self):"},{"line_number":24,"context_line":"        self._create_dummy_role_with_description()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_role_delete(self):"},{"line_number":27,"context_line":"        role_name \u003d self._create_dummy_role(add_clean_up\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_b56a4fb2","line":24,"updated":"2018-09-17 13:39:47.000000000","message":"can you test the output here and ensure that description is being show to the user?\n\nor do a `show role` based on role name and test the description is show there?","commit_id":"bb5100c45a3ff345d87c410216dfac046f068126"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"5cd877ac44b1f0b320d5ce87c1cb79d34e370ebb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self._create_dummy_role()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_role_create_with_description(self):"},{"line_number":24,"context_line":"        self._create_dummy_role_with_description()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_role_delete(self):"},{"line_number":27,"context_line":"        role_name \u003d self._create_dummy_role(add_clean_up\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_cc9e5a53","line":24,"in_reply_to":"3f79a3b5_b56a4fb2","updated":"2018-09-18 03:28:20.000000000","message":"@Steve I think we are already checking the same thing in the _create_dummy_role_with_description(). So doing again will behave duplicate lines of code. What do you think?","commit_id":"bb5100c45a3ff345d87c410216dfac046f068126"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"97425b7bff16215bfcff39aa38334ed3a7ec6af5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        raw_output \u003d self.openstack(\u0027role set --description %s %s\u0027"},{"line_number":98,"context_line":"                                    % (description, role_name))"},{"line_number":99,"context_line":"        self.assertEqual(0, len(raw_output))"},{"line_number":100,"context_line":"        raw_output \u003d self.openstack(\u0027role show %s\u0027 % role_name)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_role_add(self):"},{"line_number":103,"context_line":"        role_name \u003d self._create_dummy_role()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_f599a7cf","line":100,"updated":"2018-09-17 13:39:47.000000000","message":"similar comment here. you\u0027re testing that the command passed but not asserting any output. The description should be in there. can you parsed the returned data and see if the shown description matches the description you passed in...\n\n\n        role \u003d self.parse_show_as_object(raw_output)\n        self.assertEqual(description, role[\u0027description\u0027])","commit_id":"bb5100c45a3ff345d87c410216dfac046f068126"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"5cd877ac44b1f0b320d5ce87c1cb79d34e370ebb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        raw_output \u003d self.openstack(\u0027role set --description %s %s\u0027"},{"line_number":98,"context_line":"                                    % (description, role_name))"},{"line_number":99,"context_line":"        self.assertEqual(0, len(raw_output))"},{"line_number":100,"context_line":"        raw_output \u003d self.openstack(\u0027role show %s\u0027 % role_name)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_role_add(self):"},{"line_number":103,"context_line":"        role_name \u003d self._create_dummy_role()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_4c67aa26","line":100,"in_reply_to":"3f79a3b5_f599a7cf","updated":"2018-09-18 03:28:20.000000000","message":"Done","commit_id":"bb5100c45a3ff345d87c410216dfac046f068126"}],"releasenotes/notes/add-description-to-role-afe7b6ff668df261.yaml":[{"author":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"change_message_id":"0d932aa825eb3e5479a70b7add26f6c79e361d99","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Now user can add the description when user create\u0027s"},{"line_number":5,"context_line":"    the role using OSC ``openstack role create`` command."},{"line_number":6,"context_line":"    User can add the description by adding"},{"line_number":7,"context_line":"    `--description \u003cDescription\u003e` to OSC"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_c6af5229","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":55},"updated":"2018-09-14 05:27:23.000000000","message":"r/create\u0027s|creates","commit_id":"a6913eca462d60d284b314bcc58dc3dc72e7d283"}]}