)]}'
{"id":"openstack%2Fpython-openstackclient~492929","triplet_id":"openstack%2Fpython-openstackclient~master~I2d0ac71260d317b2ddb380934e3d8a5a84e1504b","project":"openstack/python-openstackclient","branch":"master","topic":"iteritems","hashtags":[],"change_id":"I2d0ac71260d317b2ddb380934e3d8a5a84e1504b","subject":"Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-08-11 09:42:57.000000000","updated":"2017-08-16 13:23:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3481cc357418203d0e06344efe17000f9a802bf2","_number":492929,"virtual_id_number":492929,"owner":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-08-11 12:00:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-08-16 12:41:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-11 12:00:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-08-16 12:41:53.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"}],"messages":[{"id":"a5cd9f59b269ff73a6bc0d1c2dd34c1287a3c563","author":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"date":"2017-08-11 09:42:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f715ea210921c213c52e66fd8dce695cf5da3092","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-11 12:00:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/29/492929/1/check/gate-python-openstackclient-docs-ubuntu-xenial/f919f85//doc/build/html/ : SUCCESS in 6m 19s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/29/492929/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/51b571d/ : SUCCESS in 5m 14s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/29/492929/1/check/gate-python-openstackclient-python27-ubuntu-xenial/32e0091/ : SUCCESS in 4m 47s\n- gate-python-openstackclient-python35 http://logs.openstack.org/29/492929/1/check/gate-python-openstackclient-python35/a49d9dc/ : SUCCESS in 5m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/29/492929/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/0fdefe7/ : SUCCESS in 1h 32m 59s\n- check-osc-plugins http://logs.openstack.org/29/492929/1/check/check-osc-plugins/c9b4b24/ : SUCCESS in 5m 41s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/29/492929/1/check/gate-osc-dsvm-functional-ubuntu-xenial/aff02ad/ : SUCCESS in 50m 33s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/29/492929/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/a651cef/ : FAILURE in 55m 27s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/29/492929/1/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/b636365/ : SUCCESS in 48m 11s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/29/492929/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/1a26ed7/ : SUCCESS in 1h 52m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"98ea085aa56adb176a13f01008df58e026016d5c","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-08-16 12:41:53.000000000","message":"Patch Set 1: Code-Review-1\n\nDuplicated to https://review.openstack.org/#/c/481407/\n\nIt was proposed before this.","accounts_in_message":[],"_revision_number":1},{"id":"0c12593acc76891060f10b44d86b57b205b421de","author":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"date":"2017-08-16 13:23:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3bb3a6b4e099b4c6878c50c256cbd54d95e354fa","revisions":{"3bb3a6b4e099b4c6878c50c256cbd54d95e354fa":{"kind":"REWORK","_number":1,"created":"2017-08-11 09:42:57.000000000","uploader":{"_account_id":25006,"name":"sudhir agarwal","email":"sudhir.agarwal@nectechnologies.in","username":"sudhir_agarwal"},"ref":"refs/changes/29/492929/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/29/492929/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/492929/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/492929/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/492929/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/29/492929/1"}}},"commit":{"parents":[{"commit":"06c8845a9f251cdbf0e1ab32d186ccb2f4008f39","subject":"Merge \"Add new commands for karbor osc plugin\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/06c8845a9f251cdbf0e1ab32d186ccb2f4008f39"}]}],"author":{"name":"sudhir_agarwal","email":"sudhir.agarwal@nectechnologies.in","date":"2017-08-11 09:43:02.000000000","tz":330},"committer":{"name":"sudhir_agarwal","email":"sudhir.agarwal@nectechnologies.in","date":"2017-08-11 09:45:54.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I2d0ac71260d317b2ddb380934e3d8a5a84e1504b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3bb3a6b4e099b4c6878c50c256cbd54d95e354fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3bb3a6b4e099b4c6878c50c256cbd54d95e354fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
