)]}'
{"id":"openstack%2Fpython-openstackclient~505890","triplet_id":"openstack%2Fpython-openstackclient~master~I96133a57883d22e98fcbb9fe0328d9e050472469","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1703704","hashtags":[],"change_id":"I96133a57883d22e98fcbb9fe0328d9e050472469","subject":"Support icmp-type and icmp-code to be set as zero","status":"MERGED","created":"2017-09-21 01:10:29.000000000","updated":"2017-09-27 08:48:24.000000000","submitted":"2017-09-27 05:49:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"505890-1506491390734-ca8e402b","meta_rev_id":"cec335fceb19a6bab804f8bdfb8d55132e4763a7","_number":505890,"virtual_id_number":505890,"owner":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-09-27 05:49:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2017-09-27 02:26:15.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},{"value":2,"date":"2017-09-26 21:00:47.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},{"value":1,"date":"2017-09-26 21:00:47.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-21 15:18:56.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2017-09-26 21:00:47.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-09-27 02:26:15.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-09-27 05:49:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3904efd656c5510d28daa57fed5da1ab9b2f96f5","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-21 01:10:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"296d3bb933504ad2966ebc5909d12e84422aef1d","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-21 01:44:27.000000000","message":"Topic set to bug/1703704","accounts_in_message":[],"_revision_number":1},{"id":"ad32571175c4a557d96c2fffe6e8dff7e1255f8d","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-21 02:50:51.000000000","message":"Patch Set 1: Code-Review+2\n\n(3 comments)\n\nit\u0027ll be nice if the bug fix had a release note and a test","accounts_in_message":[],"_revision_number":1},{"id":"a960d65457758f56e721b7813ccb720f085a4b2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-21 02:55:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/1/check/gate-python-openstackclient-docs-ubuntu-xenial/af047c0//doc/build/html/ : SUCCESS in 5m 42s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/8403a57/ : SUCCESS in 6m 45s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/1/check/gate-python-openstackclient-python27-ubuntu-xenial/a96fc86/ : SUCCESS in 6m 37s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/1/check/gate-python-openstackclient-python35/a8de32a/ : FAILURE in 5m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/a33076e/ : SUCCESS in 1h 28m 07s\n- check-osc-plugins http://logs.openstack.org/90/505890/1/check/check-osc-plugins/63af81f/ : SUCCESS in 7m 52s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/1/check/gate-osc-dsvm-functional-ubuntu-xenial/caab8c8/ : FAILURE in 1h 03m 58s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/f0b9ad9/ : FAILURE in 1h 03m 15s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/1/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/d11272f/ : FAILURE in 1h 03m 14s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/88d0938/ : FAILURE in 1h 02m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3df59edeae41ea593a9aab551150b70ebcf3d8ab","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2017-09-21 15:18:56.000000000","message":"Patch Set 1:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-osc-dsvm-functional-ubuntu-xenial: https://bugs.launchpad.net/bugs/1449136\n- gate-python-openstackclient-python35: unrecognized error\n\nSome of the tests failed in a way that we did not understand. Please help us classify these issues so that they can be part of Elastic Recheck http://status.openstack.org/elastic-recheck/\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":1},{"id":"40a2ba8b1a21f8aa1b345bed12e22876f56d843e","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-22 18:40:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9e0685a5b9129238daa38761f0cce44474b8b7b1","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-22 19:09:56.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"06252ae060ad334a46ffc229b5b649de5fad6d78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-22 20:35:31.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/2/check/gate-python-openstackclient-docs-ubuntu-xenial/f10631d//doc/build/html/ : SUCCESS in 6m 03s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/c12a5a4/ : FAILURE in 5m 59s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/2/check/gate-python-openstackclient-python27-ubuntu-xenial/fab8fbb/ : SUCCESS in 6m 07s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/2/check/gate-python-openstackclient-python35/ef45508/ : SUCCESS in 5m 57s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/fb8f079/ : SUCCESS in 1h 22m 15s\n- check-osc-plugins http://logs.openstack.org/90/505890/2/check/check-osc-plugins/a73d9a2/ : SUCCESS in 5m 57s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/2/check/gate-osc-dsvm-functional-ubuntu-xenial/cd36a76/ : SUCCESS in 45m 08s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/e1ea1f6/ : SUCCESS in 50m 28s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/2/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/40b5873/ : SUCCESS in 47m 10s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/2/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/de3f58d/ : SUCCESS in 1h 51m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"80aba95ed98648fe694aaf3d813e8d7cb65a1768","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-24 16:01:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c28f3a0008436cf87ed995a1342aa96fb95a369e","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-24 16:02:44.000000000","message":"Patch Set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"5257b5f5d656d2f3f6446a63390bbb1e9990edb7","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-24 16:03:16.000000000","message":"Patch Set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"32533a5d52e73f83fbb43094ec9ee2f465437a70","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-24 16:09:19.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e (3 comments)\n \u003e \n \u003e it\u0027ll be nice if the bug fix had a release note and a test\n\nAdded Some Tests now","accounts_in_message":[],"_revision_number":1},{"id":"65d41d87cf8df5631753b16b018cd3ad12190bf0","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-24 17:53:52.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"a51ee94212aaff3b2b68bfc1d103e7ddacb5f852","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-24 18:34:24.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/5/check/gate-python-openstackclient-docs-ubuntu-xenial/a944473//doc/build/html/ : SUCCESS in 5m 10s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/5/check/gate-python-openstackclient-pep8-ubuntu-xenial/3aff060/ : FAILURE in 4m 18s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/5/check/gate-python-openstackclient-python27-ubuntu-xenial/3c41047/ : SUCCESS in 4m 25s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/5/check/gate-python-openstackclient-python35/4935108/ : SUCCESS in 4m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/5/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/4739dc0/ : SUCCESS in 1h 21m 49s\n- check-osc-plugins http://logs.openstack.org/90/505890/5/check/check-osc-plugins/65c0c61/ : SUCCESS in 4m 46s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/5/check/gate-osc-dsvm-functional-ubuntu-xenial/d903d6e/ : FAILURE in 42m 07s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/5/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/715186b/ : SUCCESS in 44m 15s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/5/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/2b35cc1/ : FAILURE in 43m 19s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/5/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/27ea266/ : FAILURE in 2h 25m 27s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"4ba277d382a2799426f5c65eecb01699c5ed7b08","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-25 03:23:08.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"686a1d67e4a443ce3596df564c91ef7724cd8511","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-25 04:02:41.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"aa9b4e29520b1f2ee6acb80f0705a3abdff2c993","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-25 05:37:44.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/6/check/gate-python-openstackclient-docs-ubuntu-xenial/a56a7d0//doc/build/html/ : SUCCESS in 4m 33s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/6/check/gate-python-openstackclient-pep8-ubuntu-xenial/4e3a7fa/ : SUCCESS in 4m 58s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/6/check/gate-python-openstackclient-python27-ubuntu-xenial/81b5e28/ : SUCCESS in 4m 13s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/6/check/gate-python-openstackclient-python35/4323b74/ : SUCCESS in 4m 42s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/6/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/c112728/ : SUCCESS in 1h 29m 38s\n- check-osc-plugins http://logs.openstack.org/90/505890/6/check/check-osc-plugins/8853397/ : SUCCESS in 4m 56s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/6/check/gate-osc-dsvm-functional-ubuntu-xenial/19e5fbb/ : SUCCESS in 45m 19s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/6/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/920aaaa/ : SUCCESS in 45m 32s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/6/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/3620e79/ : FAILURE in 45m 39s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/6/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/a7d21b6/ : SUCCESS in 2h 14m 23s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"4d416b62fc809768a485f614be737e0d3d35a527","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-25 13:03:59.000000000","message":"Patch Set 6: Code-Review+2\n\nOK, looks good.\n\n  * could also use a release note.\n  * currently it\u0027ll also accept negative numbers in this implementation, consider adding an \"and\" to check if it\u0027s \u003e\u003d 0","accounts_in_message":[],"_revision_number":6},{"id":"dec36e2175ee9854d55065e2ee1ebea2b4e16399","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-09-25 15:38:13.000000000","message":"Patch Set 6: Code-Review-1\n\nI agree with Steve that an \u0027and\u0027 would be clearer than the nested if statelemts, but I do not see how negative values still slip in.\n\nThere should be a rest for the negative values, the new tests currently to not actually test for the condition being guarded against.\n\nAnd it needs a release note explainig the change.","accounts_in_message":[],"_revision_number":6},{"id":"7dbc014b55d9534207c827724babd38191ae6108","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-26 04:30:43.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"68b2f55b5f4bbe6b232b8c604bee572dfb15858d","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-26 05:23:34.000000000","message":"Patch Set 7:\n\n\u003e I agree with Steve that an \u0027and\u0027 would be clearer than the nested\n \u003e if statelemts, but I do not see how negative values still slip in.\n \u003e \n \u003e There should be a rest for the negative values, the new tests\n \u003e currently to not actually test for the condition being guarded\n \u003e against.\n \u003e \n \u003e And it needs a release note explainig the change.\n\nAdded testes for negative values? How do I add a release note?","accounts_in_message":[],"_revision_number":7},{"id":"83676f97c3ab9acd3bca5c7a8e93c112f463d5f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 05:50:12.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/7/check/gate-python-openstackclient-docs-ubuntu-xenial/a7dc37a//doc/build/html/ : SUCCESS in 4m 36s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/7/check/gate-python-openstackclient-pep8-ubuntu-xenial/92247e1/ : FAILURE in 4m 13s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/7/check/gate-python-openstackclient-python27-ubuntu-xenial/25845e0/ : FAILURE in 4m 34s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/7/check/gate-python-openstackclient-python35/debaac2/ : FAILURE in 4m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/7/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/552fab5/ : FAILURE in 1h 01m 48s\n- check-osc-plugins http://logs.openstack.org/90/505890/7/check/check-osc-plugins/5cea1e9/ : SUCCESS in 5m 28s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/7/check/gate-osc-dsvm-functional-ubuntu-xenial/dd47a1f/ : SUCCESS in 48m 07s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/7/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/5471058/ : FAILURE in 1h 16m 56s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/7/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/d1b4063/ : SUCCESS in 41m 47s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/7/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/b33984f/ : FAILURE in 23m 51s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"c9b58bef75a10cc1a3e057ee2037d3876990838b","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-26 06:01:27.000000000","message":"Patch Set 8: Published edit on patch set 7.","accounts_in_message":[],"_revision_number":8},{"id":"1e741440645b8dc6a83dd73e4c033da0a303d3ed","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-26 06:10:28.000000000","message":"Patch Set 8:\n\n\u003e \u003e I agree with Steve that an \u0027and\u0027 would be clearer than the nested\n \u003e \u003e if statelemts, but I do not see how negative values still slip\n \u003e in.\n \u003e \u003e\n \u003e \u003e There should be a rest for the negative values, the new tests\n \u003e \u003e currently to not actually test for the condition being guarded\n \u003e \u003e against.\n \u003e \u003e\n \u003e \u003e And it needs a release note explainig the change.\n \u003e \n \u003e Added testes for negative values? How do I add a release note?\n\n\nIgnore that question, Just found out about reno, Wiull amend the patch today","accounts_in_message":[],"_revision_number":8},{"id":"7b9c041a9a291d9901c647f5ce4933a79d0f91f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 07:22:17.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/8/check/gate-python-openstackclient-docs-ubuntu-xenial/e72d5ab//doc/build/html/ : SUCCESS in 13m 17s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/8/check/gate-python-openstackclient-pep8-ubuntu-xenial/92290cf/ : SUCCESS in 6m 40s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/8/check/gate-python-openstackclient-python27-ubuntu-xenial/f2749b2/ : FAILURE in 4m 16s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/8/check/gate-python-openstackclient-python35/8f89854/ : FAILURE in 7m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/8/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/21d7fa9/ : SUCCESS in 1h 18m 14s\n- check-osc-plugins http://logs.openstack.org/90/505890/8/check/check-osc-plugins/fb14973/ : SUCCESS in 9m 19s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/8/check/gate-osc-dsvm-functional-ubuntu-xenial/6ac9949/ : SUCCESS in 43m 36s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/8/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/561f979/ : SUCCESS in 47m 52s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/8/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/6b34f1f/ : SUCCESS in 39m 25s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/8/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/facc40c/ : FAILURE in 24m 46s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"8b58c92690b5bacfab8af618e4051644124f47f4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-26 13:45:24.000000000","message":"Patch Set 8:\n\nlooks like the tests are failing:\n\n  AssertionError: Expected call: mock(direction\u003d\u0027ingress\u0027, ethertype\u003d\u0027IPv4\u0027, port_range_min\u003dNone, protocol\u003d\u0027icmp\u0027, remote_ip_prefix\u003d\u00270.0.0.0/0\u0027, security_group_id\u003d\u0027security-group-id-a4cfcd08e29d48e9a8abb361083ede0e\u0027)\nActual call: mock(direction\u003d\u0027ingress\u0027, ethertype\u003d\u0027IPv4\u0027, protocol\u003d\u0027icmp\u0027, remote_ip_prefix\u003d\u00270.0.0.0/0\u0027, security_group_id\u003d\u0027security-group-id-a4cfcd08e29d48e9a8abb361083ede0e\u0027)\n\nonce that is fixed, should be mergable -- thanks for sticking with the patch","accounts_in_message":[],"_revision_number":8},{"id":"eafa092b58ab467d0eb20fc570cec2e5874e654e","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-26 15:48:01.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"ed74d7ce474e3f3c7cced9b4a09a521fb7ec3ea5","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-26 17:09:25.000000000","message":"Patch Set 10: Published edit on patch set 9.","accounts_in_message":[],"_revision_number":10},{"id":"fec3736de1e27e98946cae517d41b2c5eeab80d7","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-26 17:09:40.000000000","message":"Patch Set 10: Code-Review+2\n\nfixed up the release note a bit.","accounts_in_message":[],"_revision_number":10},{"id":"4d671e38130447c45bd6c15eaef75b5a6f656fcc","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-26 18:55:57.000000000","message":"Patch Set 10:\n\nrecheck","accounts_in_message":[],"_revision_number":10},{"id":"338981e6e179c2a1baa7787bcbf788c45a1d99bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 19:56:05.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/10/check/gate-python-openstackclient-docs-ubuntu-xenial/4c0e256//doc/build/html/ : SUCCESS in 6m 41s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/10/check/gate-python-openstackclient-pep8-ubuntu-xenial/466c72f/ : SUCCESS in 7m 51s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/10/check/gate-python-openstackclient-python27-ubuntu-xenial/7724c57/ : SUCCESS in 5m 09s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/10/check/gate-python-openstackclient-python35/6f4ea11/ : SUCCESS in 5m 22s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/90/505890/10/check/gate-python-openstackclient-releasenotes/82109ad//releasenotes/build/html/ : SUCCESS in 5m 47s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/10/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/e0290e1/ : SUCCESS in 1h 20m 20s\n- check-osc-plugins http://logs.openstack.org/90/505890/10/check/check-osc-plugins/1611e96/ : SUCCESS in 8m 45s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/10/check/gate-osc-dsvm-functional-ubuntu-xenial/ed664bb/ : SUCCESS in 1h 32m 39s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/10/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/d8a43d9/ : SUCCESS in 46m 09s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/10/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/5e7ca19/ : SUCCESS in 49m 30s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/10/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/3275fec/ : FAILURE in 2h 27m 57s (non-voting)","accounts_in_message":[],"_revision_number":10},{"id":"69f76fe771584f9eb14aed1ab6a29828269ae608","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-09-26 21:00:19.000000000","message":"Patch Set 11: Published edit on patch set 10.","accounts_in_message":[],"_revision_number":11},{"id":"04c47514f86e552bf8bfe4d0773cb102ec6e3e7e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-09-26 21:00:47.000000000","message":"Patch Set 11: Workflow+1 Code-Review+2\n\nI tweaked the release note a bit more, Steve-o it\u0027s double-backticks for code :)","accounts_in_message":[],"_revision_number":11},{"id":"d5d463120e7ef63a4e9778d878ea14e31d9be93a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 23:17:20.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/11/check/gate-python-openstackclient-docs-ubuntu-xenial/b14f737//doc/build/html/ : SUCCESS in 4m 49s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-python-openstackclient-pep8-ubuntu-xenial/c84b7b3/ : SUCCESS in 5m 24s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-python-openstackclient-python27-ubuntu-xenial/d732b2e/ : SUCCESS in 4m 49s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/11/check/gate-python-openstackclient-python35/3473dac/ : SUCCESS in 4m 00s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/90/505890/11/check/gate-python-openstackclient-releasenotes/15fff54//releasenotes/build/html/ : SUCCESS in 4m 41s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/75b392a/ : SUCCESS in 1h 04m 28s\n- check-osc-plugins http://logs.openstack.org/90/505890/11/check/check-osc-plugins/ded33fe/ : SUCCESS in 6m 18s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-osc-dsvm-functional-ubuntu-xenial/f14460e/ : SUCCESS in 45m 48s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/11/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/8a4dff3/ : SUCCESS in 44m 05s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/11/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/0571e8d/ : SUCCESS in 44m 27s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/11/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/763fb1c/ : SUCCESS in 1h 46m 56s (non-voting)","accounts_in_message":[],"_revision_number":11},{"id":"9bf2b62153a58ef9821be7b89429028c32f80e24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 23:17:30.000000000","message":"Patch Set 11: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"cd37e38d008aa8dc32d8f303c4cd35d4dd054f20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-27 00:34:39.000000000","message":"Patch Set 11: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/11/gate/gate-python-openstackclient-docs-ubuntu-xenial/ac78d00//doc/build/html/ : SUCCESS in 5m 33s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-python-openstackclient-pep8-ubuntu-xenial/17bbb87/ : SUCCESS in 5m 36s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-python-openstackclient-python27-ubuntu-xenial/ae55507/ : SUCCESS in 4m 00s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/11/gate/gate-python-openstackclient-python35/c963b3e/ : SUCCESS in 4m 12s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/90/505890/11/gate/gate-python-openstackclient-releasenotes/4505913//releasenotes/build/html/ : SUCCESS in 5m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/2b8ade9/ : SUCCESS in 1h 15m 57s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-osc-dsvm-functional-ubuntu-xenial/d0b527c/ : FAILURE in 44m 42s","accounts_in_message":[],"_revision_number":11},{"id":"21d9884279c8d663329e28bdfa1ce9f5717e5d00","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-27 02:26:15.000000000","message":"Patch Set 11: Code-Review+2\n\n\u003e I tweaked the release note a bit more, Steve-o it\u0027s\n \u003e double-backticks for code :)\n\noops, been doing too much markdown lately...","accounts_in_message":[],"_revision_number":11},{"id":"8d1dfb195cd893e6f0b934c12c1970fe1fce634c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-27 02:26:20.000000000","message":"Patch Set 11:\n\nrecheck","accounts_in_message":[],"_revision_number":11},{"id":"3d2fdf60675336bde19f1f0991aca420a15432ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-27 04:17:39.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/11/check/gate-python-openstackclient-docs-ubuntu-xenial/8ab5f29//doc/build/html/ : SUCCESS in 6m 18s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-python-openstackclient-pep8-ubuntu-xenial/951aace/ : SUCCESS in 5m 45s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-python-openstackclient-python27-ubuntu-xenial/e549dda/ : SUCCESS in 5m 14s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/11/check/gate-python-openstackclient-python35/83f7f96/ : SUCCESS in 5m 14s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/90/505890/11/check/gate-python-openstackclient-releasenotes/0886168//releasenotes/build/html/ : SUCCESS in 5m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/beaa646/ : SUCCESS in 1h 14m 59s\n- check-osc-plugins http://logs.openstack.org/90/505890/11/check/check-osc-plugins/7ddf11f/ : SUCCESS in 6m 09s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/11/check/gate-osc-dsvm-functional-ubuntu-xenial/b1729ab/ : SUCCESS in 47m 23s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/90/505890/11/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/96fadd7/ : SUCCESS in 46m 30s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/90/505890/11/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/0257478/ : SUCCESS in 37m 32s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/90/505890/11/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/d98b940/ : SUCCESS in 1h 48m 15s (non-voting)","accounts_in_message":[],"_revision_number":11},{"id":"6d0498a729ffa0cf01c7d8cdfc7712800df78663","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-27 04:17:49.000000000","message":"Patch Set 11: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"86c1a59e49382a7c5170080f53e140a9b92d8581","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-27 05:49:50.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":11},{"id":"ccf8d45cbd738dbbaddce15524b6d85fead526b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-27 05:49:50.000000000","message":"Patch Set 11: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/505890/11/gate/gate-python-openstackclient-docs-ubuntu-xenial/70ceb17//doc/build/html/ : SUCCESS in 5m 08s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-python-openstackclient-pep8-ubuntu-xenial/e1472d0/ : SUCCESS in 5m 42s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-python-openstackclient-python27-ubuntu-xenial/39798b4/ : SUCCESS in 3m 45s\n- gate-python-openstackclient-python35 http://logs.openstack.org/90/505890/11/gate/gate-python-openstackclient-python35/042d5e9/ : SUCCESS in 3m 57s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/90/505890/11/gate/gate-python-openstackclient-releasenotes/964f195//releasenotes/build/html/ : SUCCESS in 4m 55s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/c3fb8dc/ : SUCCESS in 1h 31m 53s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/90/505890/11/gate/gate-osc-dsvm-functional-ubuntu-xenial/7c933d9/ : SUCCESS in 46m 47s","accounts_in_message":[],"_revision_number":11},{"id":"cec335fceb19a6bab804f8bdfb8d55132e4763a7","author":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"date":"2017-09-27 08:48:24.000000000","message":"Patch Set 11: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit c2bcf8bdbf4acfc3991b312515b8061fc85b0c60","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"221b7052abcefa56213a6516cecc6de9c73026d1","revisions":{"2a9d540fd9e9dab468075c9bf9de76ba2464de58":{"kind":"REWORK","_number":1,"created":"2017-09-21 01:10:29.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/1"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:10:25.000000000","tz":330},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type oricmp-code are set to 0, the current implementation\nignores the same, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2a9d540fd9e9dab468075c9bf9de76ba2464de58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2a9d540fd9e9dab468075c9bf9de76ba2464de58"}]},"branch":"refs/heads/master"},"07ad8e0f82272f857567d019e21e88cac305e5ce":{"kind":"REWORK","_number":2,"created":"2017-09-22 18:40:16.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/2"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-22 18:39:47.000000000","tz":330},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type oricmp-code are set to 0, the current implementation\nignores the same, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/07ad8e0f82272f857567d019e21e88cac305e5ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/07ad8e0f82272f857567d019e21e88cac305e5ce"}]},"branch":"refs/heads/master"},"6cb2564094467dec5d2d3fb3a98366a94e2ac96b":{"kind":"REWORK","_number":3,"created":"2017-09-24 16:01:07.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/3"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-24 16:00:39.000000000","tz":330},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type oricmp-code are set to 0, the current implementation\nignores the same, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6cb2564094467dec5d2d3fb3a98366a94e2ac96b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6cb2564094467dec5d2d3fb3a98366a94e2ac96b"}]},"branch":"refs/heads/master"},"8c1c19d9e447f9916e412ea80ae5981153e2fcab":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2017-09-24 16:02:44.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/4"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"Venkatrangan Govindarajan","email":"venkatrangang@hcl.com","date":"2017-09-24 16:02:40.000000000","tz":0},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the same, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8c1c19d9e447f9916e412ea80ae5981153e2fcab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8c1c19d9e447f9916e412ea80ae5981153e2fcab"}]},"branch":"refs/heads/master"},"694332e06e8029435a0bb53a4d739d5722200980":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2017-09-24 16:03:16.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/5"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"Venkatrangan Govindarajan","email":"venkatrangang@hcl.com","date":"2017-09-24 16:03:13.000000000","tz":0},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/694332e06e8029435a0bb53a4d739d5722200980"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/694332e06e8029435a0bb53a4d739d5722200980"}]},"branch":"refs/heads/master"},"64a85011afac52bb5fe781797f72443c6604aa38":{"kind":"REWORK","_number":6,"created":"2017-09-25 03:23:08.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/6"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-25 03:22:47.000000000","tz":330},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/64a85011afac52bb5fe781797f72443c6604aa38"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/64a85011afac52bb5fe781797f72443c6604aa38"}]},"branch":"refs/heads/master"},"7bbc32af578a38e8a8f8b7debcdd0981f288c7b8":{"kind":"REWORK","_number":7,"created":"2017-09-26 04:30:43.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/7"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-26 04:30:18.000000000","tz":330},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7bbc32af578a38e8a8f8b7debcdd0981f288c7b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7bbc32af578a38e8a8f8b7debcdd0981f288c7b8"}]},"branch":"refs/heads/master"},"e4ba618a68a29cb5e26d509b862a5494becd473f":{"kind":"REWORK","_number":8,"created":"2017-09-26 06:01:27.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/8"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"Venkatrangan Govindarajan","email":"venkatrangang@hcl.com","date":"2017-09-26 06:01:20.000000000","tz":0},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e4ba618a68a29cb5e26d509b862a5494becd473f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e4ba618a68a29cb5e26d509b862a5494becd473f"}]},"branch":"refs/heads/master"},"49d06f847a1d791f81e6f2779ad47667d8a1150f":{"kind":"REWORK","_number":9,"created":"2017-09-26 15:48:01.000000000","uploader":{"_account_id":17256,"name":"Venkatrangan Govindarajan","email":"gvrangan@gmail.com","username":"gvrangan"},"ref":"refs/changes/90/505890/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/9"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-26 15:47:37.000000000","tz":330},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/49d06f847a1d791f81e6f2779ad47667d8a1150f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/49d06f847a1d791f81e6f2779ad47667d8a1150f"}]},"branch":"refs/heads/master"},"5b6763fd54776684b1bbb2301a0a28e7505b034e":{"kind":"REWORK","_number":10,"created":"2017-09-26 17:09:25.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/90/505890/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/10"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-09-26 17:09:16.000000000","tz":0},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5b6763fd54776684b1bbb2301a0a28e7505b034e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5b6763fd54776684b1bbb2301a0a28e7505b034e"}]},"branch":"refs/heads/master"},"221b7052abcefa56213a6516cecc6de9c73026d1":{"kind":"REWORK","_number":11,"created":"2017-09-26 21:00:19.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/90/505890/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/505890/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/505890/11"}}},"commit":{"parents":[{"commit":"f88d2f53ba576734a81227410e0232616dc766f4","subject":"Merge \"Add functional test cases for \"volume qos associate/disassociate\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f88d2f53ba576734a81227410e0232616dc766f4"}]}],"author":{"name":"gvrangan","email":"venkatrangang@hcl.com","date":"2017-09-21 01:07:10.000000000","tz":330},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2017-09-26 21:00:14.000000000","tz":0},"subject":"Support icmp-type and icmp-code to be set as zero","message":"Support icmp-type and icmp-code to be set as zero\n\nWhen icmp-type or icmp-code are set to 0, the current implementation\nignores the value, this fix will allow the value to be copied and\ndisplayed\n\nChange-Id: I96133a57883d22e98fcbb9fe0328d9e050472469\nSigned-off-by: gvrangan \u003cvenkatrangang@hcl.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/221b7052abcefa56213a6516cecc6de9c73026d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/221b7052abcefa56213a6516cecc6de9c73026d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
