)]}'
{"openstackclient/common/project_purge.py":[{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"99beda3693d4140aa8deae1c3ffd006714b66eef","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # images"},{"line_number":96,"context_line":"        try:"},{"line_number":97,"context_line":"            image_client \u003d self.app.client_manager.image"},{"line_number":98,"context_line":"            api_version \u003d int(getattr(image_client, \u0027version\u0027, 2.0))"},{"line_number":99,"context_line":"            if api_version \u003d\u003d 1:"},{"line_number":100,"context_line":"                data \u003d image_client.images.list(owner\u003dproject_id)"},{"line_number":101,"context_line":"            elif api_version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_7db76d88","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":68},"updated":"2017-09-22 09:16:06.000000000","message":"Since \u0027FakeImagev2Client\u0027 object has no attribute \u0027version\u0027, default value of \u0027api_version\u0027 is set to 2 to avoid ut fail.","commit_id":"eb5fdb2fc419ade30e7bb7877434bc474c5bf705"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7fff2cc511a54e685d147ac612d3b7d3ae4c4b9b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # images"},{"line_number":96,"context_line":"        try:"},{"line_number":97,"context_line":"            image_client \u003d self.app.client_manager.image"},{"line_number":98,"context_line":"            api_version \u003d int(getattr(image_client, \u0027version\u0027, 2.0))"},{"line_number":99,"context_line":"            if api_version \u003d\u003d 1:"},{"line_number":100,"context_line":"                data \u003d image_client.images.list(owner\u003dproject_id)"},{"line_number":101,"context_line":"            elif api_version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_940e7be3","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":68},"in_reply_to":"7f515b1d_7db76d88","updated":"2017-09-22 14:19:04.000000000","message":"Making the code work around a test fixture limitation has it backwards.  Add the things to the test fakes required to properly test the code.","commit_id":"eb5fdb2fc419ade30e7bb7877434bc474c5bf705"},{"author":{"_account_id":22299,"name":"lihaijing","email":"lihaijing@fiberhome.com","username":"lihaijing"},"change_message_id":"0766117d55e7be3187dc11c37e643b01bf9c7794","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # images"},{"line_number":96,"context_line":"        try:"},{"line_number":97,"context_line":"            image_client \u003d self.app.client_manager.image"},{"line_number":98,"context_line":"            api_version \u003d int(getattr(image_client, \u0027version\u0027, 2.0))"},{"line_number":99,"context_line":"            if api_version \u003d\u003d 1:"},{"line_number":100,"context_line":"                data \u003d image_client.images.list(owner\u003dproject_id)"},{"line_number":101,"context_line":"            elif api_version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_967be6bc","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":68},"in_reply_to":"7f515b1d_940e7be3","updated":"2017-09-26 00:53:14.000000000","message":"\u003e Making the code work around a test fixture limitation has it\n \u003e backwards.  Add the things to the test fakes required to properly\n \u003e test the code.\n\nI add member variable \u0027version\u0027 to class FakeImagev1/v2Client in patch set 6. Adding tests for Image v1 is a better way in the long term. But IMO it\u0027s better to do that in another commit. What do you think?","commit_id":"eb5fdb2fc419ade30e7bb7877434bc474c5bf705"}]}