)]}'
{"openstackclient/image/v1/image.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"65f2739644d508f02aa3ee853e7204d6cfe5850b","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        for attr in copy_attrs:"},{"line_number":630,"context_line":"            if attr in parsed_args:"},{"line_number":631,"context_line":"                val \u003d getattr(parsed_args, attr, None)"},{"line_number":632,"context_line":"                if val or val is 0:"},{"line_number":633,"context_line":"                    # Only include a value in kwargs for attributes that are"},{"line_number":634,"context_line":"                    # actually present on the command line"},{"line_number":635,"context_line":"                    # The zero is one of valid values for numeric attributes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_fd2e5641","line":632,"range":{"start_line":632,"start_character":29,"end_line":632,"end_character":30},"updated":"2017-09-26 20:43:15.000000000","message":"The correct test here is to compare val to None.  The point of this section is to only include attributes that were actually present on the command line, if an attr is None in parsed_args, or if it is not present in parsed_args (unlikely) it means it was not present on the command line.\n\n  if val is not None:\n\nThe bug is in not taking in to account that zero evaluates to false in the original code.","commit_id":"c5a7f4462e169fe3b9d3a88149783779291dc912"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"65f2739644d508f02aa3ee853e7204d6cfe5850b","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        for attr in copy_attrs:"},{"line_number":861,"context_line":"            if attr in parsed_args:"},{"line_number":862,"context_line":"                val \u003d getattr(parsed_args, attr, None)"},{"line_number":863,"context_line":"                if val or val is 0:"},{"line_number":864,"context_line":"                    # Only include a value in kwargs for attributes that are"},{"line_number":865,"context_line":"                    # actually present on the command line"},{"line_number":866,"context_line":"                    # The zero is one of valid values for numeric attributes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_7dd02620","line":863,"range":{"start_line":863,"start_character":30,"end_line":863,"end_character":32},"updated":"2017-09-26 20:43:15.000000000","message":"Same comment as in v1","commit_id":"c5a7f4462e169fe3b9d3a88149783779291dc912"}]}
