)]}'
{"id":"openstack%2Fpython-openstackclient~507345","triplet_id":"openstack%2Fpython-openstackclient~master~Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3","project":"openstack/python-openstackclient","branch":"master","topic":"accept_zero_when_set_image","hashtags":[],"change_id":"Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3","subject":"Accept 0 for --min-disk and --min-ram","status":"MERGED","created":"2017-09-26 04:43:25.000000000","updated":"2017-10-21 00:40:48.000000000","submitted":"2017-10-21 00:40:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"507345-1508546448545-271f2d14","meta_rev_id":"1e5db50171b703a48f08cf17e6348cabdc6e4ce3","_number":507345,"virtual_id_number":507345,"owner":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2017-10-21 00:40:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},{"value":2,"date":"2017-10-20 19:49:12.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},{"value":1,"date":"2017-10-20 19:49:12.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-26 04:43:40.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2017-10-12 06:28:44.000000000","updated_by":{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},"reviewer":{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},"state":"REVIEWER"},{"updated":"2017-10-12 13:07:25.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-10-13 19:15:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-10-20 19:49:12.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-10-21 00:40:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4a6ebbcba9b66ae710b43e82828208f1164a0286","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-09-26 04:43:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b792ead19317f899a94f2a403312b983d84dabb6","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2017-09-26 04:43:40.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"7382ed5aa6b01cfbdda2c89ef2fc5edb490c60b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 06:35:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/507345/1/check/gate-python-openstackclient-docs-ubuntu-xenial/f51487d//doc/build/html/ : SUCCESS in 5m 06s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/45/507345/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/6a5fa5a/ : SUCCESS in 5m 05s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/45/507345/1/check/gate-python-openstackclient-python27-ubuntu-xenial/679c34e/ : SUCCESS in 3m 42s\n- gate-python-openstackclient-python35 http://logs.openstack.org/45/507345/1/check/gate-python-openstackclient-python35/f17120b/ : SUCCESS in 4m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/45/507345/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/ddffafa/ : SUCCESS in 1h 10m 54s\n- check-osc-plugins http://logs.openstack.org/45/507345/1/check/check-osc-plugins/45674f8/ : SUCCESS in 6m 46s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/45/507345/1/check/gate-osc-dsvm-functional-ubuntu-xenial/1290de3/ : SUCCESS in 45m 10s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/45/507345/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/b5c1530/ : SUCCESS in 45m 47s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/45/507345/1/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/3cee569/ : SUCCESS in 45m 08s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/45/507345/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/d25cae4/ : SUCCESS in 1h 46m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2726316749292970aaf24c91e42b53d8e132b665","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-09-26 13:47:45.000000000","message":"Patch Set 1: Code-Review+2\n\nadd a release note (https://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes), but this looks fine otherwise","accounts_in_message":[],"_revision_number":1},{"id":"65f2739644d508f02aa3ee853e7204d6cfe5850b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-09-26 20:43:15.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nNice catch, however the fix is potentially problematic even though the test passes.  \u0027\u003d\u003d\u0027 is equality (same value) while \u0027is\u0027 is reference equality (same object).\n\nAlso, please add a release note referencing the bug.","accounts_in_message":[],"_revision_number":1},{"id":"d10a6fff0d9bee1c59027386c7cb0ec6ff964065","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-09-29 07:57:22.000000000","message":"Patch Set 1:\n\nHi Steve, thanks for your review.\n \u003e add a release note (https://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes),\n \u003e but this looks fine otherwise\nOkay. I will add a release note.","accounts_in_message":[],"_revision_number":1},{"id":"a57e3d3883c761f753b403012c98354ca1afcfef","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-09-29 07:59:17.000000000","message":"Patch Set 1:\n\nHi Dean, thanks for your review.\n\n\u003e  if val is not None:\n\nIt looked good, but the command got the following error after I modified like it.\n\n   update() got an unexpected keyword argument \u0027force\u0027\n\nIn openstackclient(v1), there is \u0027force\u0027 option with \u0027false\u0027 as defualt value.\nThe original code or your above code treats \u0027false\u0027 as valid value.\nIt cause openstackclient misjudege and pass \u0027force\u0027 to update() in glanceclient,\nwhich only accepts options including UPDATE_PARAMS, and cause this TypeError.\n\u0027force\u0027 is not in UPDATE_PARAMS, it shouldn\u0027t be passed to update().\n\n   --------glanceclient/v1/images.py----------\n   UPDATE_PARAMS \u003d (\u0027name\u0027, \u0027disk_format\u0027, \u0027container_format\u0027, \u0027min_disk\u0027,\n                    \u0027min_ram\u0027, \u0027owner\u0027, \u0027size\u0027, \u0027is_public\u0027, \u0027protected\u0027,\n                    \u0027location\u0027, \u0027checksum\u0027, \u0027copy_from\u0027, \u0027properties\u0027,\n                    # NOTE(bcwaldon: an attempt to update \u0027deleted\u0027 will be\n                    # ignored, but we need to support it for backwards-\n                    # compatibility with the legacy client library\n                    \u0027deleted\u0027)\n   -------------------------------------------\n\nFor your information, I had following tries.\n\n   if val is not None: --\u003e NG(\"update() got an unexpected keyword argument \u0027force\u0027\" occurs)\n   if val or val \u003d\u003d 0: --\u003e NG(\"update() got an unexpected keyword argument \u0027force\u0027\" occurs)\n   if val or val is 0: --\u003e OK","accounts_in_message":[],"_revision_number":1},{"id":"3e4619f423b2bed4bdd2a3450a6c604cc8652343","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-09-29 09:39:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6929c2fa0cc5762bbf0855da2bdc900367a88419","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-09-29 10:18:56.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed.\n\n- build-openstack-sphinx-docs http://logs.openstack.org/45/507345/2/check/build-openstack-sphinx-docs/499597f/html/latest/ : SUCCESS in 6m 52s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/45/507345/2/check/openstack-tox-pep8/20d9d67/ : SUCCESS in 6m 48s\n- openstack-tox-py27 http://logs.openstack.org/45/507345/2/check/openstack-tox-py27/f6200f7/ : SUCCESS in 6m 49s\n- openstack-tox-py35 http://logs.openstack.org/45/507345/2/check/openstack-tox-py35/b09f190/ : SUCCESS in 5m 17s\n- legacy-releasenotes http://logs.openstack.org/45/507345/2/check/legacy-releasenotes/cde0042/ : POST_FAILURE in 5m 06s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/507345/2/check/legacy-tempest-dsvm-neutron-src/b171892/ : FAILURE in 32m 45s\n- legacy-check-osc-plugins http://logs.openstack.org/45/507345/2/check/legacy-check-osc-plugins/422d681/ : FAILURE in 3m 40s (non-voting)\n- legacy-osc-dsvm-functional http://logs.openstack.org/45/507345/2/check/legacy-osc-dsvm-functional/a8e865f/ : FAILURE in 28m 03s\n- legacy-osc-dsvm-functional-tips http://logs.openstack.org/45/507345/2/check/legacy-osc-dsvm-functional-tips/6da2e9f/ : FAILURE in 33m 26s (non-voting)\n- legacy-osc-dsvm-functional-n-net http://logs.openstack.org/45/507345/2/check/legacy-osc-dsvm-functional-n-net/fca880f/ : FAILURE in 25m 26s (non-voting)\n- legacy-tripleo-ci-centos-7-nonha-multinode-oooq http://logs.openstack.org/45/507345/2/check/legacy-tripleo-ci-centos-7-nonha-multinode-oooq/33569ee/ : POST_FAILURE in 12m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"491663dec81c9fbb79c73c63a71c12cb32c2e053","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-09-29 18:46:04.000000000","message":"Patch Set 2:\n\nThis looks like a case where we are handling the option incorrectly then.  The point of the check is to determine if the option is present on the command-line, and the setting of --force to False as a default breaks our ability to do that.  I think we need to change --force to default to None, and ensure inside take_action() that we handle that as False internally as necessary.\n\nChecking for a 0 directly is just as incorrect as False,   Since we have no other way to detect the absense of an option on the command line, we are not (in this case) able to use argparse default values in the manner that -force does.  FWIW, we also have this issue in other APIs and this is why we handle other opposing pairs of options the way we do (see https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#boolean-options), like --enable|--disable.  In this case, there is no --no-force option but otherwise it must be handled the same.","accounts_in_message":[],"_revision_number":2},{"id":"02f3edb221456b808ca7e3cc649d7b85929ecd74","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-10-05 05:30:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"047decad172361e2f34d604aa262b8c109da441f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-05 07:19:53.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-docs-ubuntu-xenial/d8a5a98//doc/build/html/ : SUCCESS in 7m 36s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/fa21f73/ : SUCCESS in 4m 59s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python27-ubuntu-xenial/5e17765/ : SUCCESS in 3m 50s\n- gate-python-openstackclient-python35 http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python35/3313aa0/ : SUCCESS in 4m 14s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-releasenotes/92d1394//releasenotes/build/html/ : SUCCESS in 3m 55s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/f08a4a2/ : SUCCESS in 1h 13m 06s\n- check-osc-plugins http://logs.openstack.org/45/507345/3/check/check-osc-plugins/9f2b411/ : SUCCESS in 5m 36s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-ubuntu-xenial/004d210/ : SUCCESS in 51m 43s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/72dd4b4/ : SUCCESS in 51m 43s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/0ded0af/ : SUCCESS in 46m 43s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/45/507345/3/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/b04377a/ : SUCCESS in 1h 49m 06s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3244e62273571653fcb3d4c2836d41a3aeee384f","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-10-05 07:58:04.000000000","message":"Patch Set 3:\n\nHi,Dean.\n\nThanks. I changed \"if val or val is 0:\" to \"if val is not None:\".\nBut I didn\u0027t change --force\u0027s default value to \u0027None\u0027, because it seems that default values of other bool options(--private, --public, --protected, etc) aren\u0027t \u0027None\u0027 but \u0027False\u0027.\n\nCurrently take_action() handles these options separately from other non-bool options, so I fixed the code so that it also handles \u0027--force\u0027 like them.\nHow is this?","accounts_in_message":[],"_revision_number":3},{"id":"5709276ccafded50b1ed27889d4e6ac671eac39d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-05 08:00:05.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed.\n\n- build-openstack-sphinx-docs http://logs.openstack.org/45/507345/3/check/build-openstack-sphinx-docs/f0a4336/html/latest/ : SUCCESS in 8m 54s\n- openstack-tox-pep8 http://logs.openstack.org/45/507345/3/check/openstack-tox-pep8/300525e/ : SUCCESS in 6m 38s\n- openstack-tox-py27 http://logs.openstack.org/45/507345/3/check/openstack-tox-py27/fdfdfce/ : SUCCESS in 5m 08s\n- openstack-tox-py35 http://logs.openstack.org/45/507345/3/check/openstack-tox-py35/440141a/ : SUCCESS in 4m 29s\n- build-openstack-releasenotes http://logs.openstack.org/45/507345/3/check/build-openstack-releasenotes/1af375a/ : POST_FAILURE in 5m 07s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/507345/3/check/legacy-tempest-dsvm-neutron-src/4451588/ : SUCCESS in 1h 18m 46s\n- legacy-check-osc-plugins http://logs.openstack.org/45/507345/3/check/legacy-check-osc-plugins/9f8d254/ : FAILURE in 3m 16s (non-voting)\n- legacy-osc-dsvm-functional http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional/94e86fd/ : FAILURE in 24m 19s\n- legacy-osc-dsvm-functional-tips http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional-tips/47333a1/ : FAILURE in 25m 06s (non-voting)\n- legacy-osc-dsvm-functional-n-net http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional-n-net/3125ae5/ : FAILURE in 21m 33s (non-voting)\n- legacy-tripleo-ci-centos-7-nonha-multinode-oooq http://logs.openstack.org/45/507345/3/check/legacy-tripleo-ci-centos-7-nonha-multinode-oooq/3e39a95/ : FAILURE in 17m 38s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7fbe8f0819837effc507f20b4384e1ba364a19d7","author":{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},"date":"2017-10-10 06:57:11.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"23d3031ab4ead879c31f0ec2156d9f608536edce","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-10-10 09:00:46.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"f5e5295289543fd0b7d2daac638fec7b2e2b2d1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-10 09:03:43.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-docs-ubuntu-xenial/b87b595//doc/build/html/ : SUCCESS in 6m 53s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/9193ab9/ : SUCCESS in 5m 59s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python27-ubuntu-xenial/8bf4e25/ : SUCCESS in 6m 39s\n- gate-python-openstackclient-python35 http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python35/f1fdc8a/ : SUCCESS in 5m 47s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-releasenotes/e383483//releasenotes/build/html/ : SUCCESS in 5m 27s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/ac42282/ : SUCCESS in 1h 15m 57s\n- check-osc-plugins http://logs.openstack.org/45/507345/3/check/check-osc-plugins/6653c42/ : SUCCESS in 6m 21s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-ubuntu-xenial/aa829b9/ : SUCCESS in 41m 07s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/cd94314/ : SUCCESS in 42m 49s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/ef987f0/ : SUCCESS in 39m 00s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/45/507345/3/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/f171c85/ : SUCCESS in 2h 04m 06s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"dd5268486ddb7ea50acbf353030241c44eb8bf08","author":{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},"date":"2017-10-12 06:28:44.000000000","message":"Patch Set 3: Code-Review+1\n\nCode looks good. I also ran with this changeset and it appears to resolve the issue.","accounts_in_message":[],"_revision_number":3},{"id":"c03cc859709e8b03744e69af22e229dd0310ff4b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-10-12 13:07:25.000000000","message":"Patch Set 3: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"4c5194b942c1df115386033836abaa116854a113","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-12 13:48:35.000000000","message":"Patch Set 3:\n\nBuild failed.\n\n- openstack-tox-pep8 http://logs.openstack.org/45/507345/3/check/openstack-tox-pep8/4fe2ca2/ : RETRY_LIMIT in 1m 30s\n- openstack-tox-py27 finger://ze09.openstack.org/0ee1a99e17254a8e9c08278425d4f095 : RETRY_LIMIT in 1m 21s\n- openstack-tox-py35 finger://ze03.openstack.org/ba0f0b83e982464e93dd4734914e0917 : RETRY_LIMIT in 2m 02s\n- build-openstack-sphinx-docs finger://ze10.openstack.org/43db83b97bdc420c81af09bd5d2dc7e8 : POST_FAILURE in 6m 25s\n- build-openstack-releasenotes finger://ze10.openstack.org/9a8905086a49409ebd93eadfe8579ab8 : RETRY_LIMIT in 1m 25s\n- legacy-tempest-dsvm-neutron-src finger://ze01.openstack.org/5ec9be10dfdd412cb1922b46c6f3f8fc : POST_FAILURE in 5m 08s\n- legacy-check-osc-plugins http://logs.openstack.org/45/507345/3/check/legacy-check-osc-plugins/5ff7534/ : FAILURE in 2m 03s (non-voting)\n- legacy-osc-dsvm-functional http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional/fc633d8/ : FAILURE in 5m 15s\n- legacy-osc-dsvm-functional-tips finger://ze09.openstack.org/f4cfa624ccde42e69a61c03495771335 : POST_FAILURE in 29m 14s (non-voting)\n- legacy-osc-dsvm-functional-n-net finger://ze02.openstack.org/48f6445662fa4c219bb53acbfeb421d7 : POST_FAILURE in 5m 38s (non-voting)\n- legacy-tripleo-ci-centos-7-nonha-multinode-oooq http://logs.openstack.org/45/507345/3/check/legacy-tripleo-ci-centos-7-nonha-multinode-oooq/3de7447/ : FAILURE in 14m 43s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6d68075052ee4b859a9cf2be60d2fc8f4e50cf9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-12 15:11:11.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-docs-ubuntu-xenial/2747ae1//doc/build/html/ : SUCCESS in 5m 10s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/471f52f/ : SUCCESS in 4m 41s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python27-ubuntu-xenial/ab07606/ : SUCCESS in 5m 26s\n- gate-python-openstackclient-python35 http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python35/9002763/ : POST_FAILURE in 8m 32s\n- gate-python-openstackclient-releasenotes http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-releasenotes/057b977/ : FAILURE in 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/cbd5e4e/ : SUCCESS in 1h 19m 01s\n- check-osc-plugins http://logs.openstack.org/45/507345/3/check/check-osc-plugins/3273dfe/ : FAILURE in 44s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-ubuntu-xenial/6bc5fb5/ : SUCCESS in 48m 27s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/16caede/ : POST_FAILURE in 45m 31s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/8049f21/ : POST_FAILURE in 45m 51s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/45/507345/3/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/bc111ad/ : SUCCESS in 2h 03m 23s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"2251c4ce90aa9b49095424366bfce5ede3958f24","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-10-13 17:07:41.000000000","message":"Patch Set 3:\n\nrecheck with clean apt mirrors","accounts_in_message":[],"_revision_number":3},{"id":"0e55863f47e3f9408ab53f81d9708fd125a31af3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-13 19:15:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-docs-ubuntu-xenial/a9a9ca8//doc/build/html/ : SUCCESS in 5m 51s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/2c7499a/ : SUCCESS in 5m 43s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python27-ubuntu-xenial/91776e2/ : SUCCESS in 7m 57s\n- gate-python-openstackclient-python35 http://logs.openstack.org/45/507345/3/check/gate-python-openstackclient-python35/f62e0c5/ : SUCCESS in 5m 43s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/45/507345/3/check/gate-python-openstackclient-releasenotes/eb2c208//releasenotes/build/html/ : SUCCESS in 4m 49s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/29a68d5/ : SUCCESS in 1h 14m 54s\n- check-osc-plugins http://logs.openstack.org/45/507345/3/check/check-osc-plugins/5fd4179/ : SUCCESS in 7m 39s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-ubuntu-xenial/2269890/ : SUCCESS in 42m 34s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/1e3be2f/ : SUCCESS in 47m 51s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/45/507345/3/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/0250123/ : SUCCESS in 39m 09s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/45/507345/3/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/98f8e09/ : SUCCESS in 1h 54m 38s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"521ea0202bef3b8baa5300973bd398f04a6d8816","author":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"date":"2017-10-18 02:39:45.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"a83545e8de905f9d81a8a9dcb38813958f70c7a2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-18 05:27:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/45/507345/3/check/openstack-tox-pep8/28ed71f/ : SUCCESS in 5m 28s\n- openstack-tox-py27 http://logs.openstack.org/45/507345/3/check/openstack-tox-py27/e7d40a0/ : SUCCESS in 5m 23s\n- openstack-tox-py35 http://logs.openstack.org/45/507345/3/check/openstack-tox-py35/067b522/ : SUCCESS in 4m 59s\n- build-openstack-sphinx-docs http://logs.openstack.org/45/507345/3/check/build-openstack-sphinx-docs/8d7efdb/html/ : SUCCESS in 5m 50s\n- build-openstack-releasenotes http://logs.openstack.org/45/507345/3/check/build-openstack-releasenotes/3619ae7/html/ : SUCCESS in 6m 17s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/507345/3/check/legacy-tempest-dsvm-neutron-src/fc3204d/ : SUCCESS in 1h 19m 25s\n- legacy-check-osc-plugins http://logs.openstack.org/45/507345/3/check/legacy-check-osc-plugins/faf39aa/ : SUCCESS in 6m 04s (non-voting)\n- legacy-osc-dsvm-functional http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional/e0a1000/ : SUCCESS in 46m 22s\n- legacy-osc-dsvm-functional-tips http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional-tips/b744514/ : SUCCESS in 49m 04s (non-voting)\n- legacy-osc-dsvm-functional-n-net http://logs.openstack.org/45/507345/3/check/legacy-osc-dsvm-functional-n-net/f42e78b/ : SUCCESS in 41m 16s (non-voting)\n- legacy-tripleo-ci-centos-7-nonha-multinode-oooq http://logs.openstack.org/45/507345/3/check/legacy-tripleo-ci-centos-7-nonha-multinode-oooq/73dd908/ : SUCCESS in 2h 45m 54s (non-voting)\n- osc-functional-devstack http://logs.openstack.org/45/507345/3/check/osc-functional-devstack/df22333/ : SUCCESS in 1h 06m 27s","accounts_in_message":[],"_revision_number":3},{"id":"f063caff17dbe17b022af8f5897629f8ef412a9c","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-10-20 19:48:56.000000000","message":"Patch Set 4: Published edit on patch set 3.","accounts_in_message":[],"_revision_number":4},{"id":"87dd164c1e50867af2b536dbb91f6471282a0bc1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-10-20 19:49:12.000000000","message":"Patch Set 4: Workflow+1 Code-Review+2\n\nI re-worded the release note","accounts_in_message":[],"_revision_number":4},{"id":"628695f7476c3de3c81a1f8187d34da3d198c790","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-20 22:28:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/45/507345/4/check/openstack-tox-pep8/3f6a9e6/ : SUCCESS in 6m 00s\n- openstack-tox-py27 http://logs.openstack.org/45/507345/4/check/openstack-tox-py27/656eaab/ : SUCCESS in 6m 13s\n- openstack-tox-py35 http://logs.openstack.org/45/507345/4/check/openstack-tox-py35/62b0e5e/ : SUCCESS in 9m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/45/507345/4/check/build-openstack-sphinx-docs/10ab890/html/ : SUCCESS in 7m 07s\n- build-openstack-releasenotes http://logs.openstack.org/45/507345/4/check/build-openstack-releasenotes/24bcefc/html/ : SUCCESS in 7m 15s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/507345/4/check/legacy-tempest-dsvm-neutron-src/2df679c/ : SUCCESS in 1h 22m 26s\n- legacy-tripleo-ci-centos-7-nonha-multinode-oooq http://logs.openstack.org/45/507345/4/check/legacy-tripleo-ci-centos-7-nonha-multinode-oooq/42ab28b/ : FAILURE in 28m 38s (non-voting)\n- openstackclient-check-plugins http://logs.openstack.org/45/507345/4/check/openstackclient-check-plugins/fb931e2/ : SUCCESS in 11m 17s (non-voting)\n- osc-functional-devstack http://logs.openstack.org/45/507345/4/check/osc-functional-devstack/0563ac2/ : SUCCESS in 49m 03s\n- osc-functional-devstack-n-net http://logs.openstack.org/45/507345/4/check/osc-functional-devstack-n-net/d6a4707/ : SUCCESS in 42m 55s (non-voting)\n- osc-functional-devstack-tips http://logs.openstack.org/45/507345/4/check/osc-functional-devstack-tips/286937a/ : SUCCESS in 54m 42s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"6912e25410301d6ea7323e1c792bca60755d0779","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-20 22:28:17.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"35c7a5b79f44790f2882871a97af2485a9f37b62","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-21 00:40:48.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/45/507345/4/gate/openstack-tox-pep8/4adb27c/ : SUCCESS in 5m 58s\n- openstack-tox-py27 http://logs.openstack.org/45/507345/4/gate/openstack-tox-py27/7e797fb/ : SUCCESS in 5m 50s\n- openstack-tox-py35 http://logs.openstack.org/45/507345/4/gate/openstack-tox-py35/ce63bb3/ : SUCCESS in 6m 07s\n- build-openstack-sphinx-docs http://logs.openstack.org/45/507345/4/gate/build-openstack-sphinx-docs/5e440a8/html/ : SUCCESS in 6m 33s\n- build-openstack-releasenotes http://logs.openstack.org/45/507345/4/gate/build-openstack-releasenotes/f3b2dfd/html/ : SUCCESS in 6m 36s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/45/507345/4/gate/legacy-tempest-dsvm-neutron-src/cd6a2e2/ : SUCCESS in 1h 15m 59s\n- osc-functional-devstack http://logs.openstack.org/45/507345/4/gate/osc-functional-devstack/509d681/ : SUCCESS in 44m 09s","accounts_in_message":[],"_revision_number":4},{"id":"933dbc5eea17acf7de26b0ed5177b299faf225b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-21 00:40:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4464109c7754a9287f75ec2af84398700d1450e6","revisions":{"c5a7f4462e169fe3b9d3a88149783779291dc912":{"kind":"REWORK","_number":1,"created":"2017-09-26 04:43:25.000000000","uploader":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"ref":"refs/changes/45/507345/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/45/507345/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/1"}}},"commit":{"parents":[{"commit":"de2af66c1622115dcb28aca88aa62ce5b177c771","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de2af66c1622115dcb28aca88aa62ce5b177c771"}]}],"author":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-09-07 10:10:24.000000000","tz":540},"committer":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-09-26 04:38:44.000000000","tz":540},"subject":"Accept 0 for --min-disk and --min-ram","message":"Accept 0 for --min-disk and --min-ram\n\nThe current openstackclient implementation cannot accept 0\nfor --min-disk and --min-ram with the \"openstack image set\" command.\nIf theses options get set to 0, the option parser in openstackclient\nwrongly interprets 0 as no option value. The 0 is valid for these\noptions if administrators want to make it the default(no minimum\nrequirements).\n\nThis patch fix the parser so that it correctly treats 0 as an option\nvalue.\n\nChange-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3\nCloses-bug: #1719499\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c5a7f4462e169fe3b9d3a88149783779291dc912"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c5a7f4462e169fe3b9d3a88149783779291dc912"}]},"branch":"refs/heads/master"},"399d43477ee9d526d5796b231643eae423819141":{"kind":"REWORK","_number":2,"created":"2017-09-29 09:39:09.000000000","uploader":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"ref":"refs/changes/45/507345/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/45/507345/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/2"}}},"commit":{"parents":[{"commit":"de2af66c1622115dcb28aca88aa62ce5b177c771","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de2af66c1622115dcb28aca88aa62ce5b177c771"}]}],"author":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-09-07 10:10:24.000000000","tz":540},"committer":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-09-29 09:37:48.000000000","tz":540},"subject":"Accept 0 for --min-disk and --min-ram","message":"Accept 0 for --min-disk and --min-ram\n\nThe current openstackclient implementation cannot accept 0\nfor --min-disk and --min-ram with the \"openstack image set\" command.\nIf theses options get set to 0, the option parser in openstackclient\nwrongly interprets 0 as no option value. The 0 is valid for these\noptions if administrators want to make it the default(no minimum\nrequirements).\n\nThis patch fix the parser so that it correctly treats 0 as an option\nvalue.\n\nChange-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3\nCloses-bug: #1719499\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/399d43477ee9d526d5796b231643eae423819141"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/399d43477ee9d526d5796b231643eae423819141"}]},"branch":"refs/heads/master"},"96f095515b9bd30eb6a39afc8f20b97e65cc7c76":{"kind":"REWORK","_number":3,"created":"2017-10-05 05:30:33.000000000","uploader":{"_account_id":23982,"name":"shogoadachi","email":"sho-adachi@xc.jp.nec.com","username":"ShogoAdachi"},"ref":"refs/changes/45/507345/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/45/507345/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/3"}}},"commit":{"parents":[{"commit":"de2af66c1622115dcb28aca88aa62ce5b177c771","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de2af66c1622115dcb28aca88aa62ce5b177c771"}]}],"author":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-09-07 10:10:24.000000000","tz":540},"committer":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-10-05 05:29:53.000000000","tz":540},"subject":"Accept 0 for --min-disk and --min-ram","message":"Accept 0 for --min-disk and --min-ram\n\nThe current openstackclient implementation cannot accept 0\nfor --min-disk and --min-ram with the \"openstack image set\" command.\nIf theses options get set to 0, the option parser in openstackclient\nwrongly interprets 0 as no option value. The 0 is valid for these\noptions if administrators want to make it the default(no minimum\nrequirements).\n\nThis patch fix the parser so that it avoids only \u0027None\u0027.\n\nChange-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3\nCloses-bug: #1719499\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/96f095515b9bd30eb6a39afc8f20b97e65cc7c76"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/96f095515b9bd30eb6a39afc8f20b97e65cc7c76"}]},"branch":"refs/heads/master"},"4464109c7754a9287f75ec2af84398700d1450e6":{"kind":"REWORK","_number":4,"created":"2017-10-20 19:48:56.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/45/507345/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/45/507345/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/45/507345/4"}}},"commit":{"parents":[{"commit":"de2af66c1622115dcb28aca88aa62ce5b177c771","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de2af66c1622115dcb28aca88aa62ce5b177c771"}]}],"author":{"name":"ShogoAdachi","email":"sho-adachi@xc.jp.nec.com","date":"2017-09-07 10:10:24.000000000","tz":540},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2017-10-20 19:48:37.000000000","tz":0},"subject":"Accept 0 for --min-disk and --min-ram","message":"Accept 0 for --min-disk and --min-ram\n\nThe current openstackclient implementation cannot accept 0\nfor --min-disk and --min-ram with the \"openstack image set\" command.\nIf theses options get set to 0, the option parser in openstackclient\nwrongly interprets 0 as no option value. The 0 is valid for these\noptions if administrators want to make it the default(no minimum\nrequirements).\n\nThis patch fix the parser so that it avoids only \u0027None\u0027.\n\nChange-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3\nCloses-bug: #1719499\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4464109c7754a9287f75ec2af84398700d1450e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4464109c7754a9287f75ec2af84398700d1450e6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}