)]}'
{"openstackclient/network/sdk_utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"205ce541081c8ed4674e6af09f0a54d14d1ce0e9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    # Build the OSC column names to display for the SDK resource."},{"line_number":41,"context_line":"    attr_map \u003d {}"},{"line_number":42,"context_line":"    display_columns \u003d list(resource_dict.keys())"},{"line_number":43,"context_line":"    invisible_columns \u003d [] if invisible_columns is None else invisible_columns"},{"line_number":44,"context_line":"    for col_name in invisible_columns:"},{"line_number":45,"context_line":"        if col_name in display_columns:"},{"line_number":46,"context_line":"            display_columns.remove(col_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_8803010e","line":43,"range":{"start_line":43,"start_character":3,"end_line":43,"end_character":78},"updated":"2017-10-10 15:14:08.000000000","message":"Or we can do the similar thing with:\n\n  invisible_columns \u003d invisible_columns or []","commit_id":"885b1149c309667c6e4c3092b67fef3c01a15178"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"357ab567f4804144f465d2334bde34bb6ba737da","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    # Build the OSC column names to display for the SDK resource."},{"line_number":41,"context_line":"    attr_map \u003d {}"},{"line_number":42,"context_line":"    display_columns \u003d list(resource_dict.keys())"},{"line_number":43,"context_line":"    invisible_columns \u003d [] if invisible_columns is None else invisible_columns"},{"line_number":44,"context_line":"    for col_name in invisible_columns:"},{"line_number":45,"context_line":"        if col_name in display_columns:"},{"line_number":46,"context_line":"            display_columns.remove(col_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_da2e1ea4","line":43,"range":{"start_line":43,"start_character":3,"end_line":43,"end_character":78},"in_reply_to":"5f4e5783_35f6a591","updated":"2017-10-12 10:54:41.000000000","message":"I am not sure why we need to consider empty {} or empty set. The docstring says a list is expected. L.44 assumes any iterable, but we assumes a list so I don\u0027t think \"invisible_columns \u003d invisible_columns or []\" has negative effect and it normalizes it into []. I am okay with either. I just showed the pattern usually used in python code.","commit_id":"885b1149c309667c6e4c3092b67fef3c01a15178"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4dcaa41026b11bf007ad0dfbc19aea7c69bc583a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    # Build the OSC column names to display for the SDK resource."},{"line_number":41,"context_line":"    attr_map \u003d {}"},{"line_number":42,"context_line":"    display_columns \u003d list(resource_dict.keys())"},{"line_number":43,"context_line":"    invisible_columns \u003d [] if invisible_columns is None else invisible_columns"},{"line_number":44,"context_line":"    for col_name in invisible_columns:"},{"line_number":45,"context_line":"        if col_name in display_columns:"},{"line_number":46,"context_line":"            display_columns.remove(col_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_35f6a591","line":43,"range":{"start_line":43,"start_character":3,"end_line":43,"end_character":78},"in_reply_to":"5f4e5783_8803010e","updated":"2017-10-10 17:03:04.000000000","message":"Actually invisible_columns could be an empty {} or set() and this command will assign invisible_columns \u003d []\n\nIt\u0027s not going to happend, because invisible_columns should be a list. But your code could substitute something which is not a list.","commit_id":"885b1149c309667c6e4c3092b67fef3c01a15178"}]}