)]}'
{"id":"openstack%2Fpython-openstackclient~510876","triplet_id":"openstack%2Fpython-openstackclient~master~I3c7f915f0409c77f4c430467365eb1bcfd7757b3","project":"openstack/python-openstackclient","branch":"master","topic":"mutable_values_in_arguments","hashtags":[],"change_id":"I3c7f915f0409c77f4c430467365eb1bcfd7757b3","subject":"Avoid default mutable values in arguments","status":"MERGED","created":"2017-10-10 13:12:29.000000000","updated":"2017-10-13 14:23:54.000000000","submitted":"2017-10-13 14:23:54.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"510876-1507904634418-6691abb4","meta_rev_id":"52d8bc8d8b19ab1025d75815066d9f175d699dc9","_number":510876,"virtual_id_number":510876,"owner":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2017-10-13 10:23:59.000000000","_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-10-13 14:23:54.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":2,"date":"2017-10-10 13:16:21.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-10-12 10:54:41.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-10-12 10:54:41.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-10 13:16:21.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-10-12 10:54:41.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2017-10-13 14:23:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"32e1379ce44ceba7b3f925cb217729ee2eb5f18c","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2017-10-10 13:12:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3856658b8282431d7df37688076f1e3fef8acb7b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-10-10 13:16:21.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"4fa79d1828911356e6d46597fea21be986f9f5fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-10 15:05:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/510876/1/check/gate-python-openstackclient-docs-ubuntu-xenial/ad90983//doc/build/html/ : SUCCESS in 5m 35s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/0dd586d/ : SUCCESS in 5m 15s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-python-openstackclient-python27-ubuntu-xenial/8a14d97/ : SUCCESS in 5m 01s\n- gate-python-openstackclient-python35 http://logs.openstack.org/76/510876/1/check/gate-python-openstackclient-python35/cc1d896/ : SUCCESS in 4m 30s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/34dc3cd/ : SUCCESS in 1h 13m 23s\n- check-osc-plugins http://logs.openstack.org/76/510876/1/check/check-osc-plugins/33ba45a/ : SUCCESS in 5m 39s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-osc-dsvm-functional-ubuntu-xenial/9e3705c/ : SUCCESS in 48m 11s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/76/510876/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/05c8585/ : FAILURE in 47m 16s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/76/510876/1/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/40b1637/ : SUCCESS in 37m 39s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/76/510876/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/dae785e/ : SUCCESS in 1h 48m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"205ce541081c8ed4674e6af09f0a54d14d1ce0e9","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-10-10 15:14:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4dcaa41026b11bf007ad0dfbc19aea7c69bc583a","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2017-10-10 17:03:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"357ab567f4804144f465d2334bde34bb6ba737da","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-10-12 10:54:41.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"751386b400cd19dbca483766df3585e13d819eff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-12 10:54:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a35ea6f1779ec5b1843ede5f8bb865365af3afc4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-12 12:12:43.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/510876/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/49fb93b//doc/build/html/ : SUCCESS in 5m 21s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/af4b914/ : SUCCESS in 5m 05s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/8547eb9/ : SUCCESS in 3m 48s\n- gate-python-openstackclient-python35 http://logs.openstack.org/76/510876/1/gate/gate-python-openstackclient-python35/d69ea28/ : FAILURE in 1m 03s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/f334aab/ : SUCCESS in 1h 16m 59s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-osc-dsvm-functional-ubuntu-xenial/f70919c/ : SUCCESS in 43m 30s","accounts_in_message":[],"_revision_number":1},{"id":"90f748cb88678c1c05321c86dc26c932f391e81e","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2017-10-13 10:23:59.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e2f19a14df0f6c1d3c6e19335789b8fef5d6b69c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-13 12:58:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/510876/1/check/gate-python-openstackclient-docs-ubuntu-xenial/91a401b//doc/build/html/ : SUCCESS in 6m 15s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/80d4a2b/ : SUCCESS in 6m 59s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-python-openstackclient-python27-ubuntu-xenial/f0633d8/ : SUCCESS in 4m 12s\n- gate-python-openstackclient-python35 http://logs.openstack.org/76/510876/1/check/gate-python-openstackclient-python35/361a71c/ : SUCCESS in 4m 47s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/d0c760e/ : SUCCESS in 1h 20m 18s\n- check-osc-plugins http://logs.openstack.org/76/510876/1/check/check-osc-plugins/647f925/ : SUCCESS in 7m 03s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/76/510876/1/check/gate-osc-dsvm-functional-ubuntu-xenial/51096ee/ : SUCCESS in 37m 11s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/76/510876/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/4acac8f/ : SUCCESS in 48m 07s (non-voting)\n- gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv http://logs.openstack.org/76/510876/1/check/gate-osc-dsvm-functional-n-net-ubuntu-xenial-nv/7598ada/ : SUCCESS in 37m 46s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/76/510876/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/16d676f/ : FAILURE in 2h 23m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fc91c7bfe08bc2f093cbb702e37cf04aa13e7cda","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-13 12:58:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6441c4cd2dfca7fee36fae2b506a8ff09379052b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-13 14:23:54.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"5db670a8a175b90041c289362819df48fee3c4fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-13 14:23:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/76/510876/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/4fc516e//doc/build/html/ : SUCCESS in 6m 09s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/56065de/ : SUCCESS in 5m 56s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/a8d0033/ : SUCCESS in 4m 49s\n- gate-python-openstackclient-python35 http://logs.openstack.org/76/510876/1/gate/gate-python-openstackclient-python35/a993317/ : SUCCESS in 6m 24s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/43c81f5/ : SUCCESS in 1h 24m 27s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/76/510876/1/gate/gate-osc-dsvm-functional-ubuntu-xenial/75724b1/ : SUCCESS in 44m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"885b1149c309667c6e4c3092b67fef3c01a15178","revisions":{"885b1149c309667c6e4c3092b67fef3c01a15178":{"kind":"REWORK","_number":1,"created":"2017-10-10 13:12:29.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/76/510876/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/76/510876/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/510876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/510876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/76/510876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/76/510876/1"}}},"commit":{"parents":[{"commit":"a87bd58fb4de5dc5f99193b88d2a3f8bd1338c52","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a87bd58fb4de5dc5f99193b88d2a3f8bd1338c52"}]}],"author":{"name":"Rodolfo Alonso Hernandez","email":"rodolfo.alonso.hernandez@intel.com","date":"2017-10-10 13:04:40.000000000","tz":60},"committer":{"name":"Rodolfo Alonso Hernandez","email":"rodolfo.alonso.hernandez@intel.com","date":"2017-10-10 13:04:40.000000000","tz":60},"subject":"Avoid default mutable values in arguments","message":"Avoid default mutable values in arguments\n\nMutable values shouldn\u0027t be used as default values in function\narguments [1].\n\n[1] http://docs.python-guide.org/en/latest/writing/gotchas/\n\nChange-Id: I3c7f915f0409c77f4c430467365eb1bcfd7757b3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/885b1149c309667c6e4c3092b67fef3c01a15178"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/885b1149c309667c6e4c3092b67fef3c01a15178"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}