)]}'
{"doc/source/cli/command-objects/quota.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4d7e51a706a39ff3c19e11a9475269a56815d501","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    openstack quota list"},{"line_number":19,"context_line":"        --compute | --network | --volume"},{"line_number":20,"context_line":"        [--detail]"},{"line_number":21,"context_line":"        [\u003cproject\u003e]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --network"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df87a7cf_a8785f8f","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":17},"updated":"2017-12-11 18:46:32.000000000","message":"Why are you adding a positional here?  We don\u0027t do those on list commands, this should be the usual --project-* set of options","commit_id":"00608c30059b72c2427bca4d96b6ee4ae470aad1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8cfb0531061fa8d82c11d5ab9c53edd3ffd64cf5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    openstack quota list"},{"line_number":19,"context_line":"        --compute | --network | --volume"},{"line_number":20,"context_line":"        [--detail]"},{"line_number":21,"context_line":"        [\u003cproject\u003e]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --network"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df87a7cf_9984cfd4","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":17},"in_reply_to":"df87a7cf_a8785f8f","updated":"2017-12-11 20:54:43.000000000","message":"I wanted to do it in same way like it is now for quota list (see below). Should I change it here?","commit_id":"00608c30059b72c2427bca4d96b6ee4ae470aad1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03b71ce9e7f5b7735f9a144bfe5d7f7966ff068b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    openstack quota list"},{"line_number":19,"context_line":"        --compute | --network | --volume"},{"line_number":20,"context_line":"        [--detail]"},{"line_number":21,"context_line":"        [\u003cproject\u003e]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --network"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"9fdfeff1_ded8c9f1","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":19},"updated":"2019-02-04 16:43:35.000000000","message":"This should not be a positional argument.  The positional args are the things referenced in the command resource, here it\u0027s just \u0027quota\u0027 which is ambiguous.\n\nProject is always in a --project option, plus you need to consider the domain as projects are not unique by themselves.","commit_id":"7a2903a15b50146d7ce4c2bd704ec26633553d3f"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"f49cd4d009ba2bbaaa4a0ed7baaa0311adef2266","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    openstack quota list"},{"line_number":19,"context_line":"        --compute | --network | --volume"},{"line_number":20,"context_line":"        [--detail]"},{"line_number":21,"context_line":"        [\u003cproject\u003e]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --network"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"9fdfeff1_3b09d530","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":19},"in_reply_to":"9fdfeff1_ded8c9f1","updated":"2019-02-05 11:56:54.000000000","message":"Done","commit_id":"7a2903a15b50146d7ce4c2bd704ec26633553d3f"}],"openstackclient/common/quota.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d7c3cd1910d98deeba7cb67215f3d54c9ae215f2","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            if parsed_args.default:"},{"line_number":503,"context_line":"                network_quota \u003d client.get_quota_default(project)"},{"line_number":504,"context_line":"                if type(network_quota) is not dict:"},{"line_number":505,"context_line":"                    network_quota \u003d network_quota.to_dict()"},{"line_number":506,"context_line":"            else:"},{"line_number":507,"context_line":"                network_quota \u003d client.get_quota(project,"},{"line_number":508,"context_line":"                                                 details\u003dparsed_args.detail)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_e16a1deb","line":505,"range":{"start_line":505,"start_character":50,"end_line":505,"end_character":57},"updated":"2017-11-15 22:08:55.000000000","message":"The comment below for this check says it can go after min SDK version is 0.9.12, we\u0027re at min 0.9.19, so just remove this?","commit_id":"d20acfd65a27f8e9df857f057f800f00a9bcb3fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ed3fae8c657845be9aac1bd80baa2e3c80abe8c3","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            if parsed_args.default:"},{"line_number":503,"context_line":"                network_quota \u003d client.get_quota_default(project)"},{"line_number":504,"context_line":"                if type(network_quota) is not dict:"},{"line_number":505,"context_line":"                    network_quota \u003d network_quota.to_dict()"},{"line_number":506,"context_line":"            else:"},{"line_number":507,"context_line":"                network_quota \u003d client.get_quota(project,"},{"line_number":508,"context_line":"                                                 details\u003dparsed_args.detail)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_d05568fb","line":505,"range":{"start_line":505,"start_character":50,"end_line":505,"end_character":57},"in_reply_to":"1f485f77_e16a1deb","updated":"2017-11-17 20:59:35.000000000","message":"unfortunately this comment was wrong. I tried to remove it but some tests fails then as openstack sdk is still returning Quota object instead of dict","commit_id":"d20acfd65a27f8e9df857f057f800f00a9bcb3fa"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"965bbf2c9377146ba2ad596029c3880176fc265a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if type(network_quota) is not dict:"},{"line_number":171,"context_line":"                    network_quota \u003d network_quota.to_dict()"},{"line_number":172,"context_line":"                if detail:"},{"line_number":173,"context_line":"                    # NOTE(slaweq): Neutro return values with ke \"used\" but"},{"line_number":174,"context_line":"                    # Nova for example returns same data with key \"in_use\""},{"line_number":175,"context_line":"                    # instead."},{"line_number":176,"context_line":"                    # Because of that we need to convert Neutron key to"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_fdf0d569","line":173,"range":{"start_line":173,"start_character":62,"end_line":173,"end_character":64},"updated":"2017-12-06 17:32:45.000000000","message":"key","commit_id":"8ae59a23249a82b114e4a4b431446778f3f1ff0d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5f4948faf035d277e0fee9659858d8778ad06808","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if type(network_quota) is not dict:"},{"line_number":171,"context_line":"                    network_quota \u003d network_quota.to_dict()"},{"line_number":172,"context_line":"                if detail:"},{"line_number":173,"context_line":"                    # NOTE(slaweq): Neutro return values with ke \"used\" but"},{"line_number":174,"context_line":"                    # Nova for example returns same data with key \"in_use\""},{"line_number":175,"context_line":"                    # instead."},{"line_number":176,"context_line":"                    # Because of that we need to convert Neutron key to"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_b3590b8f","line":173,"range":{"start_line":173,"start_character":62,"end_line":173,"end_character":64},"in_reply_to":"df87a7cf_fdf0d569","updated":"2017-12-07 11:33:53.000000000","message":"Done","commit_id":"8ae59a23249a82b114e4a4b431446778f3f1ff0d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"965bbf2c9377146ba2ad596029c3880176fc265a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            default\u003dFalse,"},{"line_number":257,"context_line":"            help\u003d_(\u0027List network quota\u0027),"},{"line_number":258,"context_line":"        )"},{"line_number":259,"context_line":"        option.add_argument("},{"line_number":260,"context_line":"            \u0027--detail\u0027,"},{"line_number":261,"context_line":"            dest\u003d\u0027detail\u0027,"},{"line_number":262,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_7ddb65ec","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":14},"updated":"2017-12-06 17:32:45.000000000","message":"Why is this part of the mutex group?  It seems like --details is orthogonal to which service you might select?\n\nExcept of course that --details --volume would be empty, but handle that directly.","commit_id":"8ae59a23249a82b114e4a4b431446778f3f1ff0d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e8ca907b5176ea38dca44014adbbb76cea039734","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            default\u003dFalse,"},{"line_number":257,"context_line":"            help\u003d_(\u0027List network quota\u0027),"},{"line_number":258,"context_line":"        )"},{"line_number":259,"context_line":"        option.add_argument("},{"line_number":260,"context_line":"            \u0027--detail\u0027,"},{"line_number":261,"context_line":"            dest\u003d\u0027detail\u0027,"},{"line_number":262,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_56073183","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":14},"in_reply_to":"df87a7cf_6eee2db5","updated":"2017-12-08 09:17:46.000000000","message":"Ok, I changed it.","commit_id":"8ae59a23249a82b114e4a4b431446778f3f1ff0d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a817b4fc0121ee264fc43ea93c35f7c03bcab6a7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            default\u003dFalse,"},{"line_number":257,"context_line":"            help\u003d_(\u0027List network quota\u0027),"},{"line_number":258,"context_line":"        )"},{"line_number":259,"context_line":"        option.add_argument("},{"line_number":260,"context_line":"            \u0027--detail\u0027,"},{"line_number":261,"context_line":"            dest\u003d\u0027detail\u0027,"},{"line_number":262,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_936ba71c","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":14},"in_reply_to":"df87a7cf_7ddb65ec","updated":"2017-12-07 11:33:37.000000000","message":"I wanted to do it in a way that when user gives \"--detail\" it will returns him list of detailed quotas from all projects.\nDo You think it should be done \"per project\"","commit_id":"8ae59a23249a82b114e4a4b431446778f3f1ff0d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"92557f6d04ccde12415af6edffb4938434e26286","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            default\u003dFalse,"},{"line_number":257,"context_line":"            help\u003d_(\u0027List network quota\u0027),"},{"line_number":258,"context_line":"        )"},{"line_number":259,"context_line":"        option.add_argument("},{"line_number":260,"context_line":"            \u0027--detail\u0027,"},{"line_number":261,"context_line":"            dest\u003d\u0027detail\u0027,"},{"line_number":262,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_6eee2db5","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":14},"in_reply_to":"df87a7cf_936ba71c","updated":"2017-12-07 17:07:28.000000000","message":"I need to be clear, \"project\" (aka tenant) is a resource attribute, \"service\" is an API.  The help strings and docs need to be clear on that distinction too.\n\nSo I would expect to be able to get quotas filtered by service (--compute, --volume, etc) with _or_ without --details.","commit_id":"8ae59a23249a82b114e4a4b431446778f3f1ff0d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a0f0af3cc70eb0c7a16bf88686ff41c5b209773c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if type(network_quota) is not dict:"},{"line_number":171,"context_line":"                    network_quota \u003d network_quota.to_dict()"},{"line_number":172,"context_line":"                if detail:"},{"line_number":173,"context_line":"                    # NOTE(slaweq): Neutro return values with key \"used\" but"},{"line_number":174,"context_line":"                    # Nova for example returns same data with key \"in_use\""},{"line_number":175,"context_line":"                    # instead."},{"line_number":176,"context_line":"                    # Because of that we need to convert Neutron key to"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_20afc77d","line":173,"range":{"start_line":173,"start_character":36,"end_line":173,"end_character":49},"updated":"2018-04-23 09:06:15.000000000","message":"typo: Neutron returns","commit_id":"00608c30059b72c2427bca4d96b6ee4ae470aad1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a0f0af3cc70eb0c7a16bf88686ff41c5b209773c","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                                                           parsed_args)"},{"line_number":600,"context_line":"        volume_quota_info \u003d self.get_compute_volume_quota(volume_client,"},{"line_number":601,"context_line":"                                                          parsed_args)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        network_quota_info \u003d self.get_network_quota(parsed_args)"},{"line_number":604,"context_line":"        # NOTE(reedip): Remove the below check once requirement for"},{"line_number":605,"context_line":"        #               Openstack SDK is fixed to version 0.9.12 and"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_a04517b6","line":602,"range":{"start_line":602,"start_character":0,"end_line":602,"end_character":0},"updated":"2018-04-23 09:06:15.000000000","message":"This extra line is useless","commit_id":"00608c30059b72c2427bca4d96b6ee4ae470aad1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a0f0af3cc70eb0c7a16bf88686ff41c5b209773c","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                                                          parsed_args)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        network_quota_info \u003d self.get_network_quota(parsed_args)"},{"line_number":604,"context_line":"        # NOTE(reedip): Remove the below check once requirement for"},{"line_number":605,"context_line":"        #               Openstack SDK is fixed to version 0.9.12 and"},{"line_number":606,"context_line":"        #               above"},{"line_number":607,"context_line":"        if type(network_quota_info) is not dict:"},{"line_number":608,"context_line":"            network_quota_info \u003d network_quota_info.to_dict()"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_801a53c9","line":606,"range":{"start_line":604,"start_character":0,"end_line":606,"end_character":29},"updated":"2018-04-23 09:06:15.000000000","message":"this change of formatting is useless.","commit_id":"00608c30059b72c2427bca4d96b6ee4ae470aad1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b233d67ea219ce1301182247b8978e31e5cc9cd2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                if default:"},{"line_number":136,"context_line":"                    quota \u003d client.quotas.defaults(project)"},{"line_number":137,"context_line":"                else:"},{"line_number":138,"context_line":"                    # NOTE(slaweq): as cinder client don\u0027t supports detail flag"},{"line_number":139,"context_line":"                    # we have to pass it only if it\u0027s True which means that"},{"line_number":140,"context_line":"                    # \"client\" will be NovaClient in fact"},{"line_number":141,"context_line":"                    if detail:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_55ca6aa1","line":138,"range":{"start_line":138,"start_character":53,"end_line":138,"end_character":67},"updated":"2019-02-05 10:19:45.000000000","message":"nit: doesn\u0027t support","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"f49cd4d009ba2bbaaa4a0ed7baaa0311adef2266","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                if default:"},{"line_number":136,"context_line":"                    quota \u003d client.quotas.defaults(project)"},{"line_number":137,"context_line":"                else:"},{"line_number":138,"context_line":"                    # NOTE(slaweq): as cinder client don\u0027t supports detail flag"},{"line_number":139,"context_line":"                    # we have to pass it only if it\u0027s True which means that"},{"line_number":140,"context_line":"                    # \"client\" will be NovaClient in fact"},{"line_number":141,"context_line":"                    if detail:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_96fd380a","line":138,"range":{"start_line":138,"start_character":53,"end_line":138,"end_character":67},"in_reply_to":"9fdfeff1_55ca6aa1","updated":"2019-02-05 11:56:54.000000000","message":"Done","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b233d67ea219ce1301182247b8978e31e5cc9cd2","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                    # NOTE(slaweq): as cinder client don\u0027t supports detail flag"},{"line_number":139,"context_line":"                    # we have to pass it only if it\u0027s True which means that"},{"line_number":140,"context_line":"                    # \"client\" will be NovaClient in fact"},{"line_number":141,"context_line":"                    if detail:"},{"line_number":142,"context_line":"                        quota \u003d client.quotas.get(project, detail\u003dTrue)"},{"line_number":143,"context_line":"                    else:"},{"line_number":144,"context_line":"                        quota \u003d client.quotas.get(project)"},{"line_number":145,"context_line":"        except Exception as e:"},{"line_number":146,"context_line":"            if type(e).__name__ \u003d\u003d \u0027EndpointNotFound\u0027:"},{"line_number":147,"context_line":"                return {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_752bee2f","line":144,"range":{"start_line":141,"start_character":20,"end_line":144,"end_character":58},"updated":"2019-02-05 10:19:45.000000000","message":"You can write it shorter:\nquota \u003d client.quotas.get(project, detail\u003ddetail)","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"f49cd4d009ba2bbaaa4a0ed7baaa0311adef2266","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                    # NOTE(slaweq): as cinder client don\u0027t supports detail flag"},{"line_number":139,"context_line":"                    # we have to pass it only if it\u0027s True which means that"},{"line_number":140,"context_line":"                    # \"client\" will be NovaClient in fact"},{"line_number":141,"context_line":"                    if detail:"},{"line_number":142,"context_line":"                        quota \u003d client.quotas.get(project, detail\u003dTrue)"},{"line_number":143,"context_line":"                    else:"},{"line_number":144,"context_line":"                        quota \u003d client.quotas.get(project)"},{"line_number":145,"context_line":"        except Exception as e:"},{"line_number":146,"context_line":"            if type(e).__name__ \u003d\u003d \u0027EndpointNotFound\u0027:"},{"line_number":147,"context_line":"                return {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_b602bc08","line":144,"range":{"start_line":141,"start_character":20,"end_line":144,"end_character":58},"in_reply_to":"9fdfeff1_752bee2f","updated":"2019-02-05 11:56:54.000000000","message":"Done","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b233d67ea219ce1301182247b8978e31e5cc9cd2","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            \u0027Limit\u0027"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        quotas \u003d {}"},{"line_number":228,"context_line":"        # NOTE(slaweq): currently volume service don\u0027t provide detailed quota"},{"line_number":229,"context_line":"        # info so it is only valid for compute and network"},{"line_number":230,"context_line":"        if parsed_args.compute:"},{"line_number":231,"context_line":"            quotas.update(self.get_compute_quota("}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_b5a4f6ba","line":228,"range":{"start_line":228,"start_character":48,"end_line":228,"end_character":55},"updated":"2019-02-05 10:19:45.000000000","message":"nit: doesn\u0027t","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"f49cd4d009ba2bbaaa4a0ed7baaa0311adef2266","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            \u0027Limit\u0027"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        quotas \u003d {}"},{"line_number":228,"context_line":"        # NOTE(slaweq): currently volume service don\u0027t provide detailed quota"},{"line_number":229,"context_line":"        # info so it is only valid for compute and network"},{"line_number":230,"context_line":"        if parsed_args.compute:"},{"line_number":231,"context_line":"            quotas.update(self.get_compute_quota("}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_5607d019","line":228,"range":{"start_line":228,"start_character":48,"end_line":228,"end_character":55},"in_reply_to":"9fdfeff1_b5a4f6ba","updated":"2019-02-05 11:56:54.000000000","message":"Done","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b233d67ea219ce1301182247b8978e31e5cc9cd2","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    ) for s in result))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        if parsed_args.volume:"},{"line_number":358,"context_line":"            if parsed_args.detail:"},{"line_number":359,"context_line":"                return self._get_detailed_quotas(parsed_args)"},{"line_number":360,"context_line":"            volume_client \u003d self.app.client_manager.volume"},{"line_number":361,"context_line":"            for p in project_ids:"},{"line_number":362,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_50ca78a1","line":359,"range":{"start_line":358,"start_character":12,"end_line":359,"end_character":61},"updated":"2019-02-05 10:19:45.000000000","message":"I would put a comment before these lines as well to make sure that it is clear for all the readers that for volume there is no detailed quotas.\n\nOn the other hand I am not sure if to decide that for volume there is no detailed quota information happens in _get_detailed_quotas, and not here. I mean why you call get_detailed_quotas if for volume it is not supported?","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"f49cd4d009ba2bbaaa4a0ed7baaa0311adef2266","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    ) for s in result))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        if parsed_args.volume:"},{"line_number":358,"context_line":"            if parsed_args.detail:"},{"line_number":359,"context_line":"                return self._get_detailed_quotas(parsed_args)"},{"line_number":360,"context_line":"            volume_client \u003d self.app.client_manager.volume"},{"line_number":361,"context_line":"            for p in project_ids:"},{"line_number":362,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_16114854","line":359,"range":{"start_line":358,"start_character":12,"end_line":359,"end_character":61},"in_reply_to":"9fdfeff1_50ca78a1","updated":"2019-02-05 11:56:54.000000000","message":"Done","commit_id":"4fef681c7109141a371540714a67d1ccdd2e4527"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"51e8ab9bbc7e09a4aae25db260a7c5e9517e9176","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                if default:"},{"line_number":136,"context_line":"                    quota \u003d client.quotas.defaults(project)"},{"line_number":137,"context_line":"                else:"},{"line_number":138,"context_line":"                    quota \u003d client.quotas.get(project, details\u003ddetail)"},{"line_number":139,"context_line":"        except Exception as e:"},{"line_number":140,"context_line":"            if type(e).__name__ \u003d\u003d \u0027EndpointNotFound\u0027:"},{"line_number":141,"context_line":"                return {}"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_7048dc86","line":138,"range":{"start_line":138,"start_character":55,"end_line":138,"end_character":62},"updated":"2019-02-19 12:44:14.000000000","message":"Change to detail\u003ddetail, and the functional tests will pass, as I see","commit_id":"8b55b65f0d5960813590e48b35e5fc74c67a01d8"}],"openstackclient/tests/unit/common/test_quota.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a0f0af3cc70eb0c7a16bf88686ff41c5b209773c","unresolved":false,"context_lines":[{"line_number":901,"context_line":"        verifylist \u003d ["},{"line_number":902,"context_line":"            (\u0027project\u0027, self.projects[0].name),"},{"line_number":903,"context_line":"        ]"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_40851bce","line":904,"range":{"start_line":904,"start_character":0,"end_line":904,"end_character":0},"updated":"2018-04-23 09:06:15.000000000","message":"Useless line additions","commit_id":"00608c30059b72c2427bca4d96b6ee4ae470aad1"}]}