)]}'
{"doc/source/cli/command-objects/network.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"83bc1df0ee5dc7c5e6b62deedb422d11429e37dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f4b6375_508d5dd1","updated":"2017-11-01 13:04:31.000000000","message":"we also need to update port.rst, too, right?","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":26880,"name":"Pierre Hanselmann","email":"pierre.hanselmann@gmail.com","username":"Zophar"},"change_message_id":"888cd9a64f87bb0fa9069937814793aa92e41ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f4b6375_abf42688","in_reply_to":"3f4b6375_508d5dd1","updated":"2017-11-01 13:35:45.000000000","message":"Port has no \"dns-domain\" option/arg. Only \"dns-name\" which is already documented.","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42470a39950ff786eddb2eb79efa93ecdcbbb7de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f4b6375_0231d8a2","in_reply_to":"3f4b6375_abf42688","updated":"2017-11-01 15:43:41.000000000","message":"This patch changes the metavar of --dns-name option of \u0027port\u0027 (which adds \u003c\u003e to \u0027dns-name\u0027), but the document is already correct, so there is no need to update it.","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1caab9b34e421f03c34b937d31534b7173204f28","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":".. option:: --dns-domain \u003cdns-domain\u003e"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    Set DNS domain to this network (requires DNS integration extension)."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. option:: --tag \u003ctag\u003e"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f9dbf25_79ede789","line":172,"range":{"start_line":172,"start_character":19,"end_line":172,"end_character":21},"updated":"2018-03-02 15:11:30.000000000","message":"s/of\n\nor \u0027for\u0027, either one works","commit_id":"e196055e65e723aa9c061d67fbf9c065f05563a2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1caab9b34e421f03c34b937d31534b7173204f28","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":".. option:: --dns-domain \u003cdns-domain\u003e"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    Set DNS domain to this network (requires DNS integration extension)."},{"line_number":446,"context_line":""},{"line_number":447,"context_line":".. option:: --tag \u003ctag\u003e"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f9dbf25_39ff5f35","line":445,"range":{"start_line":445,"start_character":19,"end_line":445,"end_character":21},"updated":"2018-03-02 15:11:30.000000000","message":"s/of","commit_id":"e196055e65e723aa9c061d67fbf9c065f05563a2"}],"openstackclient/network/v2/dns.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15c401cb6e50673f811d727c8317262cdf1baa4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f4b6375_ef4fd8bb","updated":"2017-11-01 03:43:46.000000000","message":"this is nit picky, but this is kinda bugging me since we normally have command objects under openstackclient/service/api_version\n\ncan you put this in a utils class at openstackclient/network/ ?","commit_id":"9b90953b37de9a56d251991f23cd4efd1ea31574"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15c401cb6e50673f811d727c8317262cdf1baa4d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def add_dns_argument(parser, resource, attribute):"},{"line_number":19,"context_line":"    # Add dns_name and dns_domain support to network, port and floatingip"},{"line_number":20,"context_line":"    # create"},{"line_number":21,"context_line":"    # aliases\u003d[\u0027--dns-%s\u0027 % attribute],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_af49e0b7","line":18,"updated":"2017-11-01 03:43:46.000000000","message":"i already know dtroyer will say to not make this modular :)","commit_id":"9b90953b37de9a56d251991f23cd4efd1ea31574"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15c401cb6e50673f811d727c8317262cdf1baa4d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        default\u003dNone,"},{"line_number":26,"context_line":"        metavar\u003d\u0027\u003cdns-%s\u003e\u0027 % attribute,"},{"line_number":27,"context_line":"        dest\u003d\u0027dns_%s\u0027 % attribute,"},{"line_number":28,"context_line":"        help\u003d("},{"line_number":29,"context_line":"            \u0027Assign DNS %(attribute)s to this %(resource)s \u0027"},{"line_number":30,"context_line":"            \u0027(requires neutron DNS integration \u0027"},{"line_number":31,"context_line":"            \u0027extension)\u0027) % {\u0027attribute\u0027: attribute, \u0027resource\u0027: resource}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_af70c009","line":28,"updated":"2017-11-01 03:43:46.000000000","message":"we need to also update the help at docs/source/command/network.rst, port.rst and floatingip.rst","commit_id":"9b90953b37de9a56d251991f23cd4efd1ea31574"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e2fe1b60ab62a54aeea47a704a2e54367edf5b3","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            # If not, throw the original exception"},{"line_number":318,"context_line":"            common.validate_avail_extensions("},{"line_number":319,"context_line":"                self.app.client_manager.network, attrs)"},{"line_number":320,"context_line":"            raise"},{"line_number":321,"context_line":"        # tags cannot be set when created, so tags need to be set later."},{"line_number":322,"context_line":"        _tag.update_tags_for_set(client, obj, parsed_args)"},{"line_number":323,"context_line":"        display_columns, columns \u003d _get_columns_network(obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_d0026d6f","line":320,"updated":"2017-11-01 12:59:43.000000000","message":"I like this feature and helps users understand what happens, but it is better to be proposed separately as this is not directly related to dns-domain support.\n\nI also have a suggestion on the code. How about using with-clause? This can be a common pattern.\n\n  with check_missing_extension_if_error(self.app.client_manager, attrs):\n    obj \u003d client.create_network(**attrs)\n\nand the implementation would be:\n\n  @contextmanager\n  def check_missing_extension_if_error(client_manager, attrs):\n    try:\n      yield\n    except openstack.exceptions.HttpExceptions:\n      common.validate_avail_extensions(\n          self.app.client_manager.network, attrs)\n      raise\n\nI haven\u0027t test it but it should work theoretically.","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9a40dcf9f73c9cd672d78e2717fdf1ebd6953c65","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            # If not, throw the original exception"},{"line_number":318,"context_line":"            common.validate_avail_extensions("},{"line_number":319,"context_line":"                self.app.client_manager.network, attrs)"},{"line_number":320,"context_line":"            raise"},{"line_number":321,"context_line":"        # tags cannot be set when created, so tags need to be set later."},{"line_number":322,"context_line":"        _tag.update_tags_for_set(client, obj, parsed_args)"},{"line_number":323,"context_line":"        display_columns, columns \u003d _get_columns_network(obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_c2806049","line":320,"in_reply_to":"3f4b6375_0b00da66","updated":"2017-11-01 15:38:27.000000000","message":"Thanks for the background! I am okay now to implement the validation in this change.","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":26880,"name":"Pierre Hanselmann","email":"pierre.hanselmann@gmail.com","username":"Zophar"},"change_message_id":"888cd9a64f87bb0fa9069937814793aa92e41ebe","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            # If not, throw the original exception"},{"line_number":318,"context_line":"            common.validate_avail_extensions("},{"line_number":319,"context_line":"                self.app.client_manager.network, attrs)"},{"line_number":320,"context_line":"            raise"},{"line_number":321,"context_line":"        # tags cannot be set when created, so tags need to be set later."},{"line_number":322,"context_line":"        _tag.update_tags_for_set(client, obj, parsed_args)"},{"line_number":323,"context_line":"        display_columns, columns \u003d _get_columns_network(obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_0b00da66","line":320,"in_reply_to":"3f4b6375_d0026d6f","updated":"2017-11-01 13:35:45.000000000","message":"Thanks for your the feedback i\u0027ll take a look the with clause...\nI\u0027ve merged this validation as i looked into the backlog of dns-domain feature:\nhttps://review.openstack.org/#/c/387617/\nDean and Richard strongly suggested to implement it with this feature.","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        \u0027--dns-domain\u0027,"},{"line_number":174,"context_line":"        metavar\u003d\u0027\u003cdns-domain\u003e\u0027,"},{"line_number":175,"context_line":"        dest\u003d\u0027dns_domain\u0027,"},{"line_number":176,"context_line":"        help\u003d_(\"Set DNS name to this network \""},{"line_number":177,"context_line":"               \"(requires DNS integration extension)\")"},{"line_number":178,"context_line":"    )"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_6022ff03","line":176,"range":{"start_line":176,"start_character":16,"end_line":176,"end_character":31},"updated":"2018-02-18 03:00:12.000000000","message":"s/Set DNS domain for...","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        \u0027--dns-domain\u0027,"},{"line_number":174,"context_line":"        metavar\u003d\u0027\u003cdns-domain\u003e\u0027,"},{"line_number":175,"context_line":"        dest\u003d\u0027dns_domain\u0027,"},{"line_number":176,"context_line":"        help\u003d_(\"Set DNS name to this network \""},{"line_number":177,"context_line":"               \"(requires DNS integration extension)\")"},{"line_number":178,"context_line":"    )"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_30912548","line":176,"range":{"start_line":176,"start_character":16,"end_line":176,"end_character":31},"in_reply_to":"3fa0c359_6022ff03","updated":"2018-02-23 12:18:36.000000000","message":"Done","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                \u0027provider_network_type\u0027,"},{"line_number":459,"context_line":"                \u0027is_router_external\u0027,"},{"line_number":460,"context_line":"                \u0027availability_zones\u0027,"},{"line_number":461,"context_line":"                \u0027tags\u0027,"},{"line_number":462,"context_line":"            )"},{"line_number":463,"context_line":"            column_headers \u003d ("},{"line_number":464,"context_line":"                \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_0048dbc9","line":461,"updated":"2018-02-18 03:00:12.000000000","message":"what about \u0027dns_domain\u0027 here?","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                \u0027provider_network_type\u0027,"},{"line_number":459,"context_line":"                \u0027is_router_external\u0027,"},{"line_number":460,"context_line":"                \u0027availability_zones\u0027,"},{"line_number":461,"context_line":"                \u0027tags\u0027,"},{"line_number":462,"context_line":"            )"},{"line_number":463,"context_line":"            column_headers \u003d ("},{"line_number":464,"context_line":"                \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_d09fa14d","line":461,"in_reply_to":"3fa0c359_0048dbc9","updated":"2018-02-23 12:18:36.000000000","message":"As the extension is not available on every Neutron deployment, I think it is fair to not include it here.","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                \u0027Network Type\u0027,"},{"line_number":472,"context_line":"                \u0027Router Type\u0027,"},{"line_number":473,"context_line":"                \u0027Availability Zones\u0027,"},{"line_number":474,"context_line":"                \u0027Tags\u0027,"},{"line_number":475,"context_line":"            )"},{"line_number":476,"context_line":"        elif parsed_args.agent_id:"},{"line_number":477,"context_line":"            columns \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_204397b1","line":474,"updated":"2018-02-18 03:00:12.000000000","message":"and \u0027DNS Domain\u0027 here?","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                \u0027Network Type\u0027,"},{"line_number":472,"context_line":"                \u0027Router Type\u0027,"},{"line_number":473,"context_line":"                \u0027Availability Zones\u0027,"},{"line_number":474,"context_line":"                \u0027Tags\u0027,"},{"line_number":475,"context_line":"            )"},{"line_number":476,"context_line":"        elif parsed_args.agent_id:"},{"line_number":477,"context_line":"            columns \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_70aa4d71","line":474,"in_reply_to":"3fa0c359_204397b1","updated":"2018-02-23 12:18:36.000000000","message":"dito","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    parser.add_argument("},{"line_number":273,"context_line":"        \u0027--dns-name\u0027,"},{"line_number":274,"context_line":"        metavar\u003d\u0027\u003cdns-name\u003e\u0027,"},{"line_number":275,"context_line":"        help\u003d_(\"Set DNS name to this port \""},{"line_number":276,"context_line":"               \"(requires DNS integration extension)\")"},{"line_number":277,"context_line":"    )"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_0021bbfb","line":275,"range":{"start_line":275,"start_character":29,"end_line":275,"end_character":31},"updated":"2018-02-18 03:00:12.000000000","message":"s/for","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    parser.add_argument("},{"line_number":273,"context_line":"        \u0027--dns-name\u0027,"},{"line_number":274,"context_line":"        metavar\u003d\u0027\u003cdns-name\u003e\u0027,"},{"line_number":275,"context_line":"        help\u003d_(\"Set DNS name to this port \""},{"line_number":276,"context_line":"               \"(requires DNS integration extension)\")"},{"line_number":277,"context_line":"    )"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_10b3c9ea","line":275,"range":{"start_line":275,"start_character":29,"end_line":275,"end_character":31},"in_reply_to":"3fa0c359_0021bbfb","updated":"2018-02-23 12:18:36.000000000","message":"Done","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"}],"openstackclient/tests/unit/network/test_common.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e2fe1b60ab62a54aeea47a704a2e54367edf5b3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import openstack"},{"line_number":18,"context_line":"from osc_lib.exceptions import CommandError"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from openstackclient.network import common"},{"line_number":21,"context_line":"from openstackclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_5071dd0b","line":18,"updated":"2017-11-01 12:59:43.000000000","message":"Avoid attribute-level import per OpenStack coding convention.","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"83bc1df0ee5dc7c5e6b62deedb422d11429e37dd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import openstack"},{"line_number":18,"context_line":"from osc_lib.exceptions import CommandError"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from openstackclient.network import common"},{"line_number":21,"context_line":"from openstackclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_9083d5a9","line":18,"in_reply_to":"3f4b6375_5071dd0b","updated":"2017-11-01 13:04:31.000000000","message":"++","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"},{"author":{"_account_id":26880,"name":"Pierre Hanselmann","email":"pierre.hanselmann@gmail.com","username":"Zophar"},"change_message_id":"888cd9a64f87bb0fa9069937814793aa92e41ebe","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import openstack"},{"line_number":18,"context_line":"from osc_lib.exceptions import CommandError"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from openstackclient.network import common"},{"line_number":21,"context_line":"from openstackclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_0b357a46","line":18,"in_reply_to":"3f4b6375_9083d5a9","updated":"2017-11-01 13:35:45.000000000","message":"Roger!","commit_id":"152af83071fd5cffe14879964b552576c0c98d79"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        network.ipv4_address_scope_id \u003d \\"},{"line_number":380,"context_line":"            network_attrs[\u0027ipv4_address_scope\u0027]"},{"line_number":381,"context_line":"        network.ipv6_address_scope_id \u003d \\"},{"line_number":382,"context_line":"            network_attrs[\u0027ipv6_address_scope\u0027]"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return network"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_c078b3f9","line":382,"updated":"2018-02-18 03:00:12.000000000","message":"Isn\u0027t this required here:\n\nnetwork.dns_domain \u003d network_attrs[\u0027dns_domain\u0027]","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        network.ipv4_address_scope_id \u003d \\"},{"line_number":380,"context_line":"            network_attrs[\u0027ipv4_address_scope\u0027]"},{"line_number":381,"context_line":"        network.ipv6_address_scope_id \u003d \\"},{"line_number":382,"context_line":"            network_attrs[\u0027ipv6_address_scope\u0027]"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return network"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_50e2b1d6","line":382,"in_reply_to":"3fa0c359_c078b3f9","updated":"2018-02-23 12:18:36.000000000","message":"No, this is only necessary when the attribute name differs in the SDK.","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"}],"openstackclient/tests/unit/network/v2/test_network.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":871,"context_line":"               \u0027not_any_tags\u0027: \u0027black,white\u0027}"},{"line_number":872,"context_line":"        )"},{"line_number":873,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":874,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"class TestSetNetwork(TestNetwork):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_8082abc7","line":874,"updated":"2018-02-18 03:00:12.000000000","message":"Should add a test_network_list_dns_domain() test here, see https://review.openstack.org/#/c/545124/1/openstackclient/tests/unit/network/v2/test_network.py","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":871,"context_line":"               \u0027not_any_tags\u0027: \u0027black,white\u0027}"},{"line_number":872,"context_line":"        )"},{"line_number":873,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":874,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"class TestSetNetwork(TestNetwork):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_f032dd5d","line":874,"in_reply_to":"3fa0c359_8082abc7","updated":"2018-02-23 12:18:36.000000000","message":"Done","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c1be938f64999477536ae8927ef59df08fde409","unresolved":false,"context_lines":[{"line_number":871,"context_line":"               \u0027not_any_tags\u0027: \u0027black,white\u0027}"},{"line_number":872,"context_line":"        )"},{"line_number":873,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":874,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"class TestSetNetwork(TestNetwork):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_67612705","line":874,"in_reply_to":"3fa0c359_f032dd5d","updated":"2018-02-24 08:59:36.000000000","message":"Ah, now I see your point, you want to add filtering based on dns-domain to the list command, which isn\u0027t present in this version (yet). It also doesn\u0027t exist in the neutron CLI it seems, so maybe we\u0027d rather just start with providing feature parity and do another follow up on top of that?","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"}],"releasenotes/notes/network_dns_integration-5914b2c2be474a41.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15c401cb6e50673f811d727c8317262cdf1baa4d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add dns-domain support for Network commands."},{"line_number":5,"context_line":"    The new parameter ``--dns-domain`` is added to ``network create``"},{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_4fd02cca","line":4,"range":{"start_line":4,"start_character":31,"end_line":4,"end_character":38},"updated":"2017-11-01 03:43:46.000000000","message":"``network``","commit_id":"9b90953b37de9a56d251991f23cd4efd1ea31574"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15c401cb6e50673f811d727c8317262cdf1baa4d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The new parameter ``--dns-domain`` is added to ``network create``"},{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."},{"line_number":8,"context_line":"    Chech backend available extensionand return an error"},{"line_number":9,"context_line":"    message if it is missing (instead of a Bad Request HTTP 400)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_8fc62416","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":9},"updated":"2017-11-01 03:43:46.000000000","message":"check","commit_id":"9b90953b37de9a56d251991f23cd4efd1ea31574"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15c401cb6e50673f811d727c8317262cdf1baa4d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The new parameter ``--dns-domain`` is added to ``network create``"},{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."},{"line_number":8,"context_line":"    Chech backend available extensionand return an error"},{"line_number":9,"context_line":"    message if it is missing (instead of a Bad Request HTTP 400)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_6fc9a823","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":40},"updated":"2017-11-01 03:43:46.000000000","message":"extension* and","commit_id":"9b90953b37de9a56d251991f23cd4efd1ea31574"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add dns-domain support for network commands."},{"line_number":5,"context_line":"    The new parameter ``--dns-domain`` is added to ``network create``"},{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."},{"line_number":8,"context_line":"    Check backend available extension and return an error"},{"line_number":9,"context_line":"    message if it is missing (instead of a Bad Request HTTP 400)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa0c359_a08567d1","line":6,"updated":"2018-02-18 03:00:12.000000000","message":"and \u0027network list\u0027 as well, and I guess because of how it was added \u0027network delete\u0027 although that isn\u0027t as useful.\n\n--dns-name was also added to the port commands.","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add dns-domain support for network commands."},{"line_number":5,"context_line":"    The new parameter ``--dns-domain`` is added to ``network create``"},{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."},{"line_number":8,"context_line":"    Check backend available extension and return an error"},{"line_number":9,"context_line":"    message if it is missing (instead of a Bad Request HTTP 400)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa0c359_b029b5e6","line":6,"in_reply_to":"3fa0c359_a08567d1","updated":"2018-02-23 12:18:36.000000000","message":"Done","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8643201b3b169b64cd724309b148560b1d5491fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."},{"line_number":8,"context_line":"    Check backend available extension and return an error"},{"line_number":9,"context_line":"    message if it is missing (instead of a Bad Request HTTP 400)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa0c359_406ca335","line":9,"updated":"2018-02-18 03:00:12.000000000","message":"nit: missing trailing period.","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a28cf5c07993a0144b5e5aaf041551c5207a7f4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    and ``network set`` commands. This parameter is the domain"},{"line_number":7,"context_line":"    name for the network."},{"line_number":8,"context_line":"    Check backend available extension and return an error"},{"line_number":9,"context_line":"    message if it is missing (instead of a Bad Request HTTP 400)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa0c359_701fadb6","line":9,"in_reply_to":"3fa0c359_406ca335","updated":"2018-02-23 12:18:36.000000000","message":"Done","commit_id":"7a46398c633d8eee40bd90070864c714d55a9fa2"}]}