)]}'
{"doc/source/cli/command-objects/security-group-rule.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ed29fa5dff43b88ab0fc79265e8591ce7f58bb4","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":".. option:: --protocol \u003cprotocol\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    IP protocol (icmp, tcp, udp or any; default: any (all protocols))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    *Compute version 2*"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfbec78f_53526215","line":57,"updated":"2019-05-06 14:55:31.000000000","message":"I\u0027ll undo this too then, and the other related compute changes.","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"}],"openstackclient/network/v2/security_group_rule.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"46c666b6486ba9567b9bfdd9e9c24de03c8717f4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":215,"context_line":"            type\u003d_convert_to_lowercase,"},{"line_number":216,"context_line":"            help\u003d_(\"IP protocol (icmp, tcp, udp or any; default: any \""},{"line_number":217,"context_line":"                   \"(all protocols))\")"},{"line_number":218,"context_line":"        )"},{"line_number":219,"context_line":"        protocol_group.add_argument("},{"line_number":220,"context_line":"            \u0027--proto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_ec186d76","line":217,"updated":"2019-05-03 20:50:30.000000000","message":"Nova security group rule API does not support \u0027any\u0027.  IIRC, that\u0027s the reason we use \u0027tcp\u0027 as default [1]. How can nova-network handle a protocol \u0027any\u0027?\n\n[1] https://developer.openstack.org/api-ref/compute/?expanded\u003dcreate-security-group-rule-detail#create-security-group-rule","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ed29fa5dff43b88ab0fc79265e8591ce7f58bb4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":215,"context_line":"            type\u003d_convert_to_lowercase,"},{"line_number":216,"context_line":"            help\u003d_(\"IP protocol (icmp, tcp, udp or any; default: any \""},{"line_number":217,"context_line":"                   \"(all protocols))\")"},{"line_number":218,"context_line":"        )"},{"line_number":219,"context_line":"        protocol_group.add_argument("},{"line_number":220,"context_line":"            \u0027--proto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_b312be57","line":217,"in_reply_to":"dfbec78f_000265b5","updated":"2019-05-06 14:55:31.000000000","message":"That\u0027s fine with me, it\u0027s been so long since I started this I didn\u0027t even realize this part was for nova-network.","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7b0e2572a572fb02c746ddf3ec11cc192bb4a215","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":215,"context_line":"            type\u003d_convert_to_lowercase,"},{"line_number":216,"context_line":"            help\u003d_(\"IP protocol (icmp, tcp, udp or any; default: any \""},{"line_number":217,"context_line":"                   \"(all protocols))\")"},{"line_number":218,"context_line":"        )"},{"line_number":219,"context_line":"        protocol_group.add_argument("},{"line_number":220,"context_line":"            \u0027--proto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_000265b5","line":217,"in_reply_to":"dfbec78f_60c24188","updated":"2019-05-03 21:47:01.000000000","message":"It looks better we keep the current default value for nova-network case in update_parser_compute. Thought?","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eb4484148eb4a29f68ea3353aa67561cf014e460","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":215,"context_line":"            type\u003d_convert_to_lowercase,"},{"line_number":216,"context_line":"            help\u003d_(\"IP protocol (icmp, tcp, udp or any; default: any \""},{"line_number":217,"context_line":"                   \"(all protocols))\")"},{"line_number":218,"context_line":"        )"},{"line_number":219,"context_line":"        protocol_group.add_argument("},{"line_number":220,"context_line":"            \u0027--proto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_ececedf4","line":217,"in_reply_to":"dfbec78f_ec186d76","updated":"2019-05-03 21:07:47.000000000","message":"Akihiro, the neutron v2 API does support \u0027any\u0027, and it used to be the default, as there was another subproject (lbaas I believe) that got partially broken with the default changing to TCP.  And should we be worrying about the deprecated nova-network?\n\n$ openstack security group rule create --ingress --protocol any default\n+-------------------+----------------------------------------------------------+\n| Field             | Value                                                    |\n+-------------------+----------------------------------------------------------+\n| created_at        | 2019-05-03T21:02:20Z                                     |\n| description       |                                                          |\n| direction         | ingress                                                  |\n| ether_type        | IPv4                                                     |\n| id                | 008b0534-4942-4ba1-a93a-2d97232c970f                     |\n| location          | Munch({\u0027project\u0027: Munch({\u0027domain_id\u0027: \u0027default\u0027, \u0027id\u0027:   |\n|                   | u\u0027f9ddc09a037e4f438a714a6b876690b3\u0027, \u0027name\u0027: \u0027demo\u0027,     |\n|                   | \u0027domain_name\u0027: None}), \u0027cloud\u0027: \u0027\u0027, \u0027region_name\u0027:       |\n|                   | \u0027RegionOne\u0027, \u0027zone\u0027: None})                              |\n| name              | None                                                     |\n| port_range_max    | None                                                     |\n| port_range_min    | None                                                     |\n| project_id        | f9ddc09a037e4f438a714a6b876690b3                         |\n| protocol          | None                                                     |\n| remote_group_id   | None                                                     |\n| remote_ip_prefix  | 0.0.0.0/0                                                |\n| revision_number   | 0                                                        |\n| security_group_id | 4865e065-49ed-44b0-bd91-02d20ae4e1db                     |\n| tags              | []                                                       |\n| updated_at        | 2019-05-03T21:02:20Z                                     |\n+-------------------+----------------------------------------------------------+\n\nThis will create a SG rule for all IP protocols.","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f2c67df566d865f3522f97aeae0baba82a4d4d0","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":215,"context_line":"            type\u003d_convert_to_lowercase,"},{"line_number":216,"context_line":"            help\u003d_(\"IP protocol (icmp, tcp, udp or any; default: any \""},{"line_number":217,"context_line":"                   \"(all protocols))\")"},{"line_number":218,"context_line":"        )"},{"line_number":219,"context_line":"        protocol_group.add_argument("},{"line_number":220,"context_line":"            \u0027--proto\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_60c24188","line":217,"in_reply_to":"dfbec78f_ececedf4","updated":"2019-05-03 21:44:14.000000000","message":"Yeah, OSC (and OpenStackSDK) tries to support older deployments including nova-network. That\u0027s the background of my last comment.\n\nThis line belongs to *update_parser_compute* (which corresponding to nova-network feature). If we don\u0027t support nova-network, it means update_parser_compute is completely meaningless, but it does not happen yet.","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"}],"releasenotes/notes/bug-1716789-abfae897b7e61246.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ad0b4b328e7ad43a55326aa29861c59f4e519752","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    The default protocol used to create a security rule was changed to"},{"line_number":10,"context_line":"    ``tcp``, which was a regression from the neutron client.  Change it"},{"line_number":11,"context_line":"    back to ``any``, which skips sending the protocol to the API"},{"line_number":12,"context_line":"    server entirely."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Users that had been creating rules without specifying a protocol"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff82abbf_96730eb2","line":12,"updated":"2017-11-30 20:25:13.000000000","message":"So after talking to a colleague about this, it got me thinking - this change is actually *restoring* backwards compatibility to those that were using a version of the client before the change to use \u0027tcp\u0027 as the default was introduced, which actually introduced the non-backwards-compatible code.\n\nIf I add that info here would it be more amenable?","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9a6bc3dad34301addbbf530585b38e8a38801020","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    The default protocol used to create a security rule was changed to"},{"line_number":10,"context_line":"    ``tcp``, which was a regression from the neutron client.  Change it"},{"line_number":11,"context_line":"    back to ``any``, which skips sending the protocol to the API"},{"line_number":12,"context_line":"    server entirely."},{"line_number":13,"context_line":"upgrade:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Users that had been creating rules without specifying a protocol"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_59085e27","line":12,"in_reply_to":"ff82abbf_96730eb2","updated":"2017-12-01 22:22:42.000000000","message":"That\u0027s a valid argument.  When was the change introduced?  If recent, I\u0027ll buy this as a fix.\n\n/me picks 3.0 as the cutoff semi-arbitrarily (also open to input on the time frame here)","commit_id":"e4e01bb61394f40486ace00adf19caab422b88f7"}]}