)]}'
{"id":"openstack%2Fpython-openstackclient~518954","triplet_id":"openstack%2Fpython-openstackclient~master~Iedaa027240e00dced551513d8fa828564386b79f","project":"openstack/python-openstackclient","branch":"master","topic":"osc4","hashtags":[],"change_id":"Iedaa027240e00dced551513d8fa828564386b79f","subject":"Change default security group protocol to \u0027any\u0027","status":"MERGED","created":"2017-11-10 16:00:28.000000000","updated":"2019-06-22 21:39:31.000000000","submitted":"2019-06-22 21:39:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"518954-1561239571809-55b2706f","meta_rev_id":"27490a40e93568f2f84e552378e24e979b88a0d4","_number":518954,"virtual_id_number":518954,"owner":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":2,"date":"2019-06-22 21:39:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"recommended":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"all":[{"value":1,"date":"2019-05-14 11:00:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-08 08:50:13.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2019-06-22 18:56:18.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":1,"date":"2019-05-14 15:06:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2019-06-22 18:56:18.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-11 03:35:30.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2019-05-08 08:50:13.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2019-05-14 11:00:14.000000000","updated_by":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"reviewer":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"state":"REVIEWER"},{"updated":"2019-05-14 15:06:46.000000000","updated_by":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"reviewer":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"state":"REVIEWER"},{"updated":"2019-06-22 18:56:18.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-06-22 21:39:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7c317ed589d655aa92bff6c6bdf9df84e32b6979","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-11-10 16:00:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c9bce820f3151f9b5a9cbcf1ffb0c88dba1ca65","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-10 18:05:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/54/518954/1/check/openstack-tox-pep8/8e19192/ : SUCCESS in 9m 05s\n- openstack-tox-py27 http://logs.openstack.org/54/518954/1/check/openstack-tox-py27/8022e8f/ : SUCCESS in 8m 35s\n- openstack-tox-py35 http://logs.openstack.org/54/518954/1/check/openstack-tox-py35/21dab24/ : SUCCESS in 6m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/54/518954/1/check/build-openstack-sphinx-docs/374f695/html/ : SUCCESS in 6m 19s\n- build-openstack-releasenotes http://logs.openstack.org/54/518954/1/check/build-openstack-releasenotes/cea2b37/html/ : SUCCESS in 5m 58s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/54/518954/1/check/legacy-tempest-dsvm-neutron-src/3cfd02a/ : SUCCESS in 1h 14m 37s\n- legacy-tripleo-ci-centos-7-nonha-multinode-oooq http://logs.openstack.org/54/518954/1/check/legacy-tripleo-ci-centos-7-nonha-multinode-oooq/951603a/ : SUCCESS in 2h 01m 46s (non-voting)\n- openstackclient-check-plugins http://logs.openstack.org/54/518954/1/check/openstackclient-check-plugins/ecf2640/ : SUCCESS in 5m 55s (non-voting)\n- osc-tox-unit-tips http://logs.openstack.org/54/518954/1/check/osc-tox-unit-tips/ecfef41/ : SUCCESS in 9m 21s\n- osc-functional-devstack http://logs.openstack.org/54/518954/1/check/osc-functional-devstack/8b9dc58/ : SUCCESS in 35m 47s\n- osc-functional-devstack-tips http://logs.openstack.org/54/518954/1/check/osc-functional-devstack-tips/9d7810e/ : SUCCESS in 41m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7648b3afaa97e68fad31de8ceca9fa5fc06d2a27","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-11-11 03:35:30.000000000","message":"Patch Set 1: Code-Review+2\n\nthis seems like a big usability improvement. so +1","accounts_in_message":[],"_revision_number":1},{"id":"b9f3fd7eca422e10a5731b7418d1866725bc0cb7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-11-15 22:14:48.000000000","message":"Patch Set 1:\n\nThis may indeed be a usability improvement but it is not backward-compatible, as I would argue that without changing my scripts I will get a different firewall configuration than before, and not one that I would consider to be \u0027safer\u0027, it is more open.\n\nWe can consider this for osc4","accounts_in_message":[],"_revision_number":1},{"id":"e655a8167d2aafa0e8f149b8042062490afca6bc","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-11-17 04:30:59.000000000","message":"Patch Set 1:\n\nThe code as it is makes osc different from the neutron client, which is a regression in my opinion.  The change to make \u0027tcp\u0027 the default security group protocol shouldn\u0027t have been done, and I don\u0027t believe anyone from the neutron team was involved in that decision or review.  We only get the bugs when end-users notice it.  This change happened in https://review.openstack.org/#/c/307908/ and wasn\u0027t even in the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"170a63b7b552791c71773cd34889c3e5c5ec39c2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-11-17 20:23:53.000000000","message":"Patch Set 1: Code-Review-1\n\nI will not disagree that this is a sub-optimal situation, but I will strenuously stop any attempt to change this in a non-opt-in manner for existing users.  The fact is that this change results in a more open firewall configuration than yesterday and that is simply not acceptable.  We can fix it in OSC 4, that will be opt-in for users as a number of things will be breaking.  See the feature/osc4 branch.","accounts_in_message":[],"_revision_number":1},{"id":"f4603e8cb8bae70395b7b40e381d852641f848be","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-11-17 21:52:47.000000000","message":"Patch Set 1:\n\nI understand wanting to be backwards compatible, and the change is pretty close, I\u0027ll explain.\n\nFor example, if you assumed TCP but didn\u0027t specify, it will not work in most cases:\n\n$ openstack security group rule create --ingress --dst-port 99 default\nError while executing command: Bad Request (HTTP 400) (Request-ID: req-67d05bfd-58b3-4812-a962-260a992bb35b)\n\nThat\u0027s because if you specify a port range you must specify a protocol.  Running with --debug shows:\n\nRESP BODY: {\"NeutronError\": {\"message\": \"Must also specify protocol if port range is given.\", \"type\": \"SecurityGroupProtocolRequiredWithPorts\", \"detail\": \"\"}}\n\nSo it\u0027s a regression in that users that hadn\u0027t been specifying a protocol will now get an error, which should help them fix their scripts.\n\nThe only case that\u0027s an issue is if you didn\u0027t specify any arguments at all:\n\n$ openstack security group rule create --ingress default\n\nThat will currently let in all TCP.  With this change any protocol.  I\u0027m not sure that\u0027s a typical situation, but I guess the one regression I could find.","accounts_in_message":[],"_revision_number":1},{"id":"ad0b4b328e7ad43a55326aa29861c59f4e519752","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-11-30 20:25:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9a6bc3dad34301addbbf530585b38e8a38801020","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-12-01 22:22:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bcf8fb3c71707ea37146831cbd326a533f8604bc","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-12-01 22:26:42.000000000","message":"Patch Set 1:\n\nIt was merged in https://review.openstack.org/#/c/307908/ - May 2016, I don\u0027t know what version that was.","accounts_in_message":[],"_revision_number":1},{"id":"9959964d228370e3c626a4a12f820cbc16d116fc","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-12-02 00:15:27.000000000","message":"Patch Set 1:\n\nThat was released in 2.4.0, over a year and a half ago.  My gut says we\u0027re committed, I suppose I\u0027d like to hear more opinions.  It\u0027s the fact that this is a potential security complaint that makes it important to me to get it right.  Maybe I\u0027m worried about a really minor thing; having some community buy-in would ease my mind.  Unless someone beats me to it I\u0027ll kick off a thread on the ops list to see how our users feel about it.","accounts_in_message":[],"_revision_number":1},{"id":"ebfe0ce2d020d3450e071011aeb4878222dad872","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2018-09-27 21:50:37.000000000","message":"Patch Set 1:\n\nAre we almost at OSC 4 time where this can merge?","accounts_in_message":[],"_revision_number":1},{"id":"c1ebac2a31b2ec2f3ed31e338c89d03c2b55bf37","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-01 21:21:14.000000000","message":"Topic changed from bug/1716789 to osc4","accounts_in_message":[],"_revision_number":1},{"id":"46c666b6486ba9567b9bfdd9e9c24de03c8717f4","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2019-05-03 20:50:30.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"eb4484148eb4a29f68ea3353aa67561cf014e460","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-03 21:07:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2f2c67df566d865f3522f97aeae0baba82a4d4d0","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2019-05-03 21:44:14.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7b0e2572a572fb02c746ddf3ec11cc192bb4a215","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2019-05-03 21:47:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1ed29fa5dff43b88ab0fc79265e8591ce7f58bb4","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-06 14:55:31.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"04f7ffa24b0759eed169117be5523ae329ae4101","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-05-06 14:55:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"26d37941a1ca58bd4a9a9f1cfb9ef68adcd35b0d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-06 16:57:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/54/518954/2/check/openstackclient-check-plugins/8ce650b/ : SUCCESS in 5m 01s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/54/518954/2/check/osc-tox-py27-tips/0d1bd67/ : SUCCESS in 5m 27s\n- osc-tox-py36-tips http://logs.openstack.org/54/518954/2/check/osc-tox-py36-tips/8feb0a0/ : SUCCESS in 6m 30s\n- openstack-tox-cover http://logs.openstack.org/54/518954/2/check/openstack-tox-cover/a894119/cover/ : SUCCESS in 5m 22s\n- openstack-tox-lower-constraints http://logs.openstack.org/54/518954/2/check/openstack-tox-lower-constraints/9bbb61d/ : SUCCESS in 5m 07s\n- openstack-tox-pep8 http://logs.openstack.org/54/518954/2/check/openstack-tox-pep8/309f707/ : SUCCESS in 4m 46s\n- openstack-tox-py27 http://logs.openstack.org/54/518954/2/check/openstack-tox-py27/42a3d9e/ : SUCCESS in 4m 48s\n- openstack-tox-py36 http://logs.openstack.org/54/518954/2/check/openstack-tox-py36/6284270/ : SUCCESS in 4m 19s\n- openstack-tox-py37 http://logs.openstack.org/54/518954/2/check/openstack-tox-py37/f00f4b5/ : SUCCESS in 4m 37s\n- openstack-tox-docs http://logs.openstack.org/54/518954/2/check/openstack-tox-docs/a4136f6/html/ : SUCCESS in 4m 53s\n- build-openstack-releasenotes http://logs.openstack.org/54/518954/2/check/build-openstack-releasenotes/47f08cc/html/ : SUCCESS in 4m 35s\n- tempest-full http://logs.openstack.org/54/518954/2/check/tempest-full/83eb4e3/ : SUCCESS in 2h 00m 59s\n- tempest-full-py3 http://logs.openstack.org/54/518954/2/check/tempest-full-py3/6227d33/ : SUCCESS in 1h 31m 56s\n- osc-functional-devstack http://logs.openstack.org/54/518954/2/check/osc-functional-devstack/9304326/ : SUCCESS in 54m 03s\n- osc-functional-devstack-tips http://logs.openstack.org/54/518954/2/check/osc-functional-devstack-tips/637b99c/ : SUCCESS in 52m 22s","accounts_in_message":[],"_revision_number":2},{"id":"e058893e06217715cf30d66af3d943b42c3ff885","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2019-05-08 08:50:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"72e47f6725d4a5ff476544af597524328250c536","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-05-08 22:43:59.000000000","message":"Patch Set 2:\n\nNot quite yet, we need one more 3.x release before the OSC4 bits can go in...","accounts_in_message":[],"_revision_number":2},{"id":"18d98301d666466cab4a7a092fb3f77778e6d9af","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2019-05-14 11:00:14.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"41dfb9e02993841fcab9c98e38a00331eeca3fc0","author":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"date":"2019-05-14 15:06:46.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b7684d5c6a9cfa1d71b285cf9dff474a7b780019","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-06-22 18:56:18.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"babd803b0c7f07970cde966ff1c020f0bd226bf0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-22 18:56:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"025bca84ea817019696c87486fb995406ad24794","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-22 21:39:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- osc-tox-py27-tips http://logs.openstack.org/54/518954/2/gate/osc-tox-py27-tips/8b72d9b/ : SUCCESS in 5m 39s\n- osc-tox-py36-tips http://logs.openstack.org/54/518954/2/gate/osc-tox-py36-tips/2d88153/ : SUCCESS in 7m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/54/518954/2/gate/openstack-tox-lower-constraints/e999057/ : SUCCESS in 6m 34s\n- openstack-tox-pep8 http://logs.openstack.org/54/518954/2/gate/openstack-tox-pep8/1bc2417/ : SUCCESS in 5m 06s\n- openstack-tox-py27 http://logs.openstack.org/54/518954/2/gate/openstack-tox-py27/772f2e6/ : SUCCESS in 6m 04s\n- openstack-tox-py36 http://logs.openstack.org/54/518954/2/gate/openstack-tox-py36/aeb02ff/ : SUCCESS in 4m 53s\n- openstack-tox-py37 http://logs.openstack.org/54/518954/2/gate/openstack-tox-py37/947fd3b/ : SUCCESS in 6m 22s\n- openstack-tox-docs http://logs.openstack.org/54/518954/2/gate/openstack-tox-docs/30204d2/html/ : SUCCESS in 5m 47s\n- build-openstack-releasenotes http://logs.openstack.org/54/518954/2/gate/build-openstack-releasenotes/3f15528/html/ : SUCCESS in 4m 59s\n- tempest-full http://logs.openstack.org/54/518954/2/gate/tempest-full/f27f971/ : SUCCESS in 1h 54m 05s\n- tempest-full-py3 http://logs.openstack.org/54/518954/2/gate/tempest-full-py3/c8a4503/ : SUCCESS in 1h 42m 27s\n- osc-functional-devstack http://logs.openstack.org/54/518954/2/gate/osc-functional-devstack/ede8b79/ : SUCCESS in 1h 01m 54s","accounts_in_message":[],"_revision_number":2},{"id":"27490a40e93568f2f84e552378e24e979b88a0d4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-22 21:39:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"33a255612c661f174d2cb5d4ca93f8d7096e9290","revisions":{"e4e01bb61394f40486ace00adf19caab422b88f7":{"kind":"REWORK","_number":1,"created":"2017-11-10 16:00:28.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/54/518954/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/54/518954/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/1"}}},"commit":{"parents":[{"commit":"b230ba73cdfd91e07fe168ee46a928f5556fad55","subject":"Merge \"Be robust on import plugin module\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b230ba73cdfd91e07fe168ee46a928f5556fad55"}]}],"author":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2017-11-10 15:58:58.000000000","tz":-300},"committer":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2017-11-10 15:58:58.000000000","tz":-300},"subject":"Change default security group protocol to \u0027any\u0027","message":"Change default security group protocol to \u0027any\u0027\n\nThe default protocol used to create a security rule was changed to\n``tcp``, which was a regression from the neutron client.  Change it\nback to ``any``, which skips sending the protocol to the API\nserver entirely.\n\nUsers that had been creating rules without specifying a protocol\nand expecting ``tcp`` need to change to use ``--protocol tcp``\nexplicitly.\n\nChange-Id: Iedaa027240e00dced551513d8fa828564386b79f\nCloses-bug: #1716789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e4e01bb61394f40486ace00adf19caab422b88f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e4e01bb61394f40486ace00adf19caab422b88f7"}]},"branch":"refs/heads/master"},"33a255612c661f174d2cb5d4ca93f8d7096e9290":{"kind":"REWORK","_number":2,"created":"2019-05-06 14:55:38.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/54/518954/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/54/518954/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/54/518954/2"}}},"commit":{"parents":[{"commit":"a71cb02ce94c83a692faec5ec46ded0793b0bd5e","subject":"Merge \"Dropping the py35 testing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a71cb02ce94c83a692faec5ec46ded0793b0bd5e"}]}],"author":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2017-11-10 15:58:58.000000000","tz":-300},"committer":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2019-05-06 14:55:13.000000000","tz":-240},"subject":"Change default security group protocol to \u0027any\u0027","message":"Change default security group protocol to \u0027any\u0027\n\nThe default protocol used to create a security rule was changed to\n``tcp``, which was a regression from the neutron client.  Change it\nback to ``any``, which skips sending the protocol to the API\nserver entirely when using the Neutron v2 API.\n\nUsers that had been creating rules without specifying a protocol\nand expecting ``tcp`` need to change to use ``--protocol tcp``\nexplicitly.\n\nChange-Id: Iedaa027240e00dced551513d8fa828564386b79f\nCloses-bug: #1716789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/33a255612c661f174d2cb5d4ca93f8d7096e9290"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/33a255612c661f174d2cb5d4ca93f8d7096e9290"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}