)]}'
{"id":"openstack%2Fpython-openstackclient~527984","triplet_id":"openstack%2Fpython-openstackclient~master~I90010bb231affad28896713a5d6f936902c853d7","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"I90010bb231affad28896713a5d6f936902c853d7","subject":"Remove insane options from network agent add/remove actions","status":"ABANDONED","created":"2017-12-14 14:58:56.000000000","updated":"2022-03-09 17:46:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"55bbcac0c52aa5ac5fd76ac6a65f8df9e08996a9","_number":527984,"virtual_id_number":527984,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"date":"2018-02-07 21:58:18.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2018-02-05 11:23:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-14 15:51:21.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-02-05 11:23:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-02-07 21:58:18.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"955a5978df278284d2f48d1fc7f1b53eccb8e788","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2017-12-14 14:58:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"822bcf17d2e710715fe375d7aece2f388b67d3e6","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2017-12-14 15:18:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"14efc678ba4c1e08585a825b85720ae13aa6c037","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-12-14 15:51:21.000000000","message":"Patch Set 2: Code-Review+1\n\ni remember discussing this with the original author... seems like a case where they had more options planned but never followed through.\n\nneeds a release note for sure","accounts_in_message":[],"_revision_number":2},{"id":"6bcd69226a5762a489c56b55355a6204ed4b619e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-14 17:01:58.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/84/527984/2/check/openstack-tox-pep8/ee721c1/ : SUCCESS in 4m 49s\n- openstack-tox-py27 http://logs.openstack.org/84/527984/2/check/openstack-tox-py27/580200e/ : SUCCESS in 5m 43s\n- openstack-tox-py35 http://logs.openstack.org/84/527984/2/check/openstack-tox-py35/fc0e0dd/ : SUCCESS in 4m 37s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/527984/2/check/build-openstack-sphinx-docs/f825195/html/ : SUCCESS in 5m 29s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/84/527984/2/check/legacy-tempest-dsvm-neutron-src/31108a0/ : SUCCESS in 1h 35m 09s\n- openstackclient-check-plugins http://logs.openstack.org/84/527984/2/check/openstackclient-check-plugins/861b685/ : FAILURE in 3m 35s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/84/527984/2/check/osc-tox-py27-tips/8b5c609/ : SUCCESS in 6m 25s\n- osc-tox-py35-tips http://logs.openstack.org/84/527984/2/check/osc-tox-py35-tips/5ccb707/ : SUCCESS in 4m 46s\n- osc-functional-devstack http://logs.openstack.org/84/527984/2/check/osc-functional-devstack/28d3b59/ : FAILURE in 24m 58s\n- osc-functional-devstack-tips http://logs.openstack.org/84/527984/2/check/osc-functional-devstack-tips/9566cd8/ : FAILURE in 32m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"99f27124e45b7ff84134c3c1e2c971a1e7bb08ec","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2018-02-05 10:00:47.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"87597c30cdd1100c1719b62396401ae1618df9bb","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2018-02-05 10:01:14.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"58dc1df802f21a2aa38cb81a7496495db6aecabf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-05 11:23:40.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/84/527984/4/check/openstack-tox-pep8/bd6080a/ : SUCCESS in 5m 23s\n- openstack-tox-py27 http://logs.openstack.org/84/527984/4/check/openstack-tox-py27/99c3a52/ : SUCCESS in 4m 28s\n- openstack-tox-py35 http://logs.openstack.org/84/527984/4/check/openstack-tox-py35/2f4fcfc/ : SUCCESS in 3m 53s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/527984/4/check/build-openstack-sphinx-docs/b5081a9/html/ : SUCCESS in 5m 21s\n- build-openstack-releasenotes http://logs.openstack.org/84/527984/4/check/build-openstack-releasenotes/8375b35/html/ : SUCCESS in 4m 01s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/84/527984/4/check/legacy-tempest-dsvm-neutron-src/6d6f365/ : SUCCESS in 1h 15m 37s\n- openstackclient-check-plugins http://logs.openstack.org/84/527984/4/check/openstackclient-check-plugins/2f91143/ : SUCCESS in 9m 06s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/84/527984/4/check/osc-tox-py27-tips/c668cba/ : SUCCESS in 5m 52s\n- osc-tox-py35-tips http://logs.openstack.org/84/527984/4/check/osc-tox-py35-tips/6a16612/ : SUCCESS in 5m 38s\n- osc-functional-devstack http://logs.openstack.org/84/527984/4/check/osc-functional-devstack/a6e5f70/ : FAILURE in 37m 18s\n- osc-functional-devstack-tips http://logs.openstack.org/84/527984/4/check/osc-functional-devstack-tips/a1140c3/ : FAILURE in 41m 18s","accounts_in_message":[],"_revision_number":4},{"id":"c958eaf98da5356e271ae5a99ebd8b0077096f7a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-02-07 21:58:18.000000000","message":"Patch Set 4:\n\nI specifically asked that these options be maintained as they indicate what type of \"network agent\" is being used.  There was no assurance that there will not be other network agent types that would add networks or routers.  Can you offer such assurances?","accounts_in_message":[],"_revision_number":4},{"id":"55bbcac0c52aa5ac5fd76ac6a65f8df9e08996a9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-03-09 17:46:34.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2c9a247392f2eea304f80f695d484e9644d98010","revisions":{"58b9bdb927df9cb8a87a83020f4894129fa38991":{"kind":"REWORK","_number":1,"created":"2017-12-14 14:58:56.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/84/527984/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/527984/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/1"}}},"commit":{"parents":[{"commit":"8c5f7555698491c3a0b44fe6c3fee50d0189f2d6","subject":"Merge \"Send \u0027changes-since\u0027 instead of \u0027changes_since\u0027 query parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8c5f7555698491c3a0b44fe6c3fee50d0189f2d6"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2017-12-14 14:46:22.000000000","tz":60},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2017-12-14 14:46:24.000000000","tz":60},"subject":"Remove insane options for network agent add/remove actions","message":"Remove insane options for network agent add/remove actions\n\nCurrently \"network agent add/remove network/router\" commands have no\neffect except if you use them without the --dhcp/--l3 options!\n\nSuch behavior seems incorrect, that\u0027s why this change removes these\ninsane options.\n\nChange-Id: I90010bb231affad28896713a5d6f936902c853d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/58b9bdb927df9cb8a87a83020f4894129fa38991"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/58b9bdb927df9cb8a87a83020f4894129fa38991"}]},"branch":"refs/heads/master"},"428dcb3ea325045f46da2c6c828e8338aff34474":{"kind":"REWORK","_number":2,"created":"2017-12-14 15:18:28.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/84/527984/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/527984/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/2"}}},"commit":{"parents":[{"commit":"8c5f7555698491c3a0b44fe6c3fee50d0189f2d6","subject":"Merge \"Send \u0027changes-since\u0027 instead of \u0027changes_since\u0027 query parameter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8c5f7555698491c3a0b44fe6c3fee50d0189f2d6"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2017-12-14 14:46:22.000000000","tz":60},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2017-12-14 15:18:00.000000000","tz":60},"subject":"Remove insane options for network agent add/remove actions","message":"Remove insane options for network agent add/remove actions\n\nCurrently \"network agent add/remove network/router\" commands have no\neffect except if you use them without the --dhcp/--l3 options!\n\nSuch behavior seems incorrect, that\u0027s why this change removes these\ninsane options.\n\nChange-Id: I90010bb231affad28896713a5d6f936902c853d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/428dcb3ea325045f46da2c6c828e8338aff34474"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/428dcb3ea325045f46da2c6c828e8338aff34474"}]},"branch":"refs/heads/master"},"d916e0b4474bf9edaba453c1f3eecb7138e23337":{"kind":"REWORK","_number":3,"created":"2018-02-05 10:00:47.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/84/527984/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/527984/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/3"}}},"commit":{"parents":[{"commit":"25e60a4bf1184f2d9006d50d52ced1b5c83737af","subject":"Merge \"Make functional-tips job voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/25e60a4bf1184f2d9006d50d52ced1b5c83737af"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2017-12-14 14:46:22.000000000","tz":60},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2018-02-05 10:00:17.000000000","tz":60},"subject":"Remove insane options for network agent add/remove actions","message":"Remove insane options for network agent add/remove actions\n\nCurrently \"network agent add/remove network/router\" commands have no\neffect except if you use them without the --dhcp/--l3 options!\n\nSuch behavior seems incorrect, that\u0027s why this change removes these\ninsane options.\n\nChange-Id: I90010bb231affad28896713a5d6f936902c853d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d916e0b4474bf9edaba453c1f3eecb7138e23337"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d916e0b4474bf9edaba453c1f3eecb7138e23337"}]},"branch":"refs/heads/master"},"2c9a247392f2eea304f80f695d484e9644d98010":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2018-02-05 10:01:14.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/84/527984/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/527984/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/527984/4"}}},"commit":{"parents":[{"commit":"25e60a4bf1184f2d9006d50d52ced1b5c83737af","subject":"Merge \"Make functional-tips job voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/25e60a4bf1184f2d9006d50d52ced1b5c83737af"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2017-12-14 14:46:22.000000000","tz":60},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2018-02-05 10:00:53.000000000","tz":60},"subject":"Remove insane options from network agent add/remove actions","message":"Remove insane options from network agent add/remove actions\n\nCurrently \"network agent add/remove network/router\" commands have no\neffect except if you use them without the --dhcp/--l3 options!\n\nSuch behavior seems incorrect, that\u0027s why this change removes these\ninsane options.\n\nChange-Id: I90010bb231affad28896713a5d6f936902c853d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2c9a247392f2eea304f80f695d484e9644d98010"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2c9a247392f2eea304f80f695d484e9644d98010"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}