)]}'
{"id":"openstack%2Fpython-openstackclient~535364","triplet_id":"openstack%2Fpython-openstackclient~master~I498a064108124673fb738384240a5c76f8c53b67","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1744089","hashtags":[],"change_id":"I498a064108124673fb738384240a5c76f8c53b67","subject":"floatingip related should be removed from compute client","status":"ABANDONED","created":"2018-01-18 15:27:23.000000000","updated":"2018-01-29 02:41:12.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"40f4801e8601583599b0f5358062bbbccdc351e2","_number":535364,"virtual_id_number":535364,"owner":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-01-18 17:23:19.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"date":"2018-01-29 02:40:47.000000000","_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"value":1,"date":"2018-01-18 17:28:26.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},{"value":-1,"date":"2018-01-24 08:48:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2018-01-23 16:58:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2018-01-23 17:51:50.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-18 17:23:19.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-01-18 17:28:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-23 16:58:47.000000000","updated_by":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"reviewer":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"state":"REVIEWER"},{"updated":"2018-01-23 17:51:50.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-01-24 08:48:08.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"}],"messages":[{"id":"3d7370e4071e3c18460157d1c5252228d983bbba","author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"date":"2018-01-18 15:27:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"256ff8a17be4362e9f73ccb1c57973487ab3a99f","author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"date":"2018-01-18 15:49:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9ae7bfe07b108ce79a824ff9166bb74b1b3e0708","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-01-18 17:23:19.000000000","message":"Patch Set 2:\n\nwe need to take a closer look at this for backwards compatibility. current openstackclient still works with very old installs of openstack. cc dtroyer","accounts_in_message":[],"_revision_number":2},{"id":"e97281f24fd89be924bcda36cd37ecee7f6d6be5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 17:28:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/64/535364/2/check/openstack-tox-pep8/2803ca9/ : SUCCESS in 5m 26s\n- openstack-tox-py27 http://logs.openstack.org/64/535364/2/check/openstack-tox-py27/11a8856/ : SUCCESS in 4m 25s\n- openstack-tox-py35 http://logs.openstack.org/64/535364/2/check/openstack-tox-py35/f6a066d/ : SUCCESS in 5m 29s\n- build-openstack-sphinx-docs http://logs.openstack.org/64/535364/2/check/build-openstack-sphinx-docs/7314a1b/html/ : SUCCESS in 5m 10s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/64/535364/2/check/legacy-tempest-dsvm-neutron-src/2ab34ce/ : SUCCESS in 1h 26m 03s\n- openstackclient-check-plugins http://logs.openstack.org/64/535364/2/check/openstackclient-check-plugins/092b8b5/ : SUCCESS in 7m 32s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/64/535364/2/check/osc-tox-py27-tips/b4dcb67/ : SUCCESS in 5m 42s\n- osc-tox-py35-tips http://logs.openstack.org/64/535364/2/check/osc-tox-py35-tips/52104ca/ : SUCCESS in 5m 53s\n- osc-functional-devstack http://logs.openstack.org/64/535364/2/check/osc-functional-devstack/8d42349/ : SUCCESS in 38m 25s\n- osc-functional-devstack-tips http://logs.openstack.org/64/535364/2/check/osc-functional-devstack-tips/6c18152/ : SUCCESS in 50m 36s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"929bd8a8c2ee75f87215b6383dd0f7a1477fe319","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-01-18 22:53:20.000000000","message":"Patch Set 2:\n\nWhy just floating IP and not the rest of the compute support for networking?\n\nIt may be a long time before this actually is able to be removed, we still support very old clouds (kilo is in production in many places still).","accounts_in_message":[],"_revision_number":2},{"id":"a495ffbee784b9b22258fcdd1483ab3b2befb552","author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"date":"2018-01-19 03:38:25.000000000","message":"Patch Set 2:\n\nThanks for your information.I just use openstackclient with latest novaclient and find that floatingip related api has been removed from novaclient, it will raise error. Other networking apis haven\u0027t been removed. How should we be better to deal with this situation?","accounts_in_message":[],"_revision_number":2},{"id":"438b502d4c37bab813dfa7f02bc77a598c799742","author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"date":"2018-01-23 16:58:47.000000000","message":"Patch Set 2: Code-Review-1\n\nAny change here should have a release note so users know what the alternative is. If this is removed, what is the new (or already existing) command to add a floating ip to an instance?","accounts_in_message":[],"_revision_number":2},{"id":"8bc70c53bf8387a9d299282453652e917fdd16c0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-01-23 17:51:50.000000000","message":"Patch Set 2:\n\nnovaclient has a very different use case and deprecation policy than OSC.  The only real relationship OSC has with novaclient is we use it as a Python API for most of Compute.  It no longer supports all of the APIs that OSC needs to continue to support (such as the floating IPs) so we had to re-implement that in OSC directly.","accounts_in_message":[],"_revision_number":2},{"id":"3788de4bc992718d621773fda4d164e5d5526f6e","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2018-01-24 08:48:08.000000000","message":"Patch Set 2: Code-Review-1\n\nIn the OSC maintenance policy, the latest OSC tries to cover older clouds like Kilo. This is difference from novaclient. In case of novaclient, novaclient queens release mainly supports nova queens release. In case of OSC, OSC queens release supports older releases of OpenStack, so we cannot drop these codes.","accounts_in_message":[],"_revision_number":2},{"id":"43e141a9eb9f7d35c7bfe45f0446897b3922ae01","author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"date":"2018-01-29 02:40:47.000000000","message":"Patch Set 2:\n\nOK, I got it, thanks. So, I will abandon this patch.","accounts_in_message":[],"_revision_number":2},{"id":"d59737c5ecefa709f5e781df3c76c008f07f7769","author":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"date":"2018-01-29 02:41:12.000000000","message":"Abandoned\n\nwon\u0027t fix","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d9ab5fedee44f72c61a9a87008d8462825e02afd","revisions":{"b77741b6c737ba953216e102e545b24afa729194":{"kind":"REWORK","_number":1,"created":"2018-01-18 15:27:23.000000000","uploader":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"ref":"refs/changes/64/535364/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/64/535364/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/1"}}},"commit":{"parents":[{"commit":"e8dbac35f68b230b3d606776b36af1876bf6b208","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e8dbac35f68b230b3d606776b36af1876bf6b208"}]}],"author":{"name":"yushangbin","email":"yushb@gohighsec.com","date":"2018-01-18 15:26:07.000000000","tz":480},"committer":{"name":"yushangbin","email":"yushb@gohighsec.com","date":"2018-01-18 15:26:07.000000000","tz":480},"subject":"floatingip related should be removed from compute client","message":"floatingip related should be removed from compute client\n\nChange-Id: I498a064108124673fb738384240a5c76f8c53b67\nCloses-Bug: #1744089\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b77741b6c737ba953216e102e545b24afa729194"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b77741b6c737ba953216e102e545b24afa729194"}]},"branch":"refs/heads/master"},"d9ab5fedee44f72c61a9a87008d8462825e02afd":{"kind":"REWORK","_number":2,"created":"2018-01-18 15:49:36.000000000","uploader":{"_account_id":22056,"name":"yushangbin","email":"shangbin.yu@easystack.cn","username":"yushangbin"},"ref":"refs/changes/64/535364/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/64/535364/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/64/535364/2"}}},"commit":{"parents":[{"commit":"e8dbac35f68b230b3d606776b36af1876bf6b208","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e8dbac35f68b230b3d606776b36af1876bf6b208"}]}],"author":{"name":"yushangbin","email":"yushb@gohighsec.com","date":"2018-01-18 15:26:07.000000000","tz":480},"committer":{"name":"yushangbin","email":"yushb@gohighsec.com","date":"2018-01-18 15:48:48.000000000","tz":480},"subject":"floatingip related should be removed from compute client","message":"floatingip related should be removed from compute client\n\nChange-Id: I498a064108124673fb738384240a5c76f8c53b67\nCloses-Bug: #1744089\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d9ab5fedee44f72c61a9a87008d8462825e02afd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d9ab5fedee44f72c61a9a87008d8462825e02afd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}