)]}'
{"id":"openstack%2Fpython-openstackclient~536300","triplet_id":"openstack%2Fpython-openstackclient~master~I2179970df495e1215d691915c51cebe5cb4541a7","project":"openstack/python-openstackclient","branch":"master","topic":"replace-assert","hashtags":[],"change_id":"I2179970df495e1215d691915c51cebe5cb4541a7","subject":"Replace assert with condition","status":"MERGED","created":"2018-01-22 10:43:04.000000000","updated":"2018-01-22 17:56:31.000000000","submitted":"2018-01-22 17:56:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"536300-1516643791756-a327bdb8","meta_rev_id":"ce37a462f184579398e10fbed787980d3fee72b8","_number":536300,"virtual_id_number":536300,"owner":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2018-01-22 17:56:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2018-01-22 16:11:26.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2018-01-22 15:07:50.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2018-01-22 16:11:26.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-22 15:07:50.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-01-22 16:11:26.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-01-22 17:56:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7d09e9142091d4fe3bcce5168bc298efd1736cd2","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2018-01-22 10:43:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f148750a3dd13bebf2cf9aab7fd5d2b3418416d5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-22 12:37:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/00/536300/1/check/openstack-tox-pep8/e964b36/ : SUCCESS in 5m 36s\n- openstack-tox-py27 http://logs.openstack.org/00/536300/1/check/openstack-tox-py27/18ea212/ : SUCCESS in 3m 54s\n- openstack-tox-py35 http://logs.openstack.org/00/536300/1/check/openstack-tox-py35/cd4e361/ : SUCCESS in 4m 20s\n- build-openstack-sphinx-docs http://logs.openstack.org/00/536300/1/check/build-openstack-sphinx-docs/3ec45f6/html/ : SUCCESS in 5m 12s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/00/536300/1/check/legacy-tempest-dsvm-neutron-src/9e1cc5e/ : SUCCESS in 1h 43m 14s\n- openstackclient-check-plugins http://logs.openstack.org/00/536300/1/check/openstackclient-check-plugins/7d105c3/ : FAILURE in 8m 38s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/00/536300/1/check/osc-tox-py27-tips/74dba9e/ : SUCCESS in 7m 29s\n- osc-tox-py35-tips http://logs.openstack.org/00/536300/1/check/osc-tox-py35-tips/07b2adc/ : SUCCESS in 5m 07s\n- osc-functional-devstack http://logs.openstack.org/00/536300/1/check/osc-functional-devstack/1a691b6/ : SUCCESS in 38m 34s\n- osc-functional-devstack-tips http://logs.openstack.org/00/536300/1/check/osc-functional-devstack-tips/421cbc4/ : FAILURE in 1h 07m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ca1edd8e5dec23f5e12c250379dd00525c1449dd","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-01-22 15:07:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"391b8ad2b08032f9ce7fc88fe18131b2fbb2d187","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-01-22 16:11:26.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"809272bfe12e3fd9379e9f2439af5c77888fc78e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-22 16:11:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1918f98531258d5a76f8938e033259493dadcfe3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-22 17:56:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"514690488246ecdc85eb8b459787cc484d8e44c5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-22 17:56:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/00/536300/1/gate/openstack-tox-pep8/4b73663/ : SUCCESS in 5m 05s\n- openstack-tox-py27 http://logs.openstack.org/00/536300/1/gate/openstack-tox-py27/6e2a654/ : SUCCESS in 5m 08s\n- openstack-tox-py35 http://logs.openstack.org/00/536300/1/gate/openstack-tox-py35/d9c76c8/ : SUCCESS in 4m 21s\n- build-openstack-sphinx-docs http://logs.openstack.org/00/536300/1/gate/build-openstack-sphinx-docs/4b89f53/html/ : SUCCESS in 9m 36s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/00/536300/1/gate/legacy-tempest-dsvm-neutron-src/1d4bedb/ : SUCCESS in 1h 14m 49s\n- osc-tox-py27-tips http://logs.openstack.org/00/536300/1/gate/osc-tox-py27-tips/ec363d6/ : SUCCESS in 5m 49s\n- osc-tox-py35-tips http://logs.openstack.org/00/536300/1/gate/osc-tox-py35-tips/521f1b9/ : SUCCESS in 6m 07s\n- osc-functional-devstack http://logs.openstack.org/00/536300/1/gate/osc-functional-devstack/549800a/ : SUCCESS in 38m 39s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ca90985f4e5e4ebcf97afd6cce38932e73120255","revisions":{"ca90985f4e5e4ebcf97afd6cce38932e73120255":{"kind":"REWORK","_number":1,"created":"2018-01-22 10:43:04.000000000","uploader":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"ref":"refs/changes/00/536300/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/00/536300/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/536300/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/536300/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/536300/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/00/536300/1"}}},"commit":{"parents":[{"commit":"e8b56a37ccfcfeb5f12e873c8b58ba289e244870","subject":"Corrected spelling mistake","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e8b56a37ccfcfeb5f12e873c8b58ba289e244870"}]}],"author":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2018-01-22 10:24:01.000000000","tz":120},"committer":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2018-01-22 10:26:17.000000000","tz":120},"subject":"Replace assert with condition","message":"Replace assert with condition\n\na piece of code in image client has some business logic behind\nassert, which can be lost when running python in optimized mode (-O).\n\nChange-Id: I2179970df495e1215d691915c51cebe5cb4541a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ca90985f4e5e4ebcf97afd6cce38932e73120255"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ca90985f4e5e4ebcf97afd6cce38932e73120255"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}