)]}'
{"id":"openstack%2Fpython-openstackclient~538958","triplet_id":"openstack%2Fpython-openstackclient~master~I18a334280e5f384f8bb96198cdad79c612a02290","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"I18a334280e5f384f8bb96198cdad79c612a02290","subject":"Use find_ip from openstacksdk","status":"MERGED","created":"2018-01-29 16:00:56.000000000","updated":"2018-01-30 00:40:11.000000000","submitted":"2018-01-30 00:40:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"538958-1517272811797-10e4c3f1","meta_rev_id":"4aef692f365c1f87b829eb545a28b62624eba067","_number":538958,"virtual_id_number":538958,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":2,"date":"2018-01-30 00:40:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2018-01-29 18:40:31.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2018-01-29 23:10:02.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2018-01-29 22:04:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2018-01-29 23:10:02.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-29 18:40:31.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-01-29 22:04:30.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2018-01-29 23:10:02.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-01-30 00:40:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5dcfbb9b47409b9848e0d4bf87c04cce1735f34b","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-01-29 16:00:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"277c6118099a0f60b1df4bf7792b7b1cc7216f77","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2018-01-29 16:10:28.000000000","message":"Patch Set 1:\n\nLooks like some of the tests mock _find_floating_ip() and would need an update too:\n\nopenstackclient/tests/unit/network/v2/test_floating_ip_network.py","accounts_in_message":[],"_revision_number":1},{"id":"e554023282a4d0c9a360e2cd22a442760a4fe850","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-01-29 16:22:04.000000000","message":"Patch Set 1: Code-Review+1\n\n+1 to what Brian said, but this is fine to remove.","accounts_in_message":[],"_revision_number":1},{"id":"c60ac5afe590436816b6ef4ff97c59f5426ac7a0","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-01-29 18:03:50.000000000","message":"Patch Set 1:\n\nBrian - good call - fixing now.","accounts_in_message":[],"_revision_number":1},{"id":"1254ee3f4a1bd90b485dcf9c9f47056c7c45d509","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-01-29 18:07:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8546e05724cfa4c61bec3c26c5285052b39a88bf","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-01-29 18:40:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"05073e069106ecfcc6bfe79b1a50385780ab0d64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-29 20:58:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/58/538958/2/check/openstack-tox-pep8/3723c4a/ : SUCCESS in 4m 49s\n- openstack-tox-py27 http://logs.openstack.org/58/538958/2/check/openstack-tox-py27/81c0dc4/ : SUCCESS in 4m 59s\n- openstack-tox-py35 http://logs.openstack.org/58/538958/2/check/openstack-tox-py35/23d2dd6/ : SUCCESS in 5m 41s\n- build-openstack-sphinx-docs http://logs.openstack.org/58/538958/2/check/build-openstack-sphinx-docs/2ae04e9/html/ : SUCCESS in 5m 08s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/58/538958/2/check/legacy-tempest-dsvm-neutron-src/2f8d8cd/ : SUCCESS in 1h 21m 50s\n- openstackclient-check-plugins http://logs.openstack.org/58/538958/2/check/openstackclient-check-plugins/3e18d58/ : SUCCESS in 6m 45s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/58/538958/2/check/osc-tox-py27-tips/72c4f1b/ : SUCCESS in 5m 59s\n- osc-tox-py35-tips http://logs.openstack.org/58/538958/2/check/osc-tox-py35-tips/10309af/ : SUCCESS in 5m 25s\n- osc-functional-devstack http://logs.openstack.org/58/538958/2/check/osc-functional-devstack/dbd45c5/ : SUCCESS in 36m 25s\n- osc-functional-devstack-tips http://logs.openstack.org/58/538958/2/check/osc-functional-devstack-tips/4ff22ba/ : SUCCESS in 47m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9f59e11f19066677f688c4bb2917864193bfaee9","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2018-01-29 22:04:30.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1437214317ee20a6616c5d6b030cd0b27ed0ad7f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-01-29 23:10:02.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b28137e52d80fc39bfe02910e2a356738030a09b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-29 23:10:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"01350e7a85ff415ddb0532c4ca0c1c02fc7b83f8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-30 00:40:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"4aef692f365c1f87b829eb545a28b62624eba067","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-30 00:40:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/58/538958/2/gate/openstack-tox-pep8/bbc39b8/ : SUCCESS in 5m 24s\n- openstack-tox-py27 http://logs.openstack.org/58/538958/2/gate/openstack-tox-py27/383e2b0/ : SUCCESS in 4m 41s\n- openstack-tox-py35 http://logs.openstack.org/58/538958/2/gate/openstack-tox-py35/f25779f/ : SUCCESS in 5m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/58/538958/2/gate/build-openstack-sphinx-docs/669f491/html/ : SUCCESS in 6m 17s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/58/538958/2/gate/legacy-tempest-dsvm-neutron-src/aa84a91/ : SUCCESS in 1h 14m 21s\n- osc-tox-py27-tips http://logs.openstack.org/58/538958/2/gate/osc-tox-py27-tips/fafd368/ : SUCCESS in 5m 34s\n- osc-tox-py35-tips http://logs.openstack.org/58/538958/2/gate/osc-tox-py35-tips/e4c5e5d/ : SUCCESS in 6m 18s\n- osc-functional-devstack http://logs.openstack.org/58/538958/2/gate/osc-functional-devstack/a2b5b12/ : SUCCESS in 39m 19s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a742e47ecf86ef514d124ec5d10df197c01b253b","revisions":{"7e4b259e5170e194c98db15bdb2aa7f67494f43d":{"kind":"REWORK","_number":1,"created":"2018-01-29 16:00:56.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/58/538958/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/538958/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/1"}}},"commit":{"parents":[{"commit":"2ef279ab71eb56860bc0ff10e14b8a865773f83a","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2ef279ab71eb56860bc0ff10e14b8a865773f83a"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2018-01-29 15:59:08.000000000","tz":-360},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2018-01-29 15:59:08.000000000","tz":-360},"subject":"Use find_ip from openstacksdk","message":"Use find_ip from openstacksdk\n\nThe find_ip from openstacksdk started being usable by OSC back in 0.9.15\nbut the local method never got replaced.\n\nChange-Id: I18a334280e5f384f8bb96198cdad79c612a02290\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7e4b259e5170e194c98db15bdb2aa7f67494f43d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7e4b259e5170e194c98db15bdb2aa7f67494f43d"}]},"branch":"refs/heads/master"},"a742e47ecf86ef514d124ec5d10df197c01b253b":{"kind":"REWORK","_number":2,"created":"2018-01-29 18:07:38.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/58/538958/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/538958/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/538958/2"}}},"commit":{"parents":[{"commit":"2ef279ab71eb56860bc0ff10e14b8a865773f83a","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2ef279ab71eb56860bc0ff10e14b8a865773f83a"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2018-01-29 15:59:08.000000000","tz":-360},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2018-01-29 18:05:22.000000000","tz":-360},"subject":"Use find_ip from openstacksdk","message":"Use find_ip from openstacksdk\n\nThe find_ip from openstacksdk started being usable by OSC back in 0.9.15\nbut the local method never got replaced.\n\nChange-Id: I18a334280e5f384f8bb96198cdad79c612a02290\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a742e47ecf86ef514d124ec5d10df197c01b253b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a742e47ecf86ef514d124ec5d10df197c01b253b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}