)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a6c8c90527d08479488f2955c7b381f7513ad9b4","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def take_action(self, parsed_args):"},{"line_number":262,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":263,"context_line":"        network_client \u003d self.app.client_manager.network"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        server \u003d utils.find_resource("},{"line_number":266,"context_line":"            compute_client.servers, parsed_args.server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_15c5c38e","line":263,"updated":"2018-03-05 17:28:49.000000000","message":"The problem with this approach, which I struggled with in https://review.openstack.org/#/c/538539/ - is that if the cloud you\u0027re talking to isn\u0027t running neutron, this won\u0027t work. I\u0027m not sure how easy it would be to split out the nova-net vs neutron specific action logic for this code however.","commit_id":"4a994aeb09d251dd428413432742797c0d7ee0f3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ba3130d555df46b70e5ed73b21673a858494e8f","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def take_action(self, parsed_args):"},{"line_number":262,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":263,"context_line":"        network_client \u003d self.app.client_manager.network"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        server \u003d utils.find_resource("},{"line_number":266,"context_line":"            compute_client.servers, parsed_args.server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_15cf0380","line":263,"in_reply_to":"ff6b8bd7_15c5c38e","updated":"2018-03-05 17:40:44.000000000","message":"\u003e https://review.openstack.org/#/c/538539/ \n\noh. One more thing which I missed.\n\n\u003e if the cloud you\u0027re talking to isn\u0027t running neutron,\n\nLatest novaclient doesn\u0027t support nova-network, so noway to make `openstackclient` commands supporting anything except Neutron. I suppose \"neutron\" is a default and only one option now. \n\nAnyway, imo, it is better to support anything than nothing and to provide the user-friendly interface.","commit_id":"4a994aeb09d251dd428413432742797c0d7ee0f3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b11ae31d924e1b7ca875e9ec487e8f4a78062617","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def take_action(self, parsed_args):"},{"line_number":262,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":263,"context_line":"        network_client \u003d self.app.client_manager.network"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        server \u003d utils.find_resource("},{"line_number":266,"context_line":"            compute_client.servers, parsed_args.server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_107631da","line":263,"in_reply_to":"ff6b8bd7_15cf0380","updated":"2018-03-05 19:21:15.000000000","message":"First version of supporting both:\n\nhttps://review.openstack.org/#/c/549777/\n\nIt needs to remove the os-hosts part, since dean is working on that differently. Using the shade layer of openstacksdk we get the neutron or nova logic.","commit_id":"4a994aeb09d251dd428413432742797c0d7ee0f3"}]}