)]}'
{"id":"openstack%2Fpython-openstackclient~549820","triplet_id":"openstack%2Fpython-openstackclient~master~I736fb96d4d7883520a6f80f8e896d10efe709401","project":"openstack/python-openstackclient","branch":"master","topic":"add_floating","hashtags":[],"change_id":"I736fb96d4d7883520a6f80f8e896d10efe709401","subject":"Rework \"openstack server add floating ip\" cmd","status":"ABANDONED","created":"2018-03-05 16:54:36.000000000","updated":"2018-08-16 13:03:51.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ec2722c69894dc8680ba474587f07d3fc3df883d","_number":549820,"virtual_id_number":549820,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-03-05 19:21:15.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"date":"2018-03-05 21:45:47.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2018-03-05 17:40:44.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"date":"2018-03-05 20:09:46.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2018-03-05 17:39:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-05 17:39:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-03-05 19:21:15.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2018-03-05 20:09:46.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-03-05 21:45:47.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"a7682957884a62583b6e5e69c4b62d3327b5c21a","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-03-05 16:54:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a6c8c90527d08479488f2955c7b381f7513ad9b4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-03-05 17:28:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0ea7edd54231578e609a514541bd1da0af6a2517","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-05 17:39:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/20/549820/1/check/openstack-tox-pep8/1904060/ : SUCCESS in 5m 15s\n- openstack-tox-py27 http://logs.openstack.org/20/549820/1/check/openstack-tox-py27/82542ba/ : SUCCESS in 4m 32s\n- openstack-tox-py35 http://logs.openstack.org/20/549820/1/check/openstack-tox-py35/bb02456/ : SUCCESS in 4m 41s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/549820/1/check/build-openstack-sphinx-docs/ad7959c/html/ : SUCCESS in 4m 52s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/20/549820/1/check/legacy-tempest-dsvm-neutron-src/454839e/ : RETRY_LIMIT in 4m 19s\n- openstackclient-check-plugins http://logs.openstack.org/20/549820/1/check/openstackclient-check-plugins/7dcfae9/ : SUCCESS in 5m 28s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/20/549820/1/check/osc-tox-py27-tips/36ae42a/ : SUCCESS in 4m 35s\n- osc-tox-py35-tips http://logs.openstack.org/20/549820/1/check/osc-tox-py35-tips/212d16c/ : SUCCESS in 4m 31s\n- osc-functional-devstack http://logs.openstack.org/20/549820/1/check/osc-functional-devstack/3d201bb/ : FAILURE in 35m 31s\n- osc-functional-devstack-tips http://logs.openstack.org/20/549820/1/check/osc-functional-devstack-tips/2f6126d/ : FAILURE in 42m 11s","accounts_in_message":[],"_revision_number":1},{"id":"5ba3130d555df46b70e5ed73b21673a858494e8f","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-03-05 17:40:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b11ae31d924e1b7ca875e9ec487e8f4a78062617","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-03-05 19:21:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"24e8d0dd1090f2977219eb20aa0c1796e2700ca1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-03-05 20:09:46.000000000","message":"Patch Set 1:\n\nWe already have the combo nova-net/neutron login in the Network commands, let\u0027s just maintain that pattern. It already uses the SDK for the Neutron side, and I\u0027ll add the usual direct REST in api.compute_v2 for nova-net.\n\nI\u0027m prepping a follow-on to my /os-hosts review to show the pattern for \"server add floating ip\"","accounts_in_message":[],"_revision_number":1},{"id":"4a2fe56839f7242239f069c6e28a96e246ed220b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-03-05 21:45:47.000000000","message":"Patch Set 1:\n\n\u003e and I\u0027ll add the usual direct REST in api.compute_v2 for nova-net.\n\nIs what I expected would be required at this point for anything that needs to hit the compute API but can\u0027t go through novaclient python API bindings.","accounts_in_message":[],"_revision_number":1},{"id":"050fb9d4b84a31779ab1a5da0c8ad67494263f2f","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-08-16 13:03:51.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4a994aeb09d251dd428413432742797c0d7ee0f3","revisions":{"4a994aeb09d251dd428413432742797c0d7ee0f3":{"kind":"REWORK","_number":1,"created":"2018-03-05 16:54:36.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/20/549820/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/549820/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/549820/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/549820/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/549820/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/549820/1"}}},"commit":{"parents":[{"commit":"b10941ddf6f7f6894b7d87f25c173f227b111e4e","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b10941ddf6f7f6894b7d87f25c173f227b111e4e"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-03-05 16:49:28.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-03-05 16:54:34.000000000","tz":120},"subject":"Rework \"openstack server add floating ip\" cmd","message":"Rework \"openstack server add floating ip\" cmd\n\n\"openstack server add floating ip\" command relied on add_floating_ip\nmethod of novaclient\u0027s server object.\n\nUnfortunatelly or fortunately, this interface was deprecated a year\nago[1] and it is removed now from novaclient[2].\n\nThis patch reworks \"server add floating ip\" to call neutron API for\nassociating floating ip to the right port.\n\n[1] https://github.com/openstack/python-novaclient/blob/master/releasenotes/notes/microversion-v2_44-d60c8834e436ad3d.yaml\n[2] https://github.com/openstack/python-novaclient/blob/master/releasenotes/notes/remove-virt-interfaces-add-rm-fixed-floating-398c905d9c91cca8.yaml\n\nChange-Id: I736fb96d4d7883520a6f80f8e896d10efe709401\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4a994aeb09d251dd428413432742797c0d7ee0f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4a994aeb09d251dd428413432742797c0d7ee0f3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}