)]}'
{"id":"openstack%2Fpython-openstackclient~569398","triplet_id":"openstack%2Fpython-openstackclient~master~Iff4d8b47812a86d21bf5dbdddbd642b9d63ff8fe","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"Iff4d8b47812a86d21bf5dbdddbd642b9d63ff8fe","subject":"Update command test for volume.v3","status":"MERGED","created":"2018-05-18 12:12:21.000000000","updated":"2018-05-18 20:43:36.000000000","submitted":"2018-05-18 20:43:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"569398-1526676216371-1c2e32f6","meta_rev_id":"aeceeaf777070ea5a0aa32789d966661b94fc6f0","_number":569398,"virtual_id_number":569398,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-05-18 12:51:01.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2018-05-18 20:43:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2018-05-18 19:17:03.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":2,"date":"2018-05-18 12:29:02.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2018-05-18 19:17:03.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-18 12:29:02.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2018-05-18 19:17:03.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2018-05-18 20:43:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cd64ae4845f6edd1318c39bc66dcca18b58578cb","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-05-18 12:12:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66dafa117b2e73715f14e242e1b35f2191635caa","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2018-05-18 12:29:02.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good from the point of view that this fixes the gate failure.\n\nOn the other hand, I am afraid this change breaks the functional test if OS_VOLUME_API_VERSION is not specified because the default volume API version is still 2 in OSC code [1]. For most developers (I assume they use devstack), when we run the func tests, we set OS_* or OS_CLOUD (and the volume version in clouds.yaml are from DevStack), so the impact would be small. I think we can discuss it separately, so +2 on this.\n\n[1] http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/volume/client.py#n25","accounts_in_message":[],"_revision_number":1},{"id":"a3fc6dcc515a39eabb0bf0ab0241268fe03e86e7","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-05-18 12:51:01.000000000","message":"Patch Set 1:\n\nAgree. Actually - I\u0027m VERY close to having discovery fully working at the SDK layer, so perhaps it will be time to follow up and see how we can take advantage of it at the osc layer - and maybe get rid of hardcoded defaults.","accounts_in_message":[],"_revision_number":1},{"id":"6b77edfe2105ad3c2258ac5a31d9d5ca45b0d359","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-18 13:37:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/98/569398/1/check/openstack-tox-pep8/222de8d/ : SUCCESS in 5m 27s\n- openstack-tox-py27 http://logs.openstack.org/98/569398/1/check/openstack-tox-py27/e9da2f4/ : SUCCESS in 5m 38s\n- openstack-tox-py35 http://logs.openstack.org/98/569398/1/check/openstack-tox-py35/15e9def/ : SUCCESS in 4m 46s\n- build-openstack-sphinx-docs http://logs.openstack.org/98/569398/1/check/build-openstack-sphinx-docs/80b4cfd/html/ : SUCCESS in 5m 03s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/98/569398/1/check/legacy-tempest-dsvm-neutron-src/d53c5d7/ : SUCCESS in 1h 23m 40s\n- openstackclient-check-plugins http://logs.openstack.org/98/569398/1/check/openstackclient-check-plugins/c208cee/ : FAILURE in 6m 19s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/98/569398/1/check/osc-tox-py27-tips/e6eff00/ : SUCCESS in 5m 09s\n- osc-tox-py35-tips http://logs.openstack.org/98/569398/1/check/osc-tox-py35-tips/37f7f0f/ : SUCCESS in 6m 40s\n- osc-functional-devstack http://logs.openstack.org/98/569398/1/check/osc-functional-devstack/deb9e24/ : SUCCESS in 39m 30s\n- osc-functional-devstack-tips http://logs.openstack.org/98/569398/1/check/osc-functional-devstack-tips/2b81003/ : FAILURE in 41m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/569398/1/check/openstack-tox-lower-constraints/2a444eb/ : SUCCESS in 4m 13s","accounts_in_message":[],"_revision_number":1},{"id":"e5851faeb29a9931135b9b90cf1a010936d82a34","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-05-18 13:55:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"2416dd9937a464000c96aec2a676a36824c9f96c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-18 15:17:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/98/569398/1/check/openstack-tox-pep8/61ef918/ : SUCCESS in 5m 16s\n- openstack-tox-py27 http://logs.openstack.org/98/569398/1/check/openstack-tox-py27/e8db510/ : SUCCESS in 4m 21s\n- openstack-tox-py35 http://logs.openstack.org/98/569398/1/check/openstack-tox-py35/3895d02/ : SUCCESS in 4m 17s\n- build-openstack-sphinx-docs http://logs.openstack.org/98/569398/1/check/build-openstack-sphinx-docs/3b10fcc/html/ : SUCCESS in 4m 55s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/98/569398/1/check/legacy-tempest-dsvm-neutron-src/6beb139/ : SUCCESS in 1h 18m 39s\n- openstackclient-check-plugins http://logs.openstack.org/98/569398/1/check/openstackclient-check-plugins/96ae0ce/ : FAILURE in 6m 15s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/98/569398/1/check/osc-tox-py27-tips/b87ae5a/ : SUCCESS in 5m 52s\n- osc-tox-py35-tips http://logs.openstack.org/98/569398/1/check/osc-tox-py35-tips/708df90/ : SUCCESS in 5m 22s\n- osc-functional-devstack http://logs.openstack.org/98/569398/1/check/osc-functional-devstack/88d47cf/ : SUCCESS in 43m 34s\n- osc-functional-devstack-tips http://logs.openstack.org/98/569398/1/check/osc-functional-devstack-tips/f7fefd2/ : SUCCESS in 44m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/569398/1/check/openstack-tox-lower-constraints/7809cef/ : SUCCESS in 4m 50s","accounts_in_message":[],"_revision_number":1},{"id":"d09c5f130d23f310716847dbaf9b06a9fb3dd15d","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-05-18 19:17:03.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"718c4dc7b3de428f04c21ca34ea87ac7ca6f128b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-18 19:17:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"eada7ca6e1bdd2ac85ea44b0500e727e582c1d2c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-18 20:43:36.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/98/569398/1/gate/openstack-tox-pep8/41df196/ : SUCCESS in 4m 47s\n- openstack-tox-py27 http://logs.openstack.org/98/569398/1/gate/openstack-tox-py27/baf2bc9/ : SUCCESS in 4m 25s\n- openstack-tox-py35 http://logs.openstack.org/98/569398/1/gate/openstack-tox-py35/62ec1c5/ : SUCCESS in 4m 53s\n- build-openstack-sphinx-docs http://logs.openstack.org/98/569398/1/gate/build-openstack-sphinx-docs/056abed/html/ : SUCCESS in 4m 42s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/98/569398/1/gate/legacy-tempest-dsvm-neutron-src/0176f05/ : SUCCESS in 1h 24m 12s\n- osc-tox-py27-tips http://logs.openstack.org/98/569398/1/gate/osc-tox-py27-tips/556f315/ : SUCCESS in 6m 10s\n- osc-tox-py35-tips http://logs.openstack.org/98/569398/1/gate/osc-tox-py35-tips/fab755d/ : SUCCESS in 5m 38s\n- osc-functional-devstack http://logs.openstack.org/98/569398/1/gate/osc-functional-devstack/976639c/ : SUCCESS in 47m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/569398/1/gate/openstack-tox-lower-constraints/ae3df8e/ : SUCCESS in 5m 25s","accounts_in_message":[],"_revision_number":1},{"id":"aeceeaf777070ea5a0aa32789d966661b94fc6f0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-18 20:43:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f7e4d31820e797e0d374e7dfde1142373245ea87","revisions":{"f7e4d31820e797e0d374e7dfde1142373245ea87":{"kind":"REWORK","_number":1,"created":"2018-05-18 12:12:21.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/98/569398/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/98/569398/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/569398/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/569398/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/569398/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/98/569398/1"}}},"commit":{"parents":[{"commit":"06263bd5852aad9cd03a76f50140fbbb2d0751ba","subject":"Merge \"Fix limits show command without Nova and Cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/06263bd5852aad9cd03a76f50140fbbb2d0751ba"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2018-05-18 12:11:30.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2018-05-18 12:12:04.000000000","tz":-300},"subject":"Update command test for volume.v3","message":"Update command test for volume.v3\n\nThe default cinder version in devstack changed to v3 in\nhttps://review.openstack.org/#/c/566747/which breaks this\ntest. Change the test to test what\u0027s going to happen.\n\nChange-Id: Iff4d8b47812a86d21bf5dbdddbd642b9d63ff8fe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7e4d31820e797e0d374e7dfde1142373245ea87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7e4d31820e797e0d374e7dfde1142373245ea87"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}