)]}'
{"id":"openstack%2Fpython-openstackclient~572771","triplet_id":"openstack%2Fpython-openstackclient~master~Ie54c6ed83b6e9a3116e1832b3fb36dd80781366d","project":"openstack/python-openstackclient","branch":"master","topic":"nit_fix","hashtags":[],"change_id":"Ie54c6ed83b6e9a3116e1832b3fb36dd80781366d","subject":"Fix inconsistency (nit)","status":"MERGED","created":"2018-06-06 13:39:58.000000000","updated":"2018-08-13 14:03:17.000000000","submitted":"2018-08-13 14:03:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"572771-1534168997661-4bddaeb8","meta_rev_id":"597712c5e72cceb7127349d8220c511c8eeaab36","_number":572771,"virtual_id_number":572771,"owner":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"value":2,"date":"2018-08-13 14:03:17.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2018-08-13 11:32:04.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2018-08-13 13:54:12.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2018-08-13 13:54:12.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-07 20:28:13.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2018-08-13 11:32:04.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2018-08-13 13:54:12.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-08-13 14:03:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"969ea76ab8dc16b538508afdd26e37988c5afa72","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-06-06 13:39:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d5a955603c9dbdfca0640df66b89fa4f27cc707","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2018-06-06 13:51:51.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"8256512d79e42429a469d465867b7149ff8af5f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-06 13:54:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/71/572771/1/check/openstack-tox-pep8/e2a3e30/ : SUCCESS in 5m 24s\n- build-openstack-sphinx-docs http://logs.openstack.org/71/572771/1/check/build-openstack-sphinx-docs/6ac73ac/html/ : SUCCESS in 5m 36s\n- openstackclient-check-plugins http://logs.openstack.org/71/572771/1/check/openstackclient-check-plugins/3ca8e30/ : SUCCESS in 6m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"583506e68f62539f5f78bb64800e03f79cdda589","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-06-06 13:54:44.000000000","message":"Patch Set 1:\n\n\u003e (2 comments)\n\nThanks for the comment. There are two lines whose styles contradict. Feel free to check out my reply on the other change.","accounts_in_message":[],"_revision_number":1},{"id":"1c19c4c55ed6cdc8b966ac0f7933ce5d95d8d2f0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-06-06 16:51:29.000000000","message":"Patch Set 1: Code-Review-1\n\nnot a typo","accounts_in_message":[],"_revision_number":1},{"id":"87d7ea8db4a7a19acb01d170e79738592d2e331a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-06-07 20:28:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1251af5cfc487d7ee6d7f8a97d8dcd5d24244917","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-06-29 01:47:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9c7cc7cc0c41292961a4648547ff93ec17f2dafd","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-06-29 01:48:12.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"5370cb5a07af950de5958e4cb569250b896f3f78","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-29 02:00:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/71/572771/2/check/openstack-tox-pep8/ed92801/ : SUCCESS in 4m 42s\n- build-openstack-sphinx-docs http://logs.openstack.org/71/572771/2/check/build-openstack-sphinx-docs/f762ab7/html/ : SUCCESS in 9m 14s\n- openstackclient-check-plugins http://logs.openstack.org/71/572771/2/check/openstackclient-check-plugins/1bd800e/ : SUCCESS in 6m 42s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"df3ee6ec421f3f87c98bf4d91b72d0ae391a2bd8","author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"date":"2018-06-29 07:09:25.000000000","message":"Patch Set 2: Code-Review-1\n\nNo, it was not all that is needed. I think Kevin Mitchell gave a good explaination in https://review.openstack.org/#/c/572770/ why this shouldn\u0027t be merged.\n\nIf you see this differently, you should talk to the core reviewers directly in IRC and convince them.","accounts_in_message":[],"_revision_number":2},{"id":"a0303d6999dec0d3966de893e3b053fed32e0998","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-08-10 06:38:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c6c643244cce7d46ba9e9aae387e3f54d8ecf6dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-10 06:49:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/71/572771/3/check/openstack-tox-pep8/c7ce34f/ : SUCCESS in 5m 18s\n- build-openstack-sphinx-docs http://logs.openstack.org/71/572771/3/check/build-openstack-sphinx-docs/f93b6c3/html/ : SUCCESS in 6m 06s\n- openstackclient-check-plugins http://logs.openstack.org/71/572771/3/check/openstackclient-check-plugins/931f769/ : SUCCESS in 6m 29s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d67f356997f43d66613b0e9702efa56e18ffd530","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-08-13 11:32:04.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"a191fdccb83600e83d7cf312d143ccf425c68d5f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-08-13 13:54:12.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"dc2fe3211d2a4031140aa99089e0e6dc16e274ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-13 13:54:24.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"675d0061f0316fda9e8b089a69b1d9203b2274bf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-13 14:03:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"da6170cbbb6ea2f9bf9d71d164eb6d255cf82801","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-13 14:03:17.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/71/572771/3/gate/openstack-tox-pep8/5e79fc1/ : SUCCESS in 6m 44s\n- build-openstack-sphinx-docs http://logs.openstack.org/71/572771/3/gate/build-openstack-sphinx-docs/73425f2/html/ : SUCCESS in 6m 30s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"29ca9904fcbf179b6cc2c41221a3b4825069b1ad","revisions":{"2f0201279feb1d5f3e76dc02e363fce4b46da016":{"kind":"REWORK","_number":1,"created":"2018-06-06 13:39:58.000000000","uploader":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"ref":"refs/changes/71/572771/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/71/572771/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/1"}}},"commit":{"parents":[{"commit":"c18f93bafeb3304cc275dc466664c9401d722194","subject":"Merge \"Prevent \"server migrate --wait\" from hanging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c18f93bafeb3304cc275dc466664c9401d722194"}]}],"author":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-06-06 13:39:27.000000000","tz":480},"committer":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-06-06 13:39:27.000000000","tz":480},"subject":"Fix a tyo","message":"Fix a tyo\n\nChange-Id: Ie54c6ed83b6e9a3116e1832b3fb36dd80781366d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2f0201279feb1d5f3e76dc02e363fce4b46da016"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2f0201279feb1d5f3e76dc02e363fce4b46da016"}]},"branch":"refs/heads/master"},"7ecf077229d6f8ce2f513c32346f7a6702151b1e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-06-29 01:48:12.000000000","uploader":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"ref":"refs/changes/71/572771/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/71/572771/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/2"}}},"commit":{"parents":[{"commit":"c18f93bafeb3304cc275dc466664c9401d722194","subject":"Merge \"Prevent \"server migrate --wait\" from hanging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c18f93bafeb3304cc275dc466664c9401d722194"}]}],"author":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-06-06 13:39:27.000000000","tz":480},"committer":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-06-29 01:47:33.000000000","tz":0},"subject":"Fix a typo","message":"Fix a typo\n\nChange-Id: Ie54c6ed83b6e9a3116e1832b3fb36dd80781366d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7ecf077229d6f8ce2f513c32346f7a6702151b1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7ecf077229d6f8ce2f513c32346f7a6702151b1e"}]},"branch":"refs/heads/master"},"29ca9904fcbf179b6cc2c41221a3b4825069b1ad":{"kind":"REWORK","_number":3,"created":"2018-08-10 06:38:08.000000000","uploader":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"ref":"refs/changes/71/572771/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/71/572771/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/71/572771/3"}}},"commit":{"parents":[{"commit":"c18f93bafeb3304cc275dc466664c9401d722194","subject":"Merge \"Prevent \"server migrate --wait\" from hanging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c18f93bafeb3304cc275dc466664c9401d722194"}]}],"author":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-06-06 13:39:27.000000000","tz":480},"committer":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-08-10 06:24:23.000000000","tz":480},"subject":"Fix inconsistency (nit)","message":"Fix inconsistency (nit)\n\nWord choice of description for \"host-evacuate-live\" is slightly\ndifferent from that in novaclient (\"migrate of\" instead of \"migrate off\").\nhttps://github.com/openstack/python-novaclient/blob/master/doc/source/cli/nova.rst#nova-host-evacuate-live\nThey are supposed to be exactly the same, so use \"migrate off\" to\nkeep consistent.\n\nChange-Id: Ie54c6ed83b6e9a3116e1832b3fb36dd80781366d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/29ca9904fcbf179b6cc2c41221a3b4825069b1ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/29ca9904fcbf179b6cc2c41221a3b4825069b1ad"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}