)]}'
{"id":"openstack%2Fpython-openstackclient~573760","triplet_id":"openstack%2Fpython-openstackclient~master~Ib1c9c424ed1cafc2dfd8be90af8de8a774bdfbf0","project":"openstack/python-openstackclient","branch":"master","topic":"story/1751104","hashtags":[],"change_id":"Ib1c9c424ed1cafc2dfd8be90af8de8a774bdfbf0","subject":"Optimize _prep_server_detail to avoid redundant find_resource","status":"MERGED","created":"2018-06-08 15:49:02.000000000","updated":"2018-06-12 01:14:16.000000000","submitted":"2018-06-12 01:14:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"573760-1528766056842-b5792c83","meta_rev_id":"e4037f1e990a3aff42ef92cbfab55a8e6e2f2b09","_number":573760,"virtual_id_number":573760,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"date":"2018-06-11 19:59:48.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2018-06-12 01:14:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2018-06-08 16:37:08.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2018-06-09 15:36:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2018-06-09 15:36:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-08 16:37:08.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-06-09 15:36:20.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-06-12 01:14:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"70b31d4a9ae30b47da804ef717445ebdd40aedd6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-06-08 15:49:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03e37f55c274909c258637fc389d1f9279ee784a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-06-08 16:37:08.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\ngreat commit message, thanks Matt.","accounts_in_message":[],"_revision_number":1},{"id":"f3a185e450fb10923f0c86299d03a21b2006acdf","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-06-09 15:36:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7129d23eaa5940ebe9d914b9df2509c6df96ea34","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-06-11 19:59:48.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"c115661d9c94288c84f2b14da76817f41d52db6e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-11 23:26:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/60/573760/1/check/openstack-tox-pep8/65b2123/ : SUCCESS in 4m 56s\n- openstack-tox-py27 http://logs.openstack.org/60/573760/1/check/openstack-tox-py27/4f9fe64/ : SUCCESS in 5m 03s\n- openstack-tox-py35 http://logs.openstack.org/60/573760/1/check/openstack-tox-py35/85415cc/ : SUCCESS in 5m 15s\n- build-openstack-sphinx-docs http://logs.openstack.org/60/573760/1/check/build-openstack-sphinx-docs/89b53a1/html/ : SUCCESS in 5m 41s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/60/573760/1/check/legacy-tempest-dsvm-neutron-src/dd92856/ : SUCCESS in 1h 34m 14s\n- openstackclient-check-plugins http://logs.openstack.org/60/573760/1/check/openstackclient-check-plugins/ea74a9c/ : SUCCESS in 7m 23s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/60/573760/1/check/osc-tox-py27-tips/a5d3b76/ : SUCCESS in 6m 57s\n- osc-tox-py35-tips http://logs.openstack.org/60/573760/1/check/osc-tox-py35-tips/7ccdd4a/ : SUCCESS in 6m 53s\n- osc-functional-devstack http://logs.openstack.org/60/573760/1/check/osc-functional-devstack/be888ab/ : SUCCESS in 46m 51s\n- osc-functional-devstack-tips http://logs.openstack.org/60/573760/1/check/osc-functional-devstack-tips/167abc9/ : SUCCESS in 55m 28s\n- openstack-tox-lower-constraints http://logs.openstack.org/60/573760/1/check/openstack-tox-lower-constraints/a5b2278/ : SUCCESS in 5m 29s","accounts_in_message":[],"_revision_number":1},{"id":"b9ffa1eb6db4fe718c1af47452f4542612a83457","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-11 23:26:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e4bc7f8a949294fd5b295a76826c3edf2533a909","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-12 01:14:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/60/573760/1/gate/openstack-tox-pep8/c0acce8/ : SUCCESS in 6m 11s\n- openstack-tox-py27 http://logs.openstack.org/60/573760/1/gate/openstack-tox-py27/25c2afd/ : SUCCESS in 5m 53s\n- openstack-tox-py35 http://logs.openstack.org/60/573760/1/gate/openstack-tox-py35/47a661a/ : SUCCESS in 6m 08s\n- build-openstack-sphinx-docs http://logs.openstack.org/60/573760/1/gate/build-openstack-sphinx-docs/3f4360a/html/ : SUCCESS in 7m 06s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/60/573760/1/gate/legacy-tempest-dsvm-neutron-src/745ee71/ : SUCCESS in 1h 37m 56s\n- osc-tox-py27-tips http://logs.openstack.org/60/573760/1/gate/osc-tox-py27-tips/77c9c0a/ : SUCCESS in 7m 03s\n- osc-tox-py35-tips http://logs.openstack.org/60/573760/1/gate/osc-tox-py35-tips/f63cc11/ : SUCCESS in 7m 32s\n- osc-functional-devstack http://logs.openstack.org/60/573760/1/gate/osc-functional-devstack/db5c31a/ : SUCCESS in 51m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/60/573760/1/gate/openstack-tox-lower-constraints/169eaba/ : SUCCESS in 6m 28s","accounts_in_message":[],"_revision_number":1},{"id":"8dfb5661f8e96c2d893bf3bcd2d60f30227bff6f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-12 01:14:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"752a2db332780ac98c4a4c3a3778b178131a8d59","revisions":{"752a2db332780ac98c4a4c3a3778b178131a8d59":{"kind":"REWORK","_number":1,"created":"2018-06-08 15:49:02.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/60/573760/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/60/573760/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/573760/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/573760/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/573760/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/60/573760/1"}}},"commit":{"parents":[{"commit":"56b346754992adeef18257598c6f840027394377","subject":"Use Server.to_dict() rather than Server._info","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/56b346754992adeef18257598c6f840027394377"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-06-08 15:46:29.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-06-08 15:46:29.000000000","tz":-240},"subject":"Optimize _prep_server_detail to avoid redundant find_resource","message":"Optimize _prep_server_detail to avoid redundant find_resource\n\nWhen showing a server or doing a rebuild, we already have\nthe latest version of the server so _prep_server_detail\ngetting the server again is an unnecessary performance hit.\n\nShowServer is pretty obvious here. For RebuildServer, the\ncompute API actually refreshes the server before returning\nit in the response, so the client already gets the latest\nwhen the rebuild call returns.\n\nThe only other usage of _prep_server_detail that does require\na refresh is CreateServer since the POST /servers response is\na minimal version of the server object.\n\nThis adds a new refresh kwarg, backward compatible by default,\nto _prep_server_detail but changes ShowServer and RebuildServer\nto no longer refresh.\n\nChange-Id: Ib1c9c424ed1cafc2dfd8be90af8de8a774bdfbf0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/752a2db332780ac98c4a4c3a3778b178131a8d59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/752a2db332780ac98c4a4c3a3778b178131a8d59"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}