)]}'
{"doc/source/cli/command-objects/volume.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e0d9a190e30ba9b56dcf816bf9cc07e1f247099","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    New volume state"},{"line_number":348,"context_line":"    (\"available\", \"error\", \"creating\", \"deleting\", \"in-use\","},{"line_number":349,"context_line":"    \"attaching\", \"detaching\", \"error_deleting\" or \"maintenance\") (admin only)"},{"line_number":350,"context_line":"    (This option simply changes the state of the volume in the database with"},{"line_number":351,"context_line":"    no regard to actual status, exercise caution when using)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_410aea89","line":349,"updated":"2018-06-12 14:43:16.000000000","message":"isn\u0027t that what this command is doing? \n\nedit: ah, i see what\u0027s going on ...","commit_id":"ee73943b97fb6557d0acf432d6196f64e89b1f56"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"3fa3ee371c81a1680506d1a47e4a865722d402eb","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    *Volume version 2 only*"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":".. option:: --attach-status \u003cattach-status\u003e"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    New volume attach state"},{"line_number":358,"context_line":"    (\"attached\" or \"detached\") (admin only)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_d609e2db","line":355,"range":{"start_line":355,"start_character":29,"end_line":355,"end_character":42},"updated":"2018-07-13 14:39:15.000000000","message":"Especially when there are two complementary states we prefer to use distinct boolean options, in this case:\n\n --attach | --detatch\n\nAnd yes, had I seen the --state above I\u0027d have said the same thing there, possibly with the out of","commit_id":"7ea6b15bfc976c1974bd7d2f2e37b256cc95d66b"}],"openstackclient/tests/unit/volume/v2/test_volume.py":[{"author":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"change_message_id":"ba7921c97d6ab35b4f945cd2a4d05a5bec306ab0","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":1499,"context_line":"        self.volumes_mock.reset_state.assert_called_with("},{"line_number":1500,"context_line":"            self.new_volume.id, None, attach_status\u003d\u0027detached\u0027)"},{"line_number":1501,"context_line":"        self.assertIsNone(result)"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"    def test_volume_set_bootable(self):"},{"line_number":1504,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_27b2994b","line":1501,"updated":"2018-07-04 09:02:24.000000000","message":"I\u0027d like to see a test for \"attached\"","commit_id":"7017abf3a11e960bd43a96b272e5ddd7b965d189"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2e0d9a190e30ba9b56dcf816bf9cc07e1f247099","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            except Exception as e:"},{"line_number":648,"context_line":"                LOG.error(_(\"Failed to set image property: %s\"), e)"},{"line_number":649,"context_line":"                result +\u003d 1"},{"line_number":650,"context_line":"        if parsed_args.state or parsed_args.attach_status:"},{"line_number":651,"context_line":"            try:"},{"line_number":652,"context_line":"                volume_client.volumes.reset_state("},{"line_number":653,"context_line":"                    volume.id, parsed_args.state,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_412f4af5","line":650,"updated":"2018-06-12 14:43:16.000000000","message":"i think you need to break these out.","commit_id":"ee73943b97fb6557d0acf432d6196f64e89b1f56"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"1fc9cf0bf7e568ca76c5042cceae914b5053b7f8","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            except Exception as e:"},{"line_number":648,"context_line":"                LOG.error(_(\"Failed to set image property: %s\"), e)"},{"line_number":649,"context_line":"                result +\u003d 1"},{"line_number":650,"context_line":"        if parsed_args.state or parsed_args.attach_status:"},{"line_number":651,"context_line":"            try:"},{"line_number":652,"context_line":"                volume_client.volumes.reset_state("},{"line_number":653,"context_line":"                    volume.id, parsed_args.state,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fc595dfc","line":650,"in_reply_to":"5f7c97a3_412f4af5","updated":"2018-06-12 15:00:22.000000000","message":"According to the Cinder API, if any of those values are \"None\", then nothing will happen","commit_id":"ee73943b97fb6557d0acf432d6196f64e89b1f56"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"1fc9cf0bf7e568ca76c5042cceae914b5053b7f8","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                result +\u003d 1"},{"line_number":650,"context_line":"        if parsed_args.state or parsed_args.attach_status:"},{"line_number":651,"context_line":"            try:"},{"line_number":652,"context_line":"                volume_client.volumes.reset_state("},{"line_number":653,"context_line":"                    volume.id, parsed_args.state,"},{"line_number":654,"context_line":"                    attach_status\u003dparsed_args.attach_status)"},{"line_number":655,"context_line":"            except Exception as e:"},{"line_number":656,"context_line":"                LOG.error(_(\"Failed to set volume state: %s\"), e)"},{"line_number":657,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bc6f6590","line":654,"range":{"start_line":652,"start_character":0,"end_line":654,"end_character":60},"updated":"2018-06-12 15:00:22.000000000","message":"So this helps potentially avoiding 2 API calls.","commit_id":"ee73943b97fb6557d0acf432d6196f64e89b1f56"}]}