)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ebd555b65b4bf23176a3a51aaa82c8ec1afdd955","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanpuqing \u003cyanpq@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-13 05:38:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the argument when setting floating ip other properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When setting floating ip other properties, port argument is"},{"line_number":10,"context_line":"force to use."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_f87952fb","line":7,"updated":"2018-06-13 10:25:16.000000000","message":"\"Do not require port argument when updating floating IP\" would be clearer IMO.","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"85b290e657a3806f7b62fa3efa1243a27a6fe03d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanpuqing \u003cyanpq@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-13 05:38:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the argument when setting floating ip other properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When setting floating ip other properties, port argument is"},{"line_number":10,"context_line":"force to use."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_98fffe32","line":7,"in_reply_to":"5f7c97a3_f87952fb","updated":"2018-06-13 10:48:20.000000000","message":"Done","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"}],"openstackclient/network/v2/floating_ip.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ebd555b65b4bf23176a3a51aaa82c8ec1afdd955","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        parser.add_argument("},{"line_number":417,"context_line":"            \u0027floating_ip\u0027,"},{"line_number":418,"context_line":"            metavar\u003d\u0027\u003cfloating-ip\u003e\u0027,"},{"line_number":419,"context_line":"            help\u003d_(\"Floating IP to associate (IP address or ID)\"))"},{"line_number":420,"context_line":"        parser.add_argument("},{"line_number":421,"context_line":"            \u0027--port\u0027,"},{"line_number":422,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_78a3029f","line":419,"updated":"2018-06-13 10:25:16.000000000","message":"How about s/associate/update/ here? Or \"modify\" maybe.","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"85b290e657a3806f7b62fa3efa1243a27a6fe03d","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        parser.add_argument("},{"line_number":417,"context_line":"            \u0027floating_ip\u0027,"},{"line_number":418,"context_line":"            metavar\u003d\u0027\u003cfloating-ip\u003e\u0027,"},{"line_number":419,"context_line":"            help\u003d_(\"Floating IP to associate (IP address or ID)\"))"},{"line_number":420,"context_line":"        parser.add_argument("},{"line_number":421,"context_line":"            \u0027--port\u0027,"},{"line_number":422,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_38fa6a42","line":419,"in_reply_to":"5f7c97a3_78a3029f","updated":"2018-06-13 10:48:20.000000000","message":"Done","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cd64d11fb91eefeea22803418357189af561e4be","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        parser.add_argument("},{"line_number":421,"context_line":"            \u0027--port\u0027,"},{"line_number":422,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"},{"line_number":423,"context_line":"            required\u003dTrue,"},{"line_number":424,"context_line":"            help\u003d_(\"Associate the floating IP with port (name or ID)\")),"},{"line_number":425,"context_line":"        parser.add_argument("},{"line_number":426,"context_line":"            \u0027--fixed-ip-address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_256eba2b","side":"PARENT","line":423,"updated":"2018-06-13 15:35:12.000000000","message":"hmm, i don\u0027t recall why this is required... it shouldn\u0027t be required for lookup. I\u0027m assuming that if any regression happens on the client side the server side should toss up a helpful error.","commit_id":"f7e4d31820e797e0d374e7dfde1142373245ea87"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"e915310bae35d4315015ee5ce03ad4040eabdadf","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        parser.add_argument("},{"line_number":421,"context_line":"            \u0027--port\u0027,"},{"line_number":422,"context_line":"            metavar\u003d\u0027\u003cport\u003e\u0027,"},{"line_number":423,"context_line":"            required\u003dTrue,"},{"line_number":424,"context_line":"            help\u003d_(\"Associate the floating IP with port (name or ID)\")),"},{"line_number":425,"context_line":"        parser.add_argument("},{"line_number":426,"context_line":"            \u0027--fixed-ip-address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c217aeed","side":"PARENT","line":423,"in_reply_to":"5f7c97a3_256eba2b","updated":"2018-06-14 03:04:52.000000000","message":"I guess the \"set floating ip\" commmand is designed to associate IP with port at the very start...I\u0027m not sure, the patch created it.[1]\n[1]https://review.openstack.org/#/c/383025/","commit_id":"f7e4d31820e797e0d374e7dfde1142373245ea87"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"49cece72cf831585bd82c952c5eef21b09fdf258","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        if \u0027no_qos_policy\u0027 in parsed_args and parsed_args.no_qos_policy:"},{"line_number":467,"context_line":"            attrs[\u0027qos_policy_id\u0027] \u003d None"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        if attrs:"},{"line_number":470,"context_line":"            client.update_ip(obj, **attrs)"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_518f9c75","line":468,"updated":"2018-06-29 19:28:05.000000000","message":"Right, I guess somewhere around here we can check that port or fixed_ip_address has been passed and complain otherwise.  There\u0027s probably an example in one of the other networking files.","commit_id":"402c9a21b347509520be206e28ee7d0ef4004b92"}],"openstackclient/tests/unit/network/v2/test_floating_ip_network.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ebd555b65b4bf23176a3a51aaa82c8ec1afdd955","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        self.network.update_ip.assert_called_once_with("},{"line_number":748,"context_line":"            self.floating_ip, **attrs)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def test_port_and_qos_policy_option(self):"},{"line_number":751,"context_line":"        qos_policy \u003d network_fakes.FakeNetworkQosPolicy.create_one_qos_policy()"},{"line_number":752,"context_line":"        self.network.find_qos_policy \u003d mock.Mock(return_value\u003dqos_policy)"},{"line_number":753,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_38458ab4","line":750,"updated":"2018-06-13 10:25:16.000000000","message":"I guess you should remove the \"port_and_\" part of the test name if you remove the port parameters below.\n\nOr maybe leave this test unchanged and add a variant without the port setting?","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"85b290e657a3806f7b62fa3efa1243a27a6fe03d","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        self.network.update_ip.assert_called_once_with("},{"line_number":748,"context_line":"            self.floating_ip, **attrs)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def test_port_and_qos_policy_option(self):"},{"line_number":751,"context_line":"        qos_policy \u003d network_fakes.FakeNetworkQosPolicy.create_one_qos_policy()"},{"line_number":752,"context_line":"        self.network.find_qos_policy \u003d mock.Mock(return_value\u003dqos_policy)"},{"line_number":753,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_98729ee2","line":750,"in_reply_to":"5f7c97a3_38458ab4","updated":"2018-06-13 10:48:20.000000000","message":"Yes, I will add a variant, thanks.","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ebd555b65b4bf23176a3a51aaa82c8ec1afdd955","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        self.network.update_ip.assert_called_once_with("},{"line_number":773,"context_line":"            self.floating_ip, **attrs)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def test_port_and_no_qos_policy_option(self):"},{"line_number":776,"context_line":"        arglist \u003d ["},{"line_number":777,"context_line":"            \"--no-qos-policy\","},{"line_number":778,"context_line":"            self.floating_ip.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_584086a2","line":775,"updated":"2018-06-13 10:25:16.000000000","message":"Dito","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"85b290e657a3806f7b62fa3efa1243a27a6fe03d","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        self.network.update_ip.assert_called_once_with("},{"line_number":773,"context_line":"            self.floating_ip, **attrs)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def test_port_and_no_qos_policy_option(self):"},{"line_number":776,"context_line":"        arglist \u003d ["},{"line_number":777,"context_line":"            \"--no-qos-policy\","},{"line_number":778,"context_line":"            self.floating_ip.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_387d8ab1","line":775,"in_reply_to":"5f7c97a3_584086a2","updated":"2018-06-13 10:48:20.000000000","message":"Done","commit_id":"b5990b230fc7673a33a35000292e91c243afc05b"}]}