)]}'
{"id":"openstack%2Fpython-openstackclient~575057","triplet_id":"openstack%2Fpython-openstackclient~master~I908712c8913f32d3dd5fdfefe7347277d72f66de","project":"openstack/python-openstackclient","branch":"master","topic":"story/1751431","hashtags":[],"change_id":"I908712c8913f32d3dd5fdfefe7347277d72f66de","subject":"Do not require port argument when updating floating IP","status":"MERGED","created":"2018-06-13 09:39:16.000000000","updated":"2018-07-24 00:53:33.000000000","submitted":"2018-07-24 00:53:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"575057-1532393613400-1a302e5d","meta_rev_id":"1cad9011cfe5353c0ebd61c5014cd122029eb040","_number":575057,"virtual_id_number":575057,"owner":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"date":"2018-07-03 09:50:05.000000000","_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":2,"date":"2018-07-24 00:53:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2018-06-14 03:43:17.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2018-07-03 10:06:15.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2018-06-19 11:43:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},{"value":2,"date":"2018-07-23 21:37:32.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2018-07-03 19:22:58.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-06-27 00:25:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},{"value":1,"date":"2018-07-23 21:37:32.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-14 03:43:17.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-06-19 11:43:37.000000000","updated_by":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"reviewer":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"state":"REVIEWER"},{"updated":"2018-06-27 00:25:44.000000000","updated_by":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"reviewer":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"state":"REVIEWER"},{"updated":"2018-07-03 10:06:15.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2018-07-03 19:22:58.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2018-07-23 21:37:32.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-07-24 00:53:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f6deeea57bc4b98891508a488c5c802aec87846d","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-13 09:39:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ebd555b65b4bf23176a3a51aaa82c8ec1afdd955","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2018-06-13 10:25:16.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nThe patch is fine in general I think, just some minor ideas for optimization.","accounts_in_message":[],"_revision_number":1},{"id":"85b290e657a3806f7b62fa3efa1243a27a6fe03d","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-13 10:48:20.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"42c1672beb94bc7c0b970b3b1cab9c27beb6a072","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-13 10:50:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"893ed90f2e738c20c99bf63e18f6222a240b7584","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-13 12:33:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/2/check/openstack-tox-pep8/0aaac4a/ : SUCCESS in 6m 37s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/2/check/openstack-tox-py27/4b359dc/ : SUCCESS in 5m 43s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/2/check/openstack-tox-py35/d81152f/ : SUCCESS in 4m 50s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/2/check/build-openstack-sphinx-docs/cda4426/html/ : SUCCESS in 6m 04s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/2/check/legacy-tempest-dsvm-neutron-src/e46587c/ : SUCCESS in 1h 35m 01s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/2/check/openstackclient-check-plugins/c6f3c63/ : SUCCESS in 6m 31s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/2/check/osc-tox-py27-tips/04b3b7e/ : SUCCESS in 6m 43s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/2/check/osc-tox-py35-tips/b0a315c/ : SUCCESS in 7m 03s\n- osc-functional-devstack http://logs.openstack.org/57/575057/2/check/osc-functional-devstack/7abfbcd/ : FAILURE in 47m 17s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/2/check/osc-functional-devstack-tips/070eb6b/ : FAILURE in 50m 11s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/2/check/openstack-tox-lower-constraints/d8c4b6b/ : SUCCESS in 6m 26s","accounts_in_message":[],"_revision_number":2},{"id":"cd64d11fb91eefeea22803418357189af561e4be","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-06-13 15:35:12.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"744f20220350b9447166915920421d5b15823bf2","author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"date":"2018-06-14 00:40:37.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"c4346ac0361f24dcd7869f930c4303d0cfb6bafb","author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"date":"2018-06-14 00:44:35.000000000","message":"Patch Set 2: Code-Review-1\n\nIf this is acceptable, you also need to update the cli doc.","accounts_in_message":[],"_revision_number":2},{"id":"f687cd14d78751c027609ac7b272a2de7463d1e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-14 02:54:36.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/2/check/openstack-tox-pep8/6be9f71/ : SUCCESS in 5m 23s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/2/check/openstack-tox-py27/9de21f3/ : SUCCESS in 5m 15s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/2/check/openstack-tox-py35/1d2113e/ : SUCCESS in 5m 33s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/2/check/build-openstack-sphinx-docs/9ff6a5c/html/ : SUCCESS in 5m 21s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/2/check/legacy-tempest-dsvm-neutron-src/d830349/ : FAILURE in 1h 12m 19s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/2/check/openstackclient-check-plugins/fa1de46/ : SUCCESS in 5m 56s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/2/check/osc-tox-py27-tips/155bff5/ : SUCCESS in 6m 31s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/2/check/osc-tox-py35-tips/c7f1216/ : SUCCESS in 7m 30s\n- osc-functional-devstack http://logs.openstack.org/57/575057/2/check/osc-functional-devstack/572a2c0/ : FAILURE in 48m 04s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/2/check/osc-functional-devstack-tips/7680828/ : FAILURE in 52m 05s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/2/check/openstack-tox-lower-constraints/6a84d49/ : SUCCESS in 5m 52s","accounts_in_message":[],"_revision_number":2},{"id":"e915310bae35d4315015ee5ce03ad4040eabdadf","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-14 03:04:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6f83e3d859ea1976895707f42e0cd20dda421734","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-14 03:06:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a39622e27bb641c2ac1a2b086c1fa1d954de9843","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-06-14 03:43:17.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"30531b58e08250c3d8cf5a7cb75ada55e7ce37f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-14 04:46:10.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/3/check/openstack-tox-pep8/feb4460/ : SUCCESS in 5m 33s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/3/check/openstack-tox-py27/7fa4056/ : SUCCESS in 6m 43s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/3/check/openstack-tox-py35/0c00217/ : SUCCESS in 6m 59s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/3/check/build-openstack-sphinx-docs/91b2cb4/html/ : SUCCESS in 7m 33s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/3/check/legacy-tempest-dsvm-neutron-src/563276d/ : SUCCESS in 1h 26m 52s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/3/check/openstackclient-check-plugins/edc16cc/ : SUCCESS in 9m 58s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py27-tips/8ddd969/ : SUCCESS in 7m 12s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py35-tips/6c15694/ : SUCCESS in 7m 33s\n- osc-functional-devstack http://logs.openstack.org/57/575057/3/check/osc-functional-devstack/09616b2/ : FAILURE in 45m 19s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/3/check/osc-functional-devstack-tips/6d25807/ : FAILURE in 53m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/3/check/openstack-tox-lower-constraints/991daae/ : SUCCESS in 6m 13s","accounts_in_message":[],"_revision_number":3},{"id":"f36ba4090194744e0003d82cb6a29c96bdfc085f","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-14 06:01:28.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"880e2a4f21475ef5e8eea23becf00f58a4216ac5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-14 07:39:12.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/3/check/openstack-tox-pep8/4ff53f1/ : SUCCESS in 6m 57s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/3/check/openstack-tox-py27/7d947f1/ : SUCCESS in 5m 37s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/3/check/openstack-tox-py35/481659b/ : SUCCESS in 5m 48s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/3/check/build-openstack-sphinx-docs/1c6b6cd/html/ : SUCCESS in 6m 20s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/3/check/legacy-tempest-dsvm-neutron-src/c5bca21/ : FAILURE in 1h 29m 23s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/3/check/openstackclient-check-plugins/94e257e/ : SUCCESS in 7m 41s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py27-tips/9f3b746/ : SUCCESS in 6m 41s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py35-tips/c772bd5/ : SUCCESS in 7m 32s\n- osc-functional-devstack http://logs.openstack.org/57/575057/3/check/osc-functional-devstack/66ffd6b/ : FAILURE in 44m 31s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/3/check/osc-functional-devstack-tips/5b9bed1/ : FAILURE in 45m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/3/check/openstack-tox-lower-constraints/bf24dee/ : SUCCESS in 6m 14s","accounts_in_message":[],"_revision_number":3},{"id":"ddc9d50bef8b5e5d3aa8288ba0a9f27a095a2a94","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-15 01:53:39.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"123ed0ec4bd0779522a5927d7940aefc93e4282d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-15 04:49:06.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/3/check/openstack-tox-pep8/755dd80/ : SUCCESS in 7m 24s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/3/check/openstack-tox-py27/9c592fe/ : SUCCESS in 7m 18s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/3/check/openstack-tox-py35/34f3ccd/ : SUCCESS in 4m 49s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/3/check/build-openstack-sphinx-docs/c072483/html/ : SUCCESS in 6m 13s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/3/check/legacy-tempest-dsvm-neutron-src/194d8e5/ : SUCCESS in 1h 38m 33s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/3/check/openstackclient-check-plugins/298d458/ : SUCCESS in 6m 30s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py27-tips/4b1248e/ : SUCCESS in 6m 49s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py35-tips/6f58a6f/ : SUCCESS in 8m 30s\n- osc-functional-devstack http://logs.openstack.org/57/575057/3/check/osc-functional-devstack/d1ffc25/ : FAILURE in 47m 05s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/3/check/osc-functional-devstack-tips/cdce117/ : FAILURE in 40m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/3/check/openstack-tox-lower-constraints/21edc71/ : SUCCESS in 5m 56s","accounts_in_message":[],"_revision_number":3},{"id":"b3bccf17426830ec255950a2e7b2db93858b4d49","author":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"date":"2018-06-19 11:43:37.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"4801b0fbbbcdba54c42b316e8dede297f049051a","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2018-06-24 10:25:18.000000000","message":"Patch Set 3:\n\nrecheck volume type checks fixed","accounts_in_message":[],"_revision_number":3},{"id":"67432d2b45e5e10d9d019afb5335796cd73014e3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-24 11:48:05.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/3/check/openstack-tox-pep8/3f921a9/ : SUCCESS in 4m 51s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/3/check/openstack-tox-py27/7883657/ : SUCCESS in 3m 55s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/3/check/openstack-tox-py35/8b533a6/ : SUCCESS in 5m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/3/check/build-openstack-sphinx-docs/60890ec/html/ : SUCCESS in 4m 36s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/3/check/legacy-tempest-dsvm-neutron-src/7190cb5/ : SUCCESS in 1h 21m 09s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/3/check/openstackclient-check-plugins/765643d/ : SUCCESS in 6m 49s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py27-tips/d276d54/ : SUCCESS in 5m 10s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py35-tips/00fa627/ : SUCCESS in 5m 19s\n- osc-functional-devstack http://logs.openstack.org/57/575057/3/check/osc-functional-devstack/f8ee8db/ : FAILURE in 46m 12s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/3/check/osc-functional-devstack-tips/d51e9f7/ : FAILURE in 49m 19s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/3/check/openstack-tox-lower-constraints/6eeb131/ : SUCCESS in 5m 09s","accounts_in_message":[],"_revision_number":3},{"id":"1a2b164204ab15cb41b8a9ddc2d72c740b6b608e","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-25 01:42:54.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"bdf99158c1b9fde4190ff368c597abee8058f88b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-25 03:05:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/3/check/openstack-tox-pep8/c80634f/ : SUCCESS in 4m 53s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/3/check/openstack-tox-py27/7ed08af/ : SUCCESS in 5m 39s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/3/check/openstack-tox-py35/3c6b880/ : SUCCESS in 5m 51s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/3/check/build-openstack-sphinx-docs/574d6c0/html/ : SUCCESS in 5m 14s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/3/check/legacy-tempest-dsvm-neutron-src/0ffb2ac/ : SUCCESS in 1h 20m 22s\n- openstackclient-check-plugins http://logs.openstack.org/57/575057/3/check/openstackclient-check-plugins/d955f6a/ : SUCCESS in 6m 56s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py27-tips/3d699f3/ : SUCCESS in 5m 16s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/3/check/osc-tox-py35-tips/2743c27/ : SUCCESS in 7m 29s\n- osc-functional-devstack http://logs.openstack.org/57/575057/3/check/osc-functional-devstack/b7177be/ : SUCCESS in 39m 09s\n- osc-functional-devstack-tips http://logs.openstack.org/57/575057/3/check/osc-functional-devstack-tips/08d9586/ : SUCCESS in 46m 49s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/3/check/openstack-tox-lower-constraints/7bb3c60/ : SUCCESS in 6m 31s","accounts_in_message":[],"_revision_number":3},{"id":"9773fbe19e0e89a987b924f95c2c1d156f0252fa","author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"date":"2018-06-27 00:25:44.000000000","message":"Patch Set 3: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"c4f4c56994ae9f64618f1a13d26c8f7d50db1c01","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2018-06-27 14:30:53.000000000","message":"Patch Set 3:\n\nMy only issue with this patch is that *some* argument is required, for example:\n\n$ openstack floating ip set 172.24.4.7\n\nseems to be valid won\u0027t do anything, it requires one of the optional arguments.  although maybe there\u0027s an error generated in that case?","accounts_in_message":[],"_revision_number":3},{"id":"af3fc8e518e61289afe5102fc2c459d61d62ca66","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-06-28 15:37:05.000000000","message":"Patch Set 3: Code-Review-1\n\nThanks Brian, I was just wondering that myself.  We do have other commands that require an argument that we have to check and fast exit with a local error if there are none, that should be done here too.  We don\u0027t do this in argparse to keep the help text cleaner...in this case it might make sense though...","accounts_in_message":[],"_revision_number":3},{"id":"c8f82725cf46eaa266d38abd80a781cebc0d2a0d","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-06-29 11:45:14.000000000","message":"Patch Set 3:\n\n\u003e Thanks Brian, I was just wondering that myself.  We do have other\n \u003e commands that require an argument that we have to check and fast\n \u003e exit with a local error if there are none, that should be done here\n \u003e too.  We don\u0027t do this in argparse to keep the help text\n \u003e cleaner...in this case it might make sense though...\n\nYes, if you want use the command, you requires one of the optional arguments. I find some commands are so, when you loss all optional arguments, the command won\u0027t throw errors and won\u0027t do anything, such as \"unset floating ip\", so I think we should keep action of all related commands same or deal with the issue of all related commands.","accounts_in_message":[],"_revision_number":3},{"id":"49cece72cf831585bd82c952c5eef21b09fdf258","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2018-06-29 19:28:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"199a857bb70f927f44177f2e16c395e2095f9768","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-02 06:22:12.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n\nI tested some network resources, include network\\subnet\\port\\router\\security group\\floating ip\\network agent\\network flavor\\network log\\network qos policy, the problem happens all over the \"set\" command and \"unset\" command, I think we can deal with this problem uniformly in a new patch.","accounts_in_message":[],"_revision_number":3},{"id":"fd2a08bf8e2371736d8956afd34840161c6ad40e","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-03 09:50:05.000000000","message":"Patch Set 3:\n\nHello, Brian and Dean, There is a new patch for the problem that \"set\" and \"unset\" command won\u0027t do anything without all optional arguments.[1]\n[1] https://review.openstack.org/#/c/579515/","accounts_in_message":[],"_revision_number":3},{"id":"ae5dbe81d7e9ecaa73581261c00b9826a14e053d","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2018-07-03 10:06:15.000000000","message":"Patch Set 3: Code-Review+1\n\nI think it is a good idea to fix the behaviour with no arguments in a separate patch.","accounts_in_message":[],"_revision_number":3},{"id":"ba793c0b66d29c07bfa5762cf60bef9d0c4dad79","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2018-07-03 19:22:58.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"f351c7095ccc79c6122b6fd73150d7dba2ec7e0d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-07-23 21:37:32.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nok, we\u0027ll go with this with the cleanup review proposed","accounts_in_message":[],"_revision_number":3},{"id":"ceb0d2db6f8fa8e10eac8f48db4f4e8c8e0c4de6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-23 21:46:01.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"6ebc24ebca00468bd1bc27e438126a9f6063d4f5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 00:53:33.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/57/575057/3/gate/openstack-tox-pep8/9939093/ : SUCCESS in 7m 44s\n- openstack-tox-py27 http://logs.openstack.org/57/575057/3/gate/openstack-tox-py27/f74be2c/ : SUCCESS in 7m 58s\n- openstack-tox-py35 http://logs.openstack.org/57/575057/3/gate/openstack-tox-py35/f2dc1a6/ : SUCCESS in 7m 26s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/575057/3/gate/build-openstack-sphinx-docs/8273f1d/html/ : SUCCESS in 9m 05s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/57/575057/3/gate/legacy-tempest-dsvm-neutron-src/1ff216e/ : SUCCESS in 1h 48m 12s\n- osc-tox-py27-tips http://logs.openstack.org/57/575057/3/gate/osc-tox-py27-tips/b43e65c/ : SUCCESS in 9m 09s\n- osc-tox-py35-tips http://logs.openstack.org/57/575057/3/gate/osc-tox-py35-tips/bb89933/ : SUCCESS in 9m 10s\n- osc-functional-devstack http://logs.openstack.org/57/575057/3/gate/osc-functional-devstack/5548b3a/ : SUCCESS in 46m 33s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/575057/3/gate/openstack-tox-lower-constraints/c4ee533/ : SUCCESS in 7m 18s","accounts_in_message":[],"_revision_number":3},{"id":"e1785efaa60fa059e64086b9e1ec786096da54ab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 00:53:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"402c9a21b347509520be206e28ee7d0ef4004b92","revisions":{"b5990b230fc7673a33a35000292e91c243afc05b":{"kind":"REWORK","_number":1,"created":"2018-06-13 09:39:16.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/57/575057/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/575057/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/1"}}},"commit":{"parents":[{"commit":"f7e4d31820e797e0d374e7dfde1142373245ea87","subject":"Update command test for volume.v3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7e4d31820e797e0d374e7dfde1142373245ea87"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-06-13 09:21:53.000000000","tz":-240},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-06-13 09:38:54.000000000","tz":-240},"subject":"Modify the argument when setting floating ip other properties","message":"Modify the argument when setting floating ip other properties\n\nWhen setting floating ip other properties, port argument is\nforce to use.\nThe patch modifies the command, when setting floating ip other\nproperties, like tags, no need port argument.\n\nChange-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de\nStory: 1751431\nTask: 13865\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b5990b230fc7673a33a35000292e91c243afc05b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b5990b230fc7673a33a35000292e91c243afc05b"}]},"branch":"refs/heads/master"},"735c9b5c034aad97da15e45c4982ffe443c8b5b7":{"kind":"REWORK","_number":2,"created":"2018-06-13 10:50:52.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/57/575057/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/575057/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/2"}}},"commit":{"parents":[{"commit":"f7e4d31820e797e0d374e7dfde1142373245ea87","subject":"Update command test for volume.v3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7e4d31820e797e0d374e7dfde1142373245ea87"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-06-13 09:21:53.000000000","tz":-240},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-06-13 10:49:03.000000000","tz":-240},"subject":"Do not require port argument when updating floating IP","message":"Do not require port argument when updating floating IP\n\nWhen setting floating ip other properties, port argument is\nforce to use.\nThe patch modifies the command, when setting floating ip other\nproperties, like tags, no need port argument.\n\nChange-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de\nStory: 1751431\nTask: 13865\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/735c9b5c034aad97da15e45c4982ffe443c8b5b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/735c9b5c034aad97da15e45c4982ffe443c8b5b7"}]},"branch":"refs/heads/master"},"402c9a21b347509520be206e28ee7d0ef4004b92":{"kind":"REWORK","_number":3,"created":"2018-06-14 03:06:02.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/57/575057/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/575057/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/575057/3"}}},"commit":{"parents":[{"commit":"f7e4d31820e797e0d374e7dfde1142373245ea87","subject":"Update command test for volume.v3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7e4d31820e797e0d374e7dfde1142373245ea87"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-06-13 09:21:53.000000000","tz":-240},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-06-14 03:05:30.000000000","tz":-240},"subject":"Do not require port argument when updating floating IP","message":"Do not require port argument when updating floating IP\n\nWhen setting floating ip other properties, port argument is\nforce to use.\nThe patch modifies the command, when setting floating ip other\nproperties, like tags, no need port argument.\n\nChange-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de\nStory: 1751431\nTask: 13865\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/402c9a21b347509520be206e28ee7d0ef4004b92"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/402c9a21b347509520be206e28ee7d0ef4004b92"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}