)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b5d9d3cddda4eed019b24ce4bb3ba2a58b81a7ae","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            help\u003d_(\u0027Wait for rebuild to complete\u0027),"},{"line_number":1521,"context_line":"        )"},{"line_number":1522,"context_line":"        parser.add_argument("},{"line_number":1523,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1524,"context_line":"            action\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1525,"context_line":"            help\u003d_(\u0027Set the key pair name on the rebuilt instance\u0027),"},{"line_number":1526,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8dfc1e0d","line":1523,"updated":"2018-06-19 14:38:55.000000000","message":"name this argument `--key-pair-name` please.","commit_id":"7263b86132eb4f13e1bbe57aa892f70d9ddd8371"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b5d9d3cddda4eed019b24ce4bb3ba2a58b81a7ae","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"        )"},{"line_number":1522,"context_line":"        parser.add_argument("},{"line_number":1523,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1524,"context_line":"            action\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1525,"context_line":"            help\u003d_(\u0027Set the key pair name on the rebuilt instance\u0027),"},{"line_number":1526,"context_line":"        )"},{"line_number":1527,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_adff9afe","line":1524,"updated":"2018-06-19 14:38:55.000000000","message":"same","commit_id":"7263b86132eb4f13e1bbe57aa892f70d9ddd8371"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e730c72362074922a360ba340470be93d467529","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        server \u003d utils.find_resource("},{"line_number":1541,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        if parsed_args.key_name:"},{"line_number":1544,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.54\u0027):"},{"line_number":1545,"context_line":"                msg \u003d _(\u0027--os-compute-api-version 2.54 or later is required\u0027)"},{"line_number":1546,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"        # If parsed_args.image is not set, default to the currently used one."},{"line_number":1549,"context_line":"        image_id \u003d parsed_args.image or server.to_dict().get("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_153562a8","line":1546,"range":{"start_line":1543,"start_character":0,"end_line":1546,"end_character":50},"updated":"2018-06-20 10:34:24.000000000","message":"why cannot you try using a higher version in this case? I don\u0027t think we should expect the caller to force 2.54 for all calls.","commit_id":"2a188d917e92188004615fe3b39fd7dec34e4ece"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"265ac4f1d9369e2d63b4febc067fda66441d7d6d","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        server \u003d utils.find_resource("},{"line_number":1541,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        if parsed_args.key_name:"},{"line_number":1544,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.54\u0027):"},{"line_number":1545,"context_line":"                msg \u003d _(\u0027--os-compute-api-version 2.54 or later is required\u0027)"},{"line_number":1546,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"        # If parsed_args.image is not set, default to the currently used one."},{"line_number":1549,"context_line":"        image_id \u003d parsed_args.image or server.to_dict().get("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_55c75a65","line":1546,"range":{"start_line":1543,"start_character":0,"end_line":1546,"end_character":50},"in_reply_to":"5f7c97a3_153562a8","updated":"2018-06-20 10:45:26.000000000","message":"It\u0027s because of that the option key_name is added in compute API version 2.54. Reference is [1].\n\nOf course we don\u0027t expect the caller to force 2.54 for all calls, we just don\u0027t want them to use --key-name option in command \u0027openstack server rebuild\u0027 with os-compute-api-version less than 2.54 as the reason above. \n\n[1].https://developer.openstack.org/api-ref/compute/#rebuild-server-rebuild-action","commit_id":"2a188d917e92188004615fe3b39fd7dec34e4ece"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e97444c497f4906b273e5eae0f0e6d4c5d94644f","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        server \u003d utils.find_resource("},{"line_number":1541,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        if parsed_args.key_name:"},{"line_number":1544,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\u00272.54\u0027):"},{"line_number":1545,"context_line":"                msg \u003d _(\u0027--os-compute-api-version 2.54 or later is required\u0027)"},{"line_number":1546,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"        # If parsed_args.image is not set, default to the currently used one."},{"line_number":1549,"context_line":"        image_id \u003d parsed_args.image or server.to_dict().get("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_55aafa70","line":1546,"range":{"start_line":1543,"start_character":0,"end_line":1546,"end_character":50},"in_reply_to":"5f7c97a3_55c75a65","updated":"2018-06-20 10:49:11.000000000","message":"Well, this is not how microversions are supposed to be used. They should be set per call, not globally. In your case, if you need 2.54, you should request it (not the user/operator). Then there will be a clear exception if this version is not used.","commit_id":"2a188d917e92188004615fe3b39fd7dec34e4ece"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"703c868301673cf0c21566c0951270151b85ba1c","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1521,"context_line":"            help\u003d_(\u0027Wait for rebuild to complete\u0027),"},{"line_number":1522,"context_line":"        )"},{"line_number":1523,"context_line":"        parser.add_argument("},{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_a8c9ff51","line":1523,"updated":"2018-06-28 18:09:38.000000000","message":"python-novaclient\u0027s nova rebuild command also has a --key-unset option to allow unsetting the key name on the server during rebuild:\n\nhttps://github.com/openstack/python-novaclient/commit/bef67651042a3ce123222079a41461677f3f9df0#diff-195f8259a919a0b9126b2271fc1a435dR1797\n\nWe should mirror that capability here in OSC.","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"6ec3a37417c1ecbd55815c872d89a8e8b3adb532","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1521,"context_line":"            help\u003d_(\u0027Wait for rebuild to complete\u0027),"},{"line_number":1522,"context_line":"        )"},{"line_number":1523,"context_line":"        parser.add_argument("},{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_df75ee98","line":1523,"in_reply_to":"5f7c97a3_a8c9ff51","updated":"2018-06-30 13:27:40.000000000","message":"Done","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"703c868301673cf0c21566c0951270151b85ba1c","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""},{"line_number":1527,"context_line":"                   \"(Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027\"),"},{"line_number":1528,"context_line":"        )"},{"line_number":1529,"context_line":"        return parser"},{"line_number":1530,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_48c5cb5b","line":1527,"range":{"start_line":1527,"start_character":20,"end_line":1527,"end_character":21},"updated":"2018-06-28 18:09:38.000000000","message":"missing a space here","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"703c868301673cf0c21566c0951270151b85ba1c","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""},{"line_number":1527,"context_line":"                   \"(Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027\"),"},{"line_number":1528,"context_line":"        )"},{"line_number":1529,"context_line":"        return parser"},{"line_number":1530,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_a88d7f36","line":1527,"range":{"start_line":1527,"start_character":65,"end_line":1527,"end_character":66},"updated":"2018-06-28 18:09:38.000000000","message":"missing closing )","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"6ec3a37417c1ecbd55815c872d89a8e8b3adb532","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""},{"line_number":1527,"context_line":"                   \"(Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027\"),"},{"line_number":1528,"context_line":"        )"},{"line_number":1529,"context_line":"        return parser"},{"line_number":1530,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_696188d4","line":1527,"range":{"start_line":1527,"start_character":20,"end_line":1527,"end_character":21},"in_reply_to":"5f7c97a3_48c5cb5b","updated":"2018-06-30 13:27:40.000000000","message":"Done","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"6ec3a37417c1ecbd55815c872d89a8e8b3adb532","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""},{"line_number":1527,"context_line":"                   \"(Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027\"),"},{"line_number":1528,"context_line":"        )"},{"line_number":1529,"context_line":"        return parser"},{"line_number":1530,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_295b9022","line":1527,"range":{"start_line":1527,"start_character":65,"end_line":1527,"end_character":66},"in_reply_to":"5f7c97a3_a88d7f36","updated":"2018-06-30 13:27:40.000000000","message":"Done","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"703c868301673cf0c21566c0951270151b85ba1c","unresolved":false,"context_lines":[{"line_number":1554,"context_line":"        args \u003d ("},{"line_number":1555,"context_line":"            image,"},{"line_number":1556,"context_line":"            parsed_args.password,"},{"line_number":1557,"context_line":"            parsed_args.key_name"},{"line_number":1558,"context_line":"        )"},{"line_number":1559,"context_line":"        server \u003d server.rebuild(*args)"},{"line_number":1560,"context_line":"        if parsed_args.wait:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_88c76347","line":1557,"updated":"2018-06-28 18:09:38.000000000","message":"This was added to python-novaclient in 10.0.0:\n\nIe2a39bb29dd59c070adc94e79ea0f6473227a427\n\nSo lower-constraints in python-openstackclient should be updated to be at least 10.0.0:\n\nhttps://github.com/openstack/python-openstackclient/blob/master/lower-constraints.txt#L103\n\n--\n\nAlso, key_name has to be passed in as a kwarg since there is no named arg for it:\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L332\n\nSo this code likely doesn\u0027t work - has it been tested?","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"6ec3a37417c1ecbd55815c872d89a8e8b3adb532","unresolved":false,"context_lines":[{"line_number":1554,"context_line":"        args \u003d ("},{"line_number":1555,"context_line":"            image,"},{"line_number":1556,"context_line":"            parsed_args.password,"},{"line_number":1557,"context_line":"            parsed_args.key_name"},{"line_number":1558,"context_line":"        )"},{"line_number":1559,"context_line":"        server \u003d server.rebuild(*args)"},{"line_number":1560,"context_line":"        if parsed_args.wait:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_5f61ded3","line":1557,"in_reply_to":"5f7c97a3_88c76347","updated":"2018-06-30 13:27:40.000000000","message":"Done","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                   \u0027(repeat option to set multiple groups)\u0027),"},{"line_number":479,"context_line":"        )"},{"line_number":480,"context_line":"        parser.add_argument("},{"line_number":481,"context_line":"            \u0027--key-name\u0027,"},{"line_number":482,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":483,"context_line":"            help\u003d_(\u0027Keypair to inject into this server (optional extension)\u0027),"},{"line_number":484,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_755b7621","line":481,"updated":"2018-07-03 10:00:47.000000000","message":"We already have the \"--key-name\" argument to the server create command here, so I think it is preferrable to stay consistent with that, even though I agree that it would have been better to call it \"--keypair\" matching the set of \"keypair create/list/...\" commands. It would have been even better to call those \"key pair create\", matching other items like \"security group\" or \"floating ip\". But I guess it\u0027s too late for all that, it would be even more confusing to start replacements and deprecations now, I guess.","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"ed238cd295254a0df5ffe887925c9bea848fbd94","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                   \u0027(repeat option to set multiple groups)\u0027),"},{"line_number":479,"context_line":"        )"},{"line_number":480,"context_line":"        parser.add_argument("},{"line_number":481,"context_line":"            \u0027--key-name\u0027,"},{"line_number":482,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":483,"context_line":"            help\u003d_(\u0027Keypair to inject into this server (optional extension)\u0027),"},{"line_number":484,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_b907b717","line":481,"in_reply_to":"5f7c97a3_755b7621","updated":"2018-07-04 01:04:50.000000000","message":"Agree with that :)","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""},{"line_number":1527,"context_line":"                   \" Cannot be specified with the \u0027--key-unset\u0027 option.\""},{"line_number":1528,"context_line":"                   \" (Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027)\"),"},{"line_number":1529,"context_line":"        )"},{"line_number":1530,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_f8cbfba0","line":1527,"updated":"2018-07-03 10:00:47.000000000","message":"I think what you want to say here is that this option cannot be specified at the same time as the \"--key-unset/--no-key-pair\" option. How about putting them into an exclusive group, then?","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"ed238cd295254a0df5ffe887925c9bea848fbd94","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""},{"line_number":1527,"context_line":"                   \" Cannot be specified with the \u0027--key-unset\u0027 option.\""},{"line_number":1528,"context_line":"                   \" (Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027)\"),"},{"line_number":1529,"context_line":"        )"},{"line_number":1530,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_b95577fb","line":1527,"in_reply_to":"5f7c97a3_f8cbfba0","updated":"2018-07-04 01:04:50.000000000","message":"Like Matt said earlier, I mirrored option `--key-name` and \u0027--key-unset\u0027 of \u0027nova rebuild\u0027 command in python-novaclient [1]. So this one is OK with me. \n\n[1].https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L1808-L1821","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"                   \" (Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027)\"),"},{"line_number":1529,"context_line":"        )"},{"line_number":1530,"context_line":"        parser.add_argument("},{"line_number":1531,"context_line":"            \u0027--key-unset\u0027,"},{"line_number":1532,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1533,"context_line":"            default\u003dFalse,"},{"line_number":1534,"context_line":"            help\u003d_(\"Unset the key name of key pair on the rebuilt instance.\""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_98d9a785","line":1531,"updated":"2018-07-03 10:00:47.000000000","message":"What we use in other contexts would be \"--no-key-name\" instead, which I\u0027d prefer.","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"ed238cd295254a0df5ffe887925c9bea848fbd94","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"                   \" (Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027)\"),"},{"line_number":1529,"context_line":"        )"},{"line_number":1530,"context_line":"        parser.add_argument("},{"line_number":1531,"context_line":"            \u0027--key-unset\u0027,"},{"line_number":1532,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1533,"context_line":"            default\u003dFalse,"},{"line_number":1534,"context_line":"            help\u003d_(\"Unset the key name of key pair on the rebuilt instance.\""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_99699bc1","line":1531,"in_reply_to":"5f7c97a3_98d9a785","updated":"2018-07-04 01:04:50.000000000","message":"See above.","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1533,"context_line":"            default\u003dFalse,"},{"line_number":1534,"context_line":"            help\u003d_(\"Unset the key name of key pair on the rebuilt instance.\""},{"line_number":1535,"context_line":"                   \" Cannot be specified with the \u0027--key-name\u0027 option.\""},{"line_number":1536,"context_line":"                   \" (Supported by API versions \u00272.54\u0027 - \u00272.latest\u0027)\"),"},{"line_number":1537,"context_line":"        )"},{"line_number":1538,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_98c20786","line":1535,"updated":"2018-07-03 10:00:47.000000000","message":"See above.","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"            image,"},{"line_number":1574,"context_line":"            parsed_args.password,"},{"line_number":1575,"context_line":"        )"},{"line_number":1576,"context_line":"        server \u003d server.rebuild(*args, **kwargs)"},{"line_number":1577,"context_line":"        if parsed_args.wait:"},{"line_number":1578,"context_line":"            if utils.wait_for_status("},{"line_number":1579,"context_line":"                compute_client.servers.get,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_180277bb","line":1576,"updated":"2018-07-03 10:00:47.000000000","message":"I don\u0027t understand this part, why can\u0027t you just add \"**kwargs\" to the original call?","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"ed238cd295254a0df5ffe887925c9bea848fbd94","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"            image,"},{"line_number":1574,"context_line":"            parsed_args.password,"},{"line_number":1575,"context_line":"        )"},{"line_number":1576,"context_line":"        server \u003d server.rebuild(*args, **kwargs)"},{"line_number":1577,"context_line":"        if parsed_args.wait:"},{"line_number":1578,"context_line":"            if utils.wait_for_status("},{"line_number":1579,"context_line":"                compute_client.servers.get,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_d981534f","line":1576,"in_reply_to":"5f7c97a3_180277bb","updated":"2018-07-04 01:04:50.000000000","message":"OK, will do that. Thx.","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"fe9ed7e71dd118c5142e894ecbfc39dba5008f83","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"            image,"},{"line_number":1574,"context_line":"            parsed_args.password,"},{"line_number":1575,"context_line":"        )"},{"line_number":1576,"context_line":"        server \u003d server.rebuild(*args, **kwargs)"},{"line_number":1577,"context_line":"        if parsed_args.wait:"},{"line_number":1578,"context_line":"            if utils.wait_for_status("},{"line_number":1579,"context_line":"                compute_client.servers.get,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_54674aeb","line":1576,"in_reply_to":"5f7c97a3_d981534f","updated":"2018-07-04 02:12:22.000000000","message":"Done","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"df2a3e06796492bedcb625a348b81794a58e484d","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1521,"context_line":"            help\u003d_(\u0027Wait for rebuild to complete\u0027),"},{"line_number":1522,"context_line":"        )"},{"line_number":1523,"context_line":"        parser.add_argument("},{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_db61b012","line":1523,"range":{"start_line":1523,"start_character":0,"end_line":1523,"end_character":8},"updated":"2018-07-23 21:29:14.000000000","message":"These should be in an exclusive group for argparse to handle","commit_id":"d5e236ba2927f1ec8b038dc1c8da2a91e4c84aba"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"05ce304a27739123c304a7fe52d999fa3e123fe1","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1521,"context_line":"            help\u003d_(\u0027Wait for rebuild to complete\u0027),"},{"line_number":1522,"context_line":"        )"},{"line_number":1523,"context_line":"        parser.add_argument("},{"line_number":1524,"context_line":"            \u0027--key-name\u0027,"},{"line_number":1525,"context_line":"            metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1526,"context_line":"            help\u003d_(\"Set the key name of key pair on the rebuilt instance.\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_a81e835b","line":1523,"range":{"start_line":1523,"start_character":0,"end_line":1523,"end_character":8},"in_reply_to":"5f7c97a3_db61b012","updated":"2018-07-27 06:40:37.000000000","message":"Done","commit_id":"d5e236ba2927f1ec8b038dc1c8da2a91e4c84aba"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"            self.assertRaises(exceptions.CommandError,"},{"line_number":2512,"context_line":"                              self.cmd.take_action,"},{"line_number":2513,"context_line":"                              parsed_args)"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"class TestServerRemoveFixedIP(TestServer):"},{"line_number":2517,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_f8277b62","line":2514,"updated":"2018-07-03 10:00:47.000000000","message":"I think this is lacking a test for a working \"unset\" command.","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"fe9ed7e71dd118c5142e894ecbfc39dba5008f83","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"            self.assertRaises(exceptions.CommandError,"},{"line_number":2512,"context_line":"                              self.cmd.take_action,"},{"line_number":2513,"context_line":"                              parsed_args)"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"class TestServerRemoveFixedIP(TestServer):"},{"line_number":2517,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_145d5215","line":2514,"in_reply_to":"5f7c97a3_198b4b69","updated":"2018-07-04 02:12:22.000000000","message":"Done","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"ed238cd295254a0df5ffe887925c9bea848fbd94","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"            self.assertRaises(exceptions.CommandError,"},{"line_number":2512,"context_line":"                              self.cmd.take_action,"},{"line_number":2513,"context_line":"                              parsed_args)"},{"line_number":2514,"context_line":""},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"class TestServerRemoveFixedIP(TestServer):"},{"line_number":2517,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_198b4b69","line":2514,"in_reply_to":"5f7c97a3_f8277b62","updated":"2018-07-04 01:04:50.000000000","message":"Oops, sorry for missing that one.","commit_id":"fcdd200565c015564f745002313223611287840b"}],"releasenotes/notes/server-rebuild-with-keypair-name-83c1aa20db136d91.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"703c868301673cf0c21566c0951270151b85ba1c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--key-name`` option to ``server rebuild`` command to set keypair of"},{"line_number":4,"context_line":"    the server."},{"line_number":5,"context_line":"  - Noted that it is supported by API versions \u00272.54\u0027 - \u00272.latest\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_0827d320","line":5,"updated":"2018-06-28 18:09:38.000000000","message":"This shouldn\u0027t be a separate item in the features list of the release note - merge it into the same item above.","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"6ec3a37417c1ecbd55815c872d89a8e8b3adb532","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--key-name`` option to ``server rebuild`` command to set keypair of"},{"line_number":4,"context_line":"    the server."},{"line_number":5,"context_line":"  - Noted that it is supported by API versions \u00272.54\u0027 - \u00272.latest\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_3c0f5030","line":5,"in_reply_to":"5f7c97a3_0827d320","updated":"2018-06-30 13:27:40.000000000","message":"Done","commit_id":"20b1b3637d31b2d5b63dc8e909b2188f9c63347d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--key-name`` option to ``server rebuild`` command to set keypair of"},{"line_number":4,"context_line":"    the server. Noted that it is supported by --os-compute-api-version"},{"line_number":5,"context_line":"    \u00272.54\u0027 - \u00272.latest\u0027."},{"line_number":6,"context_line":"  - Add ``--key-unset`` option to ``server rebuild`` command to unset"},{"line_number":7,"context_line":"    keypair. Noted that it is supported by --os-compute-api-version"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_38bc13da","line":4,"updated":"2018-07-03 10:00:47.000000000","message":"Nit: s/Noted/Note/\n\nAlso it may be better to say \"requires version 2.54 or later\".","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"fe9ed7e71dd118c5142e894ecbfc39dba5008f83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--key-name`` option to ``server rebuild`` command to set keypair of"},{"line_number":4,"context_line":"    the server. Noted that it is supported by --os-compute-api-version"},{"line_number":5,"context_line":"    \u00272.54\u0027 - \u00272.latest\u0027."},{"line_number":6,"context_line":"  - Add ``--key-unset`` option to ``server rebuild`` command to unset"},{"line_number":7,"context_line":"    keypair. Noted that it is supported by --os-compute-api-version"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_345ace1d","line":4,"in_reply_to":"5f7c97a3_38bc13da","updated":"2018-07-04 02:12:22.000000000","message":"Done","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u00272.54\u0027 - \u00272.latest\u0027."},{"line_number":6,"context_line":"  - Add ``--key-unset`` option to ``server rebuild`` command to unset"},{"line_number":7,"context_line":"    keypair. Noted that it is supported by --os-compute-api-version"},{"line_number":8,"context_line":"    \u00272.54\u0027 - \u00272.latest\u0027."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_d8b2bf06","line":8,"updated":"2018-07-03 10:00:47.000000000","message":"Dito","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"fe9ed7e71dd118c5142e894ecbfc39dba5008f83","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u00272.54\u0027 - \u00272.latest\u0027."},{"line_number":6,"context_line":"  - Add ``--key-unset`` option to ``server rebuild`` command to unset"},{"line_number":7,"context_line":"    keypair. Noted that it is supported by --os-compute-api-version"},{"line_number":8,"context_line":"    \u00272.54\u0027 - \u00272.latest\u0027."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_d4983acd","line":8,"in_reply_to":"5f7c97a3_d8b2bf06","updated":"2018-07-04 02:12:22.000000000","message":"Done","commit_id":"fcdd200565c015564f745002313223611287840b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"df2a3e06796492bedcb625a348b81794a58e484d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add ``--key-name`` option to ``server rebuild`` command to set keypair of"},{"line_number":4,"context_line":"    the server. Note that it requires --os-compute-api-version 2.54 or later."},{"line_number":5,"context_line":"  - Add ``--key-unset`` option to ``server rebuild`` command to unset"},{"line_number":6,"context_line":"    keypair. Note that it requires --os-compute-api-version 2.54 or later."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5f7c97a3_5988476a","line":6,"updated":"2018-07-23 21:29:14.000000000","message":"Please add links to the storiy","commit_id":"d5e236ba2927f1ec8b038dc1c8da2a91e4c84aba"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"05ce304a27739123c304a7fe52d999fa3e123fe1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add ``--key-name`` option to ``server rebuild`` command to set keypair of"},{"line_number":4,"context_line":"    the server. Note that it requires --os-compute-api-version 2.54 or later."},{"line_number":5,"context_line":"  - Add ``--key-unset`` option to ``server rebuild`` command to unset"},{"line_number":6,"context_line":"    keypair. Note that it requires --os-compute-api-version 2.54 or later."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5f7c97a3_82084925","line":6,"in_reply_to":"5f7c97a3_5988476a","updated":"2018-07-27 06:40:37.000000000","message":"Sorry, I don\u0027t understand what you mean \"add links\" here. There is story link in the commit message.","commit_id":"d5e236ba2927f1ec8b038dc1c8da2a91e4c84aba"}],"requirements.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc5b93f7418f632f4835ed0f9414196a9d2ccfe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":14,"context_line":"python-glanceclient\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":15,"context_line":"python-keystoneclient\u003e\u003d3.15.0 # Apache-2.0"},{"line_number":16,"context_line":"python-novaclient\u003e\u003d10.0.0 # Apache-2.0"},{"line_number":17,"context_line":"python-cinderclient\u003e\u003d3.3.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":12,"id":"5f7c97a3_f8aa1b82","line":16,"updated":"2018-07-03 10:00:47.000000000","message":"Global lower-constraints still has 9.1.0, so I\u0027m not complete sure we can do this now.","commit_id":"fcdd200565c015564f745002313223611287840b"}]}