)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f5e0fa11289f0679133b3be3bbbb034329f95a1a","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            fixed_ip\u003dNone,"},{"line_number":369,"context_line":"        )"},{"line_number":370,"context_line":"        if parsed_args.tag:"},{"line_number":371,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\"2.49\"):"},{"line_number":372,"context_line":"                msg \u003d _(\"--os-compute-api-version 2.49 or later is required\")"},{"line_number":373,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":374,"context_line":"            kwargs[\u0027tag\u0027] \u003d parsed_args.tag"},{"line_number":375,"context_line":"        server.interface_attach(**kwargs)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_75a36401","line":373,"range":{"start_line":371,"start_character":12,"end_line":373,"end_character":50},"updated":"2020-09-18 15:01:25.000000000","message":"I\u0027m wondering whether we could be consumer friendly and have something the other way around: if --os-compute-api-version hasn\u0027t been specified, set it to 2.49 automatically","commit_id":"43c12eeba2d7ce1fa7f590eb32a57f6c43207473"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            \u0027--tag\u0027,"},{"line_number":346,"context_line":"            metavar\u003d\u0027\u003ctag\u003e\u0027,"},{"line_number":347,"context_line":"            help\u003d_(\"Tag for the attached interface. (Supported by API \""},{"line_number":348,"context_line":"                   \"versions \u00272.49\u0027 - \u00272.latest\u0027\")"},{"line_number":349,"context_line":"        )"},{"line_number":350,"context_line":"        return parser"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_24ca009f","line":348,"range":{"start_line":348,"start_character":48,"end_line":348,"end_character":49},"updated":"2020-10-12 10:37:48.000000000","message":"missing )","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            port_id\u003dport_id,"},{"line_number":367,"context_line":"            net_id\u003dNone,"},{"line_number":368,"context_line":"            fixed_ip\u003dNone,"},{"line_number":369,"context_line":"        )"},{"line_number":370,"context_line":"        if parsed_args.tag:"},{"line_number":371,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\"2.49\"):"},{"line_number":372,"context_line":"                msg \u003d _(\"--os-compute-api-version 2.49 or later is required\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e43808a0","line":369,"updated":"2020-10-12 10:37:48.000000000","message":"nit: could we use literals instead?","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        )"},{"line_number":370,"context_line":"        if parsed_args.tag:"},{"line_number":371,"context_line":"            if compute_client.api_version \u003c api_versions.APIVersion(\"2.49\"):"},{"line_number":372,"context_line":"                msg \u003d _(\"--os-compute-api-version 2.49 or later is required\")"},{"line_number":373,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":374,"context_line":"            kwargs[\u0027tag\u0027] \u003d parsed_args.tag"},{"line_number":375,"context_line":"        server.interface_attach(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a445709d","line":372,"range":{"start_line":372,"start_character":75,"end_line":372,"end_character":76},"updated":"2020-10-12 10:37:48.000000000","message":"required for what? (to use the --tag option)","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"}],"openstackclient/tests/unit/compute/v2/test_server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        self._test_server_add_port(\u0027fake-port\u0027)"},{"line_number":467,"context_line":"        self.find_port.assert_not_called()"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def test_server_add_port_with_tag_api_newer(self):"},{"line_number":470,"context_line":"        servers \u003d self.setup_servers_mock(count\u003d1)"},{"line_number":471,"context_line":"        self.find_port.return_value.id \u003d \u0027fake-port\u0027"},{"line_number":472,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_04effc86","line":469,"range":{"start_line":469,"start_character":37,"end_line":469,"end_character":47},"updated":"2020-10-12 10:37:48.000000000","message":"nit: drop this?","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            (\u0027tag\u0027, \u0027tag1\u0027),"},{"line_number":481,"context_line":"        ]"},{"line_number":482,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":483,"context_line":"        self.app.client_manager.compute.api_version \u003d 2.49"},{"line_number":484,"context_line":"        with mock.patch.object(api_versions,"},{"line_number":485,"context_line":"                               \u0027APIVersion\u0027,"},{"line_number":486,"context_line":"                               return_value\u003d2.49):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_24cfa028","line":483,"range":{"start_line":483,"start_character":54,"end_line":483,"end_character":58},"updated":"2020-10-12 10:37:48.000000000","message":"If you return an APIVersion from this, you don\u0027t need the mock below.","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        )"},{"line_number":495,"context_line":"        self.assertIsNone(result)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def test_server_add_port_with_tag_api_older(self):"},{"line_number":498,"context_line":"        servers \u003d self.setup_servers_mock(count\u003d1)"},{"line_number":499,"context_line":"        self.find_port.return_value.id \u003d \u0027fake-port\u0027"},{"line_number":500,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e4f1286c","line":497,"range":{"start_line":497,"start_character":37,"end_line":497,"end_character":47},"updated":"2020-10-12 10:37:48.000000000","message":"_pre_v249","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"542a44eecb84fe00c4b1591403464c2a011fae22","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            (\u0027tag\u0027, \u0027tag1\u0027),"},{"line_number":509,"context_line":"        ]"},{"line_number":510,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":511,"context_line":"        self.app.client_manager.compute.api_version \u003d 2.48"},{"line_number":512,"context_line":"        with mock.patch.object(api_versions,"},{"line_number":513,"context_line":"                               \u0027APIVersion\u0027,"},{"line_number":514,"context_line":"                               return_value\u003d2.49):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_84d94cf5","line":511,"updated":"2020-10-12 10:37:48.000000000","message":"Ditto","commit_id":"8d23853a95a19f19d4f79b3da01bf2fad88be4a6"}]}