)]}'
{"id":"openstack%2Fpython-openstackclient~582334","triplet_id":"openstack%2Fpython-openstackclient~master~I1bbdd33be96d82422a05982508e370237c3560f3","project":"openstack/python-openstackclient","branch":"master","topic":"582334","hashtags":[],"change_id":"I1bbdd33be96d82422a05982508e370237c3560f3","subject":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24","status":"MERGED","created":"2018-07-12 18:37:41.000000000","updated":"2019-05-01 19:24:15.000000000","submitted":"2018-07-25 19:31:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"582334-1532547095294-1a302e5d","meta_rev_id":"a2b243f9946d222126c38cf86b2aebeca58fadf3","_number":582334,"virtual_id_number":582334,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-07-25 01:19:35.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2018-07-25 19:31:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":2,"date":"2018-07-25 17:49:10.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},{"value":2,"date":"2018-07-25 03:20:21.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":1,"date":"2018-07-25 17:49:10.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-19 11:17:56.000000000","updated_by":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"reviewer":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"state":"REVIEWER"},{"updated":"2018-07-25 03:20:21.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-07-25 17:49:10.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2018-07-25 19:31:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8ad765fa3a10851cffa08f07741a97d20a5d4490","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-12 18:37:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e345c78b227d0219a39a0862c05f866caf428afd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 22:17:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/1/check/openstack-tox-pep8/ad490ac/ : FAILURE in 5m 27s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/1/check/openstack-tox-py27/cc04b89/ : FAILURE in 9m 04s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/1/check/openstack-tox-py35/8d19250/ : FAILURE in 8m 22s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/1/check/build-openstack-sphinx-docs/82a6f1a/html/ : SUCCESS in 5m 24s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/1/check/legacy-tempest-dsvm-neutron-src/c8714d3/ : SUCCESS in 1h 47m 16s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/1/check/openstackclient-check-plugins/3e150da/ : SUCCESS in 8m 46s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/1/check/osc-tox-py27-tips/11bda73/ : FAILURE in 6m 08s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/1/check/osc-tox-py35-tips/75b33b0/ : FAILURE in 6m 33s\n- osc-functional-devstack http://logs.openstack.org/34/582334/1/check/osc-functional-devstack/c5d13db/ : SUCCESS in 56m 21s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/1/check/osc-functional-devstack-tips/d278a79/ : SUCCESS in 52m 24s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/1/check/openstack-tox-lower-constraints/7e780a8/ : FAILURE in 5m 07s","accounts_in_message":[],"_revision_number":1},{"id":"76016ac4b2e944aabcebfc9d8f1606cef71b6d10","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-13 14:28:37.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"76ac10ec42df89fde873858f05a1e3379bdd08a2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-13 16:18:26.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/1/check/openstack-tox-pep8/ef62a9f/ : FAILURE in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/1/check/openstack-tox-py27/a8aed46/ : FAILURE in 6m 28s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/1/check/openstack-tox-py35/e62bc48/ : FAILURE in 6m 52s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/1/check/build-openstack-sphinx-docs/77ba9ed/html/ : SUCCESS in 7m 09s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/1/check/legacy-tempest-dsvm-neutron-src/3c46b47/ : SUCCESS in 1h 22m 38s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/1/check/openstackclient-check-plugins/934bf96/ : SUCCESS in 9m 26s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/1/check/osc-tox-py27-tips/ac9a8f5/ : FAILURE in 5m 45s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/1/check/osc-tox-py35-tips/f2c824b/ : FAILURE in 7m 42s\n- osc-functional-devstack http://logs.openstack.org/34/582334/1/check/osc-functional-devstack/f7f5feb/ : SUCCESS in 50m 08s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/1/check/osc-functional-devstack-tips/773ebbb/ : FAILURE in 51m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/1/check/openstack-tox-lower-constraints/853b658/ : FAILURE in 5m 05s","accounts_in_message":[],"_revision_number":1},{"id":"876589af88d9043ec638976657fce7badaf3f98a","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-16 20:02:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3014eb5696afcdecb0b86ef7ed7a8318bf628acc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 23:41:47.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/2/check/openstack-tox-pep8/ed159ca/ : SUCCESS in 6m 40s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/2/check/openstack-tox-py27/4fa4539/ : SUCCESS in 6m 08s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/2/check/openstack-tox-py35/10952be/ : SUCCESS in 6m 03s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/2/check/build-openstack-sphinx-docs/0181287/html/ : SUCCESS in 6m 01s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/2/check/legacy-tempest-dsvm-neutron-src/7a726ba/ : SUCCESS in 1h 34m 25s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/2/check/openstackclient-check-plugins/9e6bafb/ : SUCCESS in 7m 17s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/2/check/osc-tox-py27-tips/48f8976/ : SUCCESS in 8m 19s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/2/check/osc-tox-py35-tips/e39baf6/ : SUCCESS in 6m 30s\n- osc-functional-devstack http://logs.openstack.org/34/582334/2/check/osc-functional-devstack/fc6d3b3/ : SUCCESS in 46m 39s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/2/check/osc-functional-devstack-tips/8760c3e/ : FAILURE in 43m 54s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/2/check/openstack-tox-lower-constraints/83559e7/ : SUCCESS in 6m 35s","accounts_in_message":[],"_revision_number":2},{"id":"174f69b0ec3464cc2e4180eb80d811db0c5e5f10","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-18 16:11:34.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"f4867f3bc2625d2c1005037f26457f1b00947c4f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-18 18:15:29.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/2/check/openstack-tox-pep8/918876f/ : SUCCESS in 5m 49s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/2/check/openstack-tox-py27/e83abb6/ : SUCCESS in 5m 17s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/2/check/openstack-tox-py35/49bb54d/ : SUCCESS in 5m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/2/check/build-openstack-sphinx-docs/e41a0c3/html/ : SUCCESS in 6m 00s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/2/check/legacy-tempest-dsvm-neutron-src/cecda97/ : SUCCESS in 1h 36m 34s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/2/check/openstackclient-check-plugins/086b552/ : SUCCESS in 7m 32s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/2/check/osc-tox-py27-tips/f66d35b/ : SUCCESS in 5m 44s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/2/check/osc-tox-py35-tips/0731669/ : SUCCESS in 7m 40s\n- osc-functional-devstack http://logs.openstack.org/34/582334/2/check/osc-functional-devstack/c573897/ : FAILURE in 48m 35s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/2/check/osc-functional-devstack-tips/9bddd49/ : FAILURE in 50m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/2/check/openstack-tox-lower-constraints/63f1967/ : SUCCESS in 7m 25s","accounts_in_message":[],"_revision_number":2},{"id":"5077b72cf34e00163d2c667a54f1d0a6f6791c32","author":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"date":"2018-07-19 11:17:56.000000000","message":"Patch Set 2: Code-Review-1\n\nmaybe you need to add a test for api_version \u003c 2.24","accounts_in_message":[],"_revision_number":2},{"id":"3399f0fe4a32459123ab410551bbc7427be52a73","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-19 13:21:58.000000000","message":"Patch Set 2:\n\n\u003e maybe you need to add a test for api_version \u003c 2.24\n\nThe first few changes in openstackclient/tests/unit/compute/v2/test_server.py are just that - modifying existing tests to use version 2.24 to make sure they send disk_over_commit and pass.","accounts_in_message":[],"_revision_number":2},{"id":"b31d8dc8a6d5d6d5d72f29d6c9b216a1058dea17","author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"date":"2018-07-24 05:54:33.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"26466f1dc2b531a5f716bb68a648e96ec3ecaf6f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 07:44:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/3/check/openstack-tox-pep8/81cef27/ : SUCCESS in 6m 16s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/3/check/openstack-tox-py27/df484f6/ : SUCCESS in 5m 27s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/3/check/openstack-tox-py35/a561f8a/ : SUCCESS in 5m 00s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/3/check/build-openstack-sphinx-docs/7744da4/html/ : SUCCESS in 7m 00s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/3/check/legacy-tempest-dsvm-neutron-src/111b66d/ : SUCCESS in 1h 42m 32s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/3/check/openstackclient-check-plugins/00ecb1e/ : SUCCESS in 9m 07s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/3/check/osc-tox-py27-tips/039bbae/ : SUCCESS in 6m 10s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/3/check/osc-tox-py35-tips/f7ce9a5/ : SUCCESS in 7m 06s\n- osc-functional-devstack http://logs.openstack.org/34/582334/3/check/osc-functional-devstack/0f62e24/ : SUCCESS in 43m 31s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/3/check/osc-functional-devstack-tips/5d00dbb/ : SUCCESS in 50m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/3/check/openstack-tox-lower-constraints/9da0b22/ : SUCCESS in 5m 16s","accounts_in_message":[],"_revision_number":3},{"id":"5a80e0821e1434dc468df57d9b1878ccda143564","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-24 15:09:50.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"f7dde70eab5dabba704722e5ec39663f9ede7ea4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 17:41:31.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/4/check/openstack-tox-pep8/2a1eea2/ : SUCCESS in 7m 49s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/4/check/openstack-tox-py27/793dd39/ : SUCCESS in 5m 23s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/4/check/openstack-tox-py35/41e6c9d/ : SUCCESS in 5m 41s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/4/check/build-openstack-sphinx-docs/472f9c8/html/ : SUCCESS in 7m 59s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/4/check/legacy-tempest-dsvm-neutron-src/b79d7bd/ : SUCCESS in 1h 30m 59s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/4/check/openstackclient-check-plugins/d20cf9e/ : SUCCESS in 8m 12s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/4/check/osc-tox-py27-tips/10bb148/ : SUCCESS in 9m 29s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/4/check/osc-tox-py35-tips/8d48768/ : SUCCESS in 7m 10s\n- osc-functional-devstack http://logs.openstack.org/34/582334/4/check/osc-functional-devstack/13e89a4/ : SUCCESS in 51m 55s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/4/check/osc-functional-devstack-tips/675a60a/ : FAILURE in 56m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/4/check/openstack-tox-lower-constraints/1d18cb1/ : SUCCESS in 5m 50s","accounts_in_message":[],"_revision_number":4},{"id":"820cdc76d742539582736f0f665c9def12e39645","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-24 18:37:18.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"77644de837a025ba652b014300742a8fb99a8557","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-24 21:51:46.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/4/check/openstack-tox-pep8/70cd17b/ : SUCCESS in 5m 33s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/4/check/openstack-tox-py27/54a7c05/ : SUCCESS in 5m 38s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/4/check/openstack-tox-py35/4a8869d/ : SUCCESS in 5m 59s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/4/check/build-openstack-sphinx-docs/818add1/html/ : SUCCESS in 6m 21s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/4/check/legacy-tempest-dsvm-neutron-src/e1e24a4/ : SUCCESS in 1h 25m 18s\n- openstackclient-check-plugins http://logs.openstack.org/34/582334/4/check/openstackclient-check-plugins/48b8e2c/ : SUCCESS in 7m 45s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/4/check/osc-tox-py27-tips/e54d7a4/ : SUCCESS in 9m 03s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/4/check/osc-tox-py35-tips/e78fd08/ : SUCCESS in 7m 44s\n- osc-functional-devstack http://logs.openstack.org/34/582334/4/check/osc-functional-devstack/7cee884/ : SUCCESS in 41m 02s\n- osc-functional-devstack-tips http://logs.openstack.org/34/582334/4/check/osc-functional-devstack-tips/81fe0a4/ : SUCCESS in 42m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/4/check/openstack-tox-lower-constraints/9f355c9/ : SUCCESS in 7m 19s","accounts_in_message":[],"_revision_number":4},{"id":"acdeaa71315c4d48af9c1bef5fb3895906f18eb1","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-24 23:09:58.000000000","message":"Patch Set 4: Code-Review+1\n\nThis looks fine - but I\u0027m only giving a +1 because there is actually a much bigger story here. See:\n\nhttps://review.openstack.org/#/c/578960/8/openstack/compute/v2/server.py\n\nWe just landed all of that (with mriedem\u0027s help/feedback) in SDK this cycle. I wonder if we should either move in an equiv amount of logic here - or just make a patch to make this live migrate bit use the sdk method. It looks like we\u0027d need to expose the disk_over_commit parameter there, but that shouldnt\u0027 be hard.\n\nPerhaps land this this cycle and then early next cycle get the disk_over_commit in to sdk for older clouds and port this method over?","accounts_in_message":[],"_revision_number":4},{"id":"370ca85ab935817101effff2165a00a7e4015f55","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-25 00:22:31.000000000","message":"Patch Set 4:\n\n\u003e We just landed all of that (with mriedem\u0027s help/feedback) in SDK\n \u003e this cycle. I wonder if we should either move in an equiv amount of\n \u003e logic here - or just make a patch to make this live migrate bit use\n \u003e the sdk method. It looks like we\u0027d need to expose the\n \u003e disk_over_commit parameter there, but that shouldnt\u0027 be hard.\n \u003e \n \u003e Perhaps land this this cycle and then early next cycle get the\n \u003e disk_over_commit in to sdk for older clouds and port this method\n \u003e over?\n\nI think landing this in osc is a good idea, since it\u0027s an easy win to fix a real bug. However, there should definitely be a follow up to fix openstacksdk. I\u0027m not sure what the plan is for the conversion of osc to use the sdk, but I\u0027m assuming the live migration part of what will happen regardless?","accounts_in_message":[],"_revision_number":4},{"id":"9c8eaac5106615118c178ac2b43eadabae26ac4b","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2018-07-25 01:19:35.000000000","message":"Patch Set 4:\n\nHere\u0027s a first whack at the openstacksdk patch: https://review.openstack.org/#/c/585579/","accounts_in_message":[],"_revision_number":4},{"id":"9194840e667322e1f4c31d463287f2e6624412be","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-07-25 03:20:21.000000000","message":"Patch Set 4: Code-Review+2\n\nWe have a number of microversion-related things happening in the compute commands now, none of them are quite right in how they handle discovery because OSC just isn\u0027t wired correctly for that yet, we can fix them up soon, with SDK 1.0.\n\nOnce we have that release we will start converting OSC in some yet-to-be-determined priority to use it, I suspect microversion-related things will happen sooner than others...","accounts_in_message":[],"_revision_number":4},{"id":"35ecdbf1c8b0c9f0d19b1258e90d9b435340eaa1","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-25 17:49:10.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"72050937f8e426bf446d2caf4a7a96b9cf517665","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 17:49:24.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"ccf25496ac6d3bfd78590fdafb3c933f56e692c6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 19:31:35.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/582334/4/gate/openstack-tox-pep8/8ee43dd/ : SUCCESS in 7m 20s\n- openstack-tox-py27 http://logs.openstack.org/34/582334/4/gate/openstack-tox-py27/ec9723f/ : SUCCESS in 7m 11s\n- openstack-tox-py35 http://logs.openstack.org/34/582334/4/gate/openstack-tox-py35/44ac2f4/ : SUCCESS in 7m 31s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/582334/4/gate/build-openstack-sphinx-docs/c000dd9/html/ : SUCCESS in 6m 44s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/582334/4/gate/legacy-tempest-dsvm-neutron-src/e140f9c/ : SUCCESS in 1h 35m 38s\n- osc-tox-py27-tips http://logs.openstack.org/34/582334/4/gate/osc-tox-py27-tips/fd9e381/ : SUCCESS in 7m 16s\n- osc-tox-py35-tips http://logs.openstack.org/34/582334/4/gate/osc-tox-py35-tips/4c6d4d1/ : SUCCESS in 7m 51s\n- osc-functional-devstack http://logs.openstack.org/34/582334/4/gate/osc-functional-devstack/17762ad/ : SUCCESS in 45m 23s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/582334/4/gate/openstack-tox-lower-constraints/d67b8da/ : SUCCESS in 5m 46s","accounts_in_message":[],"_revision_number":4},{"id":"88c33d53cc08fba23bb84e4b51411f9d704792fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 19:31:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"380b48ec879a8c57d177415ab765a7d97fff522b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-01 19:24:15.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"d6121782d3aa6a95b883220b27a154e641b61f7f","revisions":{"a5ae1fee17cbe86c6e12b545681bc9d9a43d4ff6":{"kind":"REWORK","_number":1,"created":"2018-07-12 18:37:41.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/34/582334/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/34/582334/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/1"}}},"commit":{"parents":[{"commit":"e4bbc3ce4d8f38a2669be79d70d1384a56a91f10","subject":"Merge \"Skip calls to glance and nova when got no servers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e4bbc3ce4d8f38a2669be79d70d1384a56a91f10"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-12 18:34:51.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-12 18:34:51.000000000","tz":-240},"subject":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24","message":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24\n\nIn API microversion 2.25 Nova removed the disk_over_commit parameter\nto the live migration server action. This patch makes sure that we\ndon\u0027t include it in our request if we\u0027re running with 2.25 or higher.\n\nChange-Id: I1bbdd33be96d82422a05982508e370237c3560f3\nStory: #2002963\nTask: #22966\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a5ae1fee17cbe86c6e12b545681bc9d9a43d4ff6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a5ae1fee17cbe86c6e12b545681bc9d9a43d4ff6"}]},"branch":"refs/heads/master"},"58c2389e6e56701e18351c4e95427e0633aa89c3":{"kind":"REWORK","_number":2,"created":"2018-07-16 20:02:57.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/34/582334/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/34/582334/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/2"}}},"commit":{"parents":[{"commit":"e4bbc3ce4d8f38a2669be79d70d1384a56a91f10","subject":"Merge \"Skip calls to glance and nova when got no servers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e4bbc3ce4d8f38a2669be79d70d1384a56a91f10"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-12 18:34:51.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-16 20:02:30.000000000","tz":-240},"subject":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24","message":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24\n\nIn API microversion 2.25 Nova removed the disk_over_commit parameter\nto the live migration server action. This patch makes sure that we\ndon\u0027t include it in our request if we\u0027re running with 2.25 or higher.\n\nChange-Id: I1bbdd33be96d82422a05982508e370237c3560f3\nStory: #2002963\nTask: #22966\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/58c2389e6e56701e18351c4e95427e0633aa89c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/58c2389e6e56701e18351c4e95427e0633aa89c3"}]},"branch":"refs/heads/master"},"3283cebb1efa2e1d12c537011d8efb453280a455":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-07-24 05:54:33.000000000","uploader":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"ref":"refs/changes/34/582334/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/34/582334/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/3"}}},"commit":{"parents":[{"commit":"00194b4e208cfb2be606f4d436166ccd3bc75cdc","subject":"Merge \"Do not require port argument when updating floating IP\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/00194b4e208cfb2be606f4d436166ccd3bc75cdc"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-12 18:34:51.000000000","tz":-240},"committer":{"name":"Josephine Seifert","email":"josephine.seifert@secustack.com","date":"2018-07-24 05:54:33.000000000","tz":0},"subject":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24","message":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24\n\nIn API microversion 2.25 Nova removed the disk_over_commit parameter\nto the live migration server action. This patch makes sure that we\ndon\u0027t include it in our request if we\u0027re running with 2.25 or higher.\n\nChange-Id: I1bbdd33be96d82422a05982508e370237c3560f3\nStory: #2002963\nTask: #22966\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3283cebb1efa2e1d12c537011d8efb453280a455"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3283cebb1efa2e1d12c537011d8efb453280a455"}]},"branch":"refs/heads/master"},"d6121782d3aa6a95b883220b27a154e641b61f7f":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2018-07-24 15:09:50.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/34/582334/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/34/582334/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/34/582334/4"}}},"commit":{"parents":[{"commit":"00194b4e208cfb2be606f4d436166ccd3bc75cdc","subject":"Merge \"Do not require port argument when updating floating IP\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/00194b4e208cfb2be606f4d436166ccd3bc75cdc"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-12 18:34:51.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2018-07-24 15:09:27.000000000","tz":-240},"subject":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24","message":"Don\u0027t sent disk_over_commit if nova api \u003e 2.24\n\nIn API microversion 2.25 Nova removed the disk_over_commit parameter\nto the live migration server action. This patch makes sure that we\ndon\u0027t include it in our request if we\u0027re running with 2.25 or higher.\n\nStory: #2002963\nTask: #22966\nChange-Id: I1bbdd33be96d82422a05982508e370237c3560f3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d6121782d3aa6a95b883220b27a154e641b61f7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d6121782d3aa6a95b883220b27a154e641b61f7f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}