)]}'
{"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea74fde3a8443efc27f6608d0e3b6d7aeda9bb2e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                parsed_args.user).id"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        volume \u003d volume_client.volumes.create("},{"line_number":214,"context_line":"            size\u003dparsed_args.size,"},{"line_number":215,"context_line":"            snapshot_id\u003dsnapshot,"},{"line_number":216,"context_line":"            name\u003dparsed_args.name,"},{"line_number":217,"context_line":"            description\u003dparsed_args.description,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f817d79c","line":214,"range":{"start_line":214,"start_character":17,"end_line":214,"end_character":33},"updated":"2018-07-23 15:32:10.000000000","message":"Looks like you would need to use the size variable here.\n\nIt can check if size is provided and only set it to snapshot.size if not.","commit_id":"be0ce5cb29c145c5efe4850672ccd3ed53787735"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7563954f6a2d43a6a1d51d252ee2a9900663dba1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            # so since we have the object here, just override the size"},{"line_number":199,"context_line":"            # value if it\u0027s either not given or is smaller than the"},{"line_number":200,"context_line":"            # snapshot size."},{"line_number":201,"context_line":"            size \u003d max(size or 0, snapshot.size)"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            size \u003d parsed_args.size"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_985ca359","line":201,"range":{"start_line":201,"start_character":23,"end_line":201,"end_character":27},"updated":"2018-07-23 15:38:22.000000000","message":"size isn\u0027t set here yet, is it?\n\nYou will still want to set to parsed_args.size for the cases where they are creating from snapshot but want a larger size. Maybe move the \"size \u003d parsed_args.size\" to happen before the \"if parsed_args.snapshot\" line?","commit_id":"0f162193149e643628b1e97c354e7d067042d427"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a281e8c8ca55397cfc69c9863221272836fd7797","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            # so since we have the object here, just override the size"},{"line_number":199,"context_line":"            # value if it\u0027s either not given or is smaller than the"},{"line_number":200,"context_line":"            # snapshot size."},{"line_number":201,"context_line":"            size \u003d max(size or 0, snapshot.size)"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            size \u003d parsed_args.size"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ccf81c1a","line":201,"range":{"start_line":201,"start_character":23,"end_line":201,"end_character":27},"in_reply_to":"5f7c97a3_985ca359","updated":"2018-07-23 15:40:37.000000000","message":"Done","commit_id":"0f162193149e643628b1e97c354e7d067042d427"}]}
