)]}'
{"openstackclient/network/v2/network_qos_rule.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b690f9c2402be8da472debe3b0f7dbf147ec85d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        dest\u003d\u0027max_burst_kbits\u0027,"},{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic: \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e83f0eb0","line":144,"range":{"start_line":144,"start_character":75,"end_line":144,"end_character":76},"updated":"2018-08-02 21:21:52.000000000","message":"why \":\"? Maybe something like:\n\"automatic, which is set to 80%% of the ....\"","commit_id":"9b7770918e93c0ab228731cf28151c8e8e6d328a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4eda42f9cf9934e19cc1d821fa482f8d9e4fdea6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        dest\u003d\u0027max_burst_kbits\u0027,"},{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic: \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3898ef65","line":144,"range":{"start_line":144,"start_character":75,"end_line":144,"end_character":76},"in_reply_to":"5f7c97a3_e83f0eb0","updated":"2018-08-03 08:47:57.000000000","message":"Done","commit_id":"9b7770918e93c0ab228731cf28151c8e8e6d328a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7531135c44de130b4783b66becb3220a75ef8584","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        dest\u003d\u0027max_burst_kbits\u0027,"},{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2b68581f","line":144,"range":{"start_line":144,"start_character":48,"end_line":144,"end_character":59},"updated":"2018-08-08 21:18:57.000000000","message":"Since this text is for the argument, what does \"not defined\" mean in that case?","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7531135c44de130b4783b66becb3220a75ef8584","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        dest\u003d\u0027max_burst_kbits\u0027,"},{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_eb71000e","line":144,"range":{"start_line":144,"start_character":75,"end_line":144,"end_character":76},"updated":"2018-08-08 21:18:57.000000000","message":"think you need trailing period for this sentence ?","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aa74c7a5ef5b643509439540d518e3be44889216","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        dest\u003d\u0027max_burst_kbits\u0027,"},{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6f99711d","line":144,"range":{"start_line":144,"start_character":48,"end_line":144,"end_character":59},"in_reply_to":"3f79a3b5_2b68581f","updated":"2018-08-09 10:07:45.000000000","message":"I changed to \"not specified\" perhaps that\u0027s a better wording, but anyway:\nNot specified is the situation when on the CLI --max-burst-kbits is not given as parameter.","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aa74c7a5ef5b643509439540d518e3be44889216","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        dest\u003d\u0027max_burst_kbits\u0027,"},{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3a82d550","line":144,"range":{"start_line":144,"start_character":75,"end_line":144,"end_character":76},"in_reply_to":"3f79a3b5_eb71000e","updated":"2018-08-09 10:07:45.000000000","message":"I moved the trailing spaces to be leading spaces, is that what you meant?","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7531135c44de130b4783b66becb3220a75ef8584","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_cbe444af","line":145,"range":{"start_line":145,"start_character":45,"end_line":145,"end_character":50},"updated":"2018-08-08 21:18:57.000000000","message":"delete, doesn\u0027t seem needed","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7531135c44de130b4783b66becb3220a75ef8584","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4b5cb47d","line":145,"range":{"start_line":145,"start_character":27,"end_line":145,"end_character":28},"updated":"2018-08-08 21:18:57.000000000","message":"extra space","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7531135c44de130b4783b66becb3220a75ef8584","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ab654847","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":20},"updated":"2018-08-08 21:18:57.000000000","message":"s/80% ?","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aa74c7a5ef5b643509439540d518e3be44889216","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bae02598","line":145,"range":{"start_line":145,"start_character":27,"end_line":145,"end_character":28},"in_reply_to":"3f79a3b5_4b5cb47d","updated":"2018-08-09 10:07:45.000000000","message":"Done","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aa74c7a5ef5b643509439540d518e3be44889216","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fad69dc3","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":20},"in_reply_to":"3f79a3b5_ab654847","updated":"2018-08-09 10:07:45.000000000","message":"argparse dies if only 1 % is there as expects string formatting.","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aa74c7a5ef5b643509439540d518e3be44889216","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not defined means automatic \u0027"},{"line_number":145,"context_line":"               \u002780%% of the  bandwidth limit which works for typical TCP \u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7a184dd2","line":145,"range":{"start_line":145,"start_character":45,"end_line":145,"end_character":50},"in_reply_to":"3f79a3b5_cbe444af","updated":"2018-08-09 10:07:45.000000000","message":"Done","commit_id":"a6f0760868c70b4026e9f4ce9a5da62a9e3d32fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eef6624913dd88790adb22955a2d973200fc2321","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not specified means\u0027"},{"line_number":145,"context_line":"               \u0027 automatic 80%% of the bandwidth limit works for typical TCP\u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a741ed3b","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":17},"updated":"2018-08-09 10:58:47.000000000","message":"I don\u0027t think that this was what Brian meant. Convention is to left trailing space at the end of line instead of leading space in next line.","commit_id":"089ecc59ad246d2d289f95f16e54a2199bb0f205"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eef6624913dd88790adb22955a2d973200fc2321","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not specified means\u0027"},{"line_number":145,"context_line":"               \u0027 automatic 80%% of the bandwidth limit works for typical TCP\u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_27771da3","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":27},"updated":"2018-08-09 10:58:47.000000000","message":"I would personally say something like:\n\n\"automatic, which is 80% of the....\"","commit_id":"089ecc59ad246d2d289f95f16e54a2199bb0f205"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"47fdf2f888bd96d91b7b715f3e1728bec50b8393","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not specified means\u0027"},{"line_number":145,"context_line":"               \u0027 automatic 80%% of the bandwidth limit works for typical TCP\u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ca8430b4","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":27},"in_reply_to":"3f79a3b5_27771da3","updated":"2018-08-09 12:15:15.000000000","message":"Done","commit_id":"089ecc59ad246d2d289f95f16e54a2199bb0f205"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"47fdf2f888bd96d91b7b715f3e1728bec50b8393","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not specified means\u0027"},{"line_number":145,"context_line":"               \u0027 automatic 80%% of the bandwidth limit works for typical TCP\u0027"},{"line_number":146,"context_line":"               \u0027traffic. For details check the QoS user workflow.\u0027)"},{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ea9fac00","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":17},"in_reply_to":"3f79a3b5_a741ed3b","updated":"2018-08-09 12:15:15.000000000","message":"ok, I see now, was a little strange","commit_id":"089ecc59ad246d2d289f95f16e54a2199bb0f205"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd2fe7facfcb6c283d35360081c6f1ce801a18e0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not specified means \u0027"},{"line_number":145,"context_line":"               \u0027automatic, which is 80%% of the bandwidth limit, works for \u0027"},{"line_number":146,"context_line":"               \u0027typical TCP traffic. For details check the QoS user \u0027"},{"line_number":147,"context_line":"               \u0027workflow.\u0027)"},{"line_number":148,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b5090c32","line":145,"range":{"start_line":145,"start_character":65,"end_line":145,"end_character":70},"updated":"2018-08-09 16:23:40.000000000","message":"I had asked to remove the \u0027which\u0027 (was \u0027which works\u0027) in PS2, but now that you\u0027ve re-arranged the sentence you should put it back.  Sorry about that.","commit_id":"cbc467bce3d254bf13e65c8788364a4634929fe5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d5a14580ce8c2cf0fa83083c9fcf9b8a865f4cd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metavar\u003d\u0027\u003cmax-burst-kbits\u003e\u0027,"},{"line_number":143,"context_line":"        type\u003dint,"},{"line_number":144,"context_line":"        help\u003d_(\u0027Maximum burst in kilobits, 0 or not specified means \u0027"},{"line_number":145,"context_line":"               \u0027automatic, which is 80%% of the bandwidth limit, works for \u0027"},{"line_number":146,"context_line":"               \u0027typical TCP traffic. For details check the QoS user \u0027"},{"line_number":147,"context_line":"               \u0027workflow.\u0027)"},{"line_number":148,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ca0657cf","line":145,"range":{"start_line":145,"start_character":65,"end_line":145,"end_character":70},"in_reply_to":"3f79a3b5_b5090c32","updated":"2018-08-10 05:40:06.000000000","message":"Thanks for reviewing.\nFrom the other perspective I waste your review time.","commit_id":"cbc467bce3d254bf13e65c8788364a4634929fe5"}]}