)]}'
{"id":"openstack%2Fpython-openstackclient~590807","triplet_id":"openstack%2Fpython-openstackclient~master~I1e755f72f54eafb778f2f417e0dda27541797353","project":"openstack/python-openstackclient","branch":"master","topic":"improve_version_check","attention_set":{},"removed_from_attention_set":{"17280":{"account":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"last_update":"2022-07-07 10:56:37.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I1e755f72f54eafb778f2f417e0dda27541797353","subject":"Cinder: Add version checking","status":"ABANDONED","created":"2018-08-10 15:41:59.000000000","updated":"2022-07-07 10:56:37.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"35d72f9450a4fd928254ab168b7f0153659db53f","_number":590807,"virtual_id_number":590807,"owner":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-08-21 18:09:16.000000000","_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"},{"value":-1,"date":"2018-08-13 18:35:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},{"date":"2019-02-06 20:11:32.000000000","_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19684,"name":"James Luhrsen","email":"jluhrsen@redhat.com","username":"jluhrsen"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"date":"2018-08-13 21:45:39.000000000","_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"date":"2020-03-02 18:24:11.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"date":"2020-08-05 14:41:00.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19684,"name":"James Luhrsen","email":"jluhrsen@redhat.com","username":"jluhrsen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},{"value":-1,"date":"2018-08-13 18:07:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-03-04 21:54:02.000000000","_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19684,"name":"James Luhrsen","email":"jluhrsen@redhat.com","username":"jluhrsen"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"date":"2020-08-17 23:09:35.000000000","_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},{"_account_id":19684,"name":"James Luhrsen","email":"jluhrsen@redhat.com","username":"jluhrsen"},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"}],"CC":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-08-10 15:42:51.000000000","updated_by":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"reviewer":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"state":"REVIEWER"},{"updated":"2018-08-10 15:42:54.000000000","updated_by":{"_account_id":19684,"name":"James Luhrsen","email":"jluhrsen@redhat.com","username":"jluhrsen"},"reviewer":{"_account_id":19684,"name":"James Luhrsen","email":"jluhrsen@redhat.com","username":"jluhrsen"},"state":"REVIEWER"},{"updated":"2018-08-10 15:42:59.000000000","updated_by":{"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},"reviewer":{"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},"state":"REVIEWER"},{"updated":"2018-08-10 15:43:14.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-08-10 15:43:39.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2018-08-13 18:07:32.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2018-08-13 18:35:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-02-06 20:11:32.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"REVIEWER"},{"updated":"2019-08-21 18:09:16.000000000","updated_by":{"_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"},"reviewer":{"_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"},"state":"REVIEWER"},{"updated":"2020-03-02 18:24:11.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-03-04 21:54:02.000000000","updated_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"reviewer":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"state":"REVIEWER"},{"updated":"2020-08-05 14:41:00.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2020-08-17 23:09:35.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2021-05-26 09:44:43.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"CC"}],"messages":[{"id":"12e12cec72ab94dfa40c19422c9484de990ec035","author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"date":"2018-08-10 15:41:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"51d5849ef34039ce99291a38ca1025b292c5f7d8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-10 17:15:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/07/590807/1/check/openstack-tox-pep8/8f3462d/ : SUCCESS in 6m 00s\n- openstack-tox-py27 http://logs.openstack.org/07/590807/1/check/openstack-tox-py27/570f2e4/ : FAILURE in 5m 06s\n- openstack-tox-py35 http://logs.openstack.org/07/590807/1/check/openstack-tox-py35/3987564/ : FAILURE in 5m 51s\n- build-openstack-sphinx-docs http://logs.openstack.org/07/590807/1/check/build-openstack-sphinx-docs/6fd7920/html/ : SUCCESS in 5m 22s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/07/590807/1/check/legacy-tempest-dsvm-neutron-src/dea99fb/ : FAILURE in 17m 19s\n- openstackclient-check-plugins http://logs.openstack.org/07/590807/1/check/openstackclient-check-plugins/e1844d4/ : SUCCESS in 8m 52s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/07/590807/1/check/osc-tox-py27-tips/0e0b489/ : FAILURE in 6m 04s\n- osc-tox-py35-tips http://logs.openstack.org/07/590807/1/check/osc-tox-py35-tips/3a50bf1/ : FAILURE in 7m 59s\n- osc-functional-devstack http://logs.openstack.org/07/590807/1/check/osc-functional-devstack/c9ca576/ : RETRY_LIMIT in 25m 01s\n- osc-functional-devstack-tips http://logs.openstack.org/07/590807/1/check/osc-functional-devstack-tips/6117f55/ : RETRY_LIMIT in 23m 16s\n- openstack-tox-lower-constraints http://logs.openstack.org/07/590807/1/check/openstack-tox-lower-constraints/7501cb8/ : FAILURE in 5m 49s","accounts_in_message":[],"_revision_number":1},{"id":"d1c4860763474bf4db2354489553be4f3415d187","author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"date":"2018-08-13 17:28:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"40c774e70543642f1133192ce0877fe46b5d6ffa","author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"date":"2018-08-13 17:31:44.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nnote some of the tests are failing because the config is some how getting default volume version of 2. I\u0027ve looked and I cant find how that is getting configured, but here is some info:\n\nhttps://paste.fedoraproject.org/paste/~XTEgOlit2Wa5Unzxqr0UQ/raw","accounts_in_message":[],"_revision_number":2},{"id":"0584207cc20e3e9217b9c55b4b50509ba6498b7d","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-08-13 18:07:32.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027d suggest we hold off on this for a couple of weeks. We\u0027ve been getting all of the version handling properly taken care of in SDK, so I\u0027d rather not switch behavior once here and then potentially again as we start plumbing through the sdk/discovery work in the next few weeks.","accounts_in_message":[],"_revision_number":2},{"id":"488b2ef4afcd52004c852c55edbdc6aa79f75566","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-13 18:35:31.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/07/590807/2/check/openstack-tox-pep8/9fc94ab/ : SUCCESS in 5m 28s\n- openstack-tox-py27 http://logs.openstack.org/07/590807/2/check/openstack-tox-py27/b12c364/ : FAILURE in 5m 12s\n- openstack-tox-py35 http://logs.openstack.org/07/590807/2/check/openstack-tox-py35/fa58f52/ : FAILURE in 5m 55s\n- build-openstack-sphinx-docs http://logs.openstack.org/07/590807/2/check/build-openstack-sphinx-docs/af5c7ae/html/ : SUCCESS in 5m 23s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/07/590807/2/check/legacy-tempest-dsvm-neutron-src/b9cde1a/ : FAILURE in 15m 58s\n- openstackclient-check-plugins http://logs.openstack.org/07/590807/2/check/openstackclient-check-plugins/8232fc8/ : SUCCESS in 6m 59s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/07/590807/2/check/osc-tox-py27-tips/ba23a02/ : FAILURE in 6m 10s\n- osc-tox-py35-tips http://logs.openstack.org/07/590807/2/check/osc-tox-py35-tips/78d7efe/ : FAILURE in 6m 41s\n- osc-functional-devstack http://logs.openstack.org/07/590807/2/check/osc-functional-devstack/3154455/ : RETRY_LIMIT in 14m 39s\n- osc-functional-devstack-tips finger://ze08.openstack.org/c296c5756a7147bb8a5e6f68cba3a55f : RETRY_LIMIT in 1m 00s\n- openstack-tox-lower-constraints http://logs.openstack.org/07/590807/2/check/openstack-tox-lower-constraints/854ca02/ : FAILURE in 5m 10s","accounts_in_message":[],"_revision_number":2},{"id":"537209a0fbcb3505601ee3f72f289c8b2e2e9135","author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"date":"2018-08-13 21:45:39.000000000","message":"Patch Set 2:\n\nIn TripleO the minor version was added to overcloudrc, so now TripleO users cannot launch nova instances using OSCLI (unless they know to change the version in their RC file). I\u0027ve proposed to remove the minor version in TripleO as a workaround:\nhttps://review.openstack.org/#/c/591482/\n\nHowever, I think it is better to fix it here. Few weeks isn\u0027t an option I don\u0027t think, so we need 1 of the 2 patches to progress.","accounts_in_message":[],"_revision_number":2},{"id":"5a81a897565dfeb382f8660a3bcf46ceb985e20d","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2019-02-06 20:11:32.000000000","message":"Patch Set 2:\n\n\u003e I\u0027d suggest we hold off on this for a couple of weeks. We\u0027ve been\n \u003e getting all of the version handling properly taken care of in SDK,\n \u003e so I\u0027d rather not switch behavior once here and then potentially\n \u003e again as we start plumbing through the sdk/discovery work in the\n \u003e next few weeks.\n\n@Monty, can you elaborate on this? We need to find a way for osc to support cinder\u0027s API microversions, and I\u0027m not sure of the best way forward.","accounts_in_message":[],"_revision_number":2},{"id":"a8e7688d32162a900c4318b0cfd592e4c52c0aaa","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-25 15:51:29.000000000","message":"Patch Set 2:\n\n\u003e I\u0027d suggest we hold off on this for a couple of weeks. We\u0027ve been\n \u003e getting all of the version handling properly taken care of in SDK,\n \u003e so I\u0027d rather not switch behavior once here and then potentially\n \u003e again as we start plumbing through the sdk/discovery work in the\n \u003e next few weeks.\n\nDid this version handling change happen in the meantime?","accounts_in_message":[],"_revision_number":2},{"id":"47a1e441c480e2bf04b7d5b9e2941280cad0bbe5","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-05 18:00:36.000000000","message":"Patch Set 2:\n\nWe\u0027re handling microversions happily in sdk for a bit now, and it\u0027s being used by ironic at least.\n\nI think next steps here would then be to start migrating calls in osc to start using sdk instead of cinderclient - but we should get some thoughts from dtroyer on how that interacts with the osc4 branch.","accounts_in_message":[],"_revision_number":2},{"id":"d264439245ef0558ceda8b498f58ff5e0ea84cc5","author":{"_account_id":29068,"name":"James Bagwell","email":"james.bagwell@nokia.com","username":"Chaserjim"},"date":"2019-08-21 18:09:16.000000000","message":"Patch Set 2:\n\nAdding myself to follow the progression of this request as my team needs to be able to perform volume edits while volume \u0027in-use\u0027 . This feature is supported in micro-version 3.42 , however without OSC support of micro versioning, performing the volume edit is not supported.","accounts_in_message":[],"_revision_number":2},{"id":"2c3456bd472c026e042875b7004fa81ec33a469a","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-02 16:19:55.000000000","message":"Patch Set 2:\n\n3 things.\n\na) I\u0027d still prefer migrating to sdk here, since microversion support is solid and we use it in other places and all\n\nHOWEVER\n\nb) I don\u0027t think we should block forward progress on that, we can certainly migrate later (let\u0027s just make sure behavior is gonna be consistent)\n\nc) this should probably be fixed to pass tests - all of the previous blockers that existed when this was written originally should not exist anymore","accounts_in_message":[],"_revision_number":2},{"id":"43aa9c8e9d9f618a9f5e83faa997926815058515","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-02 18:20:38.000000000","message":"Patch Set 2:\n\nA couple of thoughts that may or may not apply to the patch (I don\u0027t quite get if it handles microversions or not):\n\n1) Do not default to the absolute latest microversion. Use the highest version that both the client (OSC and cinderclient) and the server understand.\n\n2) Do not default to the lowest microversion, it\u0027s a nightmare for users.\n\n3) Be very verbose and specific with error messages. Sometimes somebody sets OS_BAREMETAL_API_VERSION and then gets a cryptic error when trying to use newer features. Keep in mind that certain parts of the picture are implicit for end users.\n\nThis is what we\u0027ve learned from implementing microversions in the ironic OSC plugin.","accounts_in_message":[],"_revision_number":2},{"id":"ea25ac5f952e090df2094b5bf702c9a5abd53eb1","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-02 18:24:11.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"73f7468e8a316dea44349d8bd5ff41d93658529f","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-08-05 14:41:00.000000000","message":"Patch Set 2:\n\nAfter the discussion during the last PTG, what is the expected plan for  this review?","accounts_in_message":[],"_revision_number":2},{"id":"c5cf152593cdd59d1801544c7c93537859d67799","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-26 09:44:43.000000000","message":"Patch Set 2:\n\nI\u0027ve proposed an alternative to this at [1] that allows users to select a range of versions, which will be validated against cinderclient, but which does not bump the minimum version to latest. I think that\u0027s reasonable, personally\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/792950/","accounts_in_message":[],"_revision_number":2},{"id":"fea46d581a6b0b58a4c54bc5485bc788cffb2def","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-07 10:56:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"35d72f9450a4fd928254ab168b7f0153659db53f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-07-07 10:56:37.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"33180f523b9093ead6bcb3fd2042c9debf64a3ba","revisions":{"3f07d5828d126318514659c3c1503303d610bb3e":{"kind":"REWORK","_number":1,"created":"2018-08-10 15:41:59.000000000","uploader":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"ref":"refs/changes/07/590807/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/590807/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/1"}}},"commit":{"parents":[{"commit":"a051bda1118158cef219cddf94a24483f6b1513b","subject":"Merge \"Add DNS support to floating IP commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a051bda1118158cef219cddf94a24483f6b1513b"}]}],"author":{"name":"Tim Rozet","email":"trozet@redhat.com","date":"2018-08-10 15:38:44.000000000","tz":-240},"committer":{"name":"Tim Rozet","email":"trozet@redhat.com","date":"2018-08-10 15:41:58.000000000","tz":-240},"subject":"Cinder: Add version checking","message":"Cinder: Add version checking\n\nThe legacy version checking method of checking if the supplied version\nis in the client.API_VERSIONS is not suitable for cinder. The default\nAPI_VERSIONS in the cinderclient are specified by major version, and the\nreal API versions for cinder are specifiec with minor versions as well.\n\nThis patch adds proper version checking within the cinder client which\nwill bypass the legacy version checking method in shell.py.\n\nStory: 2003132\nTask: 23254\n\nChange-Id: I1e755f72f54eafb778f2f417e0dda27541797353\nSigned-off-by: Tim Rozet \u003ctrozet@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3f07d5828d126318514659c3c1503303d610bb3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3f07d5828d126318514659c3c1503303d610bb3e"}]},"branch":"refs/heads/master"},"33180f523b9093ead6bcb3fd2042c9debf64a3ba":{"kind":"REWORK","_number":2,"created":"2018-08-13 17:28:49.000000000","uploader":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"ref":"refs/changes/07/590807/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/590807/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/590807/2"}}},"commit":{"parents":[{"commit":"a051bda1118158cef219cddf94a24483f6b1513b","subject":"Merge \"Add DNS support to floating IP commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a051bda1118158cef219cddf94a24483f6b1513b"}]}],"author":{"name":"Tim Rozet","email":"trozet@redhat.com","date":"2018-08-10 15:38:44.000000000","tz":-240},"committer":{"name":"Tim Rozet","email":"trozet@redhat.com","date":"2018-08-13 17:28:29.000000000","tz":-240},"subject":"Cinder: Add version checking","message":"Cinder: Add version checking\n\nThe legacy version checking method of checking if the supplied version\nis in the client.API_VERSIONS is not suitable for cinder. The default\nAPI_VERSIONS in the cinderclient are specified by major version, and the\nreal API versions for cinder are specifiec with minor versions as well.\n\nThis patch adds proper version checking within the cinder client which\nwill bypass the legacy version checking method in shell.py.\n\nStory: 2003132\nTask: 23254\n\nChange-Id: I1e755f72f54eafb778f2f417e0dda27541797353\nSigned-off-by: Tim Rozet \u003ctrozet@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/33180f523b9093ead6bcb3fd2042c9debf64a3ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/33180f523b9093ead6bcb3fd2042c9debf64a3ba"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}