)]}'
{"id":"openstack%2Fpython-openstackclient~605398","triplet_id":"openstack%2Fpython-openstackclient~master~I815f6edfbae333b22eb539e14e8777f8d9dad570","project":"openstack/python-openstackclient","branch":"master","topic":"default-compute-api-version","hashtags":[],"change_id":"I815f6edfbae333b22eb539e14e8777f8d9dad570","subject":"Use 2.latest compute microversion as default","status":"ABANDONED","created":"2018-09-26 11:13:21.000000000","updated":"2019-11-04 20:21:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3773262958bbdcb833b1d80f417551843665d76b","_number":605398,"virtual_id_number":605398,"owner":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2018-10-10 12:45:28.000000000","_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2018-09-26 16:25:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2018-09-26 14:05:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2019-06-27 14:33:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"value":-1,"date":"2018-10-02 16:26:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-09-26 14:05:49.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-09-26 16:25:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-10-02 16:26:40.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-06-27 14:33:18.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"51b4892c569898a54a46e7ff802f21b369540413","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-09-26 11:13:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"51a7865fec6d3bfe8b58ea3492daa446f9052999","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-09-26 14:05:49.000000000","message":"Patch Set 1: Code-Review+2\n\nI don\u0027t recall if this is the right spot to change things, but i\u0027ll leave that to dtroyer to confirm.","accounts_in_message":[],"_revision_number":1},{"id":"a371a8c76606ab6b8a51be8c76c675f19d77a32f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-26 16:25:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstackclient-check-plugins http://logs.openstack.org/98/605398/1/check/openstackclient-check-plugins/2132028/ : SUCCESS in 6m 34s (non-voting)\n- osc-tox-py27-tips http://logs.openstack.org/98/605398/1/check/osc-tox-py27-tips/b9e1d38/ : SUCCESS in 6m 14s\n- osc-tox-py35-tips http://logs.openstack.org/98/605398/1/check/osc-tox-py35-tips/6397b12/ : SUCCESS in 5m 50s\n- openstack-tox-cover http://logs.openstack.org/98/605398/1/check/openstack-tox-cover/7e738ac/cover/ : SUCCESS in 5m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/98/605398/1/check/openstack-tox-lower-constraints/0624052/ : SUCCESS in 5m 45s\n- openstack-tox-pep8 http://logs.openstack.org/98/605398/1/check/openstack-tox-pep8/c504689/ : SUCCESS in 9m 15s\n- openstack-tox-py27 http://logs.openstack.org/98/605398/1/check/openstack-tox-py27/53d58e6/ : SUCCESS in 4m 42s\n- openstack-tox-py35 http://logs.openstack.org/98/605398/1/check/openstack-tox-py35/2199a4e/ : SUCCESS in 4m 35s\n- openstack-tox-py36 http://logs.openstack.org/98/605398/1/check/openstack-tox-py36/2aaa6f5/ : SUCCESS in 5m 03s\n- openstack-tox-docs http://logs.openstack.org/98/605398/1/check/openstack-tox-docs/1b74ed2/html/ : SUCCESS in 5m 36s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/98/605398/1/check/legacy-tempest-dsvm-neutron-src/5c9460a/ : SUCCESS in 1h 52m 22s\n- tempest-full-py3 http://logs.openstack.org/98/605398/1/check/tempest-full-py3/da8f63f/ : SUCCESS in 1h 21m 15s\n- osc-functional-devstack http://logs.openstack.org/98/605398/1/check/osc-functional-devstack/a7e6697/ : FAILURE in 58m 23s\n- osc-functional-devstack-tips http://logs.openstack.org/98/605398/1/check/osc-functional-devstack-tips/d4aba30/ : SUCCESS in 47m 43s","accounts_in_message":[],"_revision_number":1},{"id":"a027b567b9f697c3e5138c7b7cd6851025e7cbce","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2018-10-02 16:26:40.000000000","message":"Patch Set 1: Code-Review-1\n\nThis is not appropriate now, if ever, for OSC.  We continue to assume minimum microversion by default, although individual commands may specify a minimum when they are coded to handle the change.  Microversion changes are generally not backward-compatible by definition and any particular command may need changed to correctly handle the API changes.","accounts_in_message":[],"_revision_number":1},{"id":"18d0f32efc725d3dc14eb23aa9ff4d7bf132e110","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-10-10 12:45:28.000000000","message":"Patch Set 1:\n\n\u003e This is not appropriate now, if ever, for OSC.  We continue to\n \u003e assume minimum microversion by default, although individual\n \u003e commands may specify a minimum when they are coded to handle the\n \u003e change.  Microversion changes are generally not backward-compatible\n \u003e by definition and any particular command may need changed to\n \u003e correctly handle the API changes.\n\nThanks for the feedback. I see it is kind of a norm to assume minimum  api version and then adjust the commands to a newer API version if necessary. But at the same time I think assuming the latest comptute version would be nicer especially when people have got used to nova  commands and we want to completely transition to openstack commands as smoothly as possible.","accounts_in_message":[],"_revision_number":1},{"id":"125a9fd1d300376677ed10717790a90917c2dc98","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-27 14:33:18.000000000","message":"Patch Set 1: Code-Review-1\n\nI would personally like to see the openstack CLI behave more like the nova CLI and do version negotiation between the client and server to determine, by default, the highest support microversion to use if one is not specified, but this doesn\u0027t look like that\u0027s what it would do - wouldn\u0027t this just default to always telling novaclient to use 2.latest which would bypass any version negotiation and always ask for the latest microversion - which could break pretty easily I\u0027d think.","accounts_in_message":[],"_revision_number":1},{"id":"c7fb0b21c0dcdde9139b1500870a822f3cc5caa0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-06-27 20:31:39.000000000","message":"Patch Set 1:\n\nMatt, now is the time to make that change, I am planning to rip out the majority of the compatibility code around session creation and mostly stick to the ksa/sdk process.  I think novaclient uses ksa for the version negotiation now, right?  If so OSc will be very close if not identical...","accounts_in_message":[],"_revision_number":1},{"id":"ef26902f097417140997802d649582ae91d39097","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-11-04 20:21:21.000000000","message":"Abandoned\n\nThis has been sitting with -1s for a long time and is going to require some discussion first since it\u0027s a pretty drastic change in OSC usability. I would like to see OSC by default use the latest negotiated microversion between the client and server like nova CLI does, but it\u0027s a big change.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"11a51023509cba5f035340b1004f50e549c1adce","revisions":{"11a51023509cba5f035340b1004f50e549c1adce":{"kind":"REWORK","_number":1,"created":"2018-09-26 11:13:21.000000000","uploader":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"ref":"refs/changes/98/605398/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/98/605398/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/605398/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/605398/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/605398/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/98/605398/1"}}},"commit":{"parents":[{"commit":"01c3548dc8c35da198453af4e20331b5aa15f436","subject":"Fix help message for subnetpool default-quota value","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/01c3548dc8c35da198453af4e20331b5aa15f436"}]}],"author":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-09-26 11:05:56.000000000","tz":480},"committer":{"name":"Chen","email":"dstbtgagt@foxmail.com","date":"2018-09-26 11:05:56.000000000","tz":480},"subject":"Use 2.latest compute microversion as default","message":"Use 2.latest compute microversion as default\n\nWith this patch, the default os-compute-api-version will get lined\nup with that in novaclient [1].\nNote that this default value will not take effect until patch [2]\nis merged.\n\n[1] https://github.com/openstack/python-novaclient/blob/master/novaclient/shell.py#L47\n[2] https://review.openstack.org/#/c/600330/\n\nChange-Id: I815f6edfbae333b22eb539e14e8777f8d9dad570\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/11a51023509cba5f035340b1004f50e549c1adce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/11a51023509cba5f035340b1004f50e549c1adce"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}