)]}'
{"openstackclient/identity/v3/registered_limit.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4995d3bb196d64decd4763be9d87426b8910426a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        parser.add_argument("},{"line_number":187,"context_line":"            \u0027--service\u0027,"},{"line_number":188,"context_line":"            metavar\u003d\u0027\u003cservice\u003e\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service or --resource-name must be \u0027"},{"line_number":191,"context_line":"                   \u0027different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_405ebfe8","line":189,"updated":"2018-10-22 19:45:47.000000000","message":"Can\u0027t we do mutually exclusive arguments natively?\n\nThis is fine as is.","commit_id":"85663862a553e0fc8d1dc78f83a753a7f5540b85"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"5dc1161aa5fd7571f5570e6f2a55c959738c932d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        parser.add_argument("},{"line_number":187,"context_line":"            \u0027--service\u0027,"},{"line_number":188,"context_line":"            metavar\u003d\u0027\u003cservice\u003e\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service or --resource-name must be \u0027"},{"line_number":191,"context_line":"                   \u0027different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fa15164d","line":189,"in_reply_to":"3f79a3b5_405ebfe8","updated":"2018-10-24 02:56:14.000000000","message":"These are not mutually exclusive. Both can be present at a time, but whether both are present or one of the two the values must be different from the existing one.","commit_id":"85663862a553e0fc8d1dc78f83a753a7f5540b85"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d00b1cd60561ca9fd3395ceeb8ed01818907914f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        parser.add_argument("},{"line_number":187,"context_line":"            \u0027--service\u0027,"},{"line_number":188,"context_line":"            metavar\u003d\u0027\u003cservice\u003e\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service or --resource-name must be \u0027"},{"line_number":191,"context_line":"                   \u0027different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a7469721","line":189,"in_reply_to":"3f79a3b5_b6cc8b62","updated":"2018-10-24 16:49:39.000000000","message":"Ah.","commit_id":"85663862a553e0fc8d1dc78f83a753a7f5540b85"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ea4ead1c71205a637fffb2d0cb7b97bd2c6f61cb","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        parser.add_argument("},{"line_number":187,"context_line":"            \u0027--service\u0027,"},{"line_number":188,"context_line":"            metavar\u003d\u0027\u003cservice\u003e\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service or --resource-name must be \u0027"},{"line_number":191,"context_line":"                   \u0027different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b6cc8b62","line":189,"in_reply_to":"3f79a3b5_fa15164d","updated":"2018-10-24 15:15:32.000000000","message":"This is due to how limits view uniqueness constraints I believe.","commit_id":"85663862a553e0fc8d1dc78f83a753a7f5540b85"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"425020d3186e7b62d50efda16af742ac64d052ea","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service, --resource-name or --region must \u0027"},{"line_number":191,"context_line":"                   \u0027be different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--resource-name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3d43136e","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":23},"updated":"2018-10-30 13:54:43.000000000","message":"Not sure if there is a convention for using the int value or HTTP Conflict, but I\u0027ll let other reviewers weigh in.","commit_id":"66e88ae47f156166a2c4b77a43cb87e9de20f3d0"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"90a7aedf959af702ac5d908426878a96de9fce74","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service, --resource-name or --region must \u0027"},{"line_number":191,"context_line":"                   \u0027be different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--resource-name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1ad544b8","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":23},"in_reply_to":"3f79a3b5_24d7c952","updated":"2018-11-08 06:54:37.000000000","message":"Done","commit_id":"66e88ae47f156166a2c4b77a43cb87e9de20f3d0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"28de467e408d227d7f99e0e632c07ad51c9331ea","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service, --resource-name or --region must \u0027"},{"line_number":191,"context_line":"                   \u0027be different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--resource-name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e31a8a17","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":23},"in_reply_to":"3f79a3b5_3d43136e","updated":"2018-11-08 17:31:36.000000000","message":"In a help message it should be explained (briefly) in words.","commit_id":"66e88ae47f156166a2c4b77a43cb87e9de20f3d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"259691c907b6cb15e083d82ee7775138aef6b840","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service, --resource-name or --region must \u0027"},{"line_number":191,"context_line":"                   \u0027be different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027409\u0027)"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--resource-name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_24d7c952","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":23},"in_reply_to":"3f79a3b5_3d43136e","updated":"2018-11-08 03:16:45.000000000","message":"yeah, or \"HTTP 409 - Conflict\" or just \"HTTP 409\" will be more clear.","commit_id":"66e88ae47f156166a2c4b77a43cb87e9de20f3d0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"28de467e408d227d7f99e0e632c07ad51c9331ea","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service, --resource-name or --region must \u0027"},{"line_number":191,"context_line":"                   \u0027be different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027HTTP 409\u0027)"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--resource-name\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4913eeb7","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":28},"updated":"2018-11-08 17:31:36.000000000","message":"This working is clumsy and could be improved, but I am really not a fan of saying \u0027HTTP 409\u0027 here.  This is a CLI not a REST API, I had to even look up what 409 exactly was.  Is that really what the exception says when this happens?  The commit message includes \u0027Duplicate entry\u0027, that is what should appear here.","commit_id":"916d938b31c94c9019cde7c9dd73dd2b31f25ade"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"cb8904ebf91ac2c579a4aefa9207257a36a5a9ac","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            help\u003d_(\u0027Service to be updated responsible for the resource to \u0027"},{"line_number":190,"context_line":"                   \u0027limit. Either --service, --resource-name or --region must \u0027"},{"line_number":191,"context_line":"                   \u0027be different than existing value otherwise it will be \u0027"},{"line_number":192,"context_line":"                   \u0027HTTP 409\u0027)"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--resource-name\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e7fa1a0f","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":28},"in_reply_to":"3f79a3b5_4913eeb7","updated":"2018-11-09 02:48:56.000000000","message":"Done","commit_id":"916d938b31c94c9019cde7c9dd73dd2b31f25ade"}]}
