)]}'
{"id":"openstack%2Fpython-openstackclient~611469","triplet_id":"openstack%2Fpython-openstackclient~master~I47c77f3e7efe112417d2b96936fcd0cafeb9442e","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1798493","hashtags":[],"change_id":"I47c77f3e7efe112417d2b96936fcd0cafeb9442e","subject":"Improve document \u0027openstack complete\u0027","status":"MERGED","created":"2018-10-18 00:42:31.000000000","updated":"2018-10-28 20:49:47.000000000","submitted":"2018-10-28 20:49:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"611469-1540759787442-180d54ee","meta_rev_id":"d664c4bdf846e1430c25c7e4af3902350ab827e1","_number":611469,"virtual_id_number":611469,"owner":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-10-18 23:23:17.000000000","_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2018-10-28 20:49:47.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},{"value":2,"date":"2018-10-18 23:23:30.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2018-10-28 19:37:31.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2018-10-28 19:37:31.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"date":"2018-10-18 23:23:42.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-18 23:23:30.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2018-10-18 23:23:42.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2018-10-28 19:37:31.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2018-10-28 20:49:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"14ec1778b1fabd7d3ded28ab09391e1138115e30","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-18 00:42:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"477b167b283b80811b92b886696a45499a03a940","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-18 00:49:06.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"49e25b96754eabec8fef422b7e5704d6c8955ccf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-18 00:59:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/69/611469/2/check/openstackclient-check-plugins/733f198/ : SUCCESS in 5m 39s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/69/611469/2/check/openstack-tox-pep8/61c11b8/ : SUCCESS in 5m 23s\n- openstack-tox-docs http://logs.openstack.org/69/611469/2/check/openstack-tox-docs/96bcfdc/html/ : SUCCESS in 5m 14s","accounts_in_message":[],"_revision_number":2},{"id":"367061a85b83e510715d664703787c917001c7b0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-10-18 04:33:02.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"76d315e03cb38981fb617db2bd8a47c795911427","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-18 06:54:35.000000000","message":"Patch Set 2:\n\nHi Steve,\n\nI don\u0027t think we can assume there will be dependency, I agree to put it in one sentence, however I would not assume that:\n\n~~~\n When installed via a package, the ``bash-completion`` package will also be installed,\n~~~","accounts_in_message":[],"_revision_number":2},{"id":"be8bf1e3a28b93724ee642dc845e57767f703df0","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-18 06:55:18.000000000","message":"Patch Set 2:\n\nTook a quick look at openstack client in RHEL:\n\n(undercloud) [root@undercloud-0 ~]# rpm -qf $(which openstack)\npython2-openstackclient-3.14.2-1.el7ost.noarch\n(undercloud) [root@undercloud-0 ~]# yum deplist python2-openstackclient | grep bash\n  dependency: /bin/bash\n   provider: bash.x86_64 4.2.46-30.el7","accounts_in_message":[],"_revision_number":2},{"id":"f25b659b84852a5c8f479373d0cc02e90b1fdd0a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-10-18 14:59:52.000000000","message":"Patch Set 2:\n\n\u003e Took a quick look at openstack client in RHEL:\n \u003e \n \u003e (undercloud) [root@undercloud-0 ~]# rpm -qf $(which openstack)\n \u003e python2-openstackclient-3.14.2-1.el7ost.noarch\n \u003e (undercloud) [root@undercloud-0 ~]# yum deplist python2-openstackclient\n \u003e | grep bash\n \u003e dependency: /bin/bash\n \u003e provider: bash.x86_64 4.2.46-30.el7\n\nalright, cool. let\u0027s combine it into one sentence, use whatever wording you think is appropriate","accounts_in_message":[],"_revision_number":2},{"id":"ae85cc52ab6d1529e823015ad24925248a056294","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-18 23:20:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"01feb1ad5b58977a770ef6b1dd48b0bb4d1c80d3","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-18 23:23:17.000000000","message":"Patch Set 3:\n\nHi Steve,\n\nHow about now? What we are trying to say here, that yes most of the Linux distribution will have this dependency as you mention, however if the end user runs into problem that this dependency doesn\u0027t exists like in RHEL they should not panic and just install the package.\n\nAt the same time we are not mentioning any specific distribution as it might have change in future.\n\nWhat do you think about it ?\n\n~~~\nIt is highly recommended to install ``python-openstackclient`` from a package\n(``apt-get`` or ``yum``). In some distributions the package ``bash-completion`` is shipped\nas dependency, and the `openstack complete` command will be run as a post-install action,\nhowever not every distribution include this dependency and you might need to install\n``bash-completion`` package to enable autocomplete feature.\n~~~","accounts_in_message":[],"_revision_number":3},{"id":"5444cc56a7a5801487449cf34540bcc2988efd95","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2018-10-18 23:23:30.000000000","message":"Patch Set 3: Code-Review+2\n\nLgtm","accounts_in_message":[],"_revision_number":3},{"id":"1a8e35ea419033be4c4d07ca9dea2842eefab2c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-18 23:35:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstackclient-check-plugins http://logs.openstack.org/69/611469/3/check/openstackclient-check-plugins/21b5eef/ : SUCCESS in 5m 53s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/69/611469/3/check/openstack-tox-pep8/0be7be5/ : SUCCESS in 5m 31s\n- openstack-tox-docs http://logs.openstack.org/69/611469/3/check/openstack-tox-docs/73fb8c3/html/ : SUCCESS in 7m 19s","accounts_in_message":[],"_revision_number":3},{"id":"5068fb499dc309f9996c2d86357f94a6550892c2","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-19 01:09:32.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit ef045e76cec189796d5e48971b800a37bffc81ba","accounts_in_message":[],"_revision_number":3},{"id":"a3cf72dc9505d6048d828ff7fd720ff3cabd85c9","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-19 01:09:57.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit 9e963a13193d366bcc0bb2aed66f0ba94475491c","accounts_in_message":[],"_revision_number":3},{"id":"9796834f4cce4fb16d21ffc355cdeeb6f108d679","author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"date":"2018-10-19 01:10:16.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit 5d1dc7b89396d14c1e3f660a14e0097b48541077","accounts_in_message":[],"_revision_number":3},{"id":"98c9613861270176df67153a75327248e1300597","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2018-10-28 19:37:31.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"9135a982310843cbb7ec57ac6e269ca0a2c51d65","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-28 19:37:44.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"c6297597b097e15277821e5eca464f731678c199","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-28 20:49:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"e2d43fa761db51ea82663343281868dd3ab41606","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-28 20:49:47.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/611469/3/gate/openstack-tox-pep8/ef1f7ab/ : SUCCESS in 4m 37s\n- openstack-tox-docs http://logs.openstack.org/69/611469/3/gate/openstack-tox-docs/c0f38bd/html/ : SUCCESS in 4m 36s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4173690b2492680ab504ef0d60498eeb5a3d8ae2","revisions":{"931d0087abd0be8f0b355e69479930c7b63e0be3":{"kind":"REWORK","_number":1,"created":"2018-10-18 00:42:31.000000000","uploader":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"ref":"refs/changes/69/611469/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/69/611469/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/1"}}},"commit":{"parents":[{"commit":"02f492ae4cc52ed2642f42bc0c1e5e417ebfe527","subject":"Merge \"Handle not having cinderclient.v1 available\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/02f492ae4cc52ed2642f42bc0c1e5e417ebfe527"}]}],"author":{"name":"Robin Cernin","email":"rcernin@redhat.com","date":"2018-10-18 00:39:49.000000000","tz":600},"committer":{"name":"Robin Cernin","email":"rcernin@redhat.com","date":"2018-10-18 00:39:49.000000000","tz":600},"subject":"Improve document \u0027openstack complete\u0027","message":"Improve document \u0027openstack complete\u0027\n\nThe openstack complete command requires bash-completion package\nWithout the relevant package the bash completion doesn\u0027t work.\n\nChange-Id: I47c77f3e7efe112417d2b96936fcd0cafeb9442e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/931d0087abd0be8f0b355e69479930c7b63e0be3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/931d0087abd0be8f0b355e69479930c7b63e0be3"}]},"branch":"refs/heads/master"},"ff9a079542548e473274184ecd885b57aa935495":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-10-18 00:49:06.000000000","uploader":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"ref":"refs/changes/69/611469/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/69/611469/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/2"}}},"commit":{"parents":[{"commit":"02f492ae4cc52ed2642f42bc0c1e5e417ebfe527","subject":"Merge \"Handle not having cinderclient.v1 available\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/02f492ae4cc52ed2642f42bc0c1e5e417ebfe527"}]}],"author":{"name":"Robin Cernin","email":"rcernin@redhat.com","date":"2018-10-18 00:39:49.000000000","tz":600},"committer":{"name":"Robin Cernin","email":"rcernin@redhat.com","date":"2018-10-18 00:47:12.000000000","tz":600},"subject":"Improve document \u0027openstack complete\u0027","message":"Improve document \u0027openstack complete\u0027\n\nThe openstack complete command requires bash-completion package\nWithout the relevant package the bash completion doesn\u0027t work.\n\nChange-Id: I47c77f3e7efe112417d2b96936fcd0cafeb9442e\nCloses-Bug: #1798493\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ff9a079542548e473274184ecd885b57aa935495"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ff9a079542548e473274184ecd885b57aa935495"}]},"branch":"refs/heads/master"},"4173690b2492680ab504ef0d60498eeb5a3d8ae2":{"kind":"REWORK","_number":3,"created":"2018-10-18 23:20:53.000000000","uploader":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"ref":"refs/changes/69/611469/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/69/611469/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/69/611469/3"}}},"commit":{"parents":[{"commit":"02f492ae4cc52ed2642f42bc0c1e5e417ebfe527","subject":"Merge \"Handle not having cinderclient.v1 available\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/02f492ae4cc52ed2642f42bc0c1e5e417ebfe527"}]}],"author":{"name":"Robin Cernin","email":"rcernin@redhat.com","date":"2018-10-18 00:39:49.000000000","tz":600},"committer":{"name":"Robin Cernin","email":"rcernin@redhat.com","date":"2018-10-18 23:20:37.000000000","tz":600},"subject":"Improve document \u0027openstack complete\u0027","message":"Improve document \u0027openstack complete\u0027\n\nThe openstack complete command requires bash-completion package\nWithout the relevant package the bash completion doesn\u0027t work.\n\nChange-Id: I47c77f3e7efe112417d2b96936fcd0cafeb9442e\nCloses-Bug: #1798493\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4173690b2492680ab504ef0d60498eeb5a3d8ae2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4173690b2492680ab504ef0d60498eeb5a3d8ae2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}