)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d817702e9f58b236e6bb692dc98eda2c278be5a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated the take_actions for unified limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user passes --region None, the find_resource"},{"line_number":10,"context_line":"of osc_lib calls get() of region. The get API of"},{"line_number":11,"context_line":"region ignores the name param returning all the"},{"line_number":12,"context_line":"regions in result. As the find_resource checks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_3a3eb98a","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":30},"updated":"2018-10-30 12:52:23.000000000","message":"This is also achieved by not passing the parameter at all, right?","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ed4609f6467443fa70795cd3884ff0f16269991","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated the take_actions for unified limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user passes --region None, the find_resource"},{"line_number":10,"context_line":"of osc_lib calls get() of region. The get API of"},{"line_number":11,"context_line":"region ignores the name param returning all the"},{"line_number":12,"context_line":"regions in result. As the find_resource checks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_cc9265fc","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":30},"in_reply_to":"3f79a3b5_3a3eb98a","updated":"2018-10-31 01:53:41.000000000","message":"in that case, it would not add region as filter due to this if condition\n- https://review.openstack.org/#/c/612283/2/openstackclient/identity/v3/limit.py@80","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"7dcc196daffa5ab7811089615d4dc93970fbfe1d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated the take_actions for unified limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user passes --region None, the find_resource"},{"line_number":10,"context_line":"of osc_lib calls get() of region. The get API of"},{"line_number":11,"context_line":"region ignores the name param returning all the"},{"line_number":12,"context_line":"regions in result. As the find_resource checks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_afb03be1","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":30},"in_reply_to":"3f79a3b5_cc9265fc","updated":"2018-10-31 02:49:55.000000000","message":"Yes. In that condition it will not add region in filter.","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"}],"openstackclient/identity/common.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"030997497984e72268fec20732c1fb57d935c40f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        raise exceptions.CommandError(msg % name_type_or_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_resource(identity_client, name_type_or_id):"},{"line_number":72,"context_line":"    # NOTE (vishakha): Due to bug #1799153 and for any another related case"},{"line_number":73,"context_line":"    # created a new function get_resource which can be used in future"},{"line_number":74,"context_line":"    # too by these types of API\u0027s."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ec8ac1bb","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":50},"updated":"2018-10-31 01:54:23.000000000","message":"also i prefer to add this in osc lib but as of now i think keystone is the only case and adding here is first step.","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ed4609f6467443fa70795cd3884ff0f16269991","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_resource(identity_client, name_type_or_id):"},{"line_number":72,"context_line":"    # NOTE (vishakha): Due to bug #1799153 and for any another related case"},{"line_number":73,"context_line":"    # created a new function get_resource which can be used in future"},{"line_number":74,"context_line":"    # too by these types of API\u0027s."},{"line_number":75,"context_line":"    \"\"\"Find a resource by id or name.\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ac236912","line":74,"range":{"start_line":72,"start_character":47,"end_line":74,"end_character":34},"updated":"2018-10-31 01:53:41.000000000","message":"can you describe it in more detail? something like: \n\n    # NOTE (vishakha): Due to bug #1799153 and for any another related case\n    # where GET resource API does not support the filter\n    # by name, osc_lib.utils.find_resource() method cannot\n    # be used because that method try to fall back to list\n    # all the resource if requested resource cannot be get via name.\n    # Which ends up with NoUniqueMatch error. \n    # This new function is the replacement for\n    # osc_lib.utils.find_resource() for resources does not\n    # support GET by name. For exmaple: identity GET /regions.","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"7dcc196daffa5ab7811089615d4dc93970fbfe1d","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_resource(identity_client, name_type_or_id):"},{"line_number":72,"context_line":"    # NOTE (vishakha): Due to bug #1799153 and for any another related case"},{"line_number":73,"context_line":"    # created a new function get_resource which can be used in future"},{"line_number":74,"context_line":"    # too by these types of API\u0027s."},{"line_number":75,"context_line":"    \"\"\"Find a resource by id or name.\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8faf7f7b","line":74,"range":{"start_line":72,"start_character":47,"end_line":74,"end_character":34},"in_reply_to":"3f79a3b5_ac236912","updated":"2018-10-31 02:49:55.000000000","message":"Done","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1966922aa4ddc1cd8c8e3d6d14e592a5cd4f05e7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        raise exceptions.CommandError(msg % name_type_or_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_resource(identity_client, name_type_or_id):"},{"line_number":72,"context_line":"    # NOTE (vishakha): Due to bug #1799153 and for any another related case"},{"line_number":73,"context_line":"    # where GET resource API does not support the filter by name,"},{"line_number":74,"context_line":"    # osc_lib.utils.find_resource() method cannot be used because that method"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_264f6d8d","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":32},"updated":"2018-10-31 13:01:44.000000000","message":"this is confusing as you are passing identity_client.regions from caller and this param name looks like caller need to pass the identity client only. \n\nmay be you can rename it to \u0027manager\u0027 like in https://github.com/openstack/osc-lib/blob/8e9e50cc3cc34999a5b447d0bb3ff4e14e86c29f/osc_lib/utils/__init__.py#L169","commit_id":"7932563a355cb0f4d3654fb3ceb5246eda393c3b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"20328ec82224baea1da74d38855e2a882c94c8d3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        raise exceptions.CommandError(msg % name_type_or_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_resource(identity_client, name_type_or_id):"},{"line_number":72,"context_line":"    # NOTE (vishakha): Due to bug #1799153 and for any another related case"},{"line_number":73,"context_line":"    # where GET resource API does not support the filter by name,"},{"line_number":74,"context_line":"    # osc_lib.utils.find_resource() method cannot be used because that method"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9839eea3","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":32},"in_reply_to":"3f79a3b5_264f6d8d","updated":"2018-11-01 01:25:39.000000000","message":"Done","commit_id":"7932563a355cb0f4d3654fb3ceb5246eda393c3b"}],"openstackclient/identity/v3/limit.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ed4609f6467443fa70795cd3884ff0f16269991","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            identity_client, parsed_args.service"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        region \u003d None"},{"line_number":80,"context_line":"        if parsed_args.region:"},{"line_number":81,"context_line":"            val \u003d getattr(parsed_args, \u0027region\u0027, None)"},{"line_number":82,"context_line":"            if \u0027None\u0027 not in val:"},{"line_number":83,"context_line":"                region \u003d common_utils.get_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2c20b9f9","line":80,"range":{"start_line":80,"start_character":29,"end_line":80,"end_character":30},"updated":"2018-10-31 01:53:41.000000000","message":"can you add a NOTE here too about why you cannot use \nutils.find_resource() here. same details like in get_resource(). \n\nThat will help to find the reason easily in future.","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"7dcc196daffa5ab7811089615d4dc93970fbfe1d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            identity_client, parsed_args.service"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        region \u003d None"},{"line_number":80,"context_line":"        if parsed_args.region:"},{"line_number":81,"context_line":"            val \u003d getattr(parsed_args, \u0027region\u0027, None)"},{"line_number":82,"context_line":"            if \u0027None\u0027 not in val:"},{"line_number":83,"context_line":"                region \u003d common_utils.get_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2fc42b42","line":80,"range":{"start_line":80,"start_character":29,"end_line":80,"end_character":30},"in_reply_to":"3f79a3b5_2c20b9f9","updated":"2018-10-31 02:49:55.000000000","message":"Done","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ed4609f6467443fa70795cd3884ff0f16269991","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                identity_client, parsed_args.service"},{"line_number":130,"context_line":"            )"},{"line_number":131,"context_line":"        region \u003d None"},{"line_number":132,"context_line":"        if parsed_args.region:"},{"line_number":133,"context_line":"            val \u003d getattr(parsed_args, \u0027region\u0027, None)"},{"line_number":134,"context_line":"            if \u0027None\u0027 not in val:"},{"line_number":135,"context_line":"                region \u003d common_utils.get_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0c17fd9f","line":132,"range":{"start_line":132,"start_character":29,"end_line":132,"end_character":30},"updated":"2018-10-31 01:53:41.000000000","message":"ditto","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8cbccda56dc3f84b742de6d8e8f9099a7106597e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                # filter by name, osc_lib.utils.find_resource() method cannot"},{"line_number":86,"context_line":"                # be used because that method try to fall back to list all the"},{"line_number":87,"context_line":"                # resource if requested resource cannot be get via name. Which"},{"line_number":88,"context_line":"                # ends up with NoUniqueMatch error. This new function is the"},{"line_number":89,"context_line":"                # replacement for osc_lib.utils.find_resource() for resources"},{"line_number":90,"context_line":"                # does not support GET by name."},{"line_number":91,"context_line":"                # For example: identity GET /regions."},{"line_number":92,"context_line":"                region \u003d common_utils.get_resource("},{"line_number":93,"context_line":"                    identity_client.regions, parsed_args.region"},{"line_number":94,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fb86f15f","line":91,"range":{"start_line":88,"start_character":52,"end_line":91,"end_character":53},"updated":"2018-10-31 08:50:23.000000000","message":"these lines can be replaced by - \n\nSo osc_lib.utils.find_resource() fucntion cannot be used for \u0027regions\u0027, using common_utils.get_resource() instead.","commit_id":"dbb0b5b053e0deddcaece2ad71d49e3735fa1e6b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8cbccda56dc3f84b742de6d8e8f9099a7106597e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                # filter by name, osc_lib.utils.find_resource() method cannot"},{"line_number":147,"context_line":"                # be used because that method try to fall back to list all the"},{"line_number":148,"context_line":"                # resource if requested resource cannot be get via name. Which"},{"line_number":149,"context_line":"                # ends up with NoUniqueMatch error. This new function is the"},{"line_number":150,"context_line":"                # replacement for osc_lib.utils.find_resource() for resources"},{"line_number":151,"context_line":"                # does not support GET by name."},{"line_number":152,"context_line":"                # For example: identity GET /regions."},{"line_number":153,"context_line":"                region \u003d common_utils.get_resource("},{"line_number":154,"context_line":"                    identity_client.regions, parsed_args.region"},{"line_number":155,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9be1fd34","line":152,"range":{"start_line":149,"start_character":52,"end_line":152,"end_character":53},"updated":"2018-10-31 08:50:23.000000000","message":"ditto and other place too","commit_id":"dbb0b5b053e0deddcaece2ad71d49e3735fa1e6b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1966922aa4ddc1cd8c8e3d6d14e592a5cd4f05e7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                # ends up with NoUniqueMatch error."},{"line_number":89,"context_line":"                # So osc_lib.utils.find_resource() function cannot be used for"},{"line_number":90,"context_line":"                # \u0027regions\u0027, using common_utils.get_resource() instead."},{"line_number":91,"context_line":"                # For example: identity GET /regions."},{"line_number":92,"context_line":"                region \u003d common_utils.get_resource("},{"line_number":93,"context_line":"                    identity_client.regions, parsed_args.region"},{"line_number":94,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e6bbb571","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":53},"updated":"2018-10-31 13:01:44.000000000","message":"this is not needed here and confusing. \n\nother place too","commit_id":"7932563a355cb0f4d3654fb3ceb5246eda393c3b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"20328ec82224baea1da74d38855e2a882c94c8d3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                # ends up with NoUniqueMatch error."},{"line_number":89,"context_line":"                # So osc_lib.utils.find_resource() function cannot be used for"},{"line_number":90,"context_line":"                # \u0027regions\u0027, using common_utils.get_resource() instead."},{"line_number":91,"context_line":"                # For example: identity GET /regions."},{"line_number":92,"context_line":"                region \u003d common_utils.get_resource("},{"line_number":93,"context_line":"                    identity_client.regions, parsed_args.region"},{"line_number":94,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b83e2a88","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":53},"in_reply_to":"3f79a3b5_e6bbb571","updated":"2018-11-01 01:25:39.000000000","message":"Done","commit_id":"7932563a355cb0f4d3654fb3ceb5246eda393c3b"}],"openstackclient/identity/v3/registered_limit.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ed4609f6467443fa70795cd3884ff0f16269991","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            identity_client.services, parsed_args.service"},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":"        region \u003d None"},{"line_number":71,"context_line":"        if parsed_args.region:"},{"line_number":72,"context_line":"            val \u003d getattr(parsed_args, \u0027region\u0027, None)"},{"line_number":73,"context_line":"            if \u0027None\u0027 not in val:"},{"line_number":74,"context_line":"                region \u003d common_utils.get_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ac712916","line":71,"range":{"start_line":71,"start_character":29,"end_line":71,"end_character":30},"updated":"2018-10-31 01:53:41.000000000","message":"ditto. other place too","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"7dcc196daffa5ab7811089615d4dc93970fbfe1d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            identity_client.services, parsed_args.service"},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":"        region \u003d None"},{"line_number":71,"context_line":"        if parsed_args.region:"},{"line_number":72,"context_line":"            val \u003d getattr(parsed_args, \u0027region\u0027, None)"},{"line_number":73,"context_line":"            if \u0027None\u0027 not in val:"},{"line_number":74,"context_line":"                region \u003d common_utils.get_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_efbdd3b2","line":71,"range":{"start_line":71,"start_character":29,"end_line":71,"end_character":30},"in_reply_to":"3f79a3b5_ac712916","updated":"2018-10-31 02:49:55.000000000","message":"Added in all places.","commit_id":"32f9a042fc24c2c7bf909463328902241663de79"}]}