)]}'
{"openstackclient/network/v2/router.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f2eecc64e9595a4a322f0616a890f0a500e8486","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                original_net_id \u003d obj.external_gateway_info[\u0027network_id\u0027]"},{"line_number":657,"context_line":"            except (KeyError, TypeError):"},{"line_number":658,"context_line":"                msg \u003d (_(\"You must specify \u0027--external-gateway\u0027 or the router \""},{"line_number":659,"context_line":"                         \"must already have a external network in order to \""},{"line_number":660,"context_line":"                         \"set router gateway IP QoS\"))"},{"line_number":661,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":662,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0890def1","line":659,"range":{"start_line":659,"start_character":44,"end_line":659,"end_character":45},"updated":"2018-12-05 08:48:54.000000000","message":"nit: an","commit_id":"81656b7f54296dbd279d729fa3ed38b7c13830e4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"270833b5282439dbebae9fba5116c5f98b393e9b","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                original_net_id \u003d obj.external_gateway_info[\u0027network_id\u0027]"},{"line_number":657,"context_line":"            except (KeyError, TypeError):"},{"line_number":658,"context_line":"                msg \u003d (_(\"You must specify \u0027--external-gateway\u0027 or the router \""},{"line_number":659,"context_line":"                         \"must already have a external network in order to \""},{"line_number":660,"context_line":"                         \"set router gateway IP QoS\"))"},{"line_number":661,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":662,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_339acd74","line":659,"range":{"start_line":659,"start_character":44,"end_line":659,"end_character":45},"in_reply_to":"3f79a3b5_0890def1","updated":"2018-12-06 10:00:18.000000000","message":"Done","commit_id":"81656b7f54296dbd279d729fa3ed38b7c13830e4"}],"openstackclient/tests/unit/network/v2/test_router.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9718fb81b804cb602d05fb99049683febd364558","unresolved":false,"context_lines":[{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        self.assertRaises(tests_utils.ParserException, self.check_parser,"},{"line_number":1175,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"class TestShowRouter(TestRouter):"},{"line_number":1179,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9acd3093","line":1176,"updated":"2018-12-04 10:28:57.000000000","message":"Maybe You can also add test case where there is no external_gateway to check if proper exception will be raised.","commit_id":"9834723828644bdb5ccad32eb61ae54a5c2109ca"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f2eecc64e9595a4a322f0616a890f0a500e8486","unresolved":false,"context_lines":[{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    def test_unset_with_all_tag(self):"},{"line_number":1394,"context_line":"        self._test_unset_tags(with_tags\u003dFalse)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"    def test_unset_router_qos_policy(self):"},{"line_number":1397,"context_line":"        arglist \u003d ["},{"line_number":1398,"context_line":"            \u0027--qos-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a33d4be7","line":1395,"updated":"2018-12-05 08:48:54.000000000","message":"The coverage fetishistic arrived:\nI miss here a test for unset without gateway and qos policy, like:\ntest_unset_router_qos_no_gateway\ntest_unset_router_qos_no_qos","commit_id":"81656b7f54296dbd279d729fa3ed38b7c13830e4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"270833b5282439dbebae9fba5116c5f98b393e9b","unresolved":false,"context_lines":[{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    def test_unset_with_all_tag(self):"},{"line_number":1394,"context_line":"        self._test_unset_tags(with_tags\u003dFalse)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"    def test_unset_router_qos_policy(self):"},{"line_number":1397,"context_line":"        arglist \u003d ["},{"line_number":1398,"context_line":"            \u0027--qos-policy\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_73be05d0","line":1395,"in_reply_to":"3f79a3b5_a33d4be7","updated":"2018-12-06 10:00:18.000000000","message":"Done","commit_id":"81656b7f54296dbd279d729fa3ed38b7c13830e4"}]}