)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - \"os network segment range show\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially-implements: blueprint network-segment-range-management"},{"line_number":24,"context_line":"Change-Id: I335692f2db5be07c1c164f09b13f1abb80b7ba33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_b2040019","line":22,"updated":"2018-12-30 13:12:33.000000000","message":"Could you add Depends-On?\nThis depends on patch(es) in the neutron side, so we need to know when this patch is ready to merge.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - \"os network segment range show\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially-implements: blueprint network-segment-range-management"},{"line_number":24,"context_line":"Change-Id: I335692f2db5be07c1c164f09b13f1abb80b7ba33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_5bea5b75","line":22,"in_reply_to":"1f769fc5_b2040019","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Neutron patch dependencies:"},{"line_number":22,"context_line":"- https://review.openstack.org/624708"},{"line_number":23,"context_line":"- https://review.openstack.org/624709"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Partially-implements: blueprint network-segment-range-management"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_be45c545","line":24,"updated":"2019-02-04 16:20:48.000000000","message":"Please use the Depends-On: syntax for these, and put them in the last section near Change-Id:","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Neutron patch dependencies:"},{"line_number":22,"context_line":"- https://review.openstack.org/624708"},{"line_number":23,"context_line":"- https://review.openstack.org/624709"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Partially-implements: blueprint network-segment-range-management"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fdfeff1_c102240a","line":24,"in_reply_to":"9fdfeff1_be45c545","updated":"2019-02-05 02:04:58.000000000","message":"Thanks, yes, I should have done that.\nThe reason why I did not use depends-on syntax is because last time it failed the Zuul in the PS w/ depends-on even though the depends-on patches have no issue w/ CI. Let\u0027s see how it goes this time.","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7fb6436e3e14c0e1a326bad3a56c7d64544a55dc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  - \"os network segment range create\""},{"line_number":16,"context_line":"  - \"os network segment range delete\""},{"line_number":17,"context_line":"  - \"os network segment range list\""},{"line_number":18,"context_line":"  - \"os network segment range set\""},{"line_number":19,"context_line":"  - \"os network segment range show\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9fdfeff1_4430f055","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":33},"updated":"2019-02-26 15:45:35.000000000","message":"I\u0027ve run the code locally, seems this command does not have any output, so user needs to run show command again, it\u0027s better to print the result of the update.\nhttps://review.openstack.org/#/c/639110/3/doc/source/admin/config-network-segment-ranges.rst@189","commit_id":"5522663cc58b6f5c6ffc82b5cdf966ff9a11ee50"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"3c1eccf9b3d5afad18603e936888b5291de076ce","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  - \"os network segment range create\""},{"line_number":16,"context_line":"  - \"os network segment range delete\""},{"line_number":17,"context_line":"  - \"os network segment range list\""},{"line_number":18,"context_line":"  - \"os network segment range set\""},{"line_number":19,"context_line":"  - \"os network segment range show\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9fdfeff1_d389f625","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":33},"in_reply_to":"9fdfeff1_4430f055","updated":"2019-02-27 06:59:54.000000000","message":"Thanks Yulong, I was previously thinking about printing the results of the update but I found that most other set operations do not print results.\nPersonally I agree w/ you that it\u0027s more useful to have the results returned. I\u0027ve updated the PS.","commit_id":"5522663cc58b6f5c6ffc82b5cdf966ff9a11ee50"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"cd60c8a0783cda16ef381fbaf662b8446062272f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  - \"os network segment range create\""},{"line_number":16,"context_line":"  - \"os network segment range delete\""},{"line_number":17,"context_line":"  - \"os network segment range list\""},{"line_number":18,"context_line":"  - \"os network segment range set\""},{"line_number":19,"context_line":"  - \"os network segment range show\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-authored-by: Allain Legacy \u003cAllain.legacy@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9fdfeff1_c6904451","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":33},"in_reply_to":"9fdfeff1_d389f625","updated":"2019-02-27 19:27:44.000000000","message":"In OSC set commands do not produce output.","commit_id":"5522663cc58b6f5c6ffc82b5cdf966ff9a11ee50"}],"doc/source/cli/command-objects/network_segment_range.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":19,"context_line":".. code:: bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    openstack network segment range create"},{"line_number":22,"context_line":"        [--project-id \u003cproject-id\u003e]"},{"line_number":23,"context_line":"        [--physical-network \u003cphysical-network\u003e]"},{"line_number":24,"context_line":"        --shared \u003cshard\u003e"},{"line_number":25,"context_line":"        --network-type \u003cnetwork-type\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7e3581d2","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":34},"updated":"2018-12-18 19:59:58.000000000","message":"Follow the OSC pattern here: --project \u003cproject\u003e, where \u003cproject\u003e can be a name or an ID","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":19,"context_line":".. code:: bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    openstack network segment range create"},{"line_number":22,"context_line":"        [--project-id \u003cproject-id\u003e]"},{"line_number":23,"context_line":"        [--physical-network \u003cphysical-network\u003e]"},{"line_number":24,"context_line":"        --shared \u003cshard\u003e"},{"line_number":25,"context_line":"        --network-type \u003cnetwork-type\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_92bc8dbc","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":34},"in_reply_to":"3f79a3b5_7e3581d2","updated":"2018-12-24 14:39:17.000000000","message":"Done","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    openstack network segment range create"},{"line_number":22,"context_line":"        [--project-id \u003cproject-id\u003e]"},{"line_number":23,"context_line":"        [--physical-network \u003cphysical-network\u003e]"},{"line_number":24,"context_line":"        --shared \u003cshard\u003e"},{"line_number":25,"context_line":"        --network-type \u003cnetwork-type\u003e"},{"line_number":26,"context_line":"        --minimum \u003cminimum\u003e"},{"line_number":27,"context_line":"        --maximum \u003cmaximum\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_5e8f6576","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":24},"updated":"2018-12-18 19:59:58.000000000","message":"What value is given here?  If this is a boolean, use \"--shared | --private\" or something like that.  Image has a visibility attribute that uses --public|--privare|--shared for example.  We want to directly use the state, not use the attribute/value option unless the number of values is large.\n\nAlso, we should have a default value.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    openstack network segment range create"},{"line_number":22,"context_line":"        [--project-id \u003cproject-id\u003e]"},{"line_number":23,"context_line":"        [--physical-network \u003cphysical-network\u003e]"},{"line_number":24,"context_line":"        --shared \u003cshard\u003e"},{"line_number":25,"context_line":"        --network-type \u003cnetwork-type\u003e"},{"line_number":26,"context_line":"        --minimum \u003cminimum\u003e"},{"line_number":27,"context_line":"        --maximum \u003cmaximum\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_f5260b17","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":24},"in_reply_to":"3f79a3b5_5e8f6576","updated":"2018-12-24 14:39:17.000000000","message":"Done","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. option:: --project-id \u003cproject-id\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Network segment range owner. Optional when the segment range is shared"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --physical-network \u003cphysical-network\u003e"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7ef8214a","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":74},"updated":"2018-12-18 19:59:58.000000000","message":"Does it make sense to default this to the authenticated project if it is not specified?\n\nIf this command is used by a project admin that seems reasonable.  If it is only used by cloud admins creating ranges for other projects then it may not make sense.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. option:: --project-id \u003cproject-id\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Network segment range owner. Optional when the segment range is shared"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --physical-network \u003cphysical-network\u003e"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_957d57e9","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":74},"in_reply_to":"3f79a3b5_7ef8214a","updated":"2018-12-24 14:39:17.000000000","message":"It is only used by cloud admins creating ranges for other projects. So I suppose it does not make sense to default this to the authenticated project if unspecified.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Network segment range owner. Optional when the segment range is shared"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --physical-network \u003cphysical-network\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Physical network name of this network segment range"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1e748dcd","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":30},"updated":"2018-12-18 19:59:58.000000000","message":"This looks like a very similar option to network create --provider-physical-network.  I prefer to use the same option name when describing the same thing in different commands.\n\nAlso, when only a name or an ID is an acceptable value, I like to use \u003c...-id\u003e or \u003c...-name\u003e in the metavar.  That is not done everywhere right now but it probably should be...","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Network segment range owner. Optional when the segment range is shared"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --physical-network \u003cphysical-network\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Physical network name of this network segment range"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_4bcba0a4","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":30},"in_reply_to":"3f79a3b5_1e748dcd","updated":"2018-12-24 14:39:17.000000000","message":"Indeed, it\u0027s a very similar option. However, network segment range is not necessarily proposed based on the Neutron-defined provider networks. We were actually trying to not use terms like \"provider\" to avoid bringing further confusions. \nI\u0027ll leave this open for now and let the Neutron team to decide which one is better.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Network segment range is shared with other projects"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. option:: --network-type \u003cnetwork-type\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Network type of this network segment range"},{"line_number":45,"context_line":"    (geneve, gre, vlan or vxlan)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_3e9ce9ff","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":26},"updated":"2018-12-18 19:59:58.000000000","message":"This looks like a very similar option to network create --provider-network-type.  I prefer to use the same option name when describing the same thing in different commands.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Network segment range is shared with other projects"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. option:: --network-type \u003cnetwork-type\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Network type of this network segment range"},{"line_number":45,"context_line":"    (geneve, gre, vlan or vxlan)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_ebb4ec37","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":26},"in_reply_to":"3f79a3b5_3e9ce9ff","updated":"2018-12-24 14:39:17.000000000","message":"Please kindly see my comment above.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    Network type of this network segment range"},{"line_number":45,"context_line":"    (geneve, gre, vlan or vxlan)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --minimum \u003cminimum\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Minimum segment identifier for this network segment range which is based"},{"line_number":50,"context_line":"    on the network type, VLAN ID for vlan network type and tunnel ID for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fe5c31f0","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":30},"updated":"2018-12-18 19:59:58.000000000","message":"This should give some idea as to what kind of value is expected here.  Since it is different types of ID, I would at least use \u003cminimum-id\u003e...\n\nSame below","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    Network type of this network segment range"},{"line_number":45,"context_line":"    (geneve, gre, vlan or vxlan)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --minimum \u003cminimum\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Minimum segment identifier for this network segment range which is based"},{"line_number":50,"context_line":"    on the network type, VLAN ID for vlan network type and tunnel ID for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_7513dbb9","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":30},"in_reply_to":"3f79a3b5_fe5c31f0","updated":"2018-12-24 14:39:17.000000000","message":"Done","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    openstack network segment range list"},{"line_number":89,"context_line":"        [--long]"},{"line_number":90,"context_line":"        [--available]"},{"line_number":91,"context_line":"        [--not-available]"},{"line_number":92,"context_line":"        [--used]"},{"line_number":93,"context_line":"        [--not-used]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_3e5e29e2","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":25},"updated":"2018-12-18 19:59:58.000000000","message":"These kinds of pairs should be written as exclusive groups:  --available | --not-available\n\nAnd implemented that way with argparse groups","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    openstack network segment range list"},{"line_number":89,"context_line":"        [--long]"},{"line_number":90,"context_line":"        [--available]"},{"line_number":91,"context_line":"        [--not-available]"},{"line_number":92,"context_line":"        [--used]"},{"line_number":93,"context_line":"        [--not-used]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_d5442fba","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":25},"in_reply_to":"3f79a3b5_3e5e29e2","updated":"2018-12-24 14:39:17.000000000","message":"Done","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. option:: --used"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    List network segment ranges that have segments not in use currently"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. option:: --unused"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9fdfeff1_63610a12","line":109,"range":{"start_line":109,"start_character":51,"end_line":109,"end_character":71},"updated":"2019-02-04 16:20:48.000000000","message":"should this be \"in use\"?  Drop the \u0027currently\u0027 here and below","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. option:: --used"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    List network segment ranges that have segments not in use currently"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. option:: --unused"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9fdfeff1_e2bacb08","line":109,"range":{"start_line":109,"start_character":51,"end_line":109,"end_character":71},"in_reply_to":"9fdfeff1_63610a12","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"adba429b60d8caad8957572eabc69bacec9aa318","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. option:: --used"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    List network segment ranges that have segments not in use"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. option:: --unused"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9fdfeff1_51a682c3","line":109,"range":{"start_line":109,"start_character":51,"end_line":109,"end_character":61},"updated":"2019-02-25 22:29:54.000000000","message":"Should this be \u0027in use\u0027?","commit_id":"559db36564a85186b8087e1b18b2afce75ffcbb3"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"e3260cfa34f15d1ccd0f14d9e5f98e27f58cb69e","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. option:: --used"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    List network segment ranges that have segments not in use"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. option:: --unused"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9fdfeff1_06475a79","line":109,"range":{"start_line":109,"start_character":51,"end_line":109,"end_character":61},"in_reply_to":"9fdfeff1_51a682c3","updated":"2019-02-26 05:46:42.000000000","message":"Yes, nice catch. Thanks Dean.","commit_id":"559db36564a85186b8087e1b18b2afce75ffcbb3"}],"openstackclient/network/v2/network_segment_range.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":"        parser.add_argument("},{"line_number":102,"context_line":"            \u0027--shared\u0027,"},{"line_number":103,"context_line":"            metavar\u003d\u0027\u003cshared\u003e\u0027,"},{"line_number":104,"context_line":"            required\u003dTrue,"},{"line_number":105,"context_line":"            help\u003d_(\u0027Network segment range is shared with other projects\u0027),"},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5ec76567","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":28},"updated":"2018-12-18 19:59:58.000000000","message":"There is no indication what kind of value this needs to be.  As mentioned in the doc file, if there is a small number of possible values it should be implmented directly as an exclusive group of those values.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":"        parser.add_argument("},{"line_number":102,"context_line":"            \u0027--shared\u0027,"},{"line_number":103,"context_line":"            metavar\u003d\u0027\u003cshared\u003e\u0027,"},{"line_number":104,"context_line":"            required\u003dTrue,"},{"line_number":105,"context_line":"            help\u003d_(\u0027Network segment range is shared with other projects\u0027),"},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_5587bfd8","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":28},"in_reply_to":"3f79a3b5_5ec76567","updated":"2018-12-24 14:39:17.000000000","message":"Done","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7c118554c1f899490a22b0ea2bc9772bad6f244c","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        obj \u003d network_client.find_network_segment_range("},{"line_number":357,"context_line":"            parsed_args.network_segment_range, ignore_missing\u003dFalse)"},{"line_number":358,"context_line":"        attrs \u003d {}"},{"line_number":359,"context_line":"        if parsed_args.name is not None:"},{"line_number":360,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":361,"context_line":"        network_client.update_network_segment_range(obj, **attrs)"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fe10b1ac","line":359,"updated":"2018-12-18 19:59:58.000000000","message":"minimum and maximum are not used here?","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"394329e47137c140c2545add78ee66f06fe94dab","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        obj \u003d network_client.find_network_segment_range("},{"line_number":357,"context_line":"            parsed_args.network_segment_range, ignore_missing\u003dFalse)"},{"line_number":358,"context_line":"        attrs \u003d {}"},{"line_number":359,"context_line":"        if parsed_args.name is not None:"},{"line_number":360,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":361,"context_line":"        network_client.update_network_segment_range(obj, **attrs)"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_f56b6b1c","line":359,"in_reply_to":"3f79a3b5_fe10b1ac","updated":"2018-12-24 14:39:17.000000000","message":"Thanks for pointing this out. Done and associated w/ tests.","commit_id":"da8ddbb68a1a23caeaacc898058c9294c5425dbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \"--private\","},{"line_number":99,"context_line":"            dest\u003d\"private\","},{"line_number":100,"context_line":"            action\u003d\"store_true\","},{"line_number":101,"context_line":"            default\u003dFalse,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Network segment range is assigned specifically to the \u0027"},{"line_number":103,"context_line":"                   \u0027project\u0027),"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_3dff6102","line":101,"updated":"2018-12-30 13:12:33.000000000","message":"default\u003dFalse is unnecessary as this is the default value when \u0027store_ture\u0027 is specified.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \"--private\","},{"line_number":99,"context_line":"            dest\u003d\"private\","},{"line_number":100,"context_line":"            action\u003d\"store_true\","},{"line_number":101,"context_line":"            default\u003dFalse,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Network segment range is assigned specifically to the \u0027"},{"line_number":103,"context_line":"                   \u0027project\u0027),"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_7c04f217","line":101,"in_reply_to":"1f769fc5_3dff6102","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \"--shared\","},{"line_number":107,"context_line":"            dest\u003d\"shared\","},{"line_number":108,"context_line":"            action\u003d\"store_true\","},{"line_number":109,"context_line":"            default\u003dFalse,"},{"line_number":110,"context_line":"            help\u003d_(\u0027Network segment range is shared with other projects\u0027),"},{"line_number":111,"context_line":"        )"},{"line_number":112,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_5d049d15","line":109,"updated":"2018-12-30 13:12:33.000000000","message":"ditto","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \"--shared\","},{"line_number":107,"context_line":"            dest\u003d\"shared\","},{"line_number":108,"context_line":"            action\u003d\"store_true\","},{"line_number":109,"context_line":"            default\u003dFalse,"},{"line_number":110,"context_line":"            help\u003d_(\u0027Network segment range is shared with other projects\u0027),"},{"line_number":111,"context_line":"        )"},{"line_number":112,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_f70d7d37","line":109,"in_reply_to":"1f769fc5_5d049d15","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        parser.add_argument("},{"line_number":113,"context_line":"            \u0027name\u0027,"},{"line_number":114,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":115,"context_line":"            help\u003d_(\u0027New network segment range name\u0027)"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_fd080929","line":115,"updated":"2018-12-30 13:12:33.000000000","message":"I think \"name of new network segment range\" is easy to read.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        parser.add_argument("},{"line_number":113,"context_line":"            \u0027name\u0027,"},{"line_number":114,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":115,"context_line":"            help\u003d_(\u0027New network segment range name\u0027)"},{"line_number":116,"context_line":"        )"},{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_f726ddb7","line":115,"in_reply_to":"1f769fc5_fd080929","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":120,"context_line":"            help\u003d_(\u0027Network segment range owner (name or ID). Optional when \u0027"},{"line_number":121,"context_line":"                   \u0027the segment range is shared\u0027),"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":"        parser.add_argument("},{"line_number":124,"context_line":"            \u0027--network-type\u0027,"},{"line_number":125,"context_line":"            metavar\u003d\u0027\u003cnetwork-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_1d0e2534","line":122,"updated":"2018-12-30 13:12:33.000000000","message":"--project-domain is also required.\nA project name is unique inside a domain, so domain information is required to resolve a project name to project ID.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":120,"context_line":"            help\u003d_(\u0027Network segment range owner (name or ID). Optional when \u0027"},{"line_number":121,"context_line":"                   \u0027the segment range is shared\u0027),"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":"        parser.add_argument("},{"line_number":124,"context_line":"            \u0027--network-type\u0027,"},{"line_number":125,"context_line":"            metavar\u003d\u0027\u003cnetwork-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_77e3ad34","line":122,"in_reply_to":"1f769fc5_1d0e2534","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if parsed_args.shared and parsed_args.project:"},{"line_number":164,"context_line":"            msg \u003d _(\"--project is only allowed with --private\")"},{"line_number":165,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if parsed_args.private and not parsed_args.project:"},{"line_number":168,"context_line":"            msg \u003d _(\"--project is required with --private\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_bd129157","line":165,"updated":"2018-12-30 13:12:33.000000000","message":"Consier using the mutually exclusive group rather than checking them here.\nhttps://docs.python.org/3/library/argparse.html#mutual-exclusion","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if parsed_args.shared and parsed_args.project:"},{"line_number":164,"context_line":"            msg \u003d _(\"--project is only allowed with --private\")"},{"line_number":165,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if parsed_args.private and not parsed_args.project:"},{"line_number":168,"context_line":"            msg \u003d _(\"--project is required with --private\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_17d2795d","line":165,"in_reply_to":"1f769fc5_bd129157","updated":"2019-01-02 09:59:05.000000000","message":"What we want is something like:\ncommand [ --shared | [ --private --project xxx ]].\nMutually exclusive group cannot make the group of \"--private --project xxx\" mutually exclusive with \"--shared\". And we\u0027ve already added exclusive group for --shared and --private.\nThough sub-commands [1] can do the trick, as this case is simple enough, IMO manually checking/handling the options should be OK.\n\n[1] https://docs.python.org/dev/library/argparse.html#sub-commands","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if parsed_args.network_type.lower() !\u003d \u0027vlan\u0027 and \\"},{"line_number":172,"context_line":"                parsed_args.physical_network:"},{"line_number":173,"context_line":"            msg \u003d _(\"--physical-network is only allowed with --network-type \""},{"line_number":174,"context_line":"                    \"vlan\")"},{"line_number":175,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_dd0f4d2c","line":172,"updated":"2018-12-30 13:12:33.000000000","message":"Consider using parentheses rather than using a backslash.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if parsed_args.network_type.lower() !\u003d \u0027vlan\u0027 and \\"},{"line_number":172,"context_line":"                parsed_args.physical_network:"},{"line_number":173,"context_line":"            msg \u003d _(\"--physical-network is only allowed with --network-type \""},{"line_number":174,"context_line":"                    \"vlan\")"},{"line_number":175,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_57e6b146","line":172,"in_reply_to":"1f769fc5_dd0f4d2c","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \"vlan\")"},{"line_number":175,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        attrs \u003d dict()"},{"line_number":178,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":179,"context_line":"        attrs[\u0027network_type\u0027] \u003d parsed_args.network_type"},{"line_number":180,"context_line":"        attrs[\u0027minimum\u0027] \u003d parsed_args.minimum"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_7d1cf969","line":177,"updated":"2018-12-30 13:12:33.000000000","message":"Use {} instead.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \"vlan\")"},{"line_number":175,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        attrs \u003d dict()"},{"line_number":178,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":179,"context_line":"        attrs[\u0027network_type\u0027] \u003d parsed_args.network_type"},{"line_number":180,"context_line":"        attrs[\u0027minimum\u0027] \u003d parsed_args.minimum"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_573551d9","line":177,"in_reply_to":"1f769fc5_7d1cf969","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                   \u0027currently\u0027),"},{"line_number":258,"context_line":"        )"},{"line_number":259,"context_line":"        used_group.add_argument("},{"line_number":260,"context_line":"            \u0027--not-used\u0027,"},{"line_number":261,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":262,"context_line":"            default\u003dFalse,"},{"line_number":263,"context_line":"            help\u003d_(\u0027List network segment ranges that have segments not in use \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_9d19d57a","line":260,"updated":"2018-12-30 13:12:33.000000000","message":"\"unused\"?","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                   \u0027currently\u0027),"},{"line_number":258,"context_line":"        )"},{"line_number":259,"context_line":"        used_group.add_argument("},{"line_number":260,"context_line":"            \u0027--not-used\u0027,"},{"line_number":261,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":262,"context_line":"            default\u003dFalse,"},{"line_number":263,"context_line":"            help\u003d_(\u0027List network segment ranges that have segments not in use \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_574a3155","line":260,"in_reply_to":"1f769fc5_9d19d57a","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                   \u0027currently\u0027),"},{"line_number":273,"context_line":"        )"},{"line_number":274,"context_line":"        available_group.add_argument("},{"line_number":275,"context_line":"            \u0027--not-available\u0027,"},{"line_number":276,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":277,"context_line":"            default\u003dFalse,"},{"line_number":278,"context_line":"            help\u003d_(\u0027List network segment ranges that do not have available \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_3d28c184","line":275,"updated":"2018-12-30 13:12:33.000000000","message":"unavailable?","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                   \u0027currently\u0027),"},{"line_number":273,"context_line":"        )"},{"line_number":274,"context_line":"        available_group.add_argument("},{"line_number":275,"context_line":"            \u0027--not-available\u0027,"},{"line_number":276,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":277,"context_line":"            default\u003dFalse,"},{"line_number":278,"context_line":"            help\u003d_(\u0027List network segment ranges that do not have available \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_1776f9a5","line":275,"in_reply_to":"1f769fc5_3d28c184","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            \u0027--not-available\u0027,"},{"line_number":276,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":277,"context_line":"            default\u003dFalse,"},{"line_number":278,"context_line":"            help\u003d_(\u0027List network segment ranges that do not have available \u0027"},{"line_number":279,"context_line":"                   \u0027segments currently\u0027),"},{"line_number":280,"context_line":"        )"},{"line_number":281,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_5d2d7d93","line":278,"updated":"2018-12-30 13:12:33.000000000","message":"\"List network segment ranges without available segments\"","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            \u0027--not-available\u0027,"},{"line_number":276,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":277,"context_line":"            default\u003dFalse,"},{"line_number":278,"context_line":"            help\u003d_(\u0027List network segment ranges that do not have available \u0027"},{"line_number":279,"context_line":"                   \u0027segments currently\u0027),"},{"line_number":280,"context_line":"        )"},{"line_number":281,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_377bf58c","line":278,"in_reply_to":"1f769fc5_5d2d7d93","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63c16452e687eef695f4919398fadbfefd711ba3","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            \u0027Project ID\u0027,"},{"line_number":295,"context_line":"            \u0027Network Type\u0027,"},{"line_number":296,"context_line":"            \u0027Physical Network\u0027,"},{"line_number":297,"context_line":"            \u0027Minimum\u0027,"},{"line_number":298,"context_line":"            \u0027Maximum\u0027"},{"line_number":299,"context_line":"        )"},{"line_number":300,"context_line":"        columns \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_fd21e9a0","line":297,"updated":"2018-12-30 13:12:33.000000000","message":"I think \"Minimum ID\" or \"Min ID\" sounds better.","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"620f7dde42d6e9377c59ee96e5fa7536cf24edb3","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            \u0027Project ID\u0027,"},{"line_number":295,"context_line":"            \u0027Network Type\u0027,"},{"line_number":296,"context_line":"            \u0027Physical Network\u0027,"},{"line_number":297,"context_line":"            \u0027Minimum\u0027,"},{"line_number":298,"context_line":"            \u0027Maximum\u0027"},{"line_number":299,"context_line":"        )"},{"line_number":300,"context_line":"        columns \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_9769a9bf","line":297,"in_reply_to":"1f769fc5_fd21e9a0","updated":"2019-01-02 09:59:05.000000000","message":"Done","commit_id":"ccbea25c422535288cb864e153f74a5b108daae7"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--minimum\u0027,"},{"line_number":137,"context_line":"            metavar\u003d\u0027\u003cminimum-segmentation-id\u003e\u0027,"},{"line_number":138,"context_line":"            type\u003dint,"},{"line_number":139,"context_line":"            required\u003dTrue,"},{"line_number":140,"context_line":"            help\u003d_(\u0027Minimum segment identifier for this network segment \u0027"},{"line_number":141,"context_line":"                   \u0027range which is based on the network type, VLAN ID for \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_fe926d9f","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":21},"updated":"2019-02-04 16:20:48.000000000","message":"These are typed as int but the help says \u0027-id\u0027.  I just want to confirm that is correct, most of OpenStack uses UUIDs for an ID...","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--minimum\u0027,"},{"line_number":137,"context_line":"            metavar\u003d\u0027\u003cminimum-segmentation-id\u003e\u0027,"},{"line_number":138,"context_line":"            type\u003dint,"},{"line_number":139,"context_line":"            required\u003dTrue,"},{"line_number":140,"context_line":"            help\u003d_(\u0027Minimum segment identifier for this network segment \u0027"},{"line_number":141,"context_line":"                   \u0027range which is based on the network type, VLAN ID for \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_423f1787","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":21},"in_reply_to":"9fdfeff1_fe926d9f","updated":"2019-02-05 02:04:58.000000000","message":"Thanks Dean. Yes, these are correct. Segmentation ID should be typed as int.","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            \u0027--used\u0027,"},{"line_number":254,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":255,"context_line":"            help\u003d_(\u0027List network segment ranges that have segments in use \u0027"},{"line_number":256,"context_line":"                   \u0027currently\u0027),"},{"line_number":257,"context_line":"        )"},{"line_number":258,"context_line":"        used_group.add_argument("},{"line_number":259,"context_line":"            \u0027--unused\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_c3547624","line":256,"range":{"start_line":256,"start_character":20,"end_line":256,"end_character":29},"updated":"2019-02-04 16:20:48.000000000","message":"as in the docs, drop \u0027currently\u0027 here and below","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            \u0027--used\u0027,"},{"line_number":254,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":255,"context_line":"            help\u003d_(\u0027List network segment ranges that have segments in use \u0027"},{"line_number":256,"context_line":"                   \u0027currently\u0027),"},{"line_number":257,"context_line":"        )"},{"line_number":258,"context_line":"        used_group.add_argument("},{"line_number":259,"context_line":"            \u0027--unused\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_023d8f2b","line":256,"range":{"start_line":256,"start_character":20,"end_line":256,"end_character":29},"in_reply_to":"9fdfeff1_c3547624","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c4c3b51b27a908096ff34b704393e614f9118a71","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_7659b433","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2019-02-19 13:41:38.000000000","message":"2019?","commit_id":"559db36564a85186b8087e1b18b2afce75ffcbb3"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"e3260cfa34f15d1ccd0f14d9e5f98e27f58cb69e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_667c26b6","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"9fdfeff1_7659b433","updated":"2019-02-26 05:46:42.000000000","message":"Done","commit_id":"559db36564a85186b8087e1b18b2afce75ffcbb3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"cd60c8a0783cda16ef381fbaf662b8446062272f","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        return headers, display_props"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"class SetNetworkSegmentRange(command.ShowOne):"},{"line_number":372,"context_line":"    _description \u003d _(\"Set network segment range properties\")"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9fdfeff1_a67e6016","line":371,"range":{"start_line":371,"start_character":37,"end_line":371,"end_character":44},"updated":"2019-02-27 19:27:44.000000000","message":"set commands do not produce output in OSC.","commit_id":"17bc6f61e3584c9ed1824a8f149ce9ea6b830bbe"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"1fd4f697fd909a0bfa94998772e8c30ec8ea0bd6","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        return headers, display_props"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"class SetNetworkSegmentRange(command.ShowOne):"},{"line_number":372,"context_line":"    _description \u003d _(\"Set network segment range properties\")"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9fdfeff1_5432b511","line":371,"range":{"start_line":371,"start_character":37,"end_line":371,"end_character":44},"in_reply_to":"9fdfeff1_a67e6016","updated":"2019-02-28 01:38:28.000000000","message":"As commented, keep this open for now and let\u0027s get an alignment.","commit_id":"17bc6f61e3584c9ed1824a8f149ce9ea6b830bbe"}],"openstackclient/tests/functional/network/v2/test_network_segment_range.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_network_segment_range_list(self):"},{"line_number":58,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":59,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":60,"context_line":"            \u0027 network segment range create -f json \u0027 +"},{"line_number":61,"context_line":"            \u0027--shared \u0027 +"},{"line_number":62,"context_line":"            \u0027--network-type geneve \u0027 +"},{"line_number":63,"context_line":"            \u0027--minimum 2018 \u0027 +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_9e1a416d","line":60,"updated":"2019-02-04 16:20:48.000000000","message":"Create this range using different values than in test_network_segment_range_create_delete() above.  In particular I would like to see the --shared and --private options tested as this is part of enforcing the command-line interface compatibility.","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_network_segment_range_list(self):"},{"line_number":58,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":59,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":60,"context_line":"            \u0027 network segment range create -f json \u0027 +"},{"line_number":61,"context_line":"            \u0027--shared \u0027 +"},{"line_number":62,"context_line":"            \u0027--network-type geneve \u0027 +"},{"line_number":63,"context_line":"            \u0027--minimum 2018 \u0027 +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_2268d31f","line":60,"in_reply_to":"9fdfeff1_9e1a416d","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_network_segment_range_list(self):"},{"line_number":58,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":59,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":60,"context_line":"            \u0027 network segment range create -f json \u0027 +"},{"line_number":61,"context_line":"            \u0027--shared \u0027 +"},{"line_number":62,"context_line":"            \u0027--network-type geneve \u0027 +"},{"line_number":63,"context_line":"            \u0027--minimum 2018 \u0027 +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_42b6378d","line":60,"in_reply_to":"9fdfeff1_9e1a416d","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def test_network_segment_range_set_show(self):"},{"line_number":88,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":89,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":90,"context_line":"            \u0027 network segment range create -f json \u0027 +"},{"line_number":91,"context_line":"            \u0027--shared \u0027 +"},{"line_number":92,"context_line":"            \u0027--network-type geneve \u0027 +"},{"line_number":93,"context_line":"            \u0027--minimum 2018 \u0027 +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_fe36ede7","line":90,"updated":"2019-02-04 16:20:48.000000000","message":"Same comment as above, this is an opportunity to validate another combination of options.","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def test_network_segment_range_set_show(self):"},{"line_number":88,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":89,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":90,"context_line":"            \u0027 network segment range create -f json \u0027 +"},{"line_number":91,"context_line":"            \u0027--shared \u0027 +"},{"line_number":92,"context_line":"            \u0027--network-type geneve \u0027 +"},{"line_number":93,"context_line":"            \u0027--minimum 2018 \u0027 +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_026b4f1f","line":90,"in_reply_to":"9fdfeff1_fe36ede7","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def test_network_segment_range_set_show(self):"},{"line_number":88,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":89,"context_line":"        json_output \u003d json.loads(self.openstack("},{"line_number":90,"context_line":"            \u0027 network segment range create -f json \u0027 +"},{"line_number":91,"context_line":"            \u0027--shared \u0027 +"},{"line_number":92,"context_line":"            \u0027--network-type geneve \u0027 +"},{"line_number":93,"context_line":"            \u0027--minimum 2018 \u0027 +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_02b02f8b","line":90,"in_reply_to":"9fdfeff1_fe36ede7","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"adba429b60d8caad8957572eabc69bacec9aa318","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    PROJECT_NAME \u003d uuid.uuid4().hex"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def setUpClass(cls):"},{"line_number":35,"context_line":"        super(NetworkSegmentRangeTests, cls).setUpClass()"},{"line_number":36,"context_line":"        # Make a project"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_149a2861","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":16},"updated":"2019-02-25 22:29:54.000000000","message":"Do not use classmethods for this, it gets racy when testing in parallel.   We have found it most reliable to just create what you need directly in the test so nothing is shared.","commit_id":"559db36564a85186b8087e1b18b2afce75ffcbb3"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"e3260cfa34f15d1ccd0f14d9e5f98e27f58cb69e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    PROJECT_NAME \u003d uuid.uuid4().hex"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def setUpClass(cls):"},{"line_number":35,"context_line":"        super(NetworkSegmentRangeTests, cls).setUpClass()"},{"line_number":36,"context_line":"        # Make a project"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_063c3adf","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":16},"in_reply_to":"9fdfeff1_149a2861","updated":"2019-02-26 05:46:42.000000000","message":"Done","commit_id":"559db36564a85186b8087e1b18b2afce75ffcbb3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"cd60c8a0783cda16ef381fbaf662b8446062272f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE(kailun): Network segment range management is still a WIP and not"},{"line_number":26,"context_line":"# enabled by default."},{"line_number":27,"context_line":"@testtools.skip(\"bp/network-segment-range-management\")"},{"line_number":28,"context_line":"class NetworkSegmentRangeTests(common.NetworkTests):"},{"line_number":29,"context_line":"    \"\"\"Functional tests for network segment range\"\"\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9fdfeff1_e6e308d7","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":15},"updated":"2019-02-27 19:27:44.000000000","message":"Is there any way to detect if it is enabled in the target cloud?  I would prefer to no just blanket-skip the tests, as this will have to be modifed to run the tests when it is available.","commit_id":"17bc6f61e3584c9ed1824a8f149ce9ea6b830bbe"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"1fd4f697fd909a0bfa94998772e8c30ec8ea0bd6","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE(kailun): Network segment range management is still a WIP and not"},{"line_number":26,"context_line":"# enabled by default."},{"line_number":27,"context_line":"@testtools.skip(\"bp/network-segment-range-management\")"},{"line_number":28,"context_line":"class NetworkSegmentRangeTests(common.NetworkTests):"},{"line_number":29,"context_line":"    \"\"\"Functional tests for network segment range\"\"\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9fdfeff1_54bf1560","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":15},"in_reply_to":"9fdfeff1_e6e308d7","updated":"2019-02-28 01:38:28.000000000","message":"Trying to enable thru gating tests.","commit_id":"17bc6f61e3584c9ed1824a8f149ce9ea6b830bbe"}],"setup.cfg":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"683784725c482ae93593a2f2b374fe5e71fecd76","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    network_service_provider_list \u003d openstackclient.network.v2.network_service_provider:ListNetworkServiceProvider"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    network_segment_range_create \u003d openstackclient.network.v2.network_segment_range:CreateNetworkSegmentRange"},{"line_number":469,"context_line":"    network_segment_range_delete \u003d openstackclient.network.v2.network_segment_range:DeleteNetworkSegmentRange"},{"line_number":470,"context_line":"    network_segment_range_list \u003d openstackclient.network.v2.network_segment_range:ListNetworkSegmentRange"},{"line_number":471,"context_line":"    network_segment_range_set \u003d openstackclient.network.v2.network_segment_range:SetNetworkSegmentRange"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"9fdfeff1_23122264","line":468,"range":{"start_line":468,"start_character":0,"end_line":468,"end_character":4},"updated":"2019-02-04 16:20:48.000000000","message":"sort these above network_service_provider list","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"},{"author":{"_account_id":28373,"name":"Kailun Qin","email":"kailun.qin@hotmail.com","username":"kailun.qin"},"change_message_id":"65ebf8ac5afb5dc45760e3946554252c52b45bcc","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    network_service_provider_list \u003d openstackclient.network.v2.network_service_provider:ListNetworkServiceProvider"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    network_segment_range_create \u003d openstackclient.network.v2.network_segment_range:CreateNetworkSegmentRange"},{"line_number":469,"context_line":"    network_segment_range_delete \u003d openstackclient.network.v2.network_segment_range:DeleteNetworkSegmentRange"},{"line_number":470,"context_line":"    network_segment_range_list \u003d openstackclient.network.v2.network_segment_range:ListNetworkSegmentRange"},{"line_number":471,"context_line":"    network_segment_range_set \u003d openstackclient.network.v2.network_segment_range:SetNetworkSegmentRange"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"9fdfeff1_6286dbde","line":468,"range":{"start_line":468,"start_character":0,"end_line":468,"end_character":4},"in_reply_to":"9fdfeff1_23122264","updated":"2019-02-05 02:04:58.000000000","message":"Done","commit_id":"3c12cdc43b57c0979100f74ba9ea873cdb7b6431"}]}